enough with umpteen "i18n.h" files. Consolidate on pbd/i18n.h
[ardour.git] / libs / ardour / midi_model.cc
index 4c6f6633d5e2a7ec90cd2dc3f3822f198f2d43ac..7f2b7fb863f31a6b55aa2f02f314b4667dd8d358 100644 (file)
@@ -40,7 +40,7 @@
 #include "ardour/session.h"
 #include "ardour/types.h"
 
-#include "i18n.h"
+#include "pbd/i18n.h"
 
 using namespace std;
 using namespace ARDOUR;
@@ -164,84 +164,55 @@ MidiModel::NoteDiffCommand::side_effect_remove (const NotePtr note)
        side_effect_removals.insert (note);
 }
 
-void
-MidiModel::NoteDiffCommand::change (const NotePtr note, Property prop,
-                                    uint8_t new_value)
+Variant
+MidiModel::NoteDiffCommand::get_value (const NotePtr note, Property prop)
 {
-       assert (note);
-
-       NoteChange change;
-
        switch (prop) {
        case NoteNumber:
-               if (new_value == note->note()) {
-                       return;
-               }
-               change.old_value = note->note();
-               break;
+               return Variant(note->note());
        case Velocity:
-               if (new_value == note->velocity()) {
-                       return;
-               }
-               change.old_value = note->velocity();
-               break;
+               return Variant(note->velocity());
        case Channel:
-               if (new_value == note->channel()) {
-                       return;
-               }
-               change.old_value = note->channel();
-               break;
-
-
+               return Variant(note->channel());
        case StartTime:
-               fatal << "MidiModel::DiffCommand::change() with integer argument called for start time" << endmsg;
-               /*NOTREACHED*/
-               break;
+               return Variant(note->time());
        case Length:
-               fatal << "MidiModel::DiffCommand::change() with integer argument called for length" << endmsg;
-               /*NOTREACHED*/
-               break;
+               return Variant(note->length());
        }
 
-       change.note = note;
-       change.property = prop;
-       change.new_value = new_value;
-
-       _changes.push_back (change);
+       return Variant();
 }
 
-void
-MidiModel::NoteDiffCommand::change (const NotePtr note, Property prop,
-                                    TimeType new_time)
+Variant::Type
+MidiModel::NoteDiffCommand::value_type(Property prop)
 {
-       assert (note);
-
-       NoteChange change;
-
        switch (prop) {
        case NoteNumber:
-       case Channel:
        case Velocity:
-               fatal << "MidiModel::NoteDiffCommand::change() with time argument called for note, channel or velocity" << endmsg;
-               break;
-
+       case Channel:
+               return Variant::INT;
        case StartTime:
-               if (Evoral::musical_time_equal (note->time(), new_time)) {
-                       return;
-               }
-               change.old_time = note->time();
-               break;
        case Length:
-               if (Evoral::musical_time_equal (note->length(), new_time)) {
-                       return;
-               }
-               change.old_time = note->length();
-               break;
+               return Variant::BEATS;
        }
 
-       change.note = note;
-       change.property = prop;
-       change.new_time = new_time;
+       return Variant::NOTHING;
+}
+
+void
+MidiModel::NoteDiffCommand::change (const NotePtr  note,
+                                    Property       prop,
+                                    const Variant& new_value)
+{
+       assert (note);
+
+       const NoteChange change = {
+               prop, note, 0, get_value(note, prop), new_value
+       };
+
+       if (change.old_value == new_value) {
+               return;
+       }
 
        _changes.push_back (change);
 }
@@ -289,13 +260,22 @@ MidiModel::NoteDiffCommand::operator() ()
 
                for (ChangeList::iterator i = _changes.begin(); i != _changes.end(); ++i) {
                        Property prop = i->property;
+
+                       if (!i->note) {
+                               /* note found during deserialization, so try
+                                  again now that the model state is different.
+                               */
+                               i->note = _model->find_note (i->note_id);
+                               assert (i->note);
+                       }
+
                        switch (prop) {
                        case NoteNumber:
                                if (temporary_removals.find (i->note) == temporary_removals.end()) {
                                        _model->remove_note_unlocked (i->note);
                                        temporary_removals.insert (i->note);
                                }
-                               i->note->set_note (i->new_value);
+                               i->note->set_note (i->new_value.get_int());
                                break;
 
                        case StartTime:
@@ -303,7 +283,7 @@ MidiModel::NoteDiffCommand::operator() ()
                                        _model->remove_note_unlocked (i->note);
                                        temporary_removals.insert (i->note);
                                }
-                               i->note->set_time (i->new_time);
+                               i->note->set_time (i->new_value.get_beats());
                                break;
 
                        case Channel:
@@ -311,18 +291,18 @@ MidiModel::NoteDiffCommand::operator() ()
                                        _model->remove_note_unlocked (i->note);
                                        temporary_removals.insert (i->note);
                                }
-                               i->note->set_channel (i->new_value);
+                               i->note->set_channel (i->new_value.get_int());
                                break;
 
                                /* no remove-then-add required for these properties, since we do not index them
                                 */
 
                        case Velocity:
-                               i->note->set_velocity (i->new_value);
+                               i->note->set_velocity (i->new_value.get_int());
                                break;
 
                        case Length:
-                               i->note->set_length (i->new_time);
+                               i->note->set_length (i->new_value.get_beats());
                                break;
 
                        }
@@ -373,15 +353,25 @@ MidiModel::NoteDiffCommand::undo ()
                /* notes we modify in a way that requires remove-then-add to maintain ordering */
                set<NotePtr> temporary_removals;
 
+
+               /* lazily discover any affected notes that were not discovered when
+                * loading the history because of deletions, etc.
+                */
+
+               for (ChangeList::iterator i = _changes.begin(); i != _changes.end(); ++i) {
+                       if (!i->note) {
+                               i->note = _model->find_note (i->note_id);
+                               assert (i->note);
+                       }
+               }
+
                for (ChangeList::iterator i = _changes.begin(); i != _changes.end(); ++i) {
                        Property prop = i->property;
-                       switch (prop) {
 
+                       switch (prop) {
                        case NoteNumber:
-                               if (
-                                       temporary_removals.find (i->note) == temporary_removals.end() &&
-                                       find (_removed_notes.begin(), _removed_notes.end(), i->note) == _removed_notes.end()
-                                       ) {
+                               if (temporary_removals.find (i->note) == temporary_removals.end() &&
+                                   find (_removed_notes.begin(), _removed_notes.end(), i->note) == _removed_notes.end()) {
 
                                        /* We only need to mark this note for re-add if (a) we haven't
                                           already marked it and (b) it isn't on the _removed_notes
@@ -392,46 +382,42 @@ MidiModel::NoteDiffCommand::undo ()
                                        _model->remove_note_unlocked (i->note);
                                        temporary_removals.insert (i->note);
                                }
-                               i->note->set_note (i->old_value);
+                               i->note->set_note (i->old_value.get_int());
                                break;
 
                        case StartTime:
-                               if (
-                                       temporary_removals.find (i->note) == temporary_removals.end() &&
-                                       find (_removed_notes.begin(), _removed_notes.end(), i->note) == _removed_notes.end()
-                                       ) {
+                               if (temporary_removals.find (i->note) == temporary_removals.end() &&
+                                   find (_removed_notes.begin(), _removed_notes.end(), i->note) == _removed_notes.end()) {
 
                                        /* See above ... */
 
                                        _model->remove_note_unlocked (i->note);
                                        temporary_removals.insert (i->note);
                                }
-                               i->note->set_time (i->old_time);
+                               i->note->set_time (i->old_value.get_beats());
                                break;
 
                        case Channel:
-                               if (
-                                       temporary_removals.find (i->note) == temporary_removals.end() &&
-                                       find (_removed_notes.begin(), _removed_notes.end(), i->note) == _removed_notes.end()
-                                       ) {
+                               if (temporary_removals.find (i->note) == temporary_removals.end() &&
+                                   find (_removed_notes.begin(), _removed_notes.end(), i->note) == _removed_notes.end()) {
 
                                        /* See above ... */
 
                                        _model->remove_note_unlocked (i->note);
                                        temporary_removals.insert (i->note);
                                }
-                               i->note->set_channel (i->old_value);
+                               i->note->set_channel (i->old_value.get_int());
                                break;
 
                                /* no remove-then-add required for these properties, since we do not index them
                                 */
 
                        case Velocity:
-                               i->note->set_velocity (i->old_value);
+                               i->note->set_velocity (i->old_value.get_int());
                                break;
 
                        case Length:
-                               i->note->set_length (i->old_time);
+                               i->note->set_length (i->old_value.get_beats());
                                break;
                        }
                }
@@ -505,7 +491,7 @@ Evoral::Sequence<MidiModel::TimeType>::NotePtr
 MidiModel::NoteDiffCommand::unmarshal_note (XMLNode *xml_note)
 {
        unsigned int note;
-       XMLProperty* prop;
+       XMLProperty const * prop;
        unsigned int channel;
        MidiModel::TimeType time;
        MidiModel::TimeType length;
@@ -541,7 +527,7 @@ MidiModel::NoteDiffCommand::unmarshal_note (XMLNode *xml_note)
                time_str >> time;
        } else {
                warning << "note information missing time" << endmsg;
-               time = 0;
+               time = MidiModel::TimeType();
        }
 
        if ((prop = xml_note->property("length")) != 0) {
@@ -549,7 +535,7 @@ MidiModel::NoteDiffCommand::unmarshal_note (XMLNode *xml_note)
                length_str >> length;
        } else {
                warning << "note information missing length" << endmsg;
-               length = 1;
+               length = MidiModel::TimeType(1);
        }
 
        if ((prop = xml_note->property("velocity")) != 0) {
@@ -578,9 +564,9 @@ MidiModel::NoteDiffCommand::marshal_change (const NoteChange& change)
        {
                ostringstream old_value_str (ios::ate);
                if (change.property == StartTime || change.property == Length) {
-                       old_value_str << change.old_time;
+                       old_value_str << change.old_value.get_beats();
                } else {
-                       old_value_str << (unsigned int) change.old_value;
+                       old_value_str << change.old_value.get_int();
                }
                xml_change->add_property ("old", old_value_str.str());
        }
@@ -588,16 +574,24 @@ MidiModel::NoteDiffCommand::marshal_change (const NoteChange& change)
        {
                ostringstream new_value_str (ios::ate);
                if (change.property == StartTime || change.property == Length) {
-                       new_value_str << change.new_time;
+                       new_value_str << change.new_value.get_beats();
                } else {
-                       new_value_str << (unsigned int) change.new_value;
+                       new_value_str << change.new_value.get_int();
                }
                xml_change->add_property ("new", new_value_str.str());
        }
 
        ostringstream id_str;
-       id_str << change.note->id();
-       xml_change->add_property ("id", id_str.str());
+       if (change.note) {
+               id_str << change.note->id();
+               xml_change->add_property ("id", id_str.str());
+       } else if (change.note_id) {
+               warning << _("Change has no note, using note ID") << endmsg;
+               id_str << change.note_id;
+               xml_change->add_property ("id", id_str.str());
+       } else {
+               error << _("Change has no note or note ID") << endmsg;
+       }
 
        return *xml_change;
 }
@@ -605,14 +599,15 @@ MidiModel::NoteDiffCommand::marshal_change (const NoteChange& change)
 MidiModel::NoteDiffCommand::NoteChange
 MidiModel::NoteDiffCommand::unmarshal_change (XMLNode *xml_change)
 {
-       XMLProperty* prop;
+       XMLProperty const * prop;
        NoteChange change;
+       change.note_id = 0;
 
        if ((prop = xml_change->property("property")) != 0) {
                change.property = (Property) string_2_enum (prop->value(), change.property);
        } else {
                fatal << "!!!" << endmsg;
-               /*NOTREACHED*/
+               abort(); /*NOTREACHED*/
        }
 
        if ((prop = xml_change->property ("id")) == 0) {
@@ -625,7 +620,9 @@ MidiModel::NoteDiffCommand::unmarshal_change (XMLNode *xml_change)
        if ((prop = xml_change->property ("old")) != 0) {
                istringstream old_str (prop->value());
                if (change.property == StartTime || change.property == Length) {
-                       old_str >> change.old_time;
+                       Evoral::Beats old_time;
+                       old_str >> old_time;
+                       change.old_value = old_time;
                } else {
                        int integer_value_so_that_istream_does_the_right_thing;
                        old_str >> integer_value_so_that_istream_does_the_right_thing;
@@ -633,13 +630,15 @@ MidiModel::NoteDiffCommand::unmarshal_change (XMLNode *xml_change)
                }
        } else {
                fatal << "!!!" << endmsg;
-               /*NOTREACHED*/
+               abort(); /*NOTREACHED*/
        }
 
        if ((prop = xml_change->property ("new")) != 0) {
                istringstream new_str (prop->value());
                if (change.property == StartTime || change.property == Length) {
-                       new_str >> change.new_time;
+                       Evoral::Beats new_time;
+                       new_str >> new_time;
+                       change.new_value = Variant(new_time);
                } else {
                        int integer_value_so_that_istream_does_the_right_thing;
                        new_str >> integer_value_so_that_istream_does_the_right_thing;
@@ -647,19 +646,17 @@ MidiModel::NoteDiffCommand::unmarshal_change (XMLNode *xml_change)
                }
        } else {
                fatal << "!!!" << endmsg;
-               /*NOTREACHED*/
+               abort(); /*NOTREACHED*/
        }
 
        /* we must point at the instance of the note that is actually in the model.
-          so go look for it ...
+          so go look for it ... it may not be there (it could have been
+          deleted in a later operation, so store the note id so that we can
+          look it up again later).
        */
 
        change.note = _model->find_note (note_id);
-
-       if (!change.note) {
-               warning << "MIDI note #" << note_id << " not found in model - programmers should investigate this" << endmsg;
-               return change;
-       }
+       change.note_id = note_id;
 
        return change;
 }
@@ -790,6 +787,15 @@ MidiModel::SysExDiffCommand::operator() ()
                        _model->remove_sysex_unlocked (*i);
                }
 
+               /* find any sysex events that were missing when unmarshalling */
+
+               for (ChangeList::iterator i = _changes.begin(); i != _changes.end(); ++i) {
+                       if (!i->sysex) {
+                               i->sysex = _model->find_sysex (i->sysex_id);
+                               assert (i->sysex);
+                       }
+               }
+
                for (ChangeList::iterator i = _changes.begin(); i != _changes.end(); ++i) {
                        switch (i->property) {
                        case Time:
@@ -811,6 +817,15 @@ MidiModel::SysExDiffCommand::undo ()
                        _model->add_sysex_unlocked (*i);
                }
 
+               /* find any sysex events that were missing when unmarshalling */
+
+               for (ChangeList::iterator i = _changes.begin(); i != _changes.end(); ++i) {
+                       if (!i->sysex) {
+                               i->sysex = _model->find_sysex (i->sysex_id);
+                               assert (i->sysex);
+                       }
+               }
+
                for (ChangeList::iterator i = _changes.begin(); i != _changes.end(); ++i) {
                        switch (i->property) {
                        case Time:
@@ -861,14 +876,14 @@ MidiModel::SysExDiffCommand::marshal_change (const Change& change)
 MidiModel::SysExDiffCommand::Change
 MidiModel::SysExDiffCommand::unmarshal_change (XMLNode *xml_change)
 {
-       XMLProperty* prop;
+       XMLProperty const * prop;
        Change change;
 
        if ((prop = xml_change->property ("property")) != 0) {
                change.property = (Property) string_2_enum (prop->value(), change.property);
        } else {
                fatal << "!!!" << endmsg;
-               /*NOTREACHED*/
+               abort(); /*NOTREACHED*/
        }
 
        if ((prop = xml_change->property ("id")) == 0) {
@@ -883,7 +898,7 @@ MidiModel::SysExDiffCommand::unmarshal_change (XMLNode *xml_change)
                old_str >> change.old_time;
        } else {
                fatal << "!!!" << endmsg;
-               /*NOTREACHED*/
+               abort(); /*NOTREACHED*/
        }
 
        if ((prop = xml_change->property ("new")) != 0) {
@@ -891,7 +906,7 @@ MidiModel::SysExDiffCommand::unmarshal_change (XMLNode *xml_change)
                new_str >> change.new_time;
        } else {
                fatal << "!!!" << endmsg;
-               /*NOTREACHED*/
+               abort(); /*NOTREACHED*/
        }
 
        /* we must point at the instance of the sysex that is actually in the model.
@@ -899,11 +914,7 @@ MidiModel::SysExDiffCommand::unmarshal_change (XMLNode *xml_change)
        */
 
        change.sysex = _model->find_sysex (sysex_id);
-
-       if (!change.sysex) {
-               warning << "Sys-ex #" << sysex_id << " not found in model - programmers should investigate this" << endmsg;
-               return change;
-       }
+       change.sysex_id = sysex_id;
 
        return change;
 }
@@ -991,6 +1002,7 @@ MidiModel::PatchChangeDiffCommand::change_channel (PatchChangePtr patch, uint8_t
        c.patch = patch;
        c.old_channel = patch->channel ();
        c.new_channel = channel;
+       c.patch_id = patch->id();
 
        _changes.push_back (c);
 }
@@ -1003,6 +1015,7 @@ MidiModel::PatchChangeDiffCommand::change_program (PatchChangePtr patch, uint8_t
        c.patch = patch;
        c.old_program = patch->program ();
        c.new_program = program;
+       c.patch_id = patch->id();
 
        _changes.push_back (c);
 }
@@ -1033,6 +1046,15 @@ MidiModel::PatchChangeDiffCommand::operator() ()
                        _model->remove_patch_change_unlocked (*i);
                }
 
+               /* find any patch change events that were missing when unmarshalling */
+
+               for (ChangeList::iterator i = _changes.begin(); i != _changes.end(); ++i) {
+                       if (!i->patch) {
+                               i->patch = _model->find_patch_change (i->patch_id);
+                               assert (i->patch);
+                       }
+               }
+
                set<PatchChangePtr> temporary_removals;
 
                for (ChangeList::iterator i = _changes.begin(); i != _changes.end(); ++i) {
@@ -1081,6 +1103,15 @@ MidiModel::PatchChangeDiffCommand::undo ()
                        _model->add_patch_change_unlocked (*i);
                }
 
+               /* find any patch change events that were missing when unmarshalling */
+
+               for (ChangeList::iterator i = _changes.begin(); i != _changes.end(); ++i) {
+                       if (!i->patch) {
+                               i->patch = _model->find_patch_change (i->patch_id);
+                               assert (i->patch);
+                       }
+               }
+
                set<PatchChangePtr> temporary_removals;
 
                for (ChangeList::iterator i = _changes.begin(); i != _changes.end(); ++i) {
@@ -1204,15 +1235,16 @@ MidiModel::PatchChangeDiffCommand::marshal_change (const Change& c)
 MidiModel::PatchChangePtr
 MidiModel::PatchChangeDiffCommand::unmarshal_patch_change (XMLNode* n)
 {
-       XMLProperty* prop;
-       Evoral::event_id_t id;
-       Evoral::MusicalTime time = 0;
-       uint8_t channel = 0;
-       uint8_t program = 0;
+       XMLProperty const * prop;
+       XMLProperty const * prop_id;
+       Evoral::event_id_t id = 0;
+       Evoral::Beats time = Evoral::Beats();
+       int channel = 0;
+       int program = 0;
        int bank = 0;
 
-       if ((prop = n->property ("id")) != 0) {
-               istringstream s (prop->value());
+       if ((prop_id = n->property ("id")) != 0) {
+               istringstream s (prop_id->value());
                s >> id;
        }
 
@@ -1237,6 +1269,7 @@ MidiModel::PatchChangeDiffCommand::unmarshal_patch_change (XMLNode* n)
        }
 
        PatchChangePtr p (new Evoral::PatchChange<TimeType> (time, channel, program, bank));
+       assert(prop_id);
        p->set_id (id);
        return p;
 }
@@ -1244,8 +1277,9 @@ MidiModel::PatchChangeDiffCommand::unmarshal_patch_change (XMLNode* n)
 MidiModel::PatchChangeDiffCommand::Change
 MidiModel::PatchChangeDiffCommand::unmarshal_change (XMLNode* n)
 {
-       XMLProperty* prop;
+       XMLProperty const * prop;
        Change c;
+       int an_int;
 
        prop = n->property ("property");
        assert (prop);
@@ -1255,6 +1289,10 @@ MidiModel::PatchChangeDiffCommand::unmarshal_change (XMLNode* n)
        assert (prop);
        Evoral::event_id_t const id = atoi (prop->value().c_str());
 
+       /* we need to load via an int intermediate for all properties that are
+          actually uint8_t (char/byte).
+       */
+
        prop = n->property ("old");
        assert (prop);
        {
@@ -1262,11 +1300,14 @@ MidiModel::PatchChangeDiffCommand::unmarshal_change (XMLNode* n)
                if (c.property == Time) {
                        s >> c.old_time;
                } else if (c.property == Channel) {
-                       s >> c.old_channel;
+                       s >> an_int;
+                       c.old_channel = an_int;
                } else if (c.property == Program) {
-                       s >> c.old_program;
+                       s >> an_int;
+                       c.old_program = an_int;
                } else if (c.property == Bank) {
-                       s >> c.old_bank;
+                       s >> an_int;
+                       c.old_bank = an_int;
                }
        }
 
@@ -1274,19 +1315,23 @@ MidiModel::PatchChangeDiffCommand::unmarshal_change (XMLNode* n)
        assert (prop);
        {
                istringstream s (prop->value ());
+
                if (c.property == Time) {
                        s >> c.new_time;
                } else if (c.property == Channel) {
-                       s >> c.new_channel;
+                       s >> an_int;
+                       c.new_channel = an_int;
                } else if (c.property == Program) {
-                       s >> c.new_program;
+                       s >> an_int;
+                       c.new_program = an_int;
                } else if (c.property == Bank) {
-                       s >> c.new_bank;
+                       s >> an_int;
+                       c.new_bank = an_int;
                }
        }
 
        c.patch = _model->find_patch_change (id);
-       assert (c.patch);
+       c.patch_id = id;
 
        return c;
 }
@@ -1366,25 +1411,23 @@ MidiModel::PatchChangeDiffCommand::get_state ()
  * `Discrete' mode).
  */
 bool
-MidiModel::write_to (boost::shared_ptr<MidiSource> source)
+MidiModel::write_to (boost::shared_ptr<MidiSource>     source,
+                     const Glib::Threads::Mutex::Lock& source_lock)
 {
        ReadLock lock(read_lock());
 
        const bool old_percussive = percussive();
        set_percussive(false);
 
-       boost::shared_ptr<MidiSource> ms = _midi_source.lock ();
-       assert (ms);
-
-       source->drop_model();
-       source->mark_streaming_midi_write_started (note_mode());
+       source->drop_model(source_lock);
+       source->mark_streaming_midi_write_started (source_lock, note_mode());
 
-       for (Evoral::Sequence<TimeType>::const_iterator i = begin(0, true); i != end(); ++i) {
-               source->append_event_unlocked_beats(*i);
+       for (Evoral::Sequence<TimeType>::const_iterator i = begin(TimeType(), true); i != end(); ++i) {
+               source->append_event_beats(source_lock, *i);
        }
 
        set_percussive(old_percussive);
-       source->mark_streaming_write_completed();
+       source->mark_streaming_write_completed(source_lock);
 
        set_edited(false);
 
@@ -1397,7 +1440,7 @@ MidiModel::write_to (boost::shared_ptr<MidiSource> source)
     of the model.
 */
 bool
-MidiModel::sync_to_source ()
+MidiModel::sync_to_source (const Glib::Threads::Mutex::Lock& source_lock)
 {
        ReadLock lock(read_lock());
 
@@ -1405,16 +1448,24 @@ MidiModel::sync_to_source ()
        set_percussive(false);
 
        boost::shared_ptr<MidiSource> ms = _midi_source.lock ();
-       assert (ms);
+       if (!ms) {
+               error << "MIDI model has no source to sync to" << endmsg;
+               return false;
+       }
 
-       ms->mark_streaming_midi_write_started (note_mode());
+       /* Invalidate and store active notes, which will be picked up by the iterator
+          on the next roll if time progresses linearly. */
+       ms->invalidate(source_lock,
+                      ms->session().transport_rolling() ? &_active_notes : NULL);
 
-       for (Evoral::Sequence<TimeType>::const_iterator i = begin(0, true); i != end(); ++i) {
-               ms->append_event_unlocked_beats(*i);
+       ms->mark_streaming_midi_write_started (source_lock, note_mode());
+
+       for (Evoral::Sequence<TimeType>::const_iterator i = begin(TimeType(), true); i != end(); ++i) {
+               ms->append_event_beats(source_lock, *i);
        }
 
        set_percussive (old_percussive);
-       ms->mark_streaming_write_completed ();
+       ms->mark_streaming_write_completed (source_lock);
 
        set_edited (false);
 
@@ -1429,7 +1480,10 @@ MidiModel::sync_to_source ()
  * destroying the original note durations.
  */
 bool
-MidiModel::write_section_to (boost::shared_ptr<MidiSource> source, Evoral::MusicalTime begin_time, Evoral::MusicalTime end_time)
+MidiModel::write_section_to (boost::shared_ptr<MidiSource>     source,
+                             const Glib::Threads::Mutex::Lock& source_lock,
+                             Evoral::Beats                     begin_time,
+                             Evoral::Beats                     end_time)
 {
        ReadLock lock(read_lock());
        MidiStateTracker mst;
@@ -1437,19 +1491,16 @@ MidiModel::write_section_to (boost::shared_ptr<MidiSource> source, Evoral::Music
        const bool old_percussive = percussive();
        set_percussive(false);
 
-       boost::shared_ptr<MidiSource> ms = _midi_source.lock ();
-       assert (ms);
+       source->drop_model(source_lock);
+       source->mark_streaming_midi_write_started (source_lock, note_mode());
 
-       source->drop_model();
-       source->mark_streaming_midi_write_started (note_mode());
-
-       for (Evoral::Sequence<TimeType>::const_iterator i = begin(0, true); i != end(); ++i) {
-               const Evoral::Event<Evoral::MusicalTime>& ev (*i);
+       for (Evoral::Sequence<TimeType>::const_iterator i = begin(TimeType(), true); i != end(); ++i) {
+               const Evoral::Event<Evoral::Beats>& ev (*i);
 
                if (ev.time() >= begin_time && ev.time() < end_time) {
 
-                       const Evoral::MIDIEvent<Evoral::MusicalTime>* mev =
-                               static_cast<const Evoral::MIDIEvent<Evoral::MusicalTime>* > (&ev);
+                       const Evoral::MIDIEvent<Evoral::Beats>* mev =
+                               static_cast<const Evoral::MIDIEvent<Evoral::Beats>* > (&ev);
 
                        if (!mev) {
                                continue;
@@ -1466,22 +1517,22 @@ MidiModel::write_section_to (boost::shared_ptr<MidiSource> source, Evoral::Music
                                        continue;
                                }
 
-                               source->append_event_unlocked_beats (*i);
+                               source->append_event_beats (source_lock, *i);
                                mst.remove (mev->note(), mev->channel());
 
                        } else if (mev->is_note_on()) {
                                mst.add (mev->note(), mev->channel());
-                               source->append_event_unlocked_beats(*i);
+                               source->append_event_beats(source_lock, *i);
                        } else {
-                               source->append_event_unlocked_beats(*i);
+                               source->append_event_beats(source_lock, *i);
                        }
                }
        }
 
-       mst.resolve_notes (*source, end_time);
+       mst.resolve_notes (*source, source_lock, end_time);
 
        set_percussive(old_percussive);
-       source->mark_streaming_write_completed();
+       source->mark_streaming_write_completed(source_lock);
 
        set_edited(false);
 
@@ -1566,25 +1617,19 @@ MidiModel::find_sysex (gint sysex_id)
 MidiModel::WriteLock
 MidiModel::edit_lock()
 {
-       boost::shared_ptr<MidiSource> ms = _midi_source.lock ();
-       assert (ms);
+       boost::shared_ptr<MidiSource> ms          = _midi_source.lock();
+       Glib::Threads::Mutex::Lock*   source_lock = 0;
 
-       Glib::Threads::Mutex::Lock* source_lock = new Glib::Threads::Mutex::Lock (ms->mutex());
-       ms->invalidate(); // Release cached iterator's read lock on model
-       return WriteLock(new WriteLockImpl(source_lock, _lock, _control_lock));
-}
-
-/** Lock just the model, the source lock must already be held.
- * This should only be called from libardour/evoral places
- */
-MidiModel::WriteLock
-MidiModel::write_lock()
-{
-       boost::shared_ptr<MidiSource> ms = _midi_source.lock ();
-       assert (ms);
+       if (ms) {
+               /* Take source lock and invalidate iterator to release its lock on model.
+                  Add currently active notes to _active_notes so we can restore them
+                  if playback resumes at the same point after the edit. */
+               source_lock = new Glib::Threads::Mutex::Lock(ms->mutex());
+               ms->invalidate(*source_lock,
+                              ms->session().transport_rolling() ? &_active_notes : NULL);
+       }
 
-       assert (!ms->mutex().trylock ());
-       return WriteLock(new WriteLockImpl(NULL, _lock, _control_lock));
+       return WriteLock(new WriteLockImpl(source_lock, _lock, _control_lock));
 }
 
 int
@@ -1602,7 +1647,7 @@ MidiModel::resolve_overlaps_unlocked (const NotePtr note, void* arg)
        TimeType ea  = note->end_time();
 
        const Pitches& p (pitches (note->channel()));
-       NotePtr search_note(new Note<TimeType>(0, 0, 0, note->note()));
+       NotePtr search_note(new Note<TimeType>(0, TimeType(), TimeType(), note->note()));
        set<NotePtr> to_be_deleted;
        bool set_note_length = false;
        bool set_note_time = false;
@@ -1620,9 +1665,9 @@ MidiModel::resolve_overlaps_unlocked (const NotePtr note, void* arg)
 
                if ((sb > sa) && (eb <= ea)) {
                        overlap = OverlapInternal;
-               } else if ((eb >= sa) && (eb <= ea)) {
+               } else if ((eb > sa) && (eb <= ea)) {
                        overlap = OverlapStart;
-               } else if ((sb > sa) && (sb <= ea)) {
+               } else if ((sb > sa) && (sb < ea)) {
                        overlap = OverlapEnd;
                } else if ((sa >= sb) && (sa <= eb) && (ea <= eb)) {
                        overlap = OverlapExternal;
@@ -1668,7 +1713,7 @@ MidiModel::resolve_overlaps_unlocked (const NotePtr note, void* arg)
                                return -1; /* do not add the new note */
                                break;
                        default:
-                               /*NOTREACHED*/
+                               abort(); /*NOTREACHED*/
                                /* stupid gcc */
                                break;
                        }
@@ -1704,7 +1749,7 @@ MidiModel::resolve_overlaps_unlocked (const NotePtr note, void* arg)
                                note_length = min (note_length, (*i)->end_time() - note->time());
                                break;
                        default:
-                               /*NOTREACHED*/
+                               abort(); /*NOTREACHED*/
                                /* stupid gcc */
                                break;
                        }
@@ -1723,7 +1768,7 @@ MidiModel::resolve_overlaps_unlocked (const NotePtr note, void* arg)
                                /* cannot add in this case */
                                return -1;
                        default:
-                               /*NOTREACHED*/
+                               abort(); /*NOTREACHED*/
                                /* stupid gcc */
                                break;
                        }
@@ -1741,14 +1786,14 @@ MidiModel::resolve_overlaps_unlocked (const NotePtr note, void* arg)
                                to_be_deleted.insert (*i);
                                break;
                        default:
-                               /*NOTREACHED*/
+                               abort(); /*NOTREACHED*/
                                /* stupid gcc */
                                break;
                        }
                        break;
 
                default:
-                       /*NOTREACHED*/
+                       abort(); /*NOTREACHED*/
                        /* stupid gcc */
                        break;
                }
@@ -1795,7 +1840,8 @@ MidiModel::set_midi_source (boost::shared_ptr<MidiSource> s)
        boost::shared_ptr<MidiSource> old = _midi_source.lock ();
 
        if (old) {
-               old->invalidate ();
+               Source::Lock lm(old->mutex());
+               old->invalidate (lm);
        }
 
        _midi_source_connections.drop_connections ();
@@ -1919,7 +1965,7 @@ MidiModel::insert_silence_at_start (TimeType t)
        for (Controls::iterator i = controls().begin(); i != controls().end(); ++i) {
                boost::shared_ptr<AutomationControl> ac = boost::dynamic_pointer_cast<AutomationControl> (i->second);
                XMLNode& before = ac->alist()->get_state ();
-               i->second->list()->shift (0, t);
+               i->second->list()->shift (0, t.to_double());
                XMLNode& after = ac->alist()->get_state ();
                s->session().add_command (new MementoCommand<AutomationList> (new MidiAutomationListBinder (s, i->first), &before, &after));
        }
@@ -1937,50 +1983,24 @@ MidiModel::insert_silence_at_start (TimeType t)
        }
 }
 
-/** Transpose notes in a time range by a given number of semitones.  Notes
- *  will be clamped at 0 and 127 if the transposition would make them exceed
- *  that range.
- *
- *  @param from Start time.
- *  @param end End time.
- *  @param semitones Number of semitones to transpose by (+ve is higher, -ve is lower).
- */
 void
-MidiModel::transpose (TimeType from, TimeType to, int semitones)
+MidiModel::transpose (NoteDiffCommand* c, const NotePtr note_ptr, int semitones)
 {
-       boost::shared_ptr<const MidiSource> s = midi_source ();
-
-       NoteDiffCommand* c = new_note_diff_command (_("transpose"));
-
-       for (Notes::iterator i = notes().begin(); i != notes().end(); ++i) {
-
-               if ((*i)->time() >= to) {
-
-                       /* finished */
-                       break;
-
-               } else if ((*i)->time() >= from) {
+       int new_note = note_ptr->note() + semitones;
 
-                       int new_note = (*i)->note() + semitones;
-
-                       if (new_note < 0) {
-                               new_note = 0;
-                       } else if (new_note > 127) {
-                               new_note = 127;
-                       }
-
-                       c->change (*i, NoteDiffCommand::NoteNumber, (uint8_t) new_note);
-
-               }
+       if (new_note < 0) {
+               new_note = 0;
+       } else if (new_note > 127) {
+               new_note = 127;
        }
 
-       apply_command (s->session (), c);
+       c->change (note_ptr, NoteDiffCommand::NoteNumber, (uint8_t) new_note);
 }
 
 void
 MidiModel::control_list_marked_dirty ()
 {
-       AutomatableSequence<Evoral::MusicalTime>::control_list_marked_dirty ();
-       
+       AutomatableSequence<Evoral::Beats>::control_list_marked_dirty ();
+
        ContentsChanged (); /* EMIT SIGNAL */
 }