align stem-export (raw track outputs (with and w/p processing)
[ardour.git] / libs / ardour / midi_model.cc
index e185300ccae20b6a87cb4afc654c8f31e37eb97f..b5e93ae494e829a719a9b4e0a48496c5920ded1f 100644 (file)
@@ -1,6 +1,6 @@
 /*
   Copyright (C) 2007 Paul Davis
-  Author: Dave Robillard
+  Author: David Robillard
 
   This program is free software; you can redistribute it and/or modify
   it under the terms of the GNU General Public License as published by
 
 */
 
-#include <set>
-#include <iostream>
 #include <algorithm>
+#include <iostream>
+#include <set>
 #include <stdexcept>
 #include <stdint.h>
-#include "pbd/error.h"
+
+#include "pbd/compose.h"
 #include "pbd/enumwriter.h"
+#include "pbd/error.h"
+
+#include "evoral/Control.hpp"
+
 #include "midi++/events.h"
 
+#include "ardour/automation_control.h"
+#include "ardour/midi_automation_list_binder.h"
 #include "ardour/midi_model.h"
 #include "ardour/midi_source.h"
 #include "ardour/midi_state_tracker.h"
-#include "ardour/smf_source.h"
-#include "ardour/types.h"
 #include "ardour/session.h"
-#include "ardour/midi_automation_list_binder.h"
+#include "ardour/types.h"
+
+#include "i18n.h"
 
 using namespace std;
 using namespace ARDOUR;
@@ -56,7 +63,7 @@ MidiModel::new_note_diff_command (const string name)
 {
        boost::shared_ptr<MidiSource> ms = _midi_source.lock ();
        assert (ms);
-       
+
        return new NoteDiffCommand (ms->model(), name);
 }
 
@@ -66,10 +73,20 @@ MidiModel::new_sysex_diff_command (const string name)
 {
        boost::shared_ptr<MidiSource> ms = _midi_source.lock ();
        assert (ms);
-       
+
        return new SysExDiffCommand (ms->model(), name);
 }
 
+/** Start a new PatchChangeDiff command */
+MidiModel::PatchChangeDiffCommand*
+MidiModel::new_patch_change_diff_command (const string name)
+{
+       boost::shared_ptr<MidiSource> ms = _midi_source.lock ();
+       assert (ms);
+
+       return new PatchChangeDiffCommand (ms->model(), name);
+}
+
 
 /** Apply a command.
  *
@@ -107,6 +124,10 @@ MidiModel::apply_command_as_subcommand(Session& session, Command* cmd)
 #define SIDE_EFFECT_REMOVALS_ELEMENT "SideEffectRemovals"
 #define SYSEX_DIFF_COMMAND_ELEMENT "SysExDiffCommand"
 #define DIFF_SYSEXES_ELEMENT "ChangedSysExes"
+#define PATCH_CHANGE_DIFF_COMMAND_ELEMENT "PatchChangeDiffCommand"
+#define ADDED_PATCH_CHANGES_ELEMENT "AddedPatchChanges"
+#define REMOVED_PATCH_CHANGES_ELEMENT "RemovedPatchChanges"
+#define DIFF_PATCH_CHANGES_ELEMENT "ChangedPatchChanges"
 
 MidiModel::DiffCommand::DiffCommand(boost::shared_ptr<MidiModel> m, const std::string& name)
        : Command (name)
@@ -143,84 +164,55 @@ MidiModel::NoteDiffCommand::side_effect_remove (const NotePtr note)
        side_effect_removals.insert (note);
 }
 
-void
-MidiModel::NoteDiffCommand::change (const NotePtr note, Property prop,
-                                    uint8_t new_value)
+Variant
+MidiModel::NoteDiffCommand::get_value (const NotePtr note, Property prop)
 {
-       assert (note);
-       
-       NoteChange change;
-        
        switch (prop) {
        case NoteNumber:
-               if (new_value == note->note()) {
-                       return;
-               }
-               change.old_value = note->note();
-               break;
+               return Variant(note->note());
        case Velocity:
-               if (new_value == note->velocity()) {
-                       return;
-               }
-               change.old_value = note->velocity();
-               break;
+               return Variant(note->velocity());
        case Channel:
-               if (new_value == note->channel()) {
-                       return;
-               }
-               change.old_value = note->channel();
-               break;
-
-
+               return Variant(note->channel());
        case StartTime:
-               fatal << "MidiModel::DiffCommand::change() with integer argument called for start time" << endmsg;
-               /*NOTREACHED*/
-               break;
+               return Variant(note->time());
        case Length:
-               fatal << "MidiModel::DiffCommand::change() with integer argument called for length" << endmsg;
-               /*NOTREACHED*/
-               break;
+               return Variant(note->length());
        }
 
-       change.note = note;
-       change.property = prop;
-       change.new_value = new_value;
-
-       _changes.push_back (change);
+       return Variant();
 }
 
-void
-MidiModel::NoteDiffCommand::change (const NotePtr note, Property prop,
-                                    TimeType new_time)
+Variant::Type
+MidiModel::NoteDiffCommand::value_type(Property prop)
 {
-       assert (note);
-       
-       NoteChange change;
-
        switch (prop) {
        case NoteNumber:
-       case Channel:
        case Velocity:
-               fatal << "MidiModel::NoteDiffCommand::change() with time argument called for note, channel or velocity" << endmsg;
-               break;
-
+       case Channel:
+               return Variant::INT;
        case StartTime:
-               if (Evoral::musical_time_equal (note->time(), new_time)) {
-                       return;
-               }
-               change.old_time = note->time();
-               break;
        case Length:
-               if (Evoral::musical_time_equal (note->length(), new_time)) {
-                       return;
-               }
-               change.old_time = note->length();
-               break;
+               return Variant::BEATS;
        }
 
-       change.note = note;
-       change.property = prop;
-       change.new_time = new_time;
+       return Variant::NOTHING;
+}
+
+void
+MidiModel::NoteDiffCommand::change (const NotePtr  note,
+                                    Property       prop,
+                                    const Variant& new_value)
+{
+       assert (note);
+
+       const NoteChange change = {
+               prop, note, 0, get_value(note, prop), new_value
+       };
+
+       if (change.old_value == new_value) {
+               return;
+       }
 
        _changes.push_back (change);
 }
@@ -268,22 +260,30 @@ MidiModel::NoteDiffCommand::operator() ()
 
                for (ChangeList::iterator i = _changes.begin(); i != _changes.end(); ++i) {
                        Property prop = i->property;
+
+                       if (!i->note) {
+                               /* note found during deserialization, so try
+                                  again now that the model state is different.
+                               */
+                               i->note = _model->find_note (i->note_id);
+                               assert (i->note);
+                       }
+
                        switch (prop) {
                        case NoteNumber:
                                if (temporary_removals.find (i->note) == temporary_removals.end()) {
                                        _model->remove_note_unlocked (i->note);
                                        temporary_removals.insert (i->note);
                                }
-                               i->note->set_note (i->new_value);
+                               i->note->set_note (i->new_value.get_int());
                                break;
 
                        case StartTime:
                                if (temporary_removals.find (i->note) == temporary_removals.end()) {
                                        _model->remove_note_unlocked (i->note);
                                        temporary_removals.insert (i->note);
-
                                }
-                               i->note->set_time (i->new_time);
+                               i->note->set_time (i->new_value.get_beats());
                                break;
 
                        case Channel:
@@ -291,24 +291,23 @@ MidiModel::NoteDiffCommand::operator() ()
                                        _model->remove_note_unlocked (i->note);
                                        temporary_removals.insert (i->note);
                                }
-                               i->note->set_channel (i->new_value);
+                               i->note->set_channel (i->new_value.get_int());
                                break;
 
                                /* no remove-then-add required for these properties, since we do not index them
                                 */
 
                        case Velocity:
-                               i->note->set_velocity (i->new_value);
+                               i->note->set_velocity (i->new_value.get_int());
                                break;
 
                        case Length:
-                               i->note->set_length (i->new_time);
+                               i->note->set_length (i->new_value.get_beats());
                                break;
 
                        }
                }
 
-
                for (set<NotePtr>::iterator i = temporary_removals.begin(); i != temporary_removals.end(); ++i) {
                        NoteDiffCommand side_effects (model(), "side effects");
                        if (_model->add_note_unlocked (*i, &side_effects)) {
@@ -316,23 +315,9 @@ MidiModel::NoteDiffCommand::operator() ()
                                *this += side_effects;
                        } else {
                                /* The note that we removed earlier could not be re-added.  This change record
-                                  must say that the note was removed.  It is an un-note.
+                                  must say that the note was removed.  We'll keep the changes we made, though,
+                                  as if the note is re-added by the undo the changes must also be undone.
                                */
-
-                               /* We didn't change it... */
-                               for (ChangeList::iterator j = _changes.begin(); j != _changes.end(); ) {
-
-                                       ChangeList::iterator k = j;
-                                       ++k;
-                                       
-                                       if (*i == j->note) {
-                                               _changes.erase (j);
-                                       }
-
-                                       j = k;
-                               }
-
-                               /* ...in fact, we removed it */
                                _removed_notes.push_back (*i);
                        }
                }
@@ -358,46 +343,89 @@ MidiModel::NoteDiffCommand::undo ()
                        _model->remove_note_unlocked(*i);
                }
 
-               for (NoteList::iterator i = _removed_notes.begin(); i != _removed_notes.end(); ++i) {
-                       _model->add_note_unlocked(*i);
-               }
+               /* Apply changes first; this is important in the case of a note change which
+                  resulted in the note being removed by the overlap checker.  If the overlap
+                  checker removes a note, it will be in _removed_notes.  We are going to re-add
+                  it below, but first we must undo the changes we made so that the overlap
+                  checker doesn't refuse the re-add.
+               */
 
                /* notes we modify in a way that requires remove-then-add to maintain ordering */
                set<NotePtr> temporary_removals;
 
+
+               /* lazily discover any affected notes that were not discovered when
+                * loading the history because of deletions, etc.
+                */
+
+               for (ChangeList::iterator i = _changes.begin(); i != _changes.end(); ++i) {
+                       if (!i->note) {
+                               i->note = _model->find_note (i->note_id);
+                               assert (i->note);
+                       }
+               }
+
                for (ChangeList::iterator i = _changes.begin(); i != _changes.end(); ++i) {
                        Property prop = i->property;
+
                        switch (prop) {
                        case NoteNumber:
-                               if (temporary_removals.find (i->note) == temporary_removals.end()) {
+                               if (temporary_removals.find (i->note) == temporary_removals.end() &&
+                                   find (_removed_notes.begin(), _removed_notes.end(), i->note) == _removed_notes.end()) {
+
+                                       /* We only need to mark this note for re-add if (a) we haven't
+                                          already marked it and (b) it isn't on the _removed_notes
+                                          list (which means that it has already been removed and it
+                                          will be re-added anyway)
+                                       */
+
                                        _model->remove_note_unlocked (i->note);
                                        temporary_removals.insert (i->note);
                                }
-                               i->note->set_note (i->old_value);
-                               break;
-                       case Velocity:
-                               i->note->set_velocity (i->old_value);
+                               i->note->set_note (i->old_value.get_int());
                                break;
+
                        case StartTime:
-                               if (temporary_removals.find (i->note) == temporary_removals.end()) {
+                               if (temporary_removals.find (i->note) == temporary_removals.end() &&
+                                   find (_removed_notes.begin(), _removed_notes.end(), i->note) == _removed_notes.end()) {
+
+                                       /* See above ... */
+
                                        _model->remove_note_unlocked (i->note);
                                        temporary_removals.insert (i->note);
                                }
-                               i->note->set_time (i->old_time);
-                               break;
-                       case Length:
-                               i->note->set_length (i->old_time);
+                               i->note->set_time (i->old_value.get_beats());
                                break;
+
                        case Channel:
-                               if (temporary_removals.find (i->note) == temporary_removals.end()) {
+                               if (temporary_removals.find (i->note) == temporary_removals.end() &&
+                                   find (_removed_notes.begin(), _removed_notes.end(), i->note) == _removed_notes.end()) {
+
+                                       /* See above ... */
+
                                        _model->remove_note_unlocked (i->note);
                                        temporary_removals.insert (i->note);
                                }
-                               i->note->set_channel (i->old_value);
+                               i->note->set_channel (i->old_value.get_int());
+                               break;
+
+                               /* no remove-then-add required for these properties, since we do not index them
+                                */
+
+                       case Velocity:
+                               i->note->set_velocity (i->old_value.get_int());
+                               break;
+
+                       case Length:
+                               i->note->set_length (i->old_value.get_beats());
                                break;
                        }
                }
 
+               for (NoteList::iterator i = _removed_notes.begin(); i != _removed_notes.end(); ++i) {
+                       _model->add_note_unlocked(*i);
+               }
+
                for (set<NotePtr>::iterator i = temporary_removals.begin(); i != temporary_removals.end(); ++i) {
                        _model->add_note_unlocked (*i);
                }
@@ -463,10 +491,10 @@ Evoral::Sequence<MidiModel::TimeType>::NotePtr
 MidiModel::NoteDiffCommand::unmarshal_note (XMLNode *xml_note)
 {
        unsigned int note;
-       XMLProperty* prop;
+       XMLProperty const * prop;
        unsigned int channel;
-       unsigned int time;
-       unsigned int length;
+       MidiModel::TimeType time;
+       MidiModel::TimeType length;
        unsigned int velocity;
        gint id;
 
@@ -499,7 +527,7 @@ MidiModel::NoteDiffCommand::unmarshal_note (XMLNode *xml_note)
                time_str >> time;
        } else {
                warning << "note information missing time" << endmsg;
-               time = 0;
+               time = MidiModel::TimeType();
        }
 
        if ((prop = xml_note->property("length")) != 0) {
@@ -507,7 +535,7 @@ MidiModel::NoteDiffCommand::unmarshal_note (XMLNode *xml_note)
                length_str >> length;
        } else {
                warning << "note information missing length" << endmsg;
-               length = 1;
+               length = MidiModel::TimeType(1);
        }
 
        if ((prop = xml_note->property("velocity")) != 0) {
@@ -536,9 +564,9 @@ MidiModel::NoteDiffCommand::marshal_change (const NoteChange& change)
        {
                ostringstream old_value_str (ios::ate);
                if (change.property == StartTime || change.property == Length) {
-                       old_value_str << change.old_time;
+                       old_value_str << change.old_value.get_beats();
                } else {
-                       old_value_str << (unsigned int) change.old_value;
+                       old_value_str << change.old_value.get_int();
                }
                xml_change->add_property ("old", old_value_str.str());
        }
@@ -546,16 +574,24 @@ MidiModel::NoteDiffCommand::marshal_change (const NoteChange& change)
        {
                ostringstream new_value_str (ios::ate);
                if (change.property == StartTime || change.property == Length) {
-                       new_value_str << change.new_time;
+                       new_value_str << change.new_value.get_beats();
                } else {
-                       new_value_str << (unsigned int) change.new_value;
+                       new_value_str << change.new_value.get_int();
                }
                xml_change->add_property ("new", new_value_str.str());
        }
 
        ostringstream id_str;
-       id_str << change.note->id();
-       xml_change->add_property ("id", id_str.str());
+       if (change.note) {
+               id_str << change.note->id();
+               xml_change->add_property ("id", id_str.str());
+       } else if (change.note_id) {
+               warning << _("Change has no note, using note ID") << endmsg;
+               id_str << change.note_id;
+               xml_change->add_property ("id", id_str.str());
+       } else {
+               error << _("Change has no note or note ID") << endmsg;
+       }
 
        return *xml_change;
 }
@@ -563,14 +599,15 @@ MidiModel::NoteDiffCommand::marshal_change (const NoteChange& change)
 MidiModel::NoteDiffCommand::NoteChange
 MidiModel::NoteDiffCommand::unmarshal_change (XMLNode *xml_change)
 {
-       XMLProperty* prop;
+       XMLProperty const * prop;
        NoteChange change;
+       change.note_id = 0;
 
        if ((prop = xml_change->property("property")) != 0) {
                change.property = (Property) string_2_enum (prop->value(), change.property);
        } else {
                fatal << "!!!" << endmsg;
-               /*NOTREACHED*/
+               abort(); /*NOTREACHED*/
        }
 
        if ((prop = xml_change->property ("id")) == 0) {
@@ -583,7 +620,9 @@ MidiModel::NoteDiffCommand::unmarshal_change (XMLNode *xml_change)
        if ((prop = xml_change->property ("old")) != 0) {
                istringstream old_str (prop->value());
                if (change.property == StartTime || change.property == Length) {
-                       old_str >> change.old_time;
+                       Evoral::Beats old_time;
+                       old_str >> old_time;
+                       change.old_value = old_time;
                } else {
                        int integer_value_so_that_istream_does_the_right_thing;
                        old_str >> integer_value_so_that_istream_does_the_right_thing;
@@ -591,13 +630,15 @@ MidiModel::NoteDiffCommand::unmarshal_change (XMLNode *xml_change)
                }
        } else {
                fatal << "!!!" << endmsg;
-               /*NOTREACHED*/
+               abort(); /*NOTREACHED*/
        }
 
        if ((prop = xml_change->property ("new")) != 0) {
                istringstream new_str (prop->value());
                if (change.property == StartTime || change.property == Length) {
-                       new_str >> change.new_time;
+                       Evoral::Beats new_time;
+                       new_str >> new_time;
+                       change.new_value = Variant(new_time);
                } else {
                        int integer_value_so_that_istream_does_the_right_thing;
                        new_str >> integer_value_so_that_istream_does_the_right_thing;
@@ -605,19 +646,17 @@ MidiModel::NoteDiffCommand::unmarshal_change (XMLNode *xml_change)
                }
        } else {
                fatal << "!!!" << endmsg;
-               /*NOTREACHED*/
+               abort(); /*NOTREACHED*/
        }
 
        /* we must point at the instance of the note that is actually in the model.
-          so go look for it ...
+          so go look for it ... it may not be there (it could have been
+          deleted in a later operation, so store the note id so that we can
+          look it up again later).
        */
 
        change.note = _model->find_note (note_id);
-
-       if (!change.note) {
-               warning << "MIDI note #" << note_id << " not found in model - programmers should investigate this" << endmsg;
-               return change;
-       }
+       change.note_id = note_id;
 
        return change;
 }
@@ -687,29 +726,29 @@ MidiModel::NoteDiffCommand::get_state ()
        diff_command->add_property("midi-source", _model->midi_source()->id().to_s());
 
        XMLNode* changes = diff_command->add_child(DIFF_NOTES_ELEMENT);
-       for_each(_changes.begin(), _changes.end(), 
+       for_each(_changes.begin(), _changes.end(),
                 boost::bind (
                         boost::bind (&XMLNode::add_child_nocopy, changes, _1),
                         boost::bind (&NoteDiffCommand::marshal_change, this, _1)));
 
        XMLNode* added_notes = diff_command->add_child(ADDED_NOTES_ELEMENT);
-       for_each(_added_notes.begin(), _added_notes.end(), 
+       for_each(_added_notes.begin(), _added_notes.end(),
                 boost::bind(
                         boost::bind (&XMLNode::add_child_nocopy, added_notes, _1),
                         boost::bind (&NoteDiffCommand::marshal_note, this, _1)));
 
        XMLNode* removed_notes = diff_command->add_child(REMOVED_NOTES_ELEMENT);
-       for_each(_removed_notes.begin(), _removed_notes.end(), 
+       for_each(_removed_notes.begin(), _removed_notes.end(),
                 boost::bind (
                         boost::bind (&XMLNode::add_child_nocopy, removed_notes, _1),
                         boost::bind (&NoteDiffCommand::marshal_note, this, _1)));
 
-       /* if this command had side-effects, store that state too 
+       /* if this command had side-effects, store that state too
         */
 
        if (!side_effect_removals.empty()) {
                XMLNode* side_effect_notes = diff_command->add_child(SIDE_EFFECT_REMOVALS_ELEMENT);
-               for_each(side_effect_removals.begin(), side_effect_removals.end(), 
+               for_each(side_effect_removals.begin(), side_effect_removals.end(),
                         boost::bind (
                                 boost::bind (&XMLNode::add_child_nocopy, side_effect_notes, _1),
                                 boost::bind (&NoteDiffCommand::marshal_note, this, _1)));
@@ -744,6 +783,19 @@ MidiModel::SysExDiffCommand::operator() ()
        {
                MidiModel::WriteLock lock (_model->edit_lock ());
 
+               for (list<SysExPtr>::iterator i = _removed.begin(); i != _removed.end(); ++i) {
+                       _model->remove_sysex_unlocked (*i);
+               }
+
+               /* find any sysex events that were missing when unmarshalling */
+
+               for (ChangeList::iterator i = _changes.begin(); i != _changes.end(); ++i) {
+                       if (!i->sysex) {
+                               i->sysex = _model->find_sysex (i->sysex_id);
+                               assert (i->sysex);
+                       }
+               }
+
                for (ChangeList::iterator i = _changes.begin(); i != _changes.end(); ++i) {
                        switch (i->property) {
                        case Time:
@@ -761,6 +813,19 @@ MidiModel::SysExDiffCommand::undo ()
        {
                MidiModel::WriteLock lock (_model->edit_lock ());
 
+               for (list<SysExPtr>::iterator i = _removed.begin(); i != _removed.end(); ++i) {
+                       _model->add_sysex_unlocked (*i);
+               }
+
+               /* find any sysex events that were missing when unmarshalling */
+
+               for (ChangeList::iterator i = _changes.begin(); i != _changes.end(); ++i) {
+                       if (!i->sysex) {
+                               i->sysex = _model->find_sysex (i->sysex_id);
+                               assert (i->sysex);
+                       }
+               }
+
                for (ChangeList::iterator i = _changes.begin(); i != _changes.end(); ++i) {
                        switch (i->property) {
                        case Time:
@@ -774,6 +839,12 @@ MidiModel::SysExDiffCommand::undo ()
        _model->ContentsChanged(); /* EMIT SIGNAL */
 }
 
+void
+MidiModel::SysExDiffCommand::remove (SysExPtr sysex)
+{
+       _removed.push_back(sysex);
+}
+
 XMLNode&
 MidiModel::SysExDiffCommand::marshal_change (const Change& change)
 {
@@ -805,14 +876,14 @@ MidiModel::SysExDiffCommand::marshal_change (const Change& change)
 MidiModel::SysExDiffCommand::Change
 MidiModel::SysExDiffCommand::unmarshal_change (XMLNode *xml_change)
 {
-       XMLProperty* prop;
+       XMLProperty const * prop;
        Change change;
 
        if ((prop = xml_change->property ("property")) != 0) {
                change.property = (Property) string_2_enum (prop->value(), change.property);
        } else {
                fatal << "!!!" << endmsg;
-               /*NOTREACHED*/
+               abort(); /*NOTREACHED*/
        }
 
        if ((prop = xml_change->property ("id")) == 0) {
@@ -827,7 +898,7 @@ MidiModel::SysExDiffCommand::unmarshal_change (XMLNode *xml_change)
                old_str >> change.old_time;
        } else {
                fatal << "!!!" << endmsg;
-               /*NOTREACHED*/
+               abort(); /*NOTREACHED*/
        }
 
        if ((prop = xml_change->property ("new")) != 0) {
@@ -835,7 +906,7 @@ MidiModel::SysExDiffCommand::unmarshal_change (XMLNode *xml_change)
                new_str >> change.new_time;
        } else {
                fatal << "!!!" << endmsg;
-               /*NOTREACHED*/
+               abort(); /*NOTREACHED*/
        }
 
        /* we must point at the instance of the sysex that is actually in the model.
@@ -843,11 +914,7 @@ MidiModel::SysExDiffCommand::unmarshal_change (XMLNode *xml_change)
        */
 
        change.sysex = _model->find_sysex (sysex_id);
-
-       if (!change.sysex) {
-               warning << "Sys-ex #" << sysex_id << " not found in model - programmers should investigate this" << endmsg;
-               return change;
-       }
+       change.sysex_id = sysex_id;
 
        return change;
 }
@@ -882,7 +949,7 @@ MidiModel::SysExDiffCommand::get_state ()
        diff_command->add_property ("midi-source", _model->midi_source()->id().to_s());
 
        XMLNode* changes = diff_command->add_child(DIFF_SYSEXES_ELEMENT);
-       for_each (_changes.begin(), _changes.end(), 
+       for_each (_changes.begin(), _changes.end(),
                  boost::bind (
                          boost::bind (&XMLNode::add_child_nocopy, changes, _1),
                          boost::bind (&SysExDiffCommand::marshal_change, this, _1)));
@@ -890,6 +957,449 @@ MidiModel::SysExDiffCommand::get_state ()
        return *diff_command;
 }
 
+MidiModel::PatchChangeDiffCommand::PatchChangeDiffCommand (boost::shared_ptr<MidiModel> m, const string& name)
+       : DiffCommand (m, name)
+{
+       assert (_model);
+}
+
+MidiModel::PatchChangeDiffCommand::PatchChangeDiffCommand (boost::shared_ptr<MidiModel> m, const XMLNode & node)
+       : DiffCommand (m, "")
+{
+       assert (_model);
+       set_state (node, Stateful::loading_state_version);
+}
+
+void
+MidiModel::PatchChangeDiffCommand::add (PatchChangePtr p)
+{
+       _added.push_back (p);
+}
+
+void
+MidiModel::PatchChangeDiffCommand::remove (PatchChangePtr p)
+{
+       _removed.push_back (p);
+}
+
+void
+MidiModel::PatchChangeDiffCommand::change_time (PatchChangePtr patch, TimeType t)
+{
+       Change c;
+       c.property = Time;
+       c.patch = patch;
+       c.old_time = patch->time ();
+       c.new_time = t;
+
+       _changes.push_back (c);
+}
+
+void
+MidiModel::PatchChangeDiffCommand::change_channel (PatchChangePtr patch, uint8_t channel)
+{
+       Change c;
+       c.property = Channel;
+       c.patch = patch;
+       c.old_channel = patch->channel ();
+       c.new_channel = channel;
+       c.patch_id = patch->id();
+
+       _changes.push_back (c);
+}
+
+void
+MidiModel::PatchChangeDiffCommand::change_program (PatchChangePtr patch, uint8_t program)
+{
+       Change c;
+       c.property = Program;
+       c.patch = patch;
+       c.old_program = patch->program ();
+       c.new_program = program;
+       c.patch_id = patch->id();
+
+       _changes.push_back (c);
+}
+
+void
+MidiModel::PatchChangeDiffCommand::change_bank (PatchChangePtr patch, int bank)
+{
+       Change c;
+       c.property = Bank;
+       c.patch = patch;
+       c.old_bank = patch->bank ();
+       c.new_bank = bank;
+
+       _changes.push_back (c);
+}
+
+void
+MidiModel::PatchChangeDiffCommand::operator() ()
+{
+       {
+               MidiModel::WriteLock lock (_model->edit_lock ());
+
+               for (list<PatchChangePtr>::iterator i = _added.begin(); i != _added.end(); ++i) {
+                       _model->add_patch_change_unlocked (*i);
+               }
+
+               for (list<PatchChangePtr>::iterator i = _removed.begin(); i != _removed.end(); ++i) {
+                       _model->remove_patch_change_unlocked (*i);
+               }
+
+               /* find any patch change events that were missing when unmarshalling */
+
+               for (ChangeList::iterator i = _changes.begin(); i != _changes.end(); ++i) {
+                       if (!i->patch) {
+                               i->patch = _model->find_patch_change (i->patch_id);
+                               assert (i->patch);
+                       }
+               }
+
+               set<PatchChangePtr> temporary_removals;
+
+               for (ChangeList::iterator i = _changes.begin(); i != _changes.end(); ++i) {
+                       switch (i->property) {
+                       case Time:
+                               if (temporary_removals.find (i->patch) == temporary_removals.end()) {
+                                       _model->remove_patch_change_unlocked (i->patch);
+                                       temporary_removals.insert (i->patch);
+                               }
+                               i->patch->set_time (i->new_time);
+                               break;
+
+                       case Channel:
+                               i->patch->set_channel (i->new_channel);
+                               break;
+
+                       case Program:
+                               i->patch->set_program (i->new_program);
+                               break;
+
+                       case Bank:
+                               i->patch->set_bank (i->new_bank);
+                               break;
+                       }
+               }
+
+               for (set<PatchChangePtr>::iterator i = temporary_removals.begin(); i != temporary_removals.end(); ++i) {
+                       _model->add_patch_change_unlocked (*i);
+               }
+       }
+
+       _model->ContentsChanged (); /* EMIT SIGNAL */
+}
+
+void
+MidiModel::PatchChangeDiffCommand::undo ()
+{
+       {
+               MidiModel::WriteLock lock (_model->edit_lock());
+
+               for (list<PatchChangePtr>::iterator i = _added.begin(); i != _added.end(); ++i) {
+                       _model->remove_patch_change_unlocked (*i);
+               }
+
+               for (list<PatchChangePtr>::iterator i = _removed.begin(); i != _removed.end(); ++i) {
+                       _model->add_patch_change_unlocked (*i);
+               }
+
+               /* find any patch change events that were missing when unmarshalling */
+
+               for (ChangeList::iterator i = _changes.begin(); i != _changes.end(); ++i) {
+                       if (!i->patch) {
+                               i->patch = _model->find_patch_change (i->patch_id);
+                               assert (i->patch);
+                       }
+               }
+
+               set<PatchChangePtr> temporary_removals;
+
+               for (ChangeList::iterator i = _changes.begin(); i != _changes.end(); ++i) {
+                       switch (i->property) {
+                       case Time:
+                               if (temporary_removals.find (i->patch) == temporary_removals.end()) {
+                                       _model->remove_patch_change_unlocked (i->patch);
+                                       temporary_removals.insert (i->patch);
+                               }
+                               i->patch->set_time (i->old_time);
+                               break;
+
+                       case Channel:
+                               i->patch->set_channel (i->old_channel);
+                               break;
+
+                       case Program:
+                               i->patch->set_program (i->old_program);
+                               break;
+
+                       case Bank:
+                               i->patch->set_bank (i->old_bank);
+                               break;
+                       }
+               }
+
+               for (set<PatchChangePtr>::iterator i = temporary_removals.begin(); i != temporary_removals.end(); ++i) {
+                       _model->add_patch_change_unlocked (*i);
+               }
+
+       }
+
+       _model->ContentsChanged (); /* EMIT SIGNAL */
+}
+
+XMLNode &
+MidiModel::PatchChangeDiffCommand::marshal_patch_change (constPatchChangePtr p)
+{
+       XMLNode* n = new XMLNode ("patch-change");
+
+       {
+               ostringstream s (ios::ate);
+               s << int (p->id ());
+               n->add_property ("id", s.str());
+       }
+
+       {
+               ostringstream s (ios::ate);
+               s << p->time ();
+               n->add_property ("time", s.str ());
+       }
+
+       {
+               ostringstream s (ios::ate);
+               s << int (p->channel ());
+               n->add_property ("channel", s.str ());
+       }
+
+       {
+               ostringstream s (ios::ate);
+               s << int (p->program ());
+               n->add_property ("program", s.str ());
+       }
+
+       {
+               ostringstream s (ios::ate);
+               s << int (p->bank ());
+               n->add_property ("bank", s.str ());
+       }
+
+       return *n;
+}
+
+XMLNode&
+MidiModel::PatchChangeDiffCommand::marshal_change (const Change& c)
+{
+       XMLNode* n = new XMLNode (X_("Change"));
+
+       n->add_property (X_("property"), enum_2_string (c.property));
+
+       {
+               ostringstream s (ios::ate);
+               if (c.property == Time) {
+                       s << c.old_time;
+               } else if (c.property == Channel) {
+                       s << c.old_channel;
+               } else if (c.property == Program) {
+                       s << int (c.old_program);
+               } else if (c.property == Bank) {
+                       s << c.old_bank;
+               }
+
+               n->add_property (X_("old"), s.str ());
+       }
+
+       {
+               ostringstream s (ios::ate);
+
+               if (c.property == Time) {
+                       s << c.new_time;
+               } else if (c.property == Channel) {
+                       s << c.new_channel;
+               } else if (c.property == Program) {
+                       s << int (c.new_program);
+               } else if (c.property == Bank) {
+                       s << c.new_bank;
+               }
+
+               n->add_property (X_("new"), s.str ());
+       }
+
+       {
+               ostringstream s;
+               s << c.patch->id ();
+               n->add_property ("id", s.str ());
+       }
+
+       return *n;
+}
+
+MidiModel::PatchChangePtr
+MidiModel::PatchChangeDiffCommand::unmarshal_patch_change (XMLNode* n)
+{
+       XMLProperty const * prop;
+       XMLProperty const * prop_id;
+       Evoral::event_id_t id = 0;
+       Evoral::Beats time = Evoral::Beats();
+       int channel = 0;
+       int program = 0;
+       int bank = 0;
+
+       if ((prop_id = n->property ("id")) != 0) {
+               istringstream s (prop_id->value());
+               s >> id;
+       }
+
+       if ((prop = n->property ("time")) != 0) {
+               istringstream s (prop->value ());
+               s >> time;
+       }
+
+       if ((prop = n->property ("channel")) != 0) {
+               istringstream s (prop->value ());
+               s >> channel;
+       }
+
+       if ((prop = n->property ("program")) != 0) {
+               istringstream s (prop->value ());
+               s >> program;
+       }
+
+       if ((prop = n->property ("bank")) != 0) {
+               istringstream s (prop->value ());
+               s >> bank;
+       }
+
+       PatchChangePtr p (new Evoral::PatchChange<TimeType> (time, channel, program, bank));
+       assert(prop_id);
+       p->set_id (id);
+       return p;
+}
+
+MidiModel::PatchChangeDiffCommand::Change
+MidiModel::PatchChangeDiffCommand::unmarshal_change (XMLNode* n)
+{
+       XMLProperty const * prop;
+       Change c;
+       int an_int;
+
+       prop = n->property ("property");
+       assert (prop);
+       c.property = (Property) string_2_enum (prop->value(), c.property);
+
+       prop = n->property ("id");
+       assert (prop);
+       Evoral::event_id_t const id = atoi (prop->value().c_str());
+
+       /* we need to load via an int intermediate for all properties that are
+          actually uint8_t (char/byte).
+       */
+
+       prop = n->property ("old");
+       assert (prop);
+       {
+               istringstream s (prop->value ());
+               if (c.property == Time) {
+                       s >> c.old_time;
+               } else if (c.property == Channel) {
+                       s >> an_int;
+                       c.old_channel = an_int;
+               } else if (c.property == Program) {
+                       s >> an_int;
+                       c.old_program = an_int;
+               } else if (c.property == Bank) {
+                       s >> an_int;
+                       c.old_bank = an_int;
+               }
+       }
+
+       prop = n->property ("new");
+       assert (prop);
+       {
+               istringstream s (prop->value ());
+
+               if (c.property == Time) {
+                       s >> c.new_time;
+               } else if (c.property == Channel) {
+                       s >> an_int;
+                       c.new_channel = an_int;
+               } else if (c.property == Program) {
+                       s >> an_int;
+                       c.new_program = an_int;
+               } else if (c.property == Bank) {
+                       s >> an_int;
+                       c.new_bank = an_int;
+               }
+       }
+
+       c.patch = _model->find_patch_change (id);
+       c.patch_id = id;
+
+       return c;
+}
+
+int
+MidiModel::PatchChangeDiffCommand::set_state (const XMLNode& diff_command, int /*version*/)
+{
+       if (diff_command.name() != PATCH_CHANGE_DIFF_COMMAND_ELEMENT) {
+               return 1;
+       }
+
+       _added.clear ();
+       XMLNode* added = diff_command.child (ADDED_PATCH_CHANGES_ELEMENT);
+       if (added) {
+               XMLNodeList p = added->children ();
+               transform (p.begin(), p.end(), back_inserter (_added), boost::bind (&PatchChangeDiffCommand::unmarshal_patch_change, this, _1));
+       }
+
+       _removed.clear ();
+       XMLNode* removed = diff_command.child (REMOVED_PATCH_CHANGES_ELEMENT);
+       if (removed) {
+               XMLNodeList p = removed->children ();
+               transform (p.begin(), p.end(), back_inserter (_removed), boost::bind (&PatchChangeDiffCommand::unmarshal_patch_change, this, _1));
+       }
+
+       _changes.clear ();
+       XMLNode* changed = diff_command.child (DIFF_PATCH_CHANGES_ELEMENT);
+       if (changed) {
+               XMLNodeList p = changed->children ();
+               transform (p.begin(), p.end(), back_inserter (_changes), boost::bind (&PatchChangeDiffCommand::unmarshal_change, this, _1));
+       }
+
+       return 0;
+}
+
+XMLNode &
+MidiModel::PatchChangeDiffCommand::get_state ()
+{
+       XMLNode* diff_command = new XMLNode (PATCH_CHANGE_DIFF_COMMAND_ELEMENT);
+       diff_command->add_property("midi-source", _model->midi_source()->id().to_s());
+
+       XMLNode* added = diff_command->add_child (ADDED_PATCH_CHANGES_ELEMENT);
+       for_each (_added.begin(), _added.end(),
+                 boost::bind (
+                         boost::bind (&XMLNode::add_child_nocopy, added, _1),
+                         boost::bind (&PatchChangeDiffCommand::marshal_patch_change, this, _1)
+                         )
+               );
+
+       XMLNode* removed = diff_command->add_child (REMOVED_PATCH_CHANGES_ELEMENT);
+       for_each (_removed.begin(), _removed.end(),
+                 boost::bind (
+                         boost::bind (&XMLNode::add_child_nocopy, removed, _1),
+                         boost::bind (&PatchChangeDiffCommand::marshal_patch_change, this, _1)
+                         )
+               );
+
+       XMLNode* changes = diff_command->add_child (DIFF_PATCH_CHANGES_ELEMENT);
+       for_each (_changes.begin(), _changes.end(),
+                 boost::bind (
+                         boost::bind (&XMLNode::add_child_nocopy, changes, _1),
+                         boost::bind (&PatchChangeDiffCommand::marshal_change, this, _1)
+                         )
+               );
+
+       return *diff_command;
+}
+
 /** Write all of the model to a MidiSource (i.e. save the model).
  * This is different from manually using read to write to a source in that
  * note off events are written regardless of the track mode.  This is so the
@@ -901,28 +1411,26 @@ MidiModel::SysExDiffCommand::get_state ()
  * `Discrete' mode).
  */
 bool
-MidiModel::write_to (boost::shared_ptr<MidiSource> source)
+MidiModel::write_to (boost::shared_ptr<MidiSource>     source,
+                     const Glib::Threads::Mutex::Lock& source_lock)
 {
        ReadLock lock(read_lock());
 
        const bool old_percussive = percussive();
        set_percussive(false);
 
-       boost::shared_ptr<MidiSource> ms = _midi_source.lock ();
-       assert (ms);
-       
-       source->drop_model();
-       source->mark_streaming_midi_write_started (note_mode(), ms->timeline_position ());
+       source->drop_model(source_lock);
+       source->mark_streaming_midi_write_started (source_lock, note_mode());
 
-       for (Evoral::Sequence<TimeType>::const_iterator i = begin(0, true); i != end(); ++i) {
-               source->append_event_unlocked_beats(*i);
+       for (Evoral::Sequence<TimeType>::const_iterator i = begin(TimeType(), true); i != end(); ++i) {
+               source->append_event_beats(source_lock, *i);
        }
 
        set_percussive(old_percussive);
-       source->mark_streaming_write_completed();
+       source->mark_streaming_write_completed(source_lock);
 
        set_edited(false);
-        
+
        return true;
 }
 
@@ -932,7 +1440,7 @@ MidiModel::write_to (boost::shared_ptr<MidiSource> source)
     of the model.
 */
 bool
-MidiModel::sync_to_source ()
+MidiModel::sync_to_source (const Glib::Threads::Mutex::Lock& source_lock)
 {
        ReadLock lock(read_lock());
 
@@ -940,19 +1448,27 @@ MidiModel::sync_to_source ()
        set_percussive(false);
 
        boost::shared_ptr<MidiSource> ms = _midi_source.lock ();
-       assert (ms);
-       
-       ms->mark_streaming_midi_write_started (note_mode(), ms->timeline_position());
+       if (!ms) {
+               error << "MIDI model has no source to sync to" << endmsg;
+               return false;
+       }
+
+       /* Invalidate and store active notes, which will be picked up by the iterator
+          on the next roll if time progresses linearly. */
+       ms->invalidate(source_lock,
+                      ms->session().transport_rolling() ? &_active_notes : NULL);
 
-       for (Evoral::Sequence<TimeType>::const_iterator i = begin(0, true); i != end(); ++i) {
-               ms->append_event_unlocked_beats(*i);
+       ms->mark_streaming_midi_write_started (source_lock, note_mode());
+
+       for (Evoral::Sequence<TimeType>::const_iterator i = begin(TimeType(), true); i != end(); ++i) {
+               ms->append_event_beats(source_lock, *i);
        }
 
        set_percussive (old_percussive);
-       ms->mark_streaming_write_completed ();
+       ms->mark_streaming_write_completed (source_lock);
 
        set_edited (false);
-        
+
        return true;
 }
 
@@ -964,28 +1480,27 @@ MidiModel::sync_to_source ()
  * destroying the original note durations.
  */
 bool
-MidiModel::write_section_to (boost::shared_ptr<MidiSource> source, Evoral::MusicalTime begin_time, Evoral::MusicalTime end_time)
+MidiModel::write_section_to (boost::shared_ptr<MidiSource>     source,
+                             const Glib::Threads::Mutex::Lock& source_lock,
+                             Evoral::Beats                     begin_time,
+                             Evoral::Beats                     end_time)
 {
        ReadLock lock(read_lock());
        MidiStateTracker mst;
-       Evoral::MusicalTime extra_note_on_time = end_time;
 
        const bool old_percussive = percussive();
        set_percussive(false);
 
-       boost::shared_ptr<MidiSource> ms = _midi_source.lock ();
-       assert (ms);
-       
-       source->drop_model();
-       source->mark_streaming_midi_write_started (note_mode(), ms->timeline_position());
+       source->drop_model(source_lock);
+       source->mark_streaming_midi_write_started (source_lock, note_mode());
 
-       for (Evoral::Sequence<TimeType>::const_iterator i = begin(0, true); i != end(); ++i) {
-               const Evoral::Event<Evoral::MusicalTime>& ev (*i);
+       for (Evoral::Sequence<TimeType>::const_iterator i = begin(TimeType(), true); i != end(); ++i) {
+               const Evoral::Event<Evoral::Beats>& ev (*i);
 
                if (ev.time() >= begin_time && ev.time() < end_time) {
 
-                       const Evoral::MIDIEvent<Evoral::MusicalTime>* mev = 
-                               static_cast<const Evoral::MIDIEvent<Evoral::MusicalTime>* > (&ev);
+                       const Evoral::MIDIEvent<Evoral::Beats>* mev =
+                               static_cast<const Evoral::MIDIEvent<Evoral::Beats>* > (&ev);
 
                        if (!mev) {
                                continue;
@@ -995,45 +1510,29 @@ MidiModel::write_section_to (boost::shared_ptr<MidiSource> source, Evoral::Music
                        if (mev->is_note_off()) {
 
                                if (!mst.active (mev->note(), mev->channel())) {
-
-                                       /* add a note-on at the start of the range we're writing
-                                          to the file. velocity is just an arbitary reasonable value.
+                                       /* the matching note-on was outside the
+                                          time range we were given, so just
+                                          ignore this note-off.
                                        */
-
-                                       Evoral::MIDIEvent<Evoral::MusicalTime> on (mev->event_type(), extra_note_on_time, 3, 0, true);
-                                       on.set_type (mev->type());
-                                       on.set_note (mev->note());
-                                       on.set_channel (mev->channel());
-                                       on.set_velocity (mev->velocity());
-
-                                       cerr << "Add note on for odd note off, note = " << (int) on.note() << endl;
-                                       source->append_event_unlocked_beats (on);
-                                       mst.add (on.note(), on.channel());
-                                       mst.dump (cerr);
-                                       extra_note_on_time += 1.0/128.0;
+                                       continue;
                                }
 
-                               cerr << "MIDI Note off (note = " << (int) mev->note() << endl;
-                               source->append_event_unlocked_beats (*i);
+                               source->append_event_beats (source_lock, *i);
                                mst.remove (mev->note(), mev->channel());
-                               mst.dump (cerr);
 
                        } else if (mev->is_note_on()) {
-                               cerr << "MIDI Note on (note = " << (int) mev->note() << endl;
                                mst.add (mev->note(), mev->channel());
-                               source->append_event_unlocked_beats(*i);
-                               mst.dump (cerr);
+                               source->append_event_beats(source_lock, *i);
                        } else {
-                               cerr << "MIDI other event type\n";
-                               source->append_event_unlocked_beats(*i);
+                               source->append_event_beats(source_lock, *i);
                        }
                }
        }
 
-       mst.resolve_notes (*source, end_time);
+       mst.resolve_notes (*source, source_lock, end_time);
 
        set_percussive(old_percussive);
-       source->mark_streaming_write_completed();
+       source->mark_streaming_write_completed(source_lock);
 
        set_edited(false);
 
@@ -1084,6 +1583,18 @@ MidiModel::find_note (gint note_id)
        return NotePtr();
 }
 
+MidiModel::PatchChangePtr
+MidiModel::find_patch_change (Evoral::event_id_t id)
+{
+       for (PatchChanges::iterator i = patch_changes().begin(); i != patch_changes().end(); ++i) {
+               if ((*i)->id() == id) {
+                       return *i;
+               }
+       }
+
+       return PatchChangePtr ();
+}
+
 boost::shared_ptr<Evoral::Event<MidiModel::TimeType> >
 MidiModel::find_sysex (gint sysex_id)
 {
@@ -1106,27 +1617,21 @@ MidiModel::find_sysex (gint sysex_id)
 MidiModel::WriteLock
 MidiModel::edit_lock()
 {
-       boost::shared_ptr<MidiSource> ms = _midi_source.lock ();
-       assert (ms);
+       boost::shared_ptr<MidiSource> ms          = _midi_source.lock();
+       Glib::Threads::Mutex::Lock*   source_lock = 0;
+
+       if (ms) {
+               /* Take source lock and invalidate iterator to release its lock on model.
+                  Add currently active notes to _active_notes so we can restore them
+                  if playback resumes at the same point after the edit. */
+               source_lock = new Glib::Threads::Mutex::Lock(ms->mutex());
+               ms->invalidate(*source_lock,
+                              ms->session().transport_rolling() ? &_active_notes : NULL);
+       }
 
-       Glib::Mutex::Lock* source_lock = new Glib::Mutex::Lock (ms->mutex());
-       ms->invalidate(); // Release cached iterator's read lock on model
        return WriteLock(new WriteLockImpl(source_lock, _lock, _control_lock));
 }
 
-/** Lock just the model, the source lock must already be held.
- * This should only be called from libardour/evoral places
- */
-MidiModel::WriteLock
-MidiModel::write_lock()
-{
-       boost::shared_ptr<MidiSource> ms = _midi_source.lock ();
-       assert (ms);
-
-       assert (!ms->mutex().trylock ());
-       return WriteLock(new WriteLockImpl(NULL, _lock, _control_lock));
-}
-
 int
 MidiModel::resolve_overlaps_unlocked (const NotePtr note, void* arg)
 {
@@ -1142,7 +1647,7 @@ MidiModel::resolve_overlaps_unlocked (const NotePtr note, void* arg)
        TimeType ea  = note->end_time();
 
        const Pitches& p (pitches (note->channel()));
-       NotePtr search_note(new Note<TimeType>(0, 0, 0, note->note()));
+       NotePtr search_note(new Note<TimeType>(0, TimeType(), TimeType(), note->note()));
        set<NotePtr> to_be_deleted;
        bool set_note_length = false;
        bool set_note_time = false;
@@ -1150,8 +1655,8 @@ MidiModel::resolve_overlaps_unlocked (const NotePtr note, void* arg)
        TimeType note_length = note->length();
 
        DEBUG_TRACE (DEBUG::Sequence, string_compose ("%1 checking overlaps for note %2 @ %3\n", this, (int)note->note(), note->time()));
-       
-       for (Pitches::const_iterator i = p.lower_bound (search_note); 
+
+       for (Pitches::const_iterator i = p.lower_bound (search_note);
             i != p.end() && (*i)->note() == note->note(); ++i) {
 
                TimeType sb = (*i)->time();
@@ -1160,9 +1665,9 @@ MidiModel::resolve_overlaps_unlocked (const NotePtr note, void* arg)
 
                if ((sb > sa) && (eb <= ea)) {
                        overlap = OverlapInternal;
-               } else if ((eb >= sa) && (eb <= ea)) {
+               } else if ((eb > sa) && (eb <= ea)) {
                        overlap = OverlapStart;
-               } else if ((sb > sa) && (sb <= ea)) {
+               } else if ((sb > sa) && (sb < ea)) {
                        overlap = OverlapEnd;
                } else if ((sa >= sb) && (sa <= eb) && (ea <= eb)) {
                        overlap = OverlapExternal;
@@ -1171,8 +1676,9 @@ MidiModel::resolve_overlaps_unlocked (const NotePtr note, void* arg)
                        continue;
                }
 
-               DEBUG_TRACE (DEBUG::Sequence, string_compose ("\toverlap is %1 for (%2,%3) vs (%4,%5)\n", enum_2_string(overlap), 
-                                                             sa, ea, sb, eb));
+               DEBUG_TRACE (DEBUG::Sequence, string_compose (
+                                    "\toverlap is %1 for (%2,%3) vs (%4,%5)\n",
+                                    enum_2_string(overlap), sa, ea, sb, eb));
 
                if (insert_merge_policy() == InsertMergeReject) {
                        DEBUG_TRACE (DEBUG::Sequence, string_compose ("%1 just reject\n", this));
@@ -1202,12 +1708,12 @@ MidiModel::resolve_overlaps_unlocked (const NotePtr note, void* arg)
                        case InsertMergeExtend:
                                if (cmd) {
                                        cmd->change ((*i), NoteDiffCommand::Length, note->end_time() - (*i)->time());
-                               } 
+                               }
                                (*i)->set_length (note->end_time() - (*i)->time());
                                return -1; /* do not add the new note */
                                break;
                        default:
-                               /*NOTREACHED*/
+                               abort(); /*NOTREACHED*/
                                /* stupid gcc */
                                break;
                        }
@@ -1243,7 +1749,7 @@ MidiModel::resolve_overlaps_unlocked (const NotePtr note, void* arg)
                                note_length = min (note_length, (*i)->end_time() - note->time());
                                break;
                        default:
-                               /*NOTREACHED*/
+                               abort(); /*NOTREACHED*/
                                /* stupid gcc */
                                break;
                        }
@@ -1262,7 +1768,7 @@ MidiModel::resolve_overlaps_unlocked (const NotePtr note, void* arg)
                                /* cannot add in this case */
                                return -1;
                        default:
-                               /*NOTREACHED*/
+                               abort(); /*NOTREACHED*/
                                /* stupid gcc */
                                break;
                        }
@@ -1280,14 +1786,14 @@ MidiModel::resolve_overlaps_unlocked (const NotePtr note, void* arg)
                                to_be_deleted.insert (*i);
                                break;
                        default:
-                               /*NOTREACHED*/
+                               abort(); /*NOTREACHED*/
                                /* stupid gcc */
                                break;
                        }
                        break;
 
                default:
-                       /*NOTREACHED*/
+                       abort(); /*NOTREACHED*/
                        /* stupid gcc */
                        break;
                }
@@ -1304,14 +1810,14 @@ MidiModel::resolve_overlaps_unlocked (const NotePtr note, void* arg)
        if (set_note_time) {
                if (cmd) {
                        cmd->change (note, NoteDiffCommand::StartTime, note_time);
-               } 
+               }
                note->set_time (note_time);
        }
 
        if (set_note_length) {
                if (cmd) {
                        cmd->change (note, NoteDiffCommand::Length, note_length);
-               } 
+               }
                note->set_length (note_length);
        }
 
@@ -1319,7 +1825,7 @@ MidiModel::resolve_overlaps_unlocked (const NotePtr note, void* arg)
 }
 
 InsertMergePolicy
-MidiModel::insert_merge_policy () const 
+MidiModel::insert_merge_policy () const
 {
        /* XXX ultimately this should be a per-track or even per-model policy */
        boost::shared_ptr<MidiSource> ms = _midi_source.lock ();
@@ -1327,14 +1833,15 @@ MidiModel::insert_merge_policy () const
 
        return ms->session().config.get_insert_merge_policy ();
 }
-                        
+
 void
 MidiModel::set_midi_source (boost::shared_ptr<MidiSource> s)
 {
        boost::shared_ptr<MidiSource> old = _midi_source.lock ();
-       
+
        if (old) {
-               old->invalidate ();
+               Source::Lock lm(old->mutex());
+               old->invalidate (lm);
        }
 
        _midi_source_connections.drop_connections ();
@@ -1360,7 +1867,7 @@ MidiModel::set_midi_source (boost::shared_ptr<MidiSource> s)
 void
 MidiModel::source_interpolation_changed (Evoral::Parameter p, Evoral::ControlList::InterpolationStyle s)
 {
-       Glib::Mutex::Lock lm (_control_lock);
+       Glib::Threads::Mutex::Lock lm (_control_lock);
        control(p)->list()->set_interpolation (s);
 }
 
@@ -1379,7 +1886,7 @@ MidiModel::control_list_interpolation_changed (Evoral::Parameter p, Evoral::Cont
 void
 MidiModel::source_automation_state_changed (Evoral::Parameter p, AutoState s)
 {
-       Glib::Mutex::Lock lm (_control_lock);
+       Glib::Threads::Mutex::Lock lm (_control_lock);
        boost::shared_ptr<AutomationList> al = boost::dynamic_pointer_cast<AutomationList> (control(p)->list ());
        al->set_automation_state (s);
 }
@@ -1420,7 +1927,7 @@ MidiModel::midi_source ()
        return _midi_source.lock ();
 }
 
-/** Moves notes, controllers and sys-ex to insert silence at the start of the model.
+/** Moves notes, patch changes, controllers and sys-ex to insert silence at the start of the model.
  *  Adds commands to the session's current undo stack to reflect the movements.
  */
 void
@@ -1428,16 +1935,28 @@ MidiModel::insert_silence_at_start (TimeType t)
 {
        boost::shared_ptr<MidiSource> s = _midi_source.lock ();
        assert (s);
-       
+
        /* Notes */
 
        if (!notes().empty ()) {
                NoteDiffCommand* c = new_note_diff_command ("insert silence");
-               
+
                for (Notes::const_iterator i = notes().begin(); i != notes().end(); ++i) {
                        c->change (*i, NoteDiffCommand::StartTime, (*i)->time() + t);
                }
-               
+
+               apply_command_as_subcommand (s->session(), c);
+       }
+
+       /* Patch changes */
+
+       if (!patch_changes().empty ()) {
+               PatchChangeDiffCommand* c = new_patch_change_diff_command ("insert silence");
+
+               for (PatchChanges::const_iterator i = patch_changes().begin(); i != patch_changes().end(); ++i) {
+                       c->change_time (*i, (*i)->time() + t);
+               }
+
                apply_command_as_subcommand (s->session(), c);
        }
 
@@ -1446,7 +1965,7 @@ MidiModel::insert_silence_at_start (TimeType t)
        for (Controls::iterator i = controls().begin(); i != controls().end(); ++i) {
                boost::shared_ptr<AutomationControl> ac = boost::dynamic_pointer_cast<AutomationControl> (i->second);
                XMLNode& before = ac->alist()->get_state ();
-               i->second->list()->shift (0, t);
+               i->second->list()->shift (0, t.to_double());
                XMLNode& after = ac->alist()->get_state ();
                s->session().add_command (new MementoCommand<AutomationList> (new MidiAutomationListBinder (s, i->first), &before, &after));
        }
@@ -1463,3 +1982,25 @@ MidiModel::insert_silence_at_start (TimeType t)
                apply_command_as_subcommand (s->session(), c);
        }
 }
+
+void
+MidiModel::transpose (NoteDiffCommand* c, const NotePtr note_ptr, int semitones)
+{
+       int new_note = note_ptr->note() + semitones;
+
+       if (new_note < 0) {
+               new_note = 0;
+       } else if (new_note > 127) {
+               new_note = 127;
+       }
+
+       c->change (note_ptr, NoteDiffCommand::NoteNumber, (uint8_t) new_note);
+}
+
+void
+MidiModel::control_list_marked_dirty ()
+{
+       AutomatableSequence<Evoral::Beats>::control_list_marked_dirty ();
+
+       ContentsChanged (); /* EMIT SIGNAL */
+}