X-Git-Url: https://main.carlh.net/gitweb/?p=ardour.git;a=blobdiff_plain;f=libs%2Fardour%2Fluaproc.cc;h=fbba74bba328103788c8987ae02a4a1f6b76ca51;hp=35f43b5dc10d41f949a6983ef0172b6ef4be7ce0;hb=c8c6bca6587450ff64303dbc994a4cd28d6ce7aa;hpb=946a99f554a158d569b2cea5310a1197664dcda5 diff --git a/libs/ardour/luaproc.cc b/libs/ardour/luaproc.cc index 35f43b5dc1..fbba74bba3 100644 --- a/libs/ardour/luaproc.cc +++ b/libs/ardour/luaproc.cc @@ -228,25 +228,6 @@ LuaProc::load_script () } } - // query midi i/o - luabridge::LuaRef lua_dsp_has_midi_in = luabridge::getGlobal (L, "dsp_has_midi_input"); - if (lua_dsp_has_midi_in.type () == LUA_TFUNCTION) { - try { - _has_midi_input = lua_dsp_has_midi_in (); - } catch (luabridge::LuaException const& e) { - ; - } - } - - luabridge::LuaRef lua_dsp_has_midi_out = luabridge::getGlobal (L, "dsp_has_midi_output"); - if (lua_dsp_has_midi_out.type () == LUA_TFUNCTION) { - try { - _has_midi_output = lua_dsp_has_midi_out (); - } catch (luabridge::LuaException const& e) { - ; - } - } - _ctrl_params.clear (); luabridge::LuaRef lua_render = luabridge::getGlobal (L, "render_inline"); @@ -348,22 +329,24 @@ LuaProc::can_support_io_configuration (const ChanCount& in, ChanCount& out, Chan lua_State* L = lua.getState (); luabridge::LuaRef ioconfig = luabridge::getGlobal (L, "dsp_ioconfig"); - if (!ioconfig.isFunction ()) { - return false; - } luabridge::LuaRef *_iotable = NULL; // can't use reference :( - try { - luabridge::LuaRef iotable = ioconfig (); - if (iotable.isTable ()) { - _iotable = new luabridge::LuaRef (iotable); + + if (ioconfig.isFunction ()) { + try { + luabridge::LuaRef iotable = ioconfig (); + if (iotable.isTable ()) { + _iotable = new luabridge::LuaRef (iotable); + } + } catch (luabridge::LuaException const& e) { + _iotable = NULL; } - } catch (luabridge::LuaException const& e) { - return false; } if (!_iotable) { - return false; + /* empty table as default */ + luabridge::LuaRef iotable = luabridge::newTable(L); + _iotable = new luabridge::LuaRef (iotable); } // now we can reference it. @@ -371,7 +354,9 @@ LuaProc::can_support_io_configuration (const ChanCount& in, ChanCount& out, Chan delete _iotable; if ((iotable).length () < 1) { - return false; + /* empty table as only config, to get default values */ + luabridge::LuaRef ioconf = luabridge::newTable(L); + iotable[1] = ioconf; } const int audio_in = in.n_audio (); @@ -379,45 +364,51 @@ LuaProc::can_support_io_configuration (const ChanCount& in, ChanCount& out, Chan // preferred setting (provided by plugin_insert) const int preferred_out = out.n_audio (); + const int preferred_midiout = out.n_midi (); - int midi_out = _has_midi_output ? 1 : 0; + int midi_out = -1; int audio_out = -1; float penalty = 9999; bool found = false; -#define FOUNDCFG_PENALTY(in, out, p) { \ - _output_configs.insert (out); \ - if (p < penalty) { \ - audio_out = (out); \ - if (imprecise) { \ - imprecise->set (DataType::AUDIO, (in)); \ - imprecise->set (DataType::MIDI, \ - possible_midiin); \ - } \ - penalty = p; \ - found = true; \ - } \ +#define FOUNDCFG_PENALTY(in, out, p) { \ + _output_configs.insert (out); \ + if (p < penalty) { \ + audio_out = (out); \ + midi_out = possible_midiout; \ + if (imprecise) { \ + imprecise->set (DataType::AUDIO, (in)); \ + imprecise->set (DataType::MIDI, possible_midiin); \ + } \ + _has_midi_input = (possible_midiin > 0); \ + _has_midi_output = (possible_midiout > 0); \ + penalty = p; \ + found = true; \ + } \ } -#define FOUNDCFG_IMPRECISE(in, out) { \ - float p = fabsf ((float)(out) - preferred_out); \ - if (in != audio_in) { \ - p += 1000; \ - } \ - if ((out) > preferred_out) { p *= 1.1; } \ - FOUNDCFG_PENALTY(in, out, p); \ +#define FOUNDCFG_IMPRECISE(in, out) { \ + const float p = fabsf ((float)(out) - preferred_out) * \ + (((out) > preferred_out) ? 1.1 : 1) \ + + fabsf ((float)possible_midiout - preferred_midiout) * \ + ((possible_midiout - preferred_midiout) ? 0.6 : 0.5) \ + + fabsf ((float)(in) - audio_in) * \ + (((in) > audio_in) ? 275 : 250) \ + + fabsf ((float)possible_midiin - midi_in) * \ + ((possible_midiin - midi_in) ? 100 : 110); \ + FOUNDCFG_PENALTY(in, out, p); \ } -#define FOUNDCFG(out) \ +#define FOUNDCFG(out) \ FOUNDCFG_IMPRECISE(audio_in, out) -#define ANYTHINGGOES \ +#define ANYTHINGGOES \ _output_configs.insert (0); -#define UPTO(nch) { \ - for (int n = 1; n < nch; ++n) { \ - _output_configs.insert (n); \ - } \ +#define UPTO(nch) { \ + for (int n = 1; n < nch; ++n) { \ + _output_configs.insert (n); \ + } \ } if (imprecise) { @@ -432,9 +423,10 @@ LuaProc::can_support_io_configuration (const ChanCount& in, ChanCount& out, Chan int possible_in = io["audio_in"].isNumber() ? io["audio_in"] : -1; int possible_out = io["audio_out"].isNumber() ? io["audio_out"] : -1; - int possible_midiin = _has_midi_input ? 1 : 0; + int possible_midiin = io["midi_in"].isNumber() ? io["midi_in"] : 0; + int possible_midiout = io["midi_out"].isNumber() ? io["midi_out"] : 0; - if (midi_in > 0 && possible_midiin == 0 && !imprecise) { + if (midi_in != possible_midiin && !imprecise) { continue; } @@ -445,36 +437,11 @@ LuaProc::can_support_io_configuration (const ChanCount& in, ChanCount& out, Chan FOUNDCFG_PENALTY(audio_in, preferred_out, -1); } - // "imprecise" matches - if (possible_out == 0) { - /* skip configurations with no audio output, unless - * the plugin is a midi filter or generator */ - if (possible_in == 0 && _has_midi_output) { - if (audio_in == 0) { - FOUNDCFG(possible_out); - break; - } - } + if (possible_out == 0 && possible_midiout == 0) { + /* skip configurations with no output at all */ continue; } - if (possible_in == 0) { - /* no inputs, generators & instruments */ - if (possible_out == -1 || possible_out == -2) { - /* any output configuration possible - * out == -2 is invalid, interpreted as out == -1 */ - FOUNDCFG (preferred_out); - ANYTHINGGOES; - } else if (possible_out < -2) { - /* variable number of outputs up to -N, */ - FOUNDCFG (min (-possible_out, preferred_out)); - UPTO (-possible_out); - } else { - /* exact number of outputs */ - FOUNDCFG (possible_out); - } - } - if (possible_in == -1 || possible_in == -2) { /* wildcard for input */ if (possible_out == possible_in) { @@ -497,65 +464,41 @@ LuaProc::can_support_io_configuration (const ChanCount& in, ChanCount& out, Chan } } - if (possible_in < -2 || possible_in > 0) { + if (possible_in < -2 || possible_in >= 0) { /* specified number, exact or up to */ - if (possible_in < -2 && audio_in > -possible_in && !imprecise) { - /* request is too large */ - } else if (possible_in > 0 && audio_in != possible_in) { - /* this configuration needed exacty possible_in inputs */ + int desired_in; + if (possible_in >= 0) { + /* configuration can only match possible_in */ + desired_in = possible_in; + } else { + /* configuration can match up to -possible_in */ + desired_in = min (-possible_in, audio_in); + } + if (!imprecise && audio_in != desired_in) { + /* skip that configuration, it cannot match + * the required audio input count, and we + * cannot ask for change via \imprecise */ } else if (possible_out == -1 || possible_out == -2) { /* any output configuration possible - * out == -2 is invalid, interpreted as out == -1 */ - FOUNDCFG (preferred_out); + * out == -2 is invalid, interpreted as out == -1. + * Really imprecise only if desired_in != audio_in */ + FOUNDCFG_IMPRECISE (desired_in, preferred_out); ANYTHINGGOES; } else if (possible_out < -2) { /* variable number of outputs up to -N - * not specified if in > 0, but we accept it anyway */ - FOUNDCFG (min (-possible_out, preferred_out)); + * not specified if in > 0, but we accept it anyway. + * Really imprecise only if desired_in != audio_in */ + FOUNDCFG_IMPRECISE (desired_in, min (-possible_out, preferred_out)); UPTO (-possible_out) } else { - /* exact number of outputs */ - FOUNDCFG (possible_out); + /* exact number of outputs + * Really imprecise only if desired_in != audio_in */ + FOUNDCFG_IMPRECISE (desired_in, possible_out); } } } - if (!found && imprecise) { - /* try harder */ - for (luabridge::Iterator i (iotable); !i.isNil (); ++i) { - luabridge::LuaRef io (i.value ()); - if (!io.isTable()) { - continue; - } - - int possible_in = io["audio_in"].isNumber() ? io["audio_in"] : -1; - int possible_out = io["audio_out"].isNumber() ? io["audio_out"] : -1; - int possible_midiin = _has_midi_input ? 1 : 0; - - if (possible_out == 0 && possible_in == 0 && _has_midi_output) { - assert (audio_in > 0); // no input is handled above - // TODO hide audio input from plugin - FOUNDCFG_IMPRECISE (possible_in, possible_out); - continue; - } - - assert (possible_in > 0); // all other cases will have been matched above - - if (possible_out == -1 || possible_out == -2) { - FOUNDCFG_IMPRECISE (possible_in, 2); - } else if (possible_out < -2) { - /* explicitly variable number of outputs, pick maximum */ - FOUNDCFG_IMPRECISE (possible_in, min (-possible_out, preferred_out)); - } else { - /* exact number of outputs */ - FOUNDCFG_IMPRECISE (possible_in, possible_out); - } - // ideally we'll also find the closest, best matching - // input configuration with minimal output penalty... - } - } - if (!found) { return false; }