GenericUI: only connect one PropertyChanged callback
authorJulien "_FrnchFrgg_" RIVAUD <frnchfrgg@free.fr>
Thu, 28 Jul 2016 17:43:43 +0000 (19:43 +0200)
committerJulien "_FrnchFrgg_" RIVAUD <frnchfrgg@free.fr>
Thu, 28 Jul 2016 21:19:08 +0000 (23:19 +0200)
commit63bbcf968a11a3d6e89a6983d7bb810f487d63c1
tree5bf12399b8953d75608b32561d9e19ff646baad8
parent1d173bc84fb36f73be2bc9d58251ac110e4148eb
GenericUI: only connect one PropertyChanged callback

The code connected the callback to the PropertyChanged signal from the
plugin once per filepath control created. Should the plugin have several
files to open, this would be at best wasteful and at worst racy.

Connect the callback a single time, since the same callback handles all
property updates that we're interested in. Also rename the methods,
members and typedefs so that it's clear what the code is trying to do.
gtk2_ardour/generic_pluginui.cc
gtk2_ardour/plugin_ui.h