From: Julien "_FrnchFrgg_" RIVAUD <frnchfrgg@free.fr>
Date: Thu, 28 Jul 2016 21:07:44 +0000 (+0200)
Subject: GenericUI: remove duplicate connection to signal
X-Git-Tag: 5.0-rc2~86
X-Git-Url: https://main.carlh.net/gitweb/?p=ardour.git;a=commitdiff_plain;h=3365722b8b5f3ed17b53d1e9492a4bec22db3a62

GenericUI: remove duplicate connection to signal

Now that there isn't an early return anymore for Dropdowns, the common
path takes care of connecting the display update code to the correct
signal.
---

diff --git a/gtk2_ardour/generic_pluginui.cc b/gtk2_ardour/generic_pluginui.cc
index 0b85beffca..ddaba074ce 100644
--- a/gtk2_ardour/generic_pluginui.cc
+++ b/gtk2_ardour/generic_pluginui.cc
@@ -723,10 +723,6 @@ GenericPluginUI::build_control_ui (const Evoral::Parameter&             param,
 						           i->second)));
 			}
 
-			mcontrol->Changed.connect(control_connections, invalidator(*this),
-			                          boost::bind(&GenericPluginUI::ui_parameter_changed,
-			                                      this, control_ui),
-			                          gui_context());
 
 			if (use_knob) {
 				control_ui->knobtable = manage (new Table());
@@ -925,7 +921,10 @@ GenericPluginUI::build_control_ui (const Evoral::Parameter&             param,
 	}
 
 	if (mcontrol) {
-		mcontrol->Changed.connect (control_connections, invalidator (*this), boost::bind (&GenericPluginUI::ui_parameter_changed, this, control_ui), gui_context());
+		mcontrol->Changed.connect(control_connections, invalidator(*this),
+		                          boost::bind(&GenericPluginUI::ui_parameter_changed,
+		                                      this, control_ui),
+		                          gui_context());
 	}
 
 	return control_ui;