ardour.git
8 years agoremove debug output
Paul Davis [Fri, 2 Oct 2015 20:31:30 +0000 (16:31 -0400)]
remove debug output

8 years agothe return of the 1 second fade out at session close
Paul Davis [Fri, 2 Oct 2015 20:29:58 +0000 (16:29 -0400)]
the return of the 1 second fade out at session close

8 years agofix unbound DSP calc.
Robin Gareus [Fri, 2 Oct 2015 20:28:03 +0000 (22:28 +0200)]
fix unbound DSP calc.

8 years agoescape markup in region list
Robin Gareus [Fri, 2 Oct 2015 17:38:32 +0000 (19:38 +0200)]
escape markup in region list

8 years agoadd missing markup escape
Robin Gareus [Fri, 2 Oct 2015 17:14:24 +0000 (19:14 +0200)]
add missing markup escape

(e.g. import file with ampersand)

8 years agouse new error-messages
Robin Gareus [Fri, 2 Oct 2015 15:51:17 +0000 (17:51 +0200)]
use new error-messages

8 years agodefine more backend error-messages.
Robin Gareus [Fri, 2 Oct 2015 15:49:31 +0000 (17:49 +0200)]
define more backend error-messages.

8 years agoimprove CoreAudio error reporting
Robin Gareus [Fri, 2 Oct 2015 15:28:16 +0000 (17:28 +0200)]
improve CoreAudio error reporting

8 years agofix handler of fader (pitchbend) messages in Mackie Control so that the outbound...
Paul Davis [Fri, 2 Oct 2015 14:22:00 +0000 (10:22 -0400)]
fix handler of fader (pitchbend) messages in Mackie Control so that the outbound messages match the inbound ones

Pitch bend values really can span 0 to 16384, not 16383

8 years agoallow aliasing Mackie Control buttons to other buttons
Paul Davis [Fri, 2 Oct 2015 14:21:20 +0000 (10:21 -0400)]
allow aliasing Mackie Control buttons to other buttons

8 years agoprovide Main/cancel-solo as an action and make rude solo button(s) use it
Paul Davis [Fri, 2 Oct 2015 11:32:49 +0000 (07:32 -0400)]
provide Main/cancel-solo as an action and make rude solo button(s) use it

8 years agocatch changes in click status and alter LED appropriately
Paul Davis [Fri, 2 Oct 2015 11:31:48 +0000 (07:31 -0400)]
catch changes in click status and alter LED appropriately

8 years agochange zoom and scrub handling to use modifier bits
Paul Davis [Fri, 2 Oct 2015 11:31:31 +0000 (07:31 -0400)]
change zoom and scrub handling to use modifier bits

8 years agospelling correction in error message
Paul Davis [Fri, 2 Oct 2015 11:29:51 +0000 (07:29 -0400)]
spelling correction in error message

8 years agoadd a proper license to the GCC ABI check tool
Robin Gareus [Fri, 2 Oct 2015 11:17:45 +0000 (13:17 +0200)]
add a proper license to the GCC ABI check tool

8 years agore-apply roll-delay after seek - fixes #5781
Robin Gareus [Thu, 1 Oct 2015 21:17:01 +0000 (23:17 +0200)]
re-apply roll-delay after seek - fixes #5781

8 years agoremove ancient doxyfile
Robin Gareus [Thu, 1 Oct 2015 19:58:00 +0000 (21:58 +0200)]
remove ancient doxyfile

8 years agoupdate Doxyfile
Robin Gareus [Thu, 1 Oct 2015 19:57:27 +0000 (21:57 +0200)]
update Doxyfile

8 years agothere's no class called "The" :)
Robin Gareus [Thu, 1 Oct 2015 19:39:15 +0000 (21:39 +0200)]
there's no class called "The" :)

8 years agoALSA: update error-codes for HW initialization.
Robin Gareus [Thu, 1 Oct 2015 10:42:05 +0000 (12:42 +0200)]
ALSA: update error-codes for HW initialization.

8 years agoAdd parent window argument to ARDOUR_UI::check_audioengine
Tim Mayberry [Sun, 27 Sep 2015 03:15:32 +0000 (13:15 +1000)]
Add parent window argument to ARDOUR_UI::check_audioengine

Ensures relevant placement of the dialog when presented

8 years agoDisplay warning when closing Audio Setup dialog with engine stopped
Tim Mayberry [Sat, 26 Sep 2015 10:43:47 +0000 (20:43 +1000)]
Display warning when closing Audio Setup dialog with engine stopped

Only show warning when a session is loaded

8 years agoDon't hide Audio Setup dialog when clicking 'OK' if engine fails to start
Tim Mayberry [Sat, 26 Sep 2015 10:22:46 +0000 (20:22 +1000)]
Don't hide Audio Setup dialog when clicking 'OK' if engine fails to start

This has to be handled in two places, in ARDOUR_UI::do_audio_midi_setup and in
the dialogs response handler and in as the window can also be triggered via the
window action manager.

8 years agoUse AudioSetupDialog as parent of the error message popup when failing to start engine
Tim Mayberry [Sat, 26 Sep 2015 07:49:16 +0000 (17:49 +1000)]
Use AudioSetupDialog as parent of the error message popup when failing to start engine

Without a session loaded this makes the message dialog appear in front of the
AudioSetup dialog instead of randomly up in the top left somewhere. This does
mean though that if the AudioSetup dialog is not visible the error message
popup will appear randomly up in the top left(at least on windows, it seems
fine on linux) but I will fix that shortly.

8 years agoReturn meaningful error codes when ALSA backend fails to start
Tim Mayberry [Sat, 26 Sep 2015 11:03:02 +0000 (21:03 +1000)]
Return meaningful error codes when ALSA backend fails to start

Unfortunately it seems that in zita-alsa-pcmi doesn't set state() correctly in
some cases. Setting an invalid SR doesn't display the correct error message,
first guess would be that set_hwpar is failing and state() is not
representative of the actual error.

8 years agoReturn meaningful error codes when PortaudioBackend fails to start
Tim Mayberry [Sat, 26 Sep 2015 22:53:19 +0000 (08:53 +1000)]
Return meaningful error codes when PortaudioBackend fails to start

So they can be used to give a contextual error message in the GUI

8 years agoUse portaudio error codes in the PortaudioIO class.
Tim Mayberry [Sat, 26 Sep 2015 10:49:41 +0000 (20:49 +1000)]
Use portaudio error codes in the PortaudioIO class.

Having error codes defined in PortaudioIO means it is not dependent on the
ErrorCodes in AudioBackend but it doesn't really make sense to have another
set, so just use the PA ones until they become insufficient.

8 years agoUse AudioEngine::get_last_backend_error in message dialog when failing to start engine
Tim Mayberry [Sat, 26 Sep 2015 07:27:04 +0000 (17:27 +1000)]
Use AudioEngine::get_last_backend_error in message dialog when failing to start engine

If a backend is not returning AudioBackend::ErrorCode values to indicate the
type of error then the default string will be returned which is the same as
what was previously displayed.

8 years agoReinterpret the return value of AudioBackend::start as AudioBackend::ErrorCode
Tim Mayberry [Sat, 26 Sep 2015 07:14:43 +0000 (17:14 +1000)]
Reinterpret the return value of AudioBackend::start as AudioBackend::ErrorCode

This will allow backends to return a more meaningful error message. Eventually
an error code could be returned by AudioEngine::start and the GUI can then use
AudioBackend::get_error_string to convert the error into a translated error
message directly, or it may be desirable to define its own error messages.

The reasons for not doing that right now is that this is a workable solution
with the least change required.

8 years agoAdd a couple of error codes to AudioBackend::ErrorCode
Tim Mayberry [Sat, 26 Sep 2015 07:02:37 +0000 (17:02 +1000)]
Add a couple of error codes to AudioBackend::ErrorCode

Also use the error message from ARDOUR_UI::reconnect_to_engine as the default
error string

8 years agoGray out "strip silence" and "rhtyhm ferret" for midi regions.
André Nusser [Wed, 30 Sep 2015 21:20:27 +0000 (23:20 +0200)]
Gray out "strip silence" and "rhtyhm ferret" for midi regions.

The former even triggered a segfault.

8 years agoMerge branch 'chaot4-fix_track_list_context_menu'
Paul Davis [Wed, 30 Sep 2015 18:43:13 +0000 (14:43 -0400)]
Merge branch 'chaot4-fix_track_list_context_menu'

8 years agoFixed spelling.
André Nusser [Mon, 28 Sep 2015 21:48:07 +0000 (23:48 +0200)]
Fixed spelling.

8 years agoMake all the context menu entries of the track list work.
André Nusser [Mon, 28 Sep 2015 20:14:04 +0000 (22:14 +0200)]
Make all the context menu entries of the track list work.

8 years agochange the logic for a capture buffer flush to disk when a locate is occuring
Paul Davis [Wed, 30 Sep 2015 17:02:50 +0000 (13:02 -0400)]
change the logic for a capture buffer flush to disk when a locate is occuring

We can't check for Session::actively_recording() because punch out may have disabled that. Rather
than add logic to check if a flush is needed (which is not much different than the code that runs
as part of the flush to disk), just do a flush anyway.

8 years agotweak some debug output
Paul Davis [Wed, 30 Sep 2015 17:00:55 +0000 (13:00 -0400)]
tweak some debug output

8 years agoremove apparently bogus adjustment to capture_captured in AudioDiskstream::transport_...
Paul Davis [Wed, 30 Sep 2015 16:59:58 +0000 (12:59 -0400)]
remove apparently bogus adjustment to capture_captured in AudioDiskstream::transport_looped

8 years agosplit Butler::flush_tracks_to_disk() into two distinct versions with clear names...
Paul Davis [Wed, 30 Sep 2015 16:58:36 +0000 (12:58 -0400)]
split Butler::flush_tracks_to_disk() into two distinct versions with clear names and make one of them private

8 years agois there a better way to make gcc+enumwriter happy?
Robin Gareus [Tue, 29 Sep 2015 13:50:43 +0000 (15:50 +0200)]
is there a better way to make gcc+enumwriter happy?

8 years agoFix midi tracer to show MSB too. (fixes #6566)
Len Ovens [Tue, 29 Sep 2015 13:06:40 +0000 (06:06 -0700)]
Fix midi tracer to show MSB too. (fixes #6566)

8 years agoset waveform height depending on Layer mode
Robin Gareus [Tue, 29 Sep 2015 07:34:29 +0000 (09:34 +0200)]
set waveform height depending on Layer mode

Fixes background peakfile/waveform creation. Waves need to be
created directly with the proper attributes as set by StreamView.

8 years agoFix Mackie control metering (fixes #6608).
Len Ovens [Tue, 29 Sep 2015 03:13:15 +0000 (20:13 -0700)]
Fix Mackie control metering (fixes #6608).

8 years agoRevert "change the way the audio clock cursor is drawn (somewhat of an experiment...
Paul Davis [Tue, 29 Sep 2015 00:15:03 +0000 (20:15 -0400)]
Revert "change the way the audio clock cursor is drawn (somewhat of an experiment but it has some benefits"

This reverts commit 601770837e2530a73056a6aa67759d56e16e735a.

This work continued in the "clockwork" branch where it was done correctly.

8 years agoBWF USID according to EBU-R99
Robin Gareus [Mon, 28 Sep 2015 23:20:09 +0000 (01:20 +0200)]
BWF USID according to EBU-R99

8 years agochange clearlooks style file so that small_entry and related styles use text color...
Paul Davis [Mon, 28 Sep 2015 22:20:54 +0000 (18:20 -0400)]
change clearlooks style file so that small_entry and related styles use text color for text even when selected

8 years agoMerge branch 'chaot4-fix_lock_solo_ctrl_shift'
Paul Davis [Mon, 28 Sep 2015 21:59:10 +0000 (17:59 -0400)]
Merge branch 'chaot4-fix_lock_solo_ctrl_shift'

8 years agoIntroduce Ctrl+Shift+Click on lock solo in the mixer.
André Nusser [Mon, 28 Sep 2015 16:38:33 +0000 (18:38 +0200)]
Introduce Ctrl+Shift+Click on lock solo in the mixer.

8 years agofix initialization of reserved I/O names vector
Paul Davis [Mon, 28 Sep 2015 21:52:27 +0000 (17:52 -0400)]
fix initialization of reserved I/O names vector

8 years agofix const-ness
Paul Davis [Mon, 28 Sep 2015 21:52:13 +0000 (17:52 -0400)]
fix const-ness

8 years agoRevert "add new action and loop marker menu item for setting up loop record"
Paul Davis [Mon, 28 Sep 2015 21:44:04 +0000 (17:44 -0400)]
Revert "add new action and loop marker menu item for setting up loop record"

This reverts commit ebb43508f1ab75b7d7467e0e95cdd1c816cf3183.

8 years agoget loop recording working when using seam-ed looping
Paul Davis [Mon, 28 Sep 2015 21:42:02 +0000 (17:42 -0400)]
get loop recording working when using seam-ed looping

8 years agobetter more reliable checks on renamed, newly created and imported track/bus names
Paul Davis [Mon, 28 Sep 2015 18:49:49 +0000 (14:49 -0400)]
better more reliable checks on renamed, newly created and imported track/bus names

8 years agochange semantics of 4th argument to Session::locate to mean "this locate is connected...
Paul Davis [Thu, 24 Sep 2015 17:40:55 +0000 (13:40 -0400)]
change semantics of 4th argument to Session::locate to mean "this locate is connected with play-loop just being enabled"

8 years agochange the way the audio clock cursor is drawn (somewhat of an experiment but it...
Paul Davis [Tue, 22 Sep 2015 22:25:14 +0000 (18:25 -0400)]
change the way the audio clock cursor is drawn (somewhat of an experiment but it has some benefits

8 years agowhen editing an audio clock, swallow illegal keys rather than allowing them to reach...
Paul Davis [Tue, 22 Sep 2015 22:24:49 +0000 (18:24 -0400)]
when editing an audio clock, swallow illegal keys rather than allowing them to reach the rest of the GUI

8 years agofix the logic of the GUI "toggle roll" action as it pertains to loop recording
Paul Davis [Tue, 22 Sep 2015 17:24:04 +0000 (13:24 -0400)]
fix the logic of the GUI "toggle roll" action as it pertains to loop recording

8 years agoa few new DEBUG_TRACE calls related to session transport state
Paul Davis [Tue, 22 Sep 2015 17:23:18 +0000 (13:23 -0400)]
a few new DEBUG_TRACE calls related to session transport state

8 years agominor fix for possible off-by-one logic when at/near the end of the loop range
Paul Davis [Tue, 22 Sep 2015 17:22:20 +0000 (13:22 -0400)]
minor fix for possible off-by-one logic when at/near the end of the loop range

8 years agofix a long-standing bug arising from a change to some logic which reversed an "is...
Paul Davis [Tue, 22 Sep 2015 17:21:44 +0000 (13:21 -0400)]
fix a long-standing bug arising from a change to some logic which reversed an "is-rolling" test

8 years agomove code location where loop playback is cancelled when stopping
Paul Davis [Tue, 22 Sep 2015 17:20:52 +0000 (13:20 -0400)]
move code location where loop playback is cancelled when stopping

8 years agoloop record is a feature whether or not loop-is-mode is true or not
Paul Davis [Tue, 22 Sep 2015 17:18:54 +0000 (13:18 -0400)]
loop record is a feature whether or not loop-is-mode is true or not

8 years agoSession::disable_record() should work whether we are in loop mode or not
Paul Davis [Tue, 22 Sep 2015 17:18:08 +0000 (13:18 -0400)]
Session::disable_record() should work whether we are in loop mode or not

8 years agoadd new action and loop marker menu item for setting up loop record
Paul Davis [Fri, 18 Sep 2015 22:04:25 +0000 (18:04 -0400)]
add new action and loop marker menu item for setting up loop record

8 years agofix long options of gcc-glibmm-abi-check.
Robin Gareus [Mon, 28 Sep 2015 15:02:15 +0000 (17:02 +0200)]
fix long options of gcc-glibmm-abi-check.

8 years agoremove outdated limiation
Robin Gareus [Mon, 28 Sep 2015 13:40:26 +0000 (15:40 +0200)]
remove outdated limiation

8 years agoremove cruft.
Robin Gareus [Sun, 27 Sep 2015 22:36:44 +0000 (00:36 +0200)]
remove cruft.

8 years agomixer-strip name context-menu cleanup
Robin Gareus [Sun, 27 Sep 2015 19:45:40 +0000 (21:45 +0200)]
mixer-strip name context-menu cleanup

patch thanks to chaot4

8 years agoadd deva to authors.
Robin Gareus [Sun, 27 Sep 2015 14:13:37 +0000 (16:13 +0200)]
add deva to authors.

8 years agoSort ports in state-save.
Robin Gareus [Sun, 27 Sep 2015 14:10:10 +0000 (16:10 +0200)]
Sort ports in state-save.

This results in identical XML if the session did not change, allowing
to keep track of state-changes easily (e.g. session file in git).

Thanks to deva (again).

8 years agoLV2 state cleanup, patch from deva. closes #6607
Robin Gareus [Sun, 27 Sep 2015 12:07:04 +0000 (14:07 +0200)]
LV2 state cleanup, patch from deva. closes #6607

set _impl->state on session load in order to detect state changes
properly (no not save duplicate states).

+ some small mem-leaks (free state)

8 years agoClose export directory browser dialog when clicking on 'Cancel' button, Fixes #6594
Tim Mayberry [Sun, 27 Sep 2015 11:55:20 +0000 (21:55 +1000)]
Close export directory browser dialog when clicking on 'Cancel' button, Fixes #6594

8 years agoupdate semantics of PBD::remove_directory()
Robin Gareus [Sun, 27 Sep 2015 10:44:54 +0000 (12:44 +0200)]
update semantics of PBD::remove_directory()

Remove the directory recursively including itself. The function
is used in two places only:

* LV2Plugin::add_state() -- no change, remove tmp. state
* Session::save_as()  -- on error, remove target

In both cases removing the folder itself is correct.

8 years agofix mixer group-tab width - #6572
Robin Gareus [Sat, 26 Sep 2015 23:33:02 +0000 (01:33 +0200)]
fix mixer group-tab width - #6572

EditorGroupTabs are re-exposed in the idle-callback, widgets
are packed and geometry is valid.

Mixer_UI::redisplay_track_list() does not have this property.

8 years agoaccept/ignore --gcc5abi option during packaging.
Robin Gareus [Sat, 26 Sep 2015 19:23:01 +0000 (21:23 +0200)]
accept/ignore --gcc5abi option during packaging.

8 years ago..and another packaging typo
Robin Gareus [Sat, 26 Sep 2015 18:50:56 +0000 (20:50 +0200)]
..and another packaging typo

8 years agoadd missing space.
Robin Gareus [Sat, 26 Sep 2015 18:29:45 +0000 (20:29 +0200)]
add missing space.

8 years agolinux-installer: gcc4/5 warning.
Robin Gareus [Fri, 11 Sep 2015 16:46:23 +0000 (18:46 +0200)]
linux-installer: gcc4/5 warning.

8 years agonew tool to test gcc4/5 ABI
Robin Gareus [Sat, 26 Sep 2015 16:23:19 +0000 (18:23 +0200)]
new tool to test gcc4/5 ABI

8 years agoremove old gcc ABI (libstc++) test tool
Robin Gareus [Sat, 26 Sep 2015 16:42:38 +0000 (18:42 +0200)]
remove old gcc ABI (libstc++) test tool

8 years agogcc5/c++11 deprecates std::auto_ptr
Robin Gareus [Fri, 25 Sep 2015 22:22:56 +0000 (00:22 +0200)]
gcc5/c++11 deprecates std::auto_ptr

8 years agocopy LV2 options to heap.
Robin Gareus [Fri, 25 Sep 2015 17:43:43 +0000 (19:43 +0200)]
copy LV2 options to heap.

Stack pointer becomes invalid when the array goes out of scope.
Fixes rare crash in suil_wrapper_new() or GUIs iterating over options.

8 years agofix crash at session-close, amend dec4790d
Robin Gareus [Thu, 24 Sep 2015 23:05:13 +0000 (01:05 +0200)]
fix crash at session-close, amend dec4790d

8 years agoAdd some casting to keep MSVC happy
John Emmas [Thu, 24 Sep 2015 08:06:19 +0000 (09:06 +0100)]
Add some casting to keep MSVC happy

8 years agoAdd some newly introduced sources to our MSVC project (libardour)
John Emmas [Thu, 24 Sep 2015 08:05:38 +0000 (09:05 +0100)]
Add some newly introduced sources to our MSVC project (libardour)

8 years agoredisplay markers after removal - fixes #6596
Robin Gareus [Wed, 23 Sep 2015 22:27:32 +0000 (00:27 +0200)]
redisplay markers after removal - fixes #6596

8 years agofix iterator after map::erase().
Robin Gareus [Wed, 23 Sep 2015 20:23:43 +0000 (22:23 +0200)]
fix iterator after map::erase().

The iterator referring to the removed element is invalidated.
Other iterators remain valid.

8 years agostandardize VST Callback debug message print
Robin Gareus [Tue, 22 Sep 2015 18:48:21 +0000 (20:48 +0200)]
standardize VST Callback debug message print

8 years agoadd debug flags for VST Callbacks
Robin Gareus [Tue, 22 Sep 2015 18:37:35 +0000 (20:37 +0200)]
add debug flags for VST Callbacks

8 years agoHide create new item from Group Tab context menu
Todd Naugle [Mon, 21 Sep 2015 21:49:40 +0000 (16:49 -0500)]
Hide create new item from Group Tab context menu

Creating a new empty group from the group tab area just looks broken since
nothing visible happens, so hide this item when the context menu is
triggered from this location.

8 years agoPBD::Debug to stdout
Robin Gareus [Mon, 21 Sep 2015 21:08:45 +0000 (23:08 +0200)]
PBD::Debug to stdout

fixes debug output on windows. std::cerr is lost,
only std::cout, printf() and fprintf(stderr, ..) work.

8 years agoamend 01403dc (VST Pin connected)
Robin Gareus [Mon, 21 Sep 2015 21:01:38 +0000 (23:01 +0200)]
amend 01403dc (VST Pin connected)

8 years agoCreate new Groups with a consistent set of default properties.
Todd Naugle [Mon, 21 Sep 2015 19:52:25 +0000 (14:52 -0500)]
Create new Groups with a consistent set of default properties.

This is part of a larger fix for #6450. Previously new route groups were
created with different default properties depending on which code created
the new group. The group tab method had all properties set and that is now
going to be the default for all other methods (mixer strip button, etc).

8 years agoUpdate RouteGroup property defaults.
Todd Naugle [Mon, 21 Sep 2015 19:49:31 +0000 (14:49 -0500)]
Update RouteGroup property defaults.

This is part of a larger fix for #6450. Previously new route groups were
created with different default properties depending on which code created
the new group. The group tab method had all properties set and that is now
going to be the default.

8 years agoprocessor-box: explicitly check for "Amp" (Fader)
Robin Gareus [Mon, 21 Sep 2015 11:14:29 +0000 (13:14 +0200)]
processor-box: explicitly check for "Amp" (Fader)

8 years agosave-as, update button sensitivity when dir changes
Robin Gareus [Mon, 21 Sep 2015 10:05:31 +0000 (12:05 +0200)]
save-as, update button sensitivity when dir changes

8 years agoadd includes for g_open()
Robin Gareus [Mon, 21 Sep 2015 09:06:34 +0000 (11:06 +0200)]
add includes for g_open()

8 years agofix vst plugin; not sure if this was the intention, but it builds now.
Ben Loftis [Mon, 21 Sep 2015 02:20:12 +0000 (21:20 -0500)]
fix vst plugin; not sure if this was the intention, but it builds now.

8 years agoVpot assign buttons don't do anything, don't light LEDs either.
Len Ovens [Mon, 21 Sep 2015 03:09:42 +0000 (20:09 -0700)]
Vpot assign buttons don't do anything, don't light LEDs either.

8 years agoMake Mackie control surface LEDs for modifier keys only light while pressed. (fixes...
Len Ovens [Mon, 21 Sep 2015 01:26:16 +0000 (18:26 -0700)]
Make Mackie control surface LEDs for modifier keys only light while pressed. (fixes #6601)

8 years agofix VST audioMasterPinConnected callback
Robin Gareus [Mon, 21 Sep 2015 00:20:22 +0000 (02:20 +0200)]
fix VST audioMasterPinConnected callback