Paul Davis [Wed, 24 Jun 2015 17:08:55 +0000 (13:08 -0400)]
fix unused but usable variable warning
Paul Davis [Wed, 24 Jun 2015 17:08:36 +0000 (13:08 -0400)]
fix const-cast warnings
Paul Davis [Wed, 24 Jun 2015 15:55:41 +0000 (11:55 -0400)]
remove const warning in SMF C code by changing function parameter argument qualifier
Paul Davis [Wed, 24 Jun 2015 15:49:26 +0000 (11:49 -0400)]
comment unused but potentially usable variables
Paul Davis [Wed, 24 Jun 2015 15:49:15 +0000 (11:49 -0400)]
comment unused but potentially usable variables
Paul Davis [Wed, 24 Jun 2015 13:30:05 +0000 (09:30 -0400)]
try using threaded waveviews in tracks also
GZharun [Tue, 23 Jun 2015 10:15:32 +0000 (13:15 +0300)]
Fixed incomplete merge for audioengine.cc
[To be reviewed by] Paul Davis
Paul Davis [Tue, 23 Jun 2015 02:05:46 +0000 (22:05 -0400)]
never use threaded waveview rendering for Tracks
Paul Davis [Thu, 18 Jun 2015 15:10:20 +0000 (11:10 -0400)]
comment out two verbose debugging outputs
Paul Davis [Thu, 18 Jun 2015 13:02:31 +0000 (09:02 -0400)]
clip level is adjusted only by region amplitude (which is audible), not by _amplitude_above_axis
Paul Davis [Thu, 18 Jun 2015 13:00:15 +0000 (09:00 -0400)]
attempt to correctly respond to changes in _amplitude_above_axis in ArdourCanvas::WaveView
Paul Davis [Thu, 18 Jun 2015 12:59:49 +0000 (08:59 -0400)]
increase debug bitset size to accomodate additional debug bits imported from Tracks
Paul Davis [Thu, 18 Jun 2015 12:16:43 +0000 (08:16 -0400)]
update waves' fader implementation, clean up whitespace, indentation, variable initialization and remove unused members
Paul Davis [Wed, 17 Jun 2015 12:32:10 +0000 (08:32 -0400)]
no-op: fix whitespace/indentation
GZharun [Wed, 17 Jun 2015 12:11:07 +0000 (15:11 +0300)]
Fixed use case when session is being replaced with new session with the same name.
We should check session state file (*.ardour) presence to determine if the session is new for TracksLive as TracksLive has a use case which gives user a possibility to replace existing session by clicking on it's state file when new session is being created.
[To be Reviewed by] Paul Davis
GZharun [Wed, 17 Jun 2015 10:32:40 +0000 (13:32 +0300)]
[Summary] This action is duplicated. To make TRX features work correctly this flag should be dropped later.
[To be Reviewed by] Paul Davis
Paul Davis [Tue, 16 Jun 2015 15:47:35 +0000 (11:47 -0400)]
Revert "remove unused variables". They are used on OS X.
This reverts commit
0fba19e9e6e6c519c89ce63149581b8f24b38c8c.
Paul Davis [Tue, 16 Jun 2015 15:22:30 +0000 (11:22 -0400)]
remove unused variables
Paul Davis [Tue, 16 Jun 2015 15:22:10 +0000 (11:22 -0400)]
fix whitespace/indentation and compiler warnings
Paul Davis [Tue, 16 Jun 2015 15:11:57 +0000 (11:11 -0400)]
remove compilation warning (-Wunused-but-set-variable)
Paul Davis [Tue, 16 Jun 2015 14:06:27 +0000 (10:06 -0400)]
new PBD::DEBUG API changes for Waves backend
Paul Davis [Wed, 20 May 2015 14:29:20 +0000 (10:29 -0400)]
Revert "replace two more instances of !! with implicit use of operator bool()"
This reverts commit
e8eff9fb9c2fa6fc518404c2f9b731f8c28d3a23.
OS X compiler gets confused by this change.
Paul Davis [Wed, 20 May 2015 12:22:36 +0000 (08:22 -0400)]
replace two more instances of !! with implicit use of operator bool()
Paul Davis [Wed, 27 May 2015 14:57:40 +0000 (10:57 -0400)]
some more information output to log during save-as, for debugging
Paul Davis [Thu, 28 May 2015 12:56:55 +0000 (08:56 -0400)]
two required changes to default values for Tracks
Paul Davis [Wed, 27 May 2015 13:58:03 +0000 (09:58 -0400)]
Tracks doesn't know how to handle Engine (JACK) sync
Paul Davis [Tue, 26 May 2015 15:37:44 +0000 (11:37 -0400)]
fix API version SNAFU caused by re-copying EngineStateController out of Tracks
Paul Davis [Tue, 26 May 2015 00:56:03 +0000 (20:56 -0400)]
(re)implement Yevgeny's LTC branch changes in the context of ardour-merge-from-tracks (just the libs/* section)
Paul Davis [Tue, 26 May 2015 00:22:55 +0000 (20:22 -0400)]
fix indentation and style guide issues in new EngineStateController code
GZharun [Thu, 7 May 2015 11:55:00 +0000 (14:55 +0300)]
copy current EngineStateController from Tracks to import Yevgeny's LTC (re)connection related changes
Paul Davis [Mon, 25 May 2015 22:28:45 +0000 (18:28 -0400)]
fix previously cherry-picked commit to be Tracks-only, since Ardour/Mixbus are not affected
Nikolay [Wed, 13 May 2015 14:05:36 +0000 (17:05 +0300)]
[Summary] Mac OS specific bug fix: Increased priority of the top menu bar events
[Details] g_idle_add () which was used for this purpose used G_PRIORITY_DEFAULT_IDLE>=200 which was too low for correct main menu requests processing, like showing Mixer or Big Clock Window.
The priority was increased to G_PRIORITY_HIGH_IDLE = 100.
According to GTK manual (https://developer.gnome.org/glib/stable/glib-The-Main-Event-Loop.html#G-PRIORITY-HIGH-IDLE:CAPS)
GTK+ uses G_PRIORITY_HIGH_IDLE + 10 = 110 for resizing operations, and G_PRIORITY_HIGH_IDLE + 20 = 120 for redrawing operations.
I assume that during record or playback on tracks there are too many redraw request which didn't give any chance for main menu request to be processed in time with old priority value.
This change must be considered as a hot fix so far.
The issue might be deeper. Will be investigated with Paul.
[Feature reviewed] AMishyn
[Reviewed by] PDavis, GZharun
Paul Davis [Fri, 22 May 2015 22:33:01 +0000 (18:33 -0400)]
Revert "experimentally remove some C++11 flags (likely to return)"
This reverts commit
a27ad61695053fc18a9630dd9e7c2418416ba915.
This was not a fix for the problem it was an attempt to fix.
Paul Davis [Thu, 21 May 2015 17:48:53 +0000 (13:48 -0400)]
new file holding non-AVX stubs for AVX functions on linux
Paul Davis [Thu, 21 May 2015 15:25:43 +0000 (11:25 -0400)]
experimentally remove some C++11 flags (likely to return)
Paul Davis [Thu, 21 May 2015 15:24:05 +0000 (11:24 -0400)]
ensure that program version strings are not unicode
GZharun [Thu, 21 May 2015 07:40:38 +0000 (10:40 +0300)]
Fixed up types mismatch in AudioCallback and AudioCllbackData struct
Paul Davis [Wed, 20 May 2015 14:42:35 +0000 (10:42 -0400)]
fix typo in wavesbackend code
Paul Davis [Wed, 20 May 2015 14:30:10 +0000 (10:30 -0400)]
Revert "add operator bool() to Evoral::Beats"
This reverts commit
f8b5263af5e4d5088f1d5551e999679515add432.
OS X compiler gets confused by this change.
Paul Davis [Wed, 20 May 2015 14:29:42 +0000 (10:29 -0400)]
Revert "use newly added operator bool() for Evoral::Beats rather than double-negation as boolean"
This reverts commit
a19902b52f08bf33c54e60dfb49c44a1c154f4c9.
OS X compiler gets confused by this change.
Paul Davis [Wed, 20 May 2015 14:29:20 +0000 (10:29 -0400)]
Revert "replace two more instances of !! with implicit use of operator bool()"
This reverts commit
e8eff9fb9c2fa6fc518404c2f9b731f8c28d3a23.
OS X compiler gets confused by this change.
Paul Davis [Wed, 20 May 2015 12:22:36 +0000 (08:22 -0400)]
replace two more instances of !! with implicit use of operator bool()
Paul Davis [Wed, 20 May 2015 12:16:29 +0000 (08:16 -0400)]
use newly added operator bool() for Evoral::Beats rather than double-negation as boolean
Paul Davis [Wed, 20 May 2015 12:16:07 +0000 (08:16 -0400)]
add operator bool() to Evoral::Beats
Paul Davis [Wed, 20 May 2015 12:07:35 +0000 (08:07 -0400)]
use consistent (large) size when calling to_ticks()
Paul Davis [Tue, 19 May 2015 19:54:52 +0000 (15:54 -0400)]
new Session::default_track_name_pattern (DataType) method, based on an idea in Tracks
Paul Davis [Thu, 11 Sep 2014 20:56:49 +0000 (16:56 -0400)]
add new Gtkmm2ext::pixel_size() to conveniently get width&height for a given font + string
GZharun [Tue, 19 May 2015 14:19:19 +0000 (17:19 +0300)]
Fixed up the comment
Paul Davis [Tue, 19 May 2015 13:40:04 +0000 (09:40 -0400)]
add additional check for playhead priority target when testing loop range, to match Tracks' logic
Paul Davis [Tue, 19 May 2015 13:29:39 +0000 (09:29 -0400)]
add Session::reconnection_in_progress(), used by Tracks
Paul Davis [Tue, 19 May 2015 13:02:11 +0000 (09:02 -0400)]
use the frame/sample based inter-scene gap, not the msecs one (now removed)
Paul Davis [Tue, 19 May 2015 12:52:11 +0000 (08:52 -0400)]
scene gap is measured in frames, not msecs.
Could have used "samples" here but that can wait till we do a big rename
throughout the code base
Paul Davis [Tue, 19 May 2015 12:39:34 +0000 (08:39 -0400)]
add some session-scope configuration variables needed by Tracks.
Also add some comments regarding the presence of certain variables in this file
Paul Davis [Fri, 15 May 2015 17:54:43 +0000 (13:54 -0400)]
add more directory names to set managed via various APIs (automation, analysis, plugins, externals)
GZharun [Mon, 18 May 2015 12:40:49 +0000 (15:40 +0300)]
Fixed a misprint in a comment
Paul Davis [Wed, 3 Dec 2014 14:15:10 +0000 (09:15 -0500)]
add API for controlling and determining active status of a SceneChange
Conflicts:
libs/ardour/ardour/scene_change.h
GZharun [Thu, 14 May 2015 14:52:12 +0000 (17:52 +0300)]
Waves Backend MERGED from Tracks
[To be reviewed by] Paul Davis
GZharun [Thu, 14 May 2015 14:47:38 +0000 (17:47 +0300)]
Backend MERGE:
Paul Davis' change
3d12a4da82100466f1e5e286260759f07c2e657a
[To be reviewed by] Paul Davis
GZharun [Thu, 14 May 2015 14:46:21 +0000 (17:46 +0300)]
Reverted Ben's default buffer size function implementation.
Related to
eeca7f7
GZharun [Thu, 14 May 2015 14:44:04 +0000 (17:44 +0300)]
Reverted Ben's m_DefaultBufferSize stuff as it looks redundant. Will be put back if we establish the opposite
Paul Davis [Thu, 14 May 2015 02:20:38 +0000 (22:20 -0400)]
remove more explicit compiler flags by placing them in the compiler flags dictionary
Paul Davis [Thu, 14 May 2015 00:29:27 +0000 (20:29 -0400)]
minor fix for wavesaudio backend after earlier changes + merge/meld madness
Paul Davis [Wed, 13 May 2015 23:37:15 +0000 (19:37 -0400)]
add PBD::DEBUG bits for WavesAudio and WavesMIDI
Greg Zharun [Fri, 10 Apr 2015 15:08:13 +0000 (18:08 +0300)]
[Summary] AudioPort buffer does not need 64 byte alignment which cache_aligned_malloc provides.
Added new function which accepts argument to specify required alignment.
AudioPort buffer requires 32 byte alignment
[Review Required] YPosdnyakov
Paul Davis [Wed, 13 May 2015 23:11:27 +0000 (19:11 -0400)]
meld-driven unification of current ardour-ish WavesAudio backend and current tracks WavesAudio backend.
May be incomplete, and may not compile (testing to follow)
GZharun [Fri, 13 Feb 2015 15:59:04 +0000 (17:59 +0200)]
cosmetic fix (grygorii)
Paul Davis [Wed, 13 May 2015 21:32:10 +0000 (17:32 -0400)]
noop: fix indentation/whitespace
Paul Davis [Wed, 13 May 2015 20:29:27 +0000 (16:29 -0400)]
increase event pool for backend reset thread (somewhat unnecessarily, but lets keep Kyiv happy)
Paul Davis [Wed, 13 May 2015 15:01:37 +0000 (11:01 -0400)]
AudioEngine tweaks from Tracks, related to stopping audioengine and halting
Paul Davis [Wed, 13 May 2015 14:39:24 +0000 (10:39 -0400)]
merge in Tracks-derived session-end-is-N-seconds beyond last region end, but define N as zero for Ardour/Mixbus
Paul Davis [Wed, 13 May 2015 14:21:19 +0000 (10:21 -0400)]
fix indentation and remove whitespace
Paul Davis [Wed, 13 May 2015 14:16:16 +0000 (10:16 -0400)]
rename Session::add_session_range_location() to ::set_session_range_location()
Paul Davis [Tue, 16 Dec 2014 17:09:54 +0000 (12:09 -0500)]
enabling record (either tentative for punch or fully enabled) cancels play loop mode
Paul Davis [Fri, 5 Dec 2014 02:31:30 +0000 (21:31 -0500)]
implement missing methods for MIDISceneChange
Paul Davis [Wed, 3 Dec 2014 19:24:30 +0000 (14:24 -0500)]
mark session dirty after scene change is added/removed
Paul Davis [Wed, 3 Dec 2014 18:31:49 +0000 (13:31 -0500)]
add signal to indicate absence of removal of scene change from Location
Paul Davis [Wed, 13 May 2015 05:47:44 +0000 (01:47 -0400)]
remove artificial, accidental and utterly unintended limit of the numbering of scene changes
Paul Davis [Wed, 13 May 2015 05:46:04 +0000 (01:46 -0400)]
add Tracks specific handling of MMC Record Strobe, since Tracks has no concept of punch
Paul Davis [Sat, 17 Jan 2015 17:00:34 +0000 (12:00 -0500)]
properly track, update, maintain and set auto return state
Conflicts:
gtk2_ardour/ardour_ui_options.cc
Paul Davis [Fri, 30 Jan 2015 17:57:58 +0000 (12:57 -0500)]
make sure we allocate large enough buffers when doing a non-butler context disk buffer refill.
The size of the buffer now needs to reflect that we calculate read
refills in bytes, and if we are not using 32 bit float sample format
on disk, that can translate into > 1M samples.
Paul Davis [Wed, 13 May 2015 04:31:24 +0000 (00:31 -0400)]
remove Tracks runtime conditional, incorrectly added during manual merging
Paul Davis [Sat, 17 Jan 2015 17:40:46 +0000 (12:40 -0500)]
correctly track range selection trim and drag creation w.r.t playback priority
Paul Davis [Sat, 17 Jan 2015 17:01:08 +0000 (12:01 -0500)]
make editor_drag.h fully self-contained as a header file (it was missing more than a dozen necessary fwd decls etc)
Conflicts:
gtk2_ardour/editor_drag.h
Paul Davis [Sat, 17 Jan 2015 01:01:59 +0000 (20:01 -0500)]
start work on auto return target dropdown rather than button
Conflicts:
gtk2_ardour/ardour_ui.cc
Paul Davis [Sat, 17 Jan 2015 01:01:34 +0000 (20:01 -0500)]
change ArdourDropdown API to allow other types of menu elements
Paul Davis [Fri, 16 Jan 2015 22:50:10 +0000 (17:50 -0500)]
follow various events related to playhead priority (loop changes, parameter changes); remove debug output
Paul Davis [Fri, 16 Jan 2015 22:49:06 +0000 (17:49 -0500)]
remove debug output
Paul Davis [Fri, 16 Jan 2015 21:01:33 +0000 (16:01 -0500)]
fix copy-n-paste errors that used wrong buttons for playhead priorities
Paul Davis [Fri, 16 Jan 2015 20:33:46 +0000 (15:33 -0500)]
fix copy-n-paste errors that used incorrect enum values for playhead priorities
Paul Davis [Wed, 13 May 2015 03:56:55 +0000 (23:56 -0400)]
restore use of vertical margin on ardour knob popup tooltip/window
Robin Gareus [Fri, 24 Apr 2015 23:16:39 +0000 (01:16 +0200)]
API to set tooltip y-margin
Conflicts:
libs/gtkmm2ext/gtkmm2ext/persistent_tooltip.h
libs/gtkmm2ext/persistent_tooltip.cc
Paul Davis [Wed, 13 May 2015 03:17:14 +0000 (23:17 -0400)]
give different Tracks + Ardour/Mixbus playhead priority functionality, and add missing set_track_loop() call for playhead priority
Paul Davis [Wed, 13 May 2015 03:02:16 +0000 (23:02 -0400)]
correct placement of buffering adjustments w.r.t Butler thread creation
GZharun [Wed, 28 Jan 2015 14:41:12 +0000 (16:41 +0200)]
[Summary] Moved session buffers adjustment during butler thread set up to the place we are ready to handle them.
GZharun [Wed, 28 Jan 2015 10:44:38 +0000 (12:44 +0200)]
[Summary] HOT FIX: Fixed crash which happens on an attempt to load a session with audio after preferences removal, when buffer preset is set to Medium.
[Details] It happened because ARDOUR::Butler::thread_work() was called before Buttler::map_parameters() method was called, which sets up the correct buffering parameters (set_buffering_parameters () call) according to chosen preset.
I've added this calls into Butler::start_thread () to make sure everything is set up and ready for use for Butler.
This is a hot fix, because it requires the review from Paul Davis, and probably more gentle solution. But it's possible this commit may become the main solution itself.
Paul Davis [Wed, 13 May 2015 02:22:01 +0000 (22:22 -0400)]
try to correctly set up build of AVX code for windows and linux, using compiler flags dictionary.
Adds use of 'pic' compiler flags dictionary item
Paul Davis [Wed, 13 May 2015 02:21:21 +0000 (22:21 -0400)]
store compiler flags in conf/bld context object so that we can use them selectively at build time
Paul Davis [Wed, 13 May 2015 01:27:33 +0000 (21:27 -0400)]
meter computation must use absolute value of all samples (ignoring sign bit)
Paul Davis [Wed, 13 May 2015 01:27:27 +0000 (21:27 -0400)]
add windows-only AVX functions
Paul Davis [Wed, 13 May 2015 01:18:53 +0000 (21:18 -0400)]
Made optimized function Prototypes more correct.
They shouldn't be dependant on ARDOUR types as long as they will work correctly with float
samples only and with 32 unsigned int as sample counter.