Paul Davis [Wed, 6 May 2015 18:06:28 +0000 (14:06 -0400)]
add now-expected -D defines for a Tracks build
Paul Davis [Wed, 6 May 2015 18:06:10 +0000 (14:06 -0400)]
merge two small pieces of code by Valeriy into libs/gtkmm2ext, conditionally used ONLY in Tracks builds.
This code is not acceptable for use in Ardour ... comments in code explain more.
Paul Davis [Wed, 6 May 2015 17:43:02 +0000 (13:43 -0400)]
better implementation of configure and build time is_tracks_build() test
Paul Davis [Wed, 6 May 2015 17:42:39 +0000 (13:42 -0400)]
fix up waves_fastmeter.cc code to work with current fastmeter API
Paul Davis [Wed, 6 May 2015 17:15:09 +0000 (13:15 -0400)]
add clean and nice check for Tracks builds
Paul Davis [Wed, 6 May 2015 17:05:16 +0000 (13:05 -0400)]
conditionally use correct fast meter implementation
Paul Davis [Wed, 6 May 2015 17:04:58 +0000 (13:04 -0400)]
fix logic/declaration issue with modified PersistentTooltip API
Paul Davis [Wed, 6 May 2015 17:04:33 +0000 (13:04 -0400)]
add Waves Tracks version of fastmeter
Nikolay [Mon, 27 Apr 2015 15:32:00 +0000 (18:32 +0300)]
[Summary] Changed class PersistentTooltip. Now it can be used for 'non-draggable' tooltips.
[Feature reviewed] MKosharnyy
[Reviewed] VKamyshniy
Manually clean up merge mess, indentation, logic weakness, initializer order, etc.
Conflicts:
libs/gtkmm2ext/gtkmm2ext/persistent_tooltip.h
libs/gtkmm2ext/persistent_tooltip.cc
Paul Davis [Wed, 6 May 2015 16:10:41 +0000 (12:10 -0400)]
use Tracks' MainMenuDisabler during session lock (could be improved with more RAII)
Paul Davis [Wed, 6 May 2015 15:51:04 +0000 (11:51 -0400)]
hand-merge libs/gtkmm2ext part of
f49d31a82 from Tracks; provides a way to disable/re-enable OS X main menu
Nikolay [Wed, 25 Mar 2015 08:55:55 +0000 (10:55 +0200)]
[Summary] Bug fix #44332 "Please fit the Pan values monitor to channel borders"
[Feature reviewed] AMishyn
[Reviewed] VKamyshniy
Fixed up by Paul Davis to fix logic mistakes and unnecessary complexity,
and indentation.
Conflicts:
libs/gtkmm2ext/persistent_tooltip.cc
YPozdnyakov [Sun, 8 Feb 2015 15:18:39 +0000 (17:18 +0200)]
[Summary]: add keybindings Cmd-h (hide application) for mac
Conflicts:
gtk2_ardour/ardour_ui.cc
gtk2_ardour/ardour_ui.h
gtk2_ardour/ardour_ui_ed.cc
YPozdnyakov [Tue, 27 Jan 2015 11:47:47 +0000 (13:47 +0200)]
[Summary]: fix declaration of Cocoa NSApplicationDelegate methods [Reviewed by] Paul Davis
Conflicts:
libs/gtkmm2ext/gtkapplication_quartz.mm
Paul Davis [Wed, 6 May 2015 13:55:01 +0000 (09:55 -0400)]
current version of valeriy's fader object requires access to libardour API (to be changed)
Paul Davis [Wed, 6 May 2015 13:43:14 +0000 (09:43 -0400)]
add fader implementation from Tracks
Greg Zharun [Thu, 9 Apr 2015 10:27:57 +0000 (13:27 +0300)]
[Summary] Added correct memory alignment for Windows in ../pbd/malign.h
[Reviewed by] YPozdnyakov
Paul Davis [Wed, 6 May 2015 11:30:39 +0000 (07:30 -0400)]
fix panner selection logic and code in wscript
Paul Davis [Wed, 6 May 2015 11:30:23 +0000 (07:30 -0400)]
define PROGRAM_NAME in waf conf/bld objects, to allow program-dependent stuff at the wscript level
GZharun [Tue, 24 Feb 2015 12:27:36 +0000 (14:27 +0200)]
[Summary] Added possibility to identify IO thread which does not have required resources initialized during process callback handling
Conflicts:
libs/ardour/ardour/audioengine.h
libs/backends/wavesaudio/waves_audiobackend.cc
libs/pbd/pbd/pool.h
Paul Davis [Wed, 6 May 2015 10:55:05 +0000 (06:55 -0400)]
add stacktrace() support for Windows (Grygorii Zharun)
Paul Davis [Wed, 6 May 2015 02:51:17 +0000 (22:51 -0400)]
fix static library build
YPozdnyakov [Mon, 16 Feb 2015 13:15:10 +0000 (15:15 +0200)]
[Summary]: Switching from Multi-Out mode to Stereo-out shouldn’t reset panner's value in the new created tracks. Profile->get_trx () was used. [Reviewed by GZharun] [Not Reviewed by Paul Davis].
Paul Davis [Wed, 6 May 2015 02:01:33 +0000 (22:01 -0400)]
make available panners dependent on program name
Robin Gareus [Mon, 29 Jun 2015 18:03:36 +0000 (20:03 +0200)]
initialize uninitialized var - possible fix for #6400
Robin Gareus [Mon, 29 Jun 2015 16:57:51 +0000 (18:57 +0200)]
remember max shuttle-speed
Robin Gareus [Mon, 29 Jun 2015 16:57:21 +0000 (18:57 +0200)]
update system config
Robin Gareus [Mon, 29 Jun 2015 16:57:01 +0000 (18:57 +0200)]
add missing config variable for shuttle_max_speed
Ben Loftis [Sun, 28 Jun 2015 21:59:04 +0000 (16:59 -0500)]
add keybinding, V, for video window
Ben Loftis [Sun, 28 Jun 2015 16:38:26 +0000 (11:38 -0500)]
tweak some window-bindings. Use C for Clock and B for meter-Bridge
Ben Loftis [Sun, 28 Jun 2015 05:52:49 +0000 (00:52 -0500)]
show selection trim cursors in Range mode
Robin Gareus [Sun, 28 Jun 2015 01:27:54 +0000 (03:27 +0200)]
link to new floss-tutorial
Still ardour3, but close to A4.
Robin Gareus [Sun, 28 Jun 2015 00:47:11 +0000 (02:47 +0200)]
don’t confuse “Fader” with “Trim” (both <Amp>s)
Fixes pre-fader send mute point.
Paul Davis [Sat, 27 Jun 2015 02:15:51 +0000 (22:15 -0400)]
a more-likely-to-be-correct version of swing quantization.
This needs to be converted to fixed point, still.
Robin Gareus [Fri, 26 Jun 2015 23:45:20 +0000 (01:45 +0200)]
remove old irrelevant USER_ARDOUR_DIR in start-up script
It should have been XDG_CONFIG_HOME and ardour4, anyway.
Ardour4 checks for config dirs, allows to import A3 config and
also handles the case if the dir can't be created itself.
Robin Gareus [Fri, 26 Jun 2015 23:32:11 +0000 (01:32 +0200)]
remove debug code
Robin Gareus [Fri, 26 Jun 2015 23:31:22 +0000 (01:31 +0200)]
check editor/mixer/meterbridge window overlap for show/hide
Robin Gareus [Fri, 26 Jun 2015 22:56:07 +0000 (00:56 +0200)]
consolidate code
Robin Gareus [Fri, 26 Jun 2015 21:42:11 +0000 (23:42 +0200)]
update Window > Mixer accordingly
Ben Loftis [Fri, 26 Jun 2015 22:24:52 +0000 (17:24 -0500)]
add region layer keybindings
Robin Gareus [Fri, 26 Jun 2015 20:35:40 +0000 (22:35 +0200)]
Alternative approach for show/hide Meterbridge #6386
* no more on-top (transient to editor)
* similar approach as toggle editor/mixer
see also
0cd1db76f04
Paul Davis [Fri, 26 Jun 2015 20:16:25 +0000 (16:16 -0400)]
swing quantize should skip the FIRST note and start on the SECOND, then alternate, notes
Paul Davis [Fri, 26 Jun 2015 16:34:55 +0000 (12:34 -0400)]
make the quantize dialog persistent so that settings are retained
Robin Gareus [Thu, 25 Jun 2015 18:23:34 +0000 (20:23 +0200)]
keep meterbridge on top of editor - see #6386
Colin Fletcher [Thu, 25 Jun 2015 16:24:20 +0000 (17:24 +0100)]
Try to avoid coincident tempo/meter markers when removing time
If a tempo or meter marker exists immediately after the range being removed
by a 'remove time' operation, don't try to move the last marker within the
range being removed to the same position.
Ideally, TempoMap::remove_time() should do the same stuff as insert_time()
to make sure that meter changes only occur on bar lines, but that's for
another time.
Colin Fletcher [Thu, 25 Jun 2015 14:09:49 +0000 (15:09 +0100)]
rename TempoMap::cut_time() to remove_time()
Everywhere else, 'cut time' has been renamed to 'remove time': for consistency,
rename this one remaining function to match.
Robin Gareus [Thu, 25 Jun 2015 12:33:45 +0000 (14:33 +0200)]
fix windows debug builds:
undefined reference to `std::basic_ostream >& boost::operator<< , ArdourCanvas::Rect>(std::basic_ostream >&, boost::optional const&)'
Paul Davis [Wed, 24 Jun 2015 18:12:13 +0000 (14:12 -0400)]
show zero line when a DC offset moves waveform so that it doesn't intersect with the zero line (from Nimal Ratnayake <nimalr@pdn.ac.lk>)
Paul Davis [Wed, 24 Jun 2015 17:46:07 +0000 (13:46 -0400)]
rationalize save/restore of control surface "feedback" property
Paul Davis [Tue, 23 Jun 2015 21:12:52 +0000 (17:12 -0400)]
do not draw waveform outline at x-positions where the waveform "spread" would not leave at least 1 pixel between the two outline pixels.
Plus a better comment.
Paul Davis [Tue, 23 Jun 2015 18:26:10 +0000 (14:26 -0400)]
several changes, major and minor, to improve threaded waveview rendering
Robin Gareus [Tue, 23 Jun 2015 15:11:45 +0000 (17:11 +0200)]
update video import flags, relax GOP size.
Robin Gareus [Tue, 23 Jun 2015 12:27:01 +0000 (14:27 +0200)]
silence clang int/float/double -Wabsolute-value
Paul Davis [Tue, 23 Jun 2015 12:42:55 +0000 (08:42 -0400)]
create sortable, linear list for cache clearing on demand, rather than trying to maintain it in parallel with the cache map
Paul Davis [Tue, 23 Jun 2015 12:25:38 +0000 (08:25 -0400)]
textual tweak
Paul Davis [Tue, 23 Jun 2015 12:18:11 +0000 (08:18 -0400)]
provide control over waveform image cache size from GUI
Paul Davis [Tue, 23 Jun 2015 12:17:48 +0000 (08:17 -0400)]
change location for initialization of static WaveView image cache, and provide a visible method to set the cache flush threshold
Paul Davis [Tue, 23 Jun 2015 02:00:45 +0000 (22:00 -0400)]
stop endless loop in WaveViewCache::cache_flush()
Still need to figure out how this could ever happen. It requires an image (shared pointer) to
be in the linear cache image list but not in the map
John Emmas [Mon, 22 Jun 2015 15:08:46 +0000 (16:08 +0100)]
When using the Editor's Shuttle control, stop any shuttling by calling Session::request_stop()
Previously we were using a convoluted scheme of firstly setting the transport speed to 1.0, then later re-setting it to 0.0. On Windows this was having some strange side-effects (such as leaving the transport in Play mode and/or resetting the timeline to zero timecode). Hopefully this change will also work for the other platforms.
Len Ovens [Sat, 20 Jun 2015 16:32:46 +0000 (09:32 -0700)]
Add option to mackie control profile editor to remove binding (fixes #6301)
Colin Fletcher [Fri, 19 Jun 2015 15:12:07 +0000 (16:12 +0100)]
Remove "" around CATALOG number in .cue file
cue2ddp definitely wants the bar code number *not* enclosed in quotes in
.cue files. Leave the quotes in .toc files: cdrdao definitely does need
these.
Colin Fletcher [Fri, 19 Jun 2015 11:16:48 +0000 (12:16 +0100)]
Amend button caption in 'Remove time' dialogue
I missed that it still said 'Cut'.
Robin Gareus [Fri, 19 Jun 2015 20:54:22 +0000 (22:54 +0200)]
also log session-load error to stderr.
If the session fails to load, the editor and error-log window will
never be visible.
Paul Davis [Fri, 19 Jun 2015 12:32:05 +0000 (08:32 -0400)]
two more corrections to waveform zooming changes
Paul Davis [Fri, 19 Jun 2015 12:29:05 +0000 (08:29 -0400)]
fix call to consolidate image cache to use the information held in the request
Paul Davis [Fri, 19 Jun 2015 12:15:25 +0000 (08:15 -0400)]
various tweaks to the height/sizing of audioregion views and their waveforms
Paul Davis [Fri, 19 Jun 2015 12:14:02 +0000 (08:14 -0400)]
stop pixel jitter when changing waveview height.
To avoid pixel jitter, the top and bottom of each line in the waveview must be computed together in a single computation,
rather than independently.
Also, remove various height corrections and cairo translations that are not necessary or relevant anymore. A subsequent
commit for the GUI will pick up on this work to get the appearance completely correct
Paul Davis [Fri, 19 Jun 2015 12:10:45 +0000 (08:10 -0400)]
attempt to correctly respond to changes in _amplitude_above_axis in ArdourCanvas::WaveView
Paul Davis [Fri, 19 Jun 2015 12:10:35 +0000 (08:10 -0400)]
fix compiler const-cast warning
John Emmas [Fri, 19 Jun 2015 11:55:38 +0000 (12:55 +0100)]
Correctly re-start an iteration (if we delete one of the items being iterated)
John Emmas [Thu, 18 Jun 2015 08:22:34 +0000 (09:22 +0100)]
Rename 'insert_time_dialog.cc/.h' (in our MSVC project)
Robin Gareus [Wed, 17 Jun 2015 19:08:01 +0000 (21:08 +0200)]
update system-wide config
Robin Gareus [Wed, 17 Jun 2015 19:07:40 +0000 (21:07 +0200)]
skip username metadata when dumping default cfg
Colin Fletcher [Tue, 16 Jun 2015 15:20:26 +0000 (16:20 +0100)]
Accept changes to Insert/Remove time clocks without <Enter>
Pass 'true' to accept_on_focus_out of AudioClock, so that editing the
insert/remove time clock and then clicking elsewhere without hitting
<Enter> first doesn't mysteriously set the time back to 00:00:00.000.
Colin Fletcher [Tue, 16 Jun 2015 15:18:23 +0000 (16:18 +0100)]
Add 'accept on focus out' parameter (default false) to AudioClock
If this parameter is passed as 'true', then edits to the clock will be
accepted when the user clicks away from the clock, rather than
unconditionally discarded as hitherto.
Colin Fletcher [Tue, 16 Jun 2015 10:23:50 +0000 (11:23 +0100)]
Rename 'Cut time' to 'Remove time'
'Cut time' implies that the cut timeline items might end up on the
clipboard to be pasted somewhere: this isn't the case at present, so rename
the functions, class, &c. to say 'remove' rather than 'cut'.
Rename insert_time_dialog.{cc|h} to insert_remove_time_dialog while we're
at it.
Colin Fletcher [Mon, 15 Jun 2015 15:07:30 +0000 (16:07 +0100)]
Update 'Cut time' to match 'Insert time', and fix cut-time moving range markers
Add options to move glued & locked markers to Editor::cut_time(), in line
with the insert_time() implementation.
Fix up the order in which operations apply to range marker start & end
points, to avoid problems when a range which lies after the cut point is
shorter than the length of the cut.
Colin Fletcher [Sun, 14 Jun 2015 16:53:25 +0000 (17:53 +0100)]
Use 'Insert time' dialogue for 'Cut time' too.
Colin Fletcher [Tue, 16 Jun 2015 10:28:43 +0000 (11:28 +0100)]
Make 'Insert time' dialogue do for 'Cut time' too
Add a bool cut parameter to InsertTimeDialog's constructor, so it can
do double duty as 'Cut time'. The class probably ought to be renamed too.
Colin Fletcher [Sun, 14 Jun 2015 17:09:30 +0000 (18:09 +0100)]
Insert time: don't unlock markers we're not going to move anyway
Move checking for locked markers in Editor::insert_time() so it doesn't
happen if we're going to skip the marker because it's glued to musical
time.
Colin Fletcher [Sun, 14 Jun 2015 17:07:27 +0000 (18:07 +0100)]
Insert time: fix moving of range markers
When inserting time and moving a range marker, move its end first, before
moving its start, so that if the time being inserted is greater than the
length of the range, we don't try to set its start to after its end.
Robin Gareus [Wed, 17 Jun 2015 00:20:02 +0000 (02:20 +0200)]
fix 1024px width layout (remove nudge clock special case)
Due to some change somewhere along the road the nudge clock does
no longer fit in the transport-bar on 1024px screen with 100% font-scale,
even if the 2nd clock is hidden.
However, these days it does fit nicely on its default position even
with wide-editor-mixer on a 1024px screen.
Robin Gareus [Tue, 16 Jun 2015 17:27:22 +0000 (19:27 +0200)]
-Wsign-compare
Paul Davis [Tue, 16 Jun 2015 12:44:03 +0000 (08:44 -0400)]
add Record-Safe feature to libardour (from Nikolay Polyanovskii)
Paul Davis [Tue, 16 Jun 2015 11:51:50 +0000 (07:51 -0400)]
fixes for canvas text display on Retina (from Valeriy)
Robin Gareus [Mon, 15 Jun 2015 22:47:53 +0000 (00:47 +0200)]
use mpeg4 for internal video format (not mjpeg)
reduces file size.
xjadeo > 0.8 and harvid >= 0.8 handle this fine.
Robin Gareus [Sun, 14 Jun 2015 20:24:53 +0000 (22:24 +0200)]
ALSA backend: add support for half-duplex devices
Robin Gareus [Sun, 14 Jun 2015 20:16:31 +0000 (22:16 +0200)]
allow to scan for half-duplex ALSA devices
Robin Gareus [Sun, 14 Jun 2015 18:43:29 +0000 (20:43 +0200)]
prepare ALSA backend for half-duplex
Robin Gareus [Sun, 14 Jun 2015 16:10:31 +0000 (18:10 +0200)]
probe buffersize if jackd is already running.
Robin Gareus [Sat, 13 Jun 2015 20:05:29 +0000 (22:05 +0200)]
NOOP, reindent code.
Robin Gareus [Sat, 13 Jun 2015 20:04:31 +0000 (22:04 +0200)]
fix crash on OSX displaying MIDI sysex, or similar text.
Paul Davis [Fri, 12 Jun 2015 22:14:09 +0000 (18:14 -0400)]
We were 2 more debug "bits" away from overflow, so recast PBD::DEBUG mechanism away from a 64bit integer and toward std::bitset.
Clean up a few minor related PBD::DEBUG issues along the way
Paul Davis [Thu, 11 Jun 2015 21:04:08 +0000 (17:04 -0400)]
more refactoring of WaveView threaded code to try to get to heart of crash bug
Paul Davis [Thu, 11 Jun 2015 17:34:46 +0000 (13:34 -0400)]
don't queue a callback with the idle event for waveview image generation if one is already queued.
Also, hold relevant lock when waking image rendering thread.
Paul Davis [Thu, 11 Jun 2015 17:33:45 +0000 (13:33 -0400)]
comment tweak
Robin Gareus [Thu, 11 Jun 2015 13:05:46 +0000 (15:05 +0200)]
fix transport loop sub-state events
Loading a session with a loop-range, or setting
a loop-range adds LoopDeclick events.
Normal play back (no loop) never processes/clears the events.
Ardour was constantly doing split cycles for nothing.
This lead to stuck midi-notes: Split cycle calls
increment_global_port_buffer_offset() but the midi_diskstream
itself was not aware of any loop positions or offsets.
Entering loop playback adds those events explicitly
in Session::set_play_loop(). auto_loop_changed() only
needs to add/replace session-events when actively looping.
Paul Davis [Thu, 11 Jun 2015 02:26:58 +0000 (22:26 -0400)]
possible fix for crashes related to vanishing waveviews (and if it doesn't fix anything, it is still more correct than it was)
Paul Davis [Thu, 11 Jun 2015 02:04:20 +0000 (22:04 -0400)]
remove left-over debugging code
Paul Davis [Wed, 10 Jun 2015 22:48:01 +0000 (18:48 -0400)]
fix basic error with computation of partial image width; add use of DEBUG_TRACE (DEBUG::WaveView,...)