ardour.git
8 years agoAdd a couple of error codes to AudioBackend::ErrorCode
Tim Mayberry [Sat, 26 Sep 2015 07:02:37 +0000 (17:02 +1000)]
Add a couple of error codes to AudioBackend::ErrorCode

Also use the error message from ARDOUR_UI::reconnect_to_engine as the default
error string

8 years agoGray out "strip silence" and "rhtyhm ferret" for midi regions.
André Nusser [Wed, 30 Sep 2015 21:20:27 +0000 (23:20 +0200)]
Gray out "strip silence" and "rhtyhm ferret" for midi regions.

The former even triggered a segfault.

8 years agoMerge branch 'chaot4-fix_track_list_context_menu'
Paul Davis [Wed, 30 Sep 2015 18:43:13 +0000 (14:43 -0400)]
Merge branch 'chaot4-fix_track_list_context_menu'

8 years agoFixed spelling.
André Nusser [Mon, 28 Sep 2015 21:48:07 +0000 (23:48 +0200)]
Fixed spelling.

8 years agoMake all the context menu entries of the track list work.
André Nusser [Mon, 28 Sep 2015 20:14:04 +0000 (22:14 +0200)]
Make all the context menu entries of the track list work.

8 years agochange the logic for a capture buffer flush to disk when a locate is occuring
Paul Davis [Wed, 30 Sep 2015 17:02:50 +0000 (13:02 -0400)]
change the logic for a capture buffer flush to disk when a locate is occuring

We can't check for Session::actively_recording() because punch out may have disabled that. Rather
than add logic to check if a flush is needed (which is not much different than the code that runs
as part of the flush to disk), just do a flush anyway.

8 years agotweak some debug output
Paul Davis [Wed, 30 Sep 2015 17:00:55 +0000 (13:00 -0400)]
tweak some debug output

8 years agoremove apparently bogus adjustment to capture_captured in AudioDiskstream::transport_...
Paul Davis [Wed, 30 Sep 2015 16:59:58 +0000 (12:59 -0400)]
remove apparently bogus adjustment to capture_captured in AudioDiskstream::transport_looped

8 years agosplit Butler::flush_tracks_to_disk() into two distinct versions with clear names...
Paul Davis [Wed, 30 Sep 2015 16:58:36 +0000 (12:58 -0400)]
split Butler::flush_tracks_to_disk() into two distinct versions with clear names and make one of them private

8 years agois there a better way to make gcc+enumwriter happy?
Robin Gareus [Tue, 29 Sep 2015 13:50:43 +0000 (15:50 +0200)]
is there a better way to make gcc+enumwriter happy?

8 years agoFix midi tracer to show MSB too. (fixes #6566)
Len Ovens [Tue, 29 Sep 2015 13:06:40 +0000 (06:06 -0700)]
Fix midi tracer to show MSB too. (fixes #6566)

8 years agoset waveform height depending on Layer mode
Robin Gareus [Tue, 29 Sep 2015 07:34:29 +0000 (09:34 +0200)]
set waveform height depending on Layer mode

Fixes background peakfile/waveform creation. Waves need to be
created directly with the proper attributes as set by StreamView.

8 years agoFix Mackie control metering (fixes #6608).
Len Ovens [Tue, 29 Sep 2015 03:13:15 +0000 (20:13 -0700)]
Fix Mackie control metering (fixes #6608).

8 years agoRevert "change the way the audio clock cursor is drawn (somewhat of an experiment...
Paul Davis [Tue, 29 Sep 2015 00:15:03 +0000 (20:15 -0400)]
Revert "change the way the audio clock cursor is drawn (somewhat of an experiment but it has some benefits"

This reverts commit 601770837e2530a73056a6aa67759d56e16e735a.

This work continued in the "clockwork" branch where it was done correctly.

8 years agoBWF USID according to EBU-R99
Robin Gareus [Mon, 28 Sep 2015 23:20:09 +0000 (01:20 +0200)]
BWF USID according to EBU-R99

8 years agochange clearlooks style file so that small_entry and related styles use text color...
Paul Davis [Mon, 28 Sep 2015 22:20:54 +0000 (18:20 -0400)]
change clearlooks style file so that small_entry and related styles use text color for text even when selected

8 years agoMerge branch 'chaot4-fix_lock_solo_ctrl_shift'
Paul Davis [Mon, 28 Sep 2015 21:59:10 +0000 (17:59 -0400)]
Merge branch 'chaot4-fix_lock_solo_ctrl_shift'

8 years agoIntroduce Ctrl+Shift+Click on lock solo in the mixer.
André Nusser [Mon, 28 Sep 2015 16:38:33 +0000 (18:38 +0200)]
Introduce Ctrl+Shift+Click on lock solo in the mixer.

8 years agofix initialization of reserved I/O names vector
Paul Davis [Mon, 28 Sep 2015 21:52:27 +0000 (17:52 -0400)]
fix initialization of reserved I/O names vector

8 years agofix const-ness
Paul Davis [Mon, 28 Sep 2015 21:52:13 +0000 (17:52 -0400)]
fix const-ness

8 years agoRevert "add new action and loop marker menu item for setting up loop record"
Paul Davis [Mon, 28 Sep 2015 21:44:04 +0000 (17:44 -0400)]
Revert "add new action and loop marker menu item for setting up loop record"

This reverts commit ebb43508f1ab75b7d7467e0e95cdd1c816cf3183.

8 years agoget loop recording working when using seam-ed looping
Paul Davis [Mon, 28 Sep 2015 21:42:02 +0000 (17:42 -0400)]
get loop recording working when using seam-ed looping

8 years agobetter more reliable checks on renamed, newly created and imported track/bus names
Paul Davis [Mon, 28 Sep 2015 18:49:49 +0000 (14:49 -0400)]
better more reliable checks on renamed, newly created and imported track/bus names

8 years agochange semantics of 4th argument to Session::locate to mean "this locate is connected...
Paul Davis [Thu, 24 Sep 2015 17:40:55 +0000 (13:40 -0400)]
change semantics of 4th argument to Session::locate to mean "this locate is connected with play-loop just being enabled"

8 years agochange the way the audio clock cursor is drawn (somewhat of an experiment but it...
Paul Davis [Tue, 22 Sep 2015 22:25:14 +0000 (18:25 -0400)]
change the way the audio clock cursor is drawn (somewhat of an experiment but it has some benefits

8 years agowhen editing an audio clock, swallow illegal keys rather than allowing them to reach...
Paul Davis [Tue, 22 Sep 2015 22:24:49 +0000 (18:24 -0400)]
when editing an audio clock, swallow illegal keys rather than allowing them to reach the rest of the GUI

8 years agofix the logic of the GUI "toggle roll" action as it pertains to loop recording
Paul Davis [Tue, 22 Sep 2015 17:24:04 +0000 (13:24 -0400)]
fix the logic of the GUI "toggle roll" action as it pertains to loop recording

8 years agoa few new DEBUG_TRACE calls related to session transport state
Paul Davis [Tue, 22 Sep 2015 17:23:18 +0000 (13:23 -0400)]
a few new DEBUG_TRACE calls related to session transport state

8 years agominor fix for possible off-by-one logic when at/near the end of the loop range
Paul Davis [Tue, 22 Sep 2015 17:22:20 +0000 (13:22 -0400)]
minor fix for possible off-by-one logic when at/near the end of the loop range

8 years agofix a long-standing bug arising from a change to some logic which reversed an "is...
Paul Davis [Tue, 22 Sep 2015 17:21:44 +0000 (13:21 -0400)]
fix a long-standing bug arising from a change to some logic which reversed an "is-rolling" test

8 years agomove code location where loop playback is cancelled when stopping
Paul Davis [Tue, 22 Sep 2015 17:20:52 +0000 (13:20 -0400)]
move code location where loop playback is cancelled when stopping

8 years agoloop record is a feature whether or not loop-is-mode is true or not
Paul Davis [Tue, 22 Sep 2015 17:18:54 +0000 (13:18 -0400)]
loop record is a feature whether or not loop-is-mode is true or not

8 years agoSession::disable_record() should work whether we are in loop mode or not
Paul Davis [Tue, 22 Sep 2015 17:18:08 +0000 (13:18 -0400)]
Session::disable_record() should work whether we are in loop mode or not

8 years agoadd new action and loop marker menu item for setting up loop record
Paul Davis [Fri, 18 Sep 2015 22:04:25 +0000 (18:04 -0400)]
add new action and loop marker menu item for setting up loop record

8 years agofix long options of gcc-glibmm-abi-check.
Robin Gareus [Mon, 28 Sep 2015 15:02:15 +0000 (17:02 +0200)]
fix long options of gcc-glibmm-abi-check.

8 years agoremove outdated limiation
Robin Gareus [Mon, 28 Sep 2015 13:40:26 +0000 (15:40 +0200)]
remove outdated limiation

8 years agoremove cruft.
Robin Gareus [Sun, 27 Sep 2015 22:36:44 +0000 (00:36 +0200)]
remove cruft.

8 years agomixer-strip name context-menu cleanup
Robin Gareus [Sun, 27 Sep 2015 19:45:40 +0000 (21:45 +0200)]
mixer-strip name context-menu cleanup

patch thanks to chaot4

8 years agoadd deva to authors.
Robin Gareus [Sun, 27 Sep 2015 14:13:37 +0000 (16:13 +0200)]
add deva to authors.

8 years agoSort ports in state-save.
Robin Gareus [Sun, 27 Sep 2015 14:10:10 +0000 (16:10 +0200)]
Sort ports in state-save.

This results in identical XML if the session did not change, allowing
to keep track of state-changes easily (e.g. session file in git).

Thanks to deva (again).

8 years agoLV2 state cleanup, patch from deva. closes #6607
Robin Gareus [Sun, 27 Sep 2015 12:07:04 +0000 (14:07 +0200)]
LV2 state cleanup, patch from deva. closes #6607

set _impl->state on session load in order to detect state changes
properly (no not save duplicate states).

+ some small mem-leaks (free state)

8 years agoClose export directory browser dialog when clicking on 'Cancel' button, Fixes #6594
Tim Mayberry [Sun, 27 Sep 2015 11:55:20 +0000 (21:55 +1000)]
Close export directory browser dialog when clicking on 'Cancel' button, Fixes #6594

8 years agoupdate semantics of PBD::remove_directory()
Robin Gareus [Sun, 27 Sep 2015 10:44:54 +0000 (12:44 +0200)]
update semantics of PBD::remove_directory()

Remove the directory recursively including itself. The function
is used in two places only:

* LV2Plugin::add_state() -- no change, remove tmp. state
* Session::save_as()  -- on error, remove target

In both cases removing the folder itself is correct.

8 years agofix mixer group-tab width - #6572
Robin Gareus [Sat, 26 Sep 2015 23:33:02 +0000 (01:33 +0200)]
fix mixer group-tab width - #6572

EditorGroupTabs are re-exposed in the idle-callback, widgets
are packed and geometry is valid.

Mixer_UI::redisplay_track_list() does not have this property.

8 years agoaccept/ignore --gcc5abi option during packaging.
Robin Gareus [Sat, 26 Sep 2015 19:23:01 +0000 (21:23 +0200)]
accept/ignore --gcc5abi option during packaging.

8 years ago..and another packaging typo
Robin Gareus [Sat, 26 Sep 2015 18:50:56 +0000 (20:50 +0200)]
..and another packaging typo

8 years agoadd missing space.
Robin Gareus [Sat, 26 Sep 2015 18:29:45 +0000 (20:29 +0200)]
add missing space.

8 years agolinux-installer: gcc4/5 warning.
Robin Gareus [Fri, 11 Sep 2015 16:46:23 +0000 (18:46 +0200)]
linux-installer: gcc4/5 warning.

8 years agonew tool to test gcc4/5 ABI
Robin Gareus [Sat, 26 Sep 2015 16:23:19 +0000 (18:23 +0200)]
new tool to test gcc4/5 ABI

8 years agoremove old gcc ABI (libstc++) test tool
Robin Gareus [Sat, 26 Sep 2015 16:42:38 +0000 (18:42 +0200)]
remove old gcc ABI (libstc++) test tool

8 years agogcc5/c++11 deprecates std::auto_ptr
Robin Gareus [Fri, 25 Sep 2015 22:22:56 +0000 (00:22 +0200)]
gcc5/c++11 deprecates std::auto_ptr

8 years agocopy LV2 options to heap.
Robin Gareus [Fri, 25 Sep 2015 17:43:43 +0000 (19:43 +0200)]
copy LV2 options to heap.

Stack pointer becomes invalid when the array goes out of scope.
Fixes rare crash in suil_wrapper_new() or GUIs iterating over options.

8 years agofix crash at session-close, amend dec4790d
Robin Gareus [Thu, 24 Sep 2015 23:05:13 +0000 (01:05 +0200)]
fix crash at session-close, amend dec4790d

8 years agoAdd some casting to keep MSVC happy
John Emmas [Thu, 24 Sep 2015 08:06:19 +0000 (09:06 +0100)]
Add some casting to keep MSVC happy

8 years agoAdd some newly introduced sources to our MSVC project (libardour)
John Emmas [Thu, 24 Sep 2015 08:05:38 +0000 (09:05 +0100)]
Add some newly introduced sources to our MSVC project (libardour)

8 years agoredisplay markers after removal - fixes #6596
Robin Gareus [Wed, 23 Sep 2015 22:27:32 +0000 (00:27 +0200)]
redisplay markers after removal - fixes #6596

8 years agofix iterator after map::erase().
Robin Gareus [Wed, 23 Sep 2015 20:23:43 +0000 (22:23 +0200)]
fix iterator after map::erase().

The iterator referring to the removed element is invalidated.
Other iterators remain valid.

8 years agostandardize VST Callback debug message print
Robin Gareus [Tue, 22 Sep 2015 18:48:21 +0000 (20:48 +0200)]
standardize VST Callback debug message print

8 years agoadd debug flags for VST Callbacks
Robin Gareus [Tue, 22 Sep 2015 18:37:35 +0000 (20:37 +0200)]
add debug flags for VST Callbacks

8 years agoHide create new item from Group Tab context menu
Todd Naugle [Mon, 21 Sep 2015 21:49:40 +0000 (16:49 -0500)]
Hide create new item from Group Tab context menu

Creating a new empty group from the group tab area just looks broken since
nothing visible happens, so hide this item when the context menu is
triggered from this location.

8 years agoPBD::Debug to stdout
Robin Gareus [Mon, 21 Sep 2015 21:08:45 +0000 (23:08 +0200)]
PBD::Debug to stdout

fixes debug output on windows. std::cerr is lost,
only std::cout, printf() and fprintf(stderr, ..) work.

8 years agoamend 01403dc (VST Pin connected)
Robin Gareus [Mon, 21 Sep 2015 21:01:38 +0000 (23:01 +0200)]
amend 01403dc (VST Pin connected)

8 years agoCreate new Groups with a consistent set of default properties.
Todd Naugle [Mon, 21 Sep 2015 19:52:25 +0000 (14:52 -0500)]
Create new Groups with a consistent set of default properties.

This is part of a larger fix for #6450. Previously new route groups were
created with different default properties depending on which code created
the new group. The group tab method had all properties set and that is now
going to be the default for all other methods (mixer strip button, etc).

8 years agoUpdate RouteGroup property defaults.
Todd Naugle [Mon, 21 Sep 2015 19:49:31 +0000 (14:49 -0500)]
Update RouteGroup property defaults.

This is part of a larger fix for #6450. Previously new route groups were
created with different default properties depending on which code created
the new group. The group tab method had all properties set and that is now
going to be the default.

8 years agoprocessor-box: explicitly check for "Amp" (Fader)
Robin Gareus [Mon, 21 Sep 2015 11:14:29 +0000 (13:14 +0200)]
processor-box: explicitly check for "Amp" (Fader)

8 years agosave-as, update button sensitivity when dir changes
Robin Gareus [Mon, 21 Sep 2015 10:05:31 +0000 (12:05 +0200)]
save-as, update button sensitivity when dir changes

8 years agoadd includes for g_open()
Robin Gareus [Mon, 21 Sep 2015 09:06:34 +0000 (11:06 +0200)]
add includes for g_open()

8 years agofix vst plugin; not sure if this was the intention, but it builds now.
Ben Loftis [Mon, 21 Sep 2015 02:20:12 +0000 (21:20 -0500)]
fix vst plugin; not sure if this was the intention, but it builds now.

8 years agoVpot assign buttons don't do anything, don't light LEDs either.
Len Ovens [Mon, 21 Sep 2015 03:09:42 +0000 (20:09 -0700)]
Vpot assign buttons don't do anything, don't light LEDs either.

8 years agoMake Mackie control surface LEDs for modifier keys only light while pressed. (fixes...
Len Ovens [Mon, 21 Sep 2015 01:26:16 +0000 (18:26 -0700)]
Make Mackie control surface LEDs for modifier keys only light while pressed. (fixes #6601)

8 years agofix VST audioMasterPinConnected callback
Robin Gareus [Mon, 21 Sep 2015 00:20:22 +0000 (02:20 +0200)]
fix VST audioMasterPinConnected callback

8 years agoadd André to authors list.
Robin Gareus [Sun, 20 Sep 2015 20:30:43 +0000 (22:30 +0200)]
add André to authors list.

8 years agofix duplicating multiple selected regions - fixes #6202
André Nusser [Sun, 20 Sep 2015 20:22:39 +0000 (22:22 +0200)]
fix duplicating multiple selected regions - fixes #6202

8 years agoexplicit string.h include for memset()
Robin Gareus [Sun, 20 Sep 2015 18:24:49 +0000 (20:24 +0200)]
explicit string.h include for memset()

8 years agoupdate SFDB settings when track selection changes
Robin Gareus [Sun, 20 Sep 2015 18:03:09 +0000 (20:03 +0200)]
update SFDB settings when track selection changes

8 years agofix initial state of Import Dialog
Robin Gareus [Sun, 20 Sep 2015 18:02:40 +0000 (20:02 +0200)]
fix initial state of Import Dialog

8 years agosilence detection: include fades.
Robin Gareus [Sun, 20 Sep 2015 17:40:32 +0000 (19:40 +0200)]
silence detection: include fades.

Fades must be outside of regions above threshold in order
to properly split drum-hits or fast transients in general.

8 years agofix sndfilesource::open return value typo.
Robin Gareus [Sun, 20 Sep 2015 16:38:52 +0000 (18:38 +0200)]
fix sndfilesource::open return value typo.

8 years agobasic GUI support to auto-align video by LTC.
Robin Gareus [Sun, 20 Sep 2015 16:37:39 +0000 (18:37 +0200)]
basic GUI support to auto-align video by LTC.

8 years agoprepare LTC File Reader
Robin Gareus [Sun, 20 Sep 2015 01:17:26 +0000 (03:17 +0200)]
prepare LTC File Reader

8 years agoGUI part of silence-trim fade constraint.
Robin Gareus [Sat, 19 Sep 2015 23:28:37 +0000 (01:28 +0200)]
GUI part of silence-trim fade constraint.

8 years agoadd silence-stripping fade constraints
Robin Gareus [Sat, 19 Sep 2015 23:28:15 +0000 (01:28 +0200)]
add silence-stripping fade constraints

Ensure that non-silent regions are at least
as long as the selected fade-duration.

8 years agoSilence detect: constrain duration in GUI.
Robin Gareus [Sat, 19 Sep 2015 21:33:35 +0000 (23:33 +0200)]
Silence detect: constrain duration in GUI.

8 years agoNOOP, whitespace.
Robin Gareus [Sat, 19 Sep 2015 18:31:32 +0000 (20:31 +0200)]
NOOP, whitespace.

8 years agoindicate that silence trim is already active.
Robin Gareus [Sat, 19 Sep 2015 18:28:56 +0000 (20:28 +0200)]
indicate that silence trim is already active.

8 years agoband-aid for Glib::operator<<
Robin Gareus [Sat, 19 Sep 2015 16:38:56 +0000 (18:38 +0200)]
band-aid for Glib::operator<<

it seems that g_locale_from_utf8() (called by <<) is not thread safe,
at least not on OSX.

glib error-code 1, Invalid byte sequence in conversion input
-> throws Glib::Error.

possible fix for #6435, route-creation is interrupted via catch(...)

8 years agoDummy: add a CC only test-sequence
Robin Gareus [Sat, 19 Sep 2015 16:32:35 +0000 (18:32 +0200)]
Dummy: add a CC only test-sequence

8 years agofix crash at exit, ctrl+s during quit.
Robin Gareus [Sat, 19 Sep 2015 16:32:23 +0000 (18:32 +0200)]
fix crash at exit, ctrl+s during quit.

8 years agofix possible endless loop in silence detection
Robin Gareus [Sat, 19 Sep 2015 16:31:41 +0000 (18:31 +0200)]
fix possible endless loop in silence detection

8 years agoremove cruft
Robin Gareus [Sat, 19 Sep 2015 16:30:01 +0000 (18:30 +0200)]
remove cruft

8 years agoStripSilence: invalidate Completed connection - fixes #6600
Robin Gareus [Sat, 19 Sep 2015 16:29:51 +0000 (18:29 +0200)]
StripSilence: invalidate Completed connection - fixes #6600

8 years agotweak colors for silence-detection
Robin Gareus [Sat, 19 Sep 2015 16:10:29 +0000 (18:10 +0200)]
tweak colors for silence-detection

The text annotation needs to be visible:
 - above default background (dark gray)
 - above waveform (orange)
 - above silent-highly regions (violet, was bright turqoise)

old color (dark blue) failed for all but the waveform.

8 years agofix silence-strip process report
Robin Gareus [Sat, 19 Sep 2015 15:32:40 +0000 (17:32 +0200)]
fix silence-strip process report

8 years agofix progress reporter, use idle callback.
Robin Gareus [Sat, 19 Sep 2015 15:32:12 +0000 (17:32 +0200)]
fix progress reporter, use idle callback.

do not directly hook into Glib's Main Context.

8 years agounhardcode OSX bundle-name
Robin Gareus [Sat, 19 Sep 2015 13:10:15 +0000 (15:10 +0200)]
unhardcode OSX bundle-name

8 years agoFix windows test to also pass under wine
Tim Mayberry [Sat, 19 Sep 2015 00:59:39 +0000 (10:59 +1000)]
Fix windows test to also pass under wine

It looks as if the default timer resolution for applications running under wine
is different than Windows so just test that the minimum timer resolution is
below a certain amount rather than checking before and after calling
timeBeginPeriod

8 years agono c99
Robin Gareus [Fri, 18 Sep 2015 23:22:14 +0000 (01:22 +0200)]
no c99

8 years agospeed-up smf_track_delete() from O(N^2) to O(n)
Robin Gareus [Fri, 18 Sep 2015 22:38:32 +0000 (00:38 +0200)]
speed-up smf_track_delete() from O(N^2) to O(n)

8 years agocreate new Event-IDs for pasted midi-notes
Robin Gareus [Fri, 18 Sep 2015 18:37:00 +0000 (20:37 +0200)]
create new Event-IDs for pasted midi-notes

8 years agoNOOP - SMF debugging.
Robin Gareus [Fri, 18 Sep 2015 13:13:09 +0000 (15:13 +0200)]
NOOP - SMF debugging.