Robin Gareus [Mon, 19 Jan 2015 23:46:58 +0000 (00:46 +0100)]
few more basic ControList/Curve Tests
Guido Aulisi [Sat, 16 Aug 2014 10:26:33 +0000 (12:26 +0200)]
Curve::_get_vector: fix return value when veclen == 1
When the crossfade length is only 1 frame, I got strange
gain coefficients from get_vector (63 in my case).
The function wrongly returned the x axis value.
Robin Gareus [Mon, 19 Jan 2015 22:53:52 +0000 (23:53 +0100)]
2-point Curve Linear Interpolation Test
Paul Davis [Mon, 19 Jan 2015 21:18:48 +0000 (16:18 -0500)]
C fix for readtest (git command ordering caused this)
Paul Davis [Mon, 19 Jan 2015 21:17:16 +0000 (16:17 -0500)]
various fixes and improvements
Paul Davis [Mon, 19 Jan 2015 21:16:51 +0000 (16:16 -0500)]
new C version of readtester, without libsndfile
Robin Gareus [Mon, 19 Jan 2015 21:14:58 +0000 (22:14 +0100)]
minimalistic Evoral::Curve Unit Test.
Paul Davis [Mon, 19 Jan 2015 19:57:24 +0000 (14:57 -0500)]
new read tester for investigating read bandwidth issues
nick_m [Mon, 19 Jan 2015 17:49:44 +0000 (04:49 +1100)]
Fixes for when rubberbanding_snaps_to_grid config setting is off.
The initial point and the ultimately selected items were always following
the snap settings. Also the VCC was displaying incorrectly on button press.
Robin Gareus [Mon, 19 Jan 2015 16:50:50 +0000 (17:50 +0100)]
Hotfix crash in OSX engine dialog.
This is not really a fix, just some quick hack
to make ardour start at all if there’s no prior
CoreAudio EngineState in the config.
Ben Loftis [Mon, 19 Jan 2015 13:29:25 +0000 (07:29 -0600)]
use C locale, because POSIX locale is not supported on windows, and operation is undefined. C works on all platforms
John Emmas [Sun, 18 Jan 2015 18:52:24 +0000 (18:52 +0000)]
On Windows, #include <shellapi.h> so we can use ShellExecute()
Ben Loftis [Sun, 18 Jan 2015 17:16:28 +0000 (11:16 -0600)]
fix open_uri for windows
Ben Loftis [Sun, 18 Jan 2015 15:43:05 +0000 (09:43 -0600)]
Dramatically improve windows session-save-time by avoiding recursive calls to set_locale.
David Robillard [Sun, 18 Jan 2015 03:19:57 +0000 (22:19 -0500)]
Fix MIDI bounce/consolidate note resolution.
David Robillard [Sun, 18 Jan 2015 02:33:00 +0000 (21:33 -0500)]
Fix stuck notes in short MIDI regions.
Robin Gareus [Sat, 17 Jan 2015 21:38:48 +0000 (22:38 +0100)]
consistent display of period-size.
Robin Gareus [Sat, 17 Jan 2015 21:02:36 +0000 (22:02 +0100)]
fix panner send-strip color
Robin Gareus [Sat, 17 Jan 2015 20:28:59 +0000 (21:28 +0100)]
display current buffer size - hopefully w/o breaking ASIO
Robin Gareus [Sat, 17 Jan 2015 20:09:37 +0000 (21:09 +0100)]
Robin Gareus [Sat, 17 Jan 2015 20:02:00 +0000 (21:02 +0100)]
Engine Dialog: fix various signal connections
connect/disconnect button was connected multiple times
Also the button allowed to start a backend with
invalid settings (after changing backend).
Q: does “Connect to” make sense? It’s redundant with
“Apply”.
Robin Gareus [Sat, 17 Jan 2015 18:51:57 +0000 (19:51 +0100)]
engine dialog fix buffersize sensitivity
Robin Gareus [Sat, 17 Jan 2015 18:50:48 +0000 (19:50 +0100)]
update engine dialog UI state
fixes crash when jack is started externally
and the dialog is displayed later.
The current state e.g. avail buffer sizes is not
are queried from the backend, Apply,OK -> crash
because the dropdown is empty)
nick_m [Sat, 17 Jan 2015 18:25:23 +0000 (05:25 +1100)]
Fix some ignored region selection changes (probably others).
Fix ignored right click track selection change.
Robin Gareus [Sat, 17 Jan 2015 17:19:25 +0000 (18:19 +0100)]
waf: fix concurrency issue with duplicate targets
The same source file cannot safely be used in different wscripts
with concurrency (if they were in the same wscript it works
.c.1.o .c.2.o, etc).
[387/764] c: libs/fst/vstwin.c -> build/libs/fst/vstwin.c.1.o
[731/764] c: libs/fst/vstwin.c -> build/libs/fst/vstwin.c.1.o
[746/764] cxxprogram: build/libs/fst/scanner.cc.1.o build/libs/fst/vstwin.c.1.o -> build/libs/fst/ardour-vst-scanner.exe
[750/764] cxxshlib: [...] build/libs/fst/vstwin.c.1.o [...] -> build/libs/ardour/ardour-3.dll
and about one every full moon (depending on concurrency) it failed:
missing file: 'build/libs/fst/vstwin.c.1.o'
David Robillard [Sat, 17 Jan 2015 03:06:10 +0000 (22:06 -0500)]
Revert "Kludgey fix for invisible playhead when scrolled."
This reverts commit
8f823388d9bd5aa8e297ab05be8c9fb323518945.
David Robillard [Sat, 17 Jan 2015 03:04:26 +0000 (22:04 -0500)]
Compute arrow bbox manually to appease crazy canvas.
David Robillard [Sat, 17 Jan 2015 02:04:38 +0000 (21:04 -0500)]
Kludgey fix for invisible playhead when scrolled.
The problem this is avoiding makes absolutely no sense. Either I'm dumb, or
something is more deeply wrong with scroll group bounding boxes, or both, but I
don't care anymore. This works. Viva release mode.
Robin Gareus [Sat, 17 Jan 2015 00:26:29 +0000 (01:26 +0100)]
David Robillard [Sat, 17 Jan 2015 00:09:47 +0000 (19:09 -0500)]
Put playhead on top of everything.
Achieve this by adding a new hscroll group just for cursors.
That requires a slightly smarter window_to_canvas() to deal with overlapping
sensitive scroll groups. New rule is that scroll groups can overlap, but the
most sensitive one found from the top down will be chosen to translate
coordinates. This basically means don't overlap scroll groups with different
sensitivities.
In the presence of scroll groups, having a canvas-wide window_to_canvas()
and/or canvas_to_window() fundamentally makes no sense. At some point in the
glorious future we should kill those and use only item-relative coordinate
translation.
David Robillard [Fri, 16 Jan 2015 23:36:58 +0000 (18:36 -0500)]
Update arrow bbox when geometry changes.
David Robillard [Fri, 16 Jan 2015 23:26:54 +0000 (18:26 -0500)]
Fix clipping for scroll groups an offset bbox.
Ben Loftis [Fri, 16 Jan 2015 23:14:06 +0000 (17:14 -0600)]
ASIO devices have a preferred buffersize.
pass this value up so it can be used by the engine dialog.
if for some reason the engine dialog still doesn't have a buffersize selected, print an error and try 512 instead of crashing.
Robin Gareus [Fri, 16 Jan 2015 21:24:04 +0000 (22:24 +0100)]
DMG background images for Mixbus
Robin Gareus [Fri, 16 Jan 2015 21:21:12 +0000 (22:21 +0100)]
mixbus quick-start PDF is history
David Robillard [Fri, 16 Jan 2015 19:52:40 +0000 (14:52 -0500)]
Fix hidden notes at trimmed region start.
nick_m [Fri, 16 Jan 2015 17:55:05 +0000 (04:55 +1100)]
Fix note resize double undo bug.
Newly drawn notes are selected.
Clear midi note selection on Selection::set_state().
David Robillard [Thu, 15 Jan 2015 01:31:38 +0000 (20:31 -0500)]
Fix setting command key bindings on OSX.
Robin Gareus [Wed, 14 Jan 2015 19:10:34 +0000 (20:10 +0100)]
don’t show “-all-“ group with currently does nothing.
Robin Gareus [Wed, 14 Jan 2015 18:29:55 +0000 (19:29 +0100)]
JACK: add support for device names with whitespace
This is backwards compatible, quotes are only added if needed.
JACK1 < 0.123.1-30 and JACK2 < 1.9.10-25 fail with either
whitespace or quotes, so nothing is lost.
nick_m [Wed, 14 Jan 2015 14:39:00 +0000 (01:39 +1100)]
Reduce selection loss when changing mouse modes.
Never change selection when smart mode toggled.
nick_m [Wed, 14 Jan 2015 13:06:16 +0000 (00:06 +1100)]
A test for less brutall deselection on mouse mode change.
Mostly stops toggling smart mode from doing anything to the selection.
Ben Loftis [Wed, 14 Jan 2015 12:30:16 +0000 (06:30 -0600)]
toggling smart mode is just an option.
it should not force mouse-mode to Object
it should not clear the current object selection
David Robillard [Wed, 14 Jan 2015 04:53:28 +0000 (23:53 -0500)]
Remove drag code from automation region view.
Let the editor handle it like (almost) everything else.
David Robillard [Wed, 14 Jan 2015 04:30:37 +0000 (23:30 -0500)]
Fix automation range drag and implement for MIDI.
Range select rect sticks around now after switching to the draw tool, but
disappears if a note selection is made. Not sure if draw is really the most
appropriate tool here (particularly if we ever implement actual pencil-like
drawing); edit contents seems more appropriate but that would probably cause
more selection issues, so here we are.
Ben Loftis [Tue, 13 Jan 2015 19:33:42 +0000 (13:33 -0600)]
when the mouse tool changes, smart mode should have no effect on clearing selections
Robin Gareus [Tue, 13 Jan 2015 17:36:10 +0000 (18:36 +0100)]
fix auditioning of regions with offset - fixes #6131
nick_m [Tue, 13 Jan 2015 11:52:02 +0000 (22:52 +1100)]
Don't reuse _optimization_iterator - fixes crash on multiple note delete undo.
nick_m [Tue, 13 Jan 2015 10:41:30 +0000 (21:41 +1100)]
Fix missing selection undo for track header click and route list select.
David Robillard [Tue, 13 Jan 2015 06:00:53 +0000 (01:00 -0500)]
Give tempo dialog initial focus to BPM spinner.
Robin Gareus [Mon, 12 Jan 2015 22:17:39 +0000 (23:17 +0100)]
LTC: don’t flag “no lock” until delta was at zero at least least once.
Robin Gareus [Mon, 12 Jan 2015 21:34:08 +0000 (22:34 +0100)]
show title bar for big clock window
fixes #6116
(on OSX and [most] Linux WMs the title-bar was implicitly present)
Robin Gareus [Mon, 12 Jan 2015 19:45:34 +0000 (20:45 +0100)]
small tool to debug .peak files
Robin Gareus [Mon, 12 Jan 2015 19:27:23 +0000 (20:27 +0100)]
add an explicit indicator for LTC lock
Robin Gareus [Mon, 12 Jan 2015 17:57:02 +0000 (18:57 +0100)]
strict OSX packaging, fail on error
Robin Gareus [Mon, 12 Jan 2015 02:08:14 +0000 (03:08 +0100)]
force complete peak compute.
Do not skip peaks when creating peak files while recording.
Fixes missing peaks in #6127
(TODO: after double-check and sign-off, remove ‘force’
parameter from ::compute_and_write_peaks API)
John Emmas [Mon, 12 Jan 2015 14:47:44 +0000 (14:47 +0000)]
Following my last change we can now give 'MSVCArdour3.vsprops.in' its correct name
This change is MSVC specific and shouldn't affect the other builds
John Emmas [Mon, 12 Jan 2015 14:43:22 +0000 (14:43 +0000)]
When building with MSVC make sure any backends / panners etc get copied to the correct target folder
(i.e. 'lib/ardour3' or 'lib/mixbus3' as appropriate)
These changes are MSVC specific and shouldn't affect the other builds
David Robillard [Mon, 12 Jan 2015 07:31:27 +0000 (02:31 -0500)]
Don't default to grab mode when undoing selection.
I'm not sure how/why this ever happens, but it does, switching the tool when it
shouldn't, which is annoying. I'm also not sure if this fallback is necessary
for some reason, but it seems to work fine without for me.
David Robillard [Mon, 12 Jan 2015 07:05:19 +0000 (02:05 -0500)]
Fix whitespace.
David Robillard [Mon, 12 Jan 2015 07:04:55 +0000 (02:04 -0500)]
Merge duplicated code.
David Robillard [Mon, 12 Jan 2015 07:04:08 +0000 (02:04 -0500)]
Trim include tree.
David Robillard [Mon, 12 Jan 2015 07:03:49 +0000 (02:03 -0500)]
Fix crash when undoing note delete.
David Robillard [Mon, 12 Jan 2015 06:02:58 +0000 (01:02 -0500)]
Fix broken whitespace (noop).
David Robillard [Mon, 12 Jan 2015 06:02:37 +0000 (01:02 -0500)]
Put tempo lines below tracks.
David Robillard [Mon, 12 Jan 2015 06:01:44 +0000 (01:01 -0500)]
Remove unused vertical scroll group.
David Robillard [Mon, 12 Jan 2015 05:57:10 +0000 (00:57 -0500)]
Fix mouse event position offset bug.
Search scroll groups for event delivery from top to bottom rather than bottom
to top. Overlapping scroll groups still aren't properly supported by the
canvas, but currently all we care about is that the top one gets the event, so
the hscroll group (tempo lines) can be below the hvscroll group (tracks), but
the latter gets events.
David Robillard [Mon, 12 Jan 2015 02:41:17 +0000 (21:41 -0500)]
Revert "hotfix z-stacking"
This reverts commit
03f0229bcfc35916f81c6187948df3ea3b79a976.
Mitigate the fallout from said overly aggressive revert: preserve the alpha
values to not break the color configuration for when the lines are fixed.
Robin Gareus [Sun, 11 Jan 2015 14:58:28 +0000 (15:58 +0100)]
add a midi->audio dummy backend mode.
this allows to easily debug latency compensation
as well as visualize lost midi events.
Ben Loftis [Sun, 11 Jan 2015 17:46:36 +0000 (11:46 -0600)]
remove track-selection requirement so fit_selected_tracks works as coded. change name to fit-selection. remove action to zoom (both axes) because this can trivially be accomplished by clicking (f)it and (z)oom sequentially, and it frees a keybinding. remaining bug: Fitting a selection of MIDI regions doesnt work right
Robin Gareus [Sun, 11 Jan 2015 13:13:54 +0000 (14:13 +0100)]
hotfix z-stacking
This reverts commit
780c1762 and
e70c9a3
Both combined introduced various bugs:
* rubberband-selection has a scroll-offset
* region drag/drop has wrong y-offset
* ranges (loop etc) are above the playhead
* possible scroll performance hit (long unclipped
lines in h_scroll_group)
on the downside: time-grid is now no longer visible behind
the rulers. Doing that will require a different approach…
Robin Gareus [Sun, 11 Jan 2015 01:55:48 +0000 (02:55 +0100)]
clean up whitespace & debug output in
44203ce
David Robillard [Sun, 11 Jan 2015 00:38:37 +0000 (19:38 -0500)]
Raise threshold for showing ticks for a bit.
This fixes two zoom levels (the closest that shows bars, and the next closest)
that had the same tick resolution despite enough space.
David Robillard [Sun, 11 Jan 2015 00:38:21 +0000 (19:38 -0500)]
Raise regions about tempo lines.
Robin Gareus [Sat, 10 Jan 2015 18:39:45 +0000 (19:39 +0100)]
consistent autobuild log output
Robin Gareus [Sat, 10 Jan 2015 18:31:50 +0000 (19:31 +0100)]
gracefully handle missing .midnam
Fixes bug: Add a .midnam to local preferences.
use it in a session. delete the .midnam,
reload session -> crash
nick_m [Sat, 10 Jan 2015 17:07:31 +0000 (04:07 +1100)]
Fix AutomationTrackItem rubberband click thinking it was unhandled.
Fix several other cases where a single mouse click could cause several
(not nested) selection ops.
Fix missing selection memento for midi notes and midi commands.
Rename some variables.
Fix random style issues.
John Emmas [Sat, 10 Jan 2015 12:15:47 +0000 (12:15 +0000)]
Accommodate a newly introduced #define ('LIBARDOUR') when building with MSVC
These changes are MSVC specific and shouldn't affect the other builds.
John Emmas [Sat, 10 Jan 2015 12:13:33 +0000 (12:13 +0000)]
Accommodate a newly introduced #define ('PROGRAM_VERSION') when building with MSVC
This change is MSVC specific and shouldn't affect the other builds.
John Emmas [Sat, 10 Jan 2015 11:58:58 +0000 (11:58 +0000)]
Add a newly introduced header file to our MSVC project (libevoral)
This change is MSVC specific and shouldn't affect the other builds.
John Emmas [Sat, 10 Jan 2015 11:56:24 +0000 (11:56 +0000)]
Add support for the C99 function 'log2()' which is newly needed by 'gtk2_ardour/tempo_lines.cc' (but isn't available from MSVC).
These changes are MSVC specific and shouldn't affect the other builds.
(incidentally, libpbd already offers a function called 'fast_log2()'. Not sure if that could have been used instead...)
David Robillard [Fri, 9 Jan 2015 22:49:16 +0000 (17:49 -0500)]
Fix initial display of grouped MIDI region colors.
David Robillard [Fri, 9 Jan 2015 22:48:58 +0000 (17:48 -0500)]
Use quotes to include local library headers.
Ben Loftis [Fri, 9 Jan 2015 18:20:02 +0000 (12:20 -0600)]
fix select-all-regions-within (it used to select everything overlapped)
Ben Loftis [Fri, 9 Jan 2015 17:14:34 +0000 (11:14 -0600)]
make set_selection_from_region do something visible
Ben Loftis [Thu, 8 Jan 2015 22:27:24 +0000 (16:27 -0600)]
stash Bring Into Session inside the Cleanup submenu
Robin Gareus [Fri, 9 Jan 2015 17:05:27 +0000 (18:05 +0100)]
add .m2t video extension
Robin Gareus [Thu, 8 Jan 2015 19:31:23 +0000 (20:31 +0100)]
remove cruft (old unused pre-git version files)
Robin Gareus [Fri, 9 Jan 2015 05:02:36 +0000 (06:02 +0100)]
fix LTC alignment.
LTC-slave: offset the parsed LTC-frame instead of changing the
frame's timestamp. This fixes an issue with freewheel timeout and
delta-calculation. Align transport-time with output to match
capture alignment: "with existing material".
LTC-generator: follow suit. align clock with master-bus out.
This is a semi-permanent workaround. Once [tracks feeding] the
master-bus is/are delayed to align to output. The generator
needs to use (worst_track_latency not worst_playback_latency)
Robin Gareus [Fri, 9 Jan 2015 02:18:43 +0000 (03:18 +0100)]
Revert "don't unpack and repack meters unnecessarily during LevelMeterBase::setup_meters()"
This reverts commit
d00e035fe0618c8e3f4c87c6386fc87efb58cd62.
..which introduced a bug.
Meter count and type may change when switching the meter point or simply
when selecting a different track in the editor-mixer. Additional meters
were not unpacked and remained on canvas.
Ideally we'd just remove the excess meters or meters where the type
changed, but that's far more complex than just repacking them all.
David Robillard [Fri, 9 Jan 2015 04:28:02 +0000 (23:28 -0500)]
Fix offset events when consolidating MIDI range.
David Robillard [Fri, 9 Jan 2015 02:10:54 +0000 (21:10 -0500)]
More contrast between different division lines.
David Robillard [Fri, 9 Jan 2015 02:10:13 +0000 (21:10 -0500)]
Stop showing bar lines sooner.
Not sure if this is a DPI dependent thing, but when zooming out some of the
steps had way too dense bar lines for me.
David Robillard [Fri, 9 Jan 2015 01:15:02 +0000 (20:15 -0500)]
Fix windows key bindings.
I am not sure if this is correct, but since the name in the bindings didn't
match that in keyboard.cc, the modifier was just ignored, which results in
conflicting bindings and consequent bugs.
"Meta" seems to be the name for this thing (oddly, to me), so I chose that,
though since my window manager steals this key (as basically all the standard
ones do these days) I can't tell if these bindings actually work with the
desired key.
David Robillard [Fri, 9 Jan 2015 00:59:40 +0000 (19:59 -0500)]
Fix show MIDI regions using track color.
David Robillard [Fri, 9 Jan 2015 00:22:09 +0000 (19:22 -0500)]
Fix inactive track header color.
David Robillard [Fri, 9 Jan 2015 00:13:00 +0000 (19:13 -0500)]
Prevent note trim to zero length (shown as stuck).
The reasonable value 1 tick doesn't seem to work here, presumably it gets lost
in rounding conversion somewhere. Instead use a really small power of two
reciprocal. Once we use actual beats and ticks we can fix this to be a minimum
of one tick (the actual minimum length for a note).
David Robillard [Thu, 8 Jan 2015 23:47:08 +0000 (18:47 -0500)]
Fix value ramps to reach specified upper value.
David Robillard [Thu, 8 Jan 2015 23:46:16 +0000 (18:46 -0500)]
Clamp value spinner when valid range changes.
David Robillard [Thu, 8 Jan 2015 23:34:18 +0000 (18:34 -0500)]
Meter-like note colours, but still mostly green.
The previous colours made low velocity notes almost invisible. This fixes that
and attempts meter-like colours where yellowish is high, but without going all
the way into red for a generally consistent range of colors.