Robin Gareus [Wed, 7 Aug 2013 13:57:29 +0000 (15:57 +0200)]
fix compiler warning
Robin Gareus [Sun, 4 Aug 2013 16:50:51 +0000 (18:50 +0200)]
fix meter-background highlight when peaking. (> vs >=)
Robin Gareus [Sun, 4 Aug 2013 16:49:28 +0000 (18:49 +0200)]
fix rounding issue when dragging video with fractional fps
Robin Gareus [Sun, 4 Aug 2013 15:23:58 +0000 (17:23 +0200)]
vtl: import audio at video-offset, forget offset on "Remove Video"
Robin Gareus [Sun, 4 Aug 2013 14:22:00 +0000 (16:22 +0200)]
Timecode: fix subframe rounding
if sub-frames are used, frames are rounded up for the later half of
a sub-frame. e.g. @48KSPS, 25fps, 100 subframes per frame
audio-samples >=1910 already yield 00:00:00:01
Robin Gareus [Sun, 4 Aug 2013 14:13:43 +0000 (16:13 +0200)]
fix no-roll LTC encoder, honor locates when transport is stopped
Robin Gareus [Sat, 3 Aug 2013 22:06:29 +0000 (00:06 +0200)]
make master-meter in toolbar optional
Robin Gareus [Sat, 3 Aug 2013 19:35:19 +0000 (21:35 +0200)]
advance track's play-position even if processing is locked
fixes
* http://tracker.ardour.org/view.php?id=5628
* http://tracker.ardour.org/view.php?id=5561
Robin Gareus [Sat, 3 Aug 2013 14:54:57 +0000 (16:54 +0200)]
dedicated namespace for video-utils
conflicting symbol prophylaxis
Robin Gareus [Sat, 3 Aug 2013 14:41:25 +0000 (16:41 +0200)]
remove strtok_r() from video_query_info()
for minGW compatibility
Robin Gareus [Sat, 3 Aug 2013 11:59:22 +0000 (13:59 +0200)]
add a peak reset button to the editor meter
see http://tracker.ardour.org/view.php?id=5601
Robin Gareus [Sat, 3 Aug 2013 11:45:27 +0000 (13:45 +0200)]
fix gtk "child->parent == NULL" asserts
Robin Gareus [Sat, 3 Aug 2013 01:44:51 +0000 (03:44 +0200)]
properly handle port removal in route.
bug:
- add midi track
- add additional midi port
- remove additional midi port
- press play
-> crash
because..
ARDOUR::MidiTrack::roll's route_buffer still has 2 midi-channels. This is
because processor_max_streams was not updated (no plugins added/removed)
fill_buffers_with_input() eventually asserts when trying to get the 2nd
(nonexistant) midi port via ARDOUR::PortSet::nth_midi_port() in
ARDOUR::PortSet::port().
Robin Gareus [Sat, 3 Aug 2013 00:46:08 +0000 (02:46 +0200)]
fix "other" port-group tab
Separate port-bundles for each jack client in the connection manager.
Previously, apps were only listed as separate bundles if the
ports were gathered at different times. ie one app shows up after
the other (and if no complete re-scan was triggered)
Fixes issue reported by Fons Adriaensen.
Michael Fisher [Fri, 2 Aug 2013 23:23:36 +0000 (18:23 -0500)]
Send and Read MIDI Positions the right way
Robin Gareus [Fri, 2 Aug 2013 22:50:09 +0000 (00:50 +0200)]
on session-load: skip output-change-handler until IOs are restored
fixes loading a session with tracks that have more input-ports
than output-ports.
the problem:
input -ports are added first, when added, IO::ensure_port() emits
IOChange::ConfigurationChanged which in turn triggers the route to
allocate corresponding output ports.
Due to this callback the output-ports were created before the actual
output-port-configuration and plugin-configuration from the
session-state was parsed and set.
Robin Gareus [Fri, 2 Aug 2013 21:02:13 +0000 (23:02 +0200)]
disallow invalid port-removal
do not allow port-removal if the port would be re-added immediately
after that again because the main-delivery actually needs it.
As a side effect this prevents this crash:
* create a stereo-track, then remove one output
-> unhandled exception "AudioEngine::PortRegistrationFailure&"
The problem:
- the port is removed from the RCU ports list,
but Port::drop() (which calls jack_port_unregister) is only called
from the Port's destructor at some later time.
(because a reference to the port still exists elsewhere)
- the jack-port is not yet removed.
- meanwhile Delivery::configure_io comes along and notices that
there are more audio-buffers than ports and tries to re-register the port.
- but the port still exists in jack, so it fails and throws an exception
...which is not handled.
Paul Davis [Fri, 2 Aug 2013 16:50:52 +0000 (12:50 -0400)]
fix typos in display of error message about an LV2 plugin preset
Michael Fisher [Fri, 2 Aug 2013 15:29:12 +0000 (10:29 -0500)]
Resolve duplicate symbol 'cocoa_open_uri' on OSX builds.
cocoa_open_uri.mm was being added to the source list
twice and also compiling twice. This patch enusres it is
only added once.
Robin Gareus [Fri, 2 Aug 2013 15:40:58 +0000 (17:40 +0200)]
keep port-matrix in sync when deleting ports. and fix segfault on session close with io-matrix visible
Michael Fisher [Thu, 1 Aug 2013 19:14:01 +0000 (14:14 -0500)]
Midi clock housekeeping
Michael Fisher [Thu, 1 Aug 2013 18:54:58 +0000 (13:54 -0500)]
Make Session::send_song_position_pointer a no-op
Michael Fisher [Thu, 1 Aug 2013 18:47:22 +0000 (13:47 -0500)]
Revamp clock processing so it uses an internal frame reference.
MidiClockTicker::Position managed by boost::scoped_ptr
Michael Fisher [Thu, 1 Aug 2013 15:07:18 +0000 (10:07 -0500)]
WIP - Experimenting with an alternative clock generating algo
- Transport debug output (tracing where transport_frame
is updated
Michael Fisher [Thu, 1 Aug 2013 05:55:58 +0000 (00:55 -0500)]
Human readable printing of MIDI Position messages
Michael Fisher [Thu, 1 Aug 2013 05:09:42 +0000 (00:09 -0500)]
- Send position data from internal position class
- Proper midi beat conversions for all time signatures
- Disable responding to Session::PositionChanged in place
of Session::Located.
Michael Fisher [Wed, 31 Jul 2013 12:15:52 +0000 (07:15 -0500)]
Test code removal...
Michael Fisher [Wed, 31 Jul 2013 12:02:28 +0000 (07:02 -0500)]
MIDI Clock - Shuffling locate code (not actually used yet)
- Subscribe to Session::Locate to detect seeks
- Shuffle Mclk locating computations into a separate private class
Michael Fisher [Mon, 29 Jul 2013 21:15:04 +0000 (16:15 -0500)]
Stop compiler warning about NSURL
Robin Gareus [Fri, 2 Aug 2013 01:39:00 +0000 (03:39 +0200)]
rework MIDI [processor|plugin] chain
* forward midi-data around plugins that have no MIDI-out
* allow to insert plugins with no MIDI-input at a point with one MIDI-channel
This works because excess ports (both plugin and route) remain
unconnected and use scratch-buffers.
Tested with LV2, LXVST and LADSPA.
(AU plugins with variable in/out retain the old behavior, no bypass)
fixes http://tracker.ardour.org/view.php?id=5630
Paul Davis [Thu, 1 Aug 2013 14:46:22 +0000 (10:46 -0400)]
remove an identical odd namespacing typo
Paul Davis [Thu, 1 Aug 2013 14:44:34 +0000 (10:44 -0400)]
remove odd namespacing typo
Paul Davis [Thu, 1 Aug 2013 14:10:21 +0000 (10:10 -0400)]
add _ISOC9X_SOURCE define to compiler command line to provide uniform access to llabs()
Robin Gareus [Thu, 1 Aug 2013 01:17:49 +0000 (03:17 +0200)]
re-check meterbridge metric-area on route deletion
fixes http://tracker.ardour.org/view.php?id=5616#c15204
Robin Gareus [Wed, 31 Jul 2013 22:35:24 +0000 (00:35 +0200)]
use zeroed scratch buffers for "silent" plugin runs
Plugins rewrite the buffer data in-place and some plugins
can produce output even when fed with silence.
Hence, during a PluginInsert::silence() run a plugin can
inject data into the "silent" buffers which causes side-effects.
Kudos to Chris 'oofus' Goddard for finding this issue.
Robin Gareus [Wed, 31 Jul 2013 18:19:57 +0000 (20:19 +0200)]
tiny detail.. GUI-callback may try to check vmonitor->is_started() or issue a periodic seek update while it's going away
Robin Gareus [Wed, 31 Jul 2013 17:24:26 +0000 (19:24 +0200)]
clean up some valgrid "Uninitialised value was created by a heap allocation" wanings
Robin Gareus [Wed, 31 Jul 2013 17:22:58 +0000 (19:22 +0200)]
correct error message
Robin Gareus [Wed, 31 Jul 2013 17:29:06 +0000 (19:29 +0200)]
fix close_allv() sentinel
Robin Gareus [Wed, 31 Jul 2013 16:30:09 +0000 (18:30 +0200)]
valgrind ignore glib UTF8 warnings
Robin Gareus [Wed, 31 Jul 2013 13:52:41 +0000 (15:52 +0200)]
initialize two more uninitialized vars..
Robin Gareus [Wed, 31 Jul 2013 13:24:46 +0000 (15:24 +0200)]
Robin Gareus [Wed, 31 Jul 2013 13:22:51 +0000 (15:22 +0200)]
initialize some uninitialized values
Robin Gareus [Wed, 31 Jul 2013 13:17:22 +0000 (15:17 +0200)]
catch assert()
Robin Gareus [Wed, 31 Jul 2013 12:45:02 +0000 (14:45 +0200)]
LV2 - use scratch buffers to scratch :)
Robin Gareus [Wed, 31 Jul 2013 12:21:40 +0000 (14:21 +0200)]
another amend to
00f26394a9
Robin Gareus [Wed, 31 Jul 2013 00:00:31 +0000 (02:00 +0200)]
fix stupid copy/paste error in
00f26394a9
Robin Gareus [Tue, 30 Jul 2013 23:59:50 +0000 (01:59 +0200)]
minimize meter-peak re-draw area
Robin Gareus [Tue, 30 Jul 2013 18:22:31 +0000 (20:22 +0200)]
RMS meter: remove unused peak-detection
Robin Gareus [Tue, 30 Jul 2013 18:21:02 +0000 (20:21 +0200)]
adjust meterbridge label-heigh options
Robin Gareus [Tue, 30 Jul 2013 16:28:06 +0000 (18:28 +0200)]
add name-tooltips to the meterbridge meters
Robin Gareus [Tue, 30 Jul 2013 15:54:52 +0000 (17:54 +0200)]
clean up
44fc92c3 (not a threading issue but sigc++ problem)
RouteUI is not sigc::trackable itself (only derived classes are)
RouteUI::~RouteUI() does not disconnect from signals on destruction.
Robin Gareus [Tue, 30 Jul 2013 14:55:33 +0000 (16:55 +0200)]
use dedicated buffers for route (and track)
"scratch buffers are by definition scratch and their contents are undefined at all times"
"silent buffers are by definition all-zero and should not be used for real data"
But track & route were using those for actual data; plugins (which may run
in the same thread and may get the same buffers) use them for scratch thereby
overwriting real data.
In particular get_silent_buffers() (used by LadspaPlugin::connect_and_run)
clears the buffer which can holds real data:
e.g. via Route::passthru_silence() -> plugin1 -> plugin2 (clears output of plugin1)
Robin Gareus [Tue, 30 Jul 2013 13:12:32 +0000 (15:12 +0200)]
disconnect AuxSend connection when deleting bus
fixes crash:
- add bus
- aux-send a signal to that bus
- delete bus
- add another bus
- aux-send a signal to "another bus"
- click "Aux Send" button on "another bus"
- crash
Robin Gareus [Tue, 30 Jul 2013 01:02:45 +0000 (03:02 +0200)]
Revert "fix issue with generator plugins and no-roll disk monitoring"
This reverts commit
bd34ab04cd43ed2f5bf6eebb8b6ea0e0e5cbb727.
Robin Gareus [Tue, 30 Jul 2013 00:27:06 +0000 (02:27 +0200)]
fix issue with generator plugins and no-roll disk monitoring
Michael Fisher [Fri, 19 Jul 2013 22:40:16 +0000 (17:40 -0500)]
Return an empty string instead of a bool
Michael Fisher [Wed, 17 Jul 2013 21:05:09 +0000 (16:05 -0500)]
Cast param for std::time to a pointer of time_t
- bleeding clang (trunk 186535 v3.4) fails here
Michael Fisher [Wed, 17 Jul 2013 01:46:46 +0000 (20:46 -0500)]
Proper OSX/CLANG/CXX11 support in stl_delete.h
- replaces fix in
066df0d218ee4391eb3e15259deca5ccc190ed84
- Check if _LIBCPP_VECTOR is defined for vector_delete.
This is defined in libc++'s headers which Apple is using
instead of libstdc++
Michael Fisher [Mon, 29 Jul 2013 17:30:37 +0000 (12:30 -0500)]
Housekeeping, code style
Michael Fisher [Mon, 29 Jul 2013 17:19:55 +0000 (12:19 -0500)]
Moving Mclk locating code to ticker.cc. Housekeeping
Michael Fisher [Sun, 28 Jul 2013 22:18:30 +0000 (17:18 -0500)]
Add method to send a song position pointer message
Michael Fisher [Sun, 28 Jul 2013 22:17:40 +0000 (17:17 -0500)]
Send a song position pointer with mmc and fullframe fake locating
Michael Fisher [Sun, 28 Jul 2013 19:05:24 +0000 (14:05 -0500)]
Add relavent OSX midi options in the startup dialog
- MIDI driver options are now "None" and "coremidi" on OSX
- If coremidi is selected, jack will start with midi activated
- Requires Jack OSX version 0.90 beta 15 (or another version that
supports midi
Robin Gareus [Mon, 29 Jul 2013 18:02:57 +0000 (20:02 +0200)]
tweak meterbridge-label height
Robin Gareus [Mon, 29 Jul 2013 17:43:34 +0000 (19:43 +0200)]
change default BBC-meter color
Robin Gareus [Mon, 29 Jul 2013 17:43:19 +0000 (19:43 +0200)]
fix compiler warning
Robin Gareus [Mon, 29 Jul 2013 17:43:05 +0000 (19:43 +0200)]
use K-20 meter as default master bus
Robin Gareus [Mon, 29 Jul 2013 17:42:41 +0000 (19:42 +0200)]
add option to resize meterbridge track-labels
Robin Gareus [Mon, 29 Jul 2013 14:31:33 +0000 (16:31 +0200)]
explicitly re-init meter when theme changes.
fixes:
14:14 < oofus> rgareus: BBC meter colour changed, all meters
except the one on the tool bar picked it up
Robin Gareus [Mon, 29 Jul 2013 13:26:36 +0000 (15:26 +0200)]
change metric-scale on the sides of meterbridge when scrolling
Robin Gareus [Mon, 29 Jul 2013 01:54:43 +0000 (03:54 +0200)]
allow to configure color of BBC meter
Robin Gareus [Sun, 28 Jul 2013 20:34:28 +0000 (22:34 +0200)]
left/right meter marks in mixer (narrow red-stripe)
Robin Gareus [Sun, 28 Jul 2013 19:34:01 +0000 (21:34 +0200)]
change default meter-fall-off to 13.3 dB/sec
Robin Gareus [Sun, 28 Jul 2013 19:24:27 +0000 (21:24 +0200)]
use 3px for peak-hold in LED mode -> display 2 bright lines
Robin Gareus [Sun, 28 Jul 2013 18:43:21 +0000 (20:43 +0200)]
fix diamond inheritance - gtkmm main class is sigc::trackable
Robin Gareus [Sun, 28 Jul 2013 18:32:52 +0000 (20:32 +0200)]
fix compiler warnings.
Robin Gareus [Sun, 28 Jul 2013 16:29:39 +0000 (18:29 +0200)]
tweak meter-LED style
Edgar Aichinger [Sun, 28 Jul 2013 14:50:26 +0000 (16:50 +0200)]
update german translation for libardour
fixes x42's screwup with prev commit.
Edgar Aichinger [Sun, 28 Jul 2013 14:45:42 +0000 (16:45 +0200)]
update german translation
Robin Gareus [Sun, 28 Jul 2013 13:55:36 +0000 (15:55 +0200)]
k-meter +4 marks
Robin Gareus [Sun, 28 Jul 2013 13:54:13 +0000 (15:54 +0200)]
fix meterbridge window on OSX
Robin Gareus [Sun, 28 Jul 2013 01:29:16 +0000 (03:29 +0200)]
add dedicated line-up level for IEC1/DIN meter (15dbFS)
Robin Gareus [Sun, 28 Jul 2013 01:01:37 +0000 (03:01 +0200)]
make LED meter style optional
Robin Gareus [Sun, 28 Jul 2013 01:31:34 +0000 (03:31 +0200)]
tweak meter-metric red-boxes/stripes
Robin Gareus [Sat, 27 Jul 2013 20:44:38 +0000 (22:44 +0200)]
add red-boxes to meter-marks and fix Nordic scale color
Robin Gareus [Sat, 27 Jul 2013 19:26:22 +0000 (21:26 +0200)]
update meter marks and colors..
Robin Gareus [Sat, 27 Jul 2013 13:02:19 +0000 (15:02 +0200)]
Aux-sends do not have a GUI - fixes #5621
Robin Gareus [Fri, 26 Jul 2013 20:57:39 +0000 (22:57 +0200)]
some more VU-meter tick marks..
Robin Gareus [Fri, 26 Jul 2013 15:17:05 +0000 (17:17 +0200)]
cache shaded meter-background regardless of color
previously, shaded patterns were assumed to have different colors as well.
Robin Gareus [Fri, 26 Jul 2013 15:10:05 +0000 (17:10 +0200)]
fix meter background redraw issue #5601
Robin Gareus [Thu, 25 Jul 2013 21:33:11 +0000 (23:33 +0200)]
fix typo for 0VU = 8dBu in config
Robin Gareus [Thu, 25 Jul 2013 18:56:25 +0000 (20:56 +0200)]
cache midi metrics depending on meter-type and data-type(s)
Robin Gareus [Thu, 25 Jul 2013 17:55:26 +0000 (19:55 +0200)]
remember meter-background highlight when type or width changes..
Robin Gareus [Thu, 25 Jul 2013 17:04:52 +0000 (19:04 +0200)]
[re]implement horizontal meter
Robin Gareus [Thu, 25 Jul 2013 12:19:28 +0000 (14:19 +0200)]
vtl: replace Ardour with Program-Name in messages
Robin Gareus [Thu, 25 Jul 2013 12:18:39 +0000 (14:18 +0200)]
prepare horizontal meters (level-meter H/V Box abstraction)
Robin Gareus [Thu, 25 Jul 2013 11:06:58 +0000 (13:06 +0200)]
set midi-metric ticks depending on meter-type
Robin Gareus [Thu, 25 Jul 2013 09:06:58 +0000 (11:06 +0200)]
VU meter label color&shadow tweak by the_CLA
Robin Gareus [Thu, 25 Jul 2013 09:03:36 +0000 (11:03 +0200)]
tweak label alignment