Robin Gareus [Tue, 10 May 2016 18:06:15 +0000 (20:06 +0200)]
prepare route pin display (shared mixer + editor-mixer window proxy)
Robin Gareus [Mon, 9 May 2016 10:45:36 +0000 (12:45 +0200)]
turn Pin GUI into Widget.
Paul Davis [Tue, 10 May 2016 14:04:03 +0000 (10:04 -0400)]
use main window visibility when toggling between editor + mixer
Paul Davis [Tue, 10 May 2016 14:03:45 +0000 (10:03 -0400)]
add visibility tracking for main window
Paul Davis [Tue, 10 May 2016 13:46:12 +0000 (09:46 -0400)]
track geometry via configure events for tabbable own-windows
Paul Davis [Mon, 9 May 2016 12:14:33 +0000 (08:14 -0400)]
copy-n-paste the ARDOUR_UI toggle-roll code into BasicUI (for Faderport and others)
John Emmas [Sun, 8 May 2016 11:06:12 +0000 (12:06 +0100)]
Fix bug 6833 in bugzilla
http://tracker.ardour.org/view.php?id=6833
When searching for our keyboard bindings file, ArdourKeyboard::find_bindings_files() was trying to find files with the wrong extension:- "..keys" rather than ".keys" (note the extra period). Fortunately, some later code was masking the problem (so we were eventually finding the file correctly). However we might as well fix the problem here, just in case we ever need to call ArdourKeyboard::find_bindings_files() from somewhere else in the future.
John Emmas [Sun, 8 May 2016 10:56:51 +0000 (11:56 +0100)]
Accommodate newly introduced source(s) in our MSVC project (libardour)
Paul Davis [Sat, 7 May 2016 17:35:57 +0000 (13:35 -0400)]
fix shared_ptr<Route> management in Mackie support so that deleted routes are destroyed
Paul Davis [Sat, 7 May 2016 17:32:31 +0000 (13:32 -0400)]
make boost shared_ptr debugging a little easier to turn on/off
Robin Gareus [Sat, 7 May 2016 15:17:41 +0000 (17:17 +0200)]
GUI part of LocaleGuard optimization.
Robin Gareus [Sat, 7 May 2016 15:16:59 +0000 (17:16 +0200)]
a few strategic LocaleGuards..
..to prevent switching forth and back during individual
::state(), ::set_state() when loading/saving the session or locating.
Robin Gareus [Sat, 7 May 2016 13:38:17 +0000 (15:38 +0200)]
fix LV2 locale guard (missed in
6d343ba search/replace)
Robin Gareus [Sat, 7 May 2016 10:20:40 +0000 (12:20 +0200)]
Revert "Add a global state localeguard (and one for route templates)"
This reverts commit
2b7a047e92bc5ebe3287860ff9c9f2fb0acb193c.
Robin Gareus [Sat, 7 May 2016 10:19:41 +0000 (12:19 +0200)]
fix LocaleGuard contstructor (
3dc77280)
Robin Gareus [Sat, 7 May 2016 10:15:12 +0000 (12:15 +0200)]
locale debugging
Robin Gareus [Fri, 6 May 2016 23:22:32 +0000 (01:22 +0200)]
trying to get to the bottom of the decimal comma.
Robin Gareus [Fri, 6 May 2016 23:11:28 +0000 (01:11 +0200)]
Add a global state localeguard (and one for route templates)
Robin Gareus [Fri, 6 May 2016 23:06:20 +0000 (01:06 +0200)]
add a locale-guard to panner state
Robin Gareus [Fri, 6 May 2016 19:25:21 +0000 (21:25 +0200)]
add missing include
Robin Gareus [Fri, 6 May 2016 18:59:24 +0000 (20:59 +0200)]
convert WinMME Device names to UTF-8
Robin Gareus [Fri, 6 May 2016 14:26:22 +0000 (16:26 +0200)]
amend
baca1fd3 (actually use preset)
Robin Gareus [Fri, 6 May 2016 14:04:05 +0000 (16:04 +0200)]
Create new track by dragging an instrument from the favorites sidebar
Robin Gareus [Fri, 6 May 2016 14:02:24 +0000 (16:02 +0200)]
allow lua to construct PresetRecords
Robin Gareus [Fri, 6 May 2016 14:02:04 +0000 (16:02 +0200)]
add API to load Instrument Preset when creating a Midi track
Robin Gareus [Fri, 6 May 2016 12:55:36 +0000 (14:55 +0200)]
separate Preset + Favorite DnD Targets
Sidebar is a source of "Favorites" and a destination for Presets.
Robin Gareus [Fri, 6 May 2016 12:51:29 +0000 (14:51 +0200)]
DnDTreeview: allow to handle multiple drag-targets
Robin Gareus [Fri, 6 May 2016 02:02:34 +0000 (04:02 +0200)]
fix a -Wreorder
Robin Gareus [Fri, 6 May 2016 01:59:02 +0000 (03:59 +0200)]
use WindowManager toggle API for script-manager
Robin Gareus [Fri, 6 May 2016 01:09:20 +0000 (03:09 +0200)]
NO-OP whitespace
Robin Gareus [Fri, 6 May 2016 01:08:46 +0000 (03:08 +0200)]
re-introduce "add track/bus" from mixer window
Robin Gareus [Thu, 5 May 2016 21:49:44 +0000 (23:49 +0200)]
lua script to bounce regions w/processing and replace the region
Robin Gareus [Thu, 5 May 2016 21:44:10 +0000 (23:44 +0200)]
what an oversight!
Robin Gareus [Thu, 5 May 2016 19:49:56 +0000 (21:49 +0200)]
we always only use the "C" locale when saving.
Robin Gareus [Thu, 5 May 2016 18:29:28 +0000 (20:29 +0200)]
remove assert()s from LocaleGuard
Paul Davis [Thu, 5 May 2016 18:21:55 +0000 (14:21 -0400)]
minor comment change
Paul Davis [Thu, 5 May 2016 18:21:02 +0000 (14:21 -0400)]
spelling fixes and an explanatory comment
Robin Gareus [Thu, 5 May 2016 18:02:23 +0000 (20:02 +0200)]
rework locale-guard for C and C++ locales
let's hope querying the C-locale is more lightweight than setting it
on windows.
Robin Gareus [Thu, 5 May 2016 16:33:15 +0000 (18:33 +0200)]
no need to force a change here.
Fixes an issue with Mixbus where set_active() is a NO-OP for mixbusses.
Paul Davis [Thu, 5 May 2016 03:09:37 +0000 (23:09 -0400)]
OMNIBUS COMMIT: prefer const XMLNode::property method (and provide a real one)
Robin Gareus [Wed, 4 May 2016 23:59:11 +0000 (01:59 +0200)]
fix another menu typo in
fda03d1
Robin Gareus [Wed, 4 May 2016 23:28:17 +0000 (01:28 +0200)]
fix "warning: this decimal constant is unsigned only in ISO C90"
Robin Gareus [Wed, 4 May 2016 23:21:53 +0000 (01:21 +0200)]
fix ppc builds
Paul Davis [Wed, 4 May 2016 21:38:10 +0000 (17:38 -0400)]
don't bother compiling nsview code swizzling for PPC
The platform has no support for libdispatch which is handy when setting up an objective C block,
and also has no Retina, which means it doesn't suffer the problem this code is intended to fix
Robin Gareus [Wed, 4 May 2016 15:52:17 +0000 (17:52 +0200)]
use existing API to find the instrument
Robin Gareus [Wed, 4 May 2016 15:36:40 +0000 (17:36 +0200)]
add option to limit track-header meters to stereo
Robin Gareus [Wed, 4 May 2016 10:57:30 +0000 (12:57 +0200)]
NO-OP, whitespace
Robin Gareus [Tue, 3 May 2016 18:12:58 +0000 (20:12 +0200)]
tweak cases where pin-mapping is reset & always sanitize map
Robin Gareus [Tue, 3 May 2016 17:24:33 +0000 (19:24 +0200)]
John Emmas [Tue, 3 May 2016 16:30:58 +0000 (17:30 +0100)]
MSVC won't compile 'const float _demolition[]' because it uses 'divide by zero' while initializing
Hopefully we can use INFINITY and NAN for the relevant initializers ?
John Emmas [Tue, 3 May 2016 16:26:41 +0000 (17:26 +0100)]
Accommodate newly introduced source(s) in our MSVC project (audiographer)
Robin Gareus [Tue, 3 May 2016 16:17:29 +0000 (18:17 +0200)]
handle single-bus, non-variable i/o Audio Units w/multiple configurations.
Alexandre Prokoudine [Tue, 3 May 2016 13:18:18 +0000 (16:18 +0300)]
Update Russian translation
Robin Gareus [Tue, 3 May 2016 12:42:39 +0000 (14:42 +0200)]
Sidechain is one word
Robin Gareus [Tue, 3 May 2016 12:33:37 +0000 (14:33 +0200)]
consistent menu labels
Robin Gareus [Tue, 3 May 2016 12:06:23 +0000 (14:06 +0200)]
batch remove tracks
Robin Gareus [Tue, 3 May 2016 11:56:08 +0000 (13:56 +0200)]
another (non critical) concurrency issue:
Ignore latency-updates while removing tracks.
remove_tracks() calls disconnect_all() which can trigger the backend
to perform a latency-recompute in a different thread (process thread).
That calls Session::update_latency() which iterates over all routes
including the one(s) to be deleted.
At the same time disconnect_all() may propagate Port::PostDisconnect()
leading to a lock contention.
(no crash just a lot of unnecessary work. remove_routes() calls
update_latency_compensation() which triggers a recompute if needed)
Robin Gareus [Tue, 3 May 2016 01:04:46 +0000 (03:04 +0200)]
skip updating editor-route display when closing the session
Robin Gareus [Tue, 3 May 2016 00:19:26 +0000 (02:19 +0200)]
mark initial TAV as hidden to speed up initial display.
This prevents an extra call to "redisplay" from TAV::hide() which
triggers handle_gui_changes.
Visible TAVs are positioned using show_at() which unsets _hidden.
Robin Gareus [Tue, 3 May 2016 12:26:25 +0000 (14:26 +0200)]
speed up track creation
For every added Trackview/Mixerstrip, Ardour looks up GUI properties which
results in a total of 13 calls for the initial default items per track:
("height", "visible", "layer-display", "strip-width")
Since the tracks don't yet exist, the properties don't either.
Every lookup result in iterating over all all XMLNotes and for every
"Object". ->property ("id") and ->value () allocates memory.
Adding 64 tracks to an empty session results in 528293 string
allocations and deallocations in XMLNode::property() taking ~30%
of the track creation time.
This commit XMLnode's const method to prevent memory allocation
and caches a pointer to the XMLNode* to skip iterating over object
state.
Robin Gareus [Tue, 3 May 2016 00:07:40 +0000 (02:07 +0200)]
add a const method to check for existing key/value properties
handy to lookup up XMLNodes with "id" == ID w/o allocating memory.
Robin Gareus [Mon, 2 May 2016 18:24:54 +0000 (20:24 +0200)]
use same tooltip timeout throughout Ardour -- part two
Robin Gareus [Mon, 2 May 2016 18:24:46 +0000 (20:24 +0200)]
use same tooltip timeout throughout Ardour -- part one
Robin Gareus [Mon, 2 May 2016 15:12:42 +0000 (17:12 +0200)]
_plugin_display can be a LuaPluginDisplay
Robin Gareus [Mon, 2 May 2016 13:43:43 +0000 (15:43 +0200)]
remove a stray semicolon
Robin Gareus [Mon, 2 May 2016 13:43:22 +0000 (15:43 +0200)]
Export format GUI updates for loudness normalization
Robin Gareus [Mon, 2 May 2016 13:28:16 +0000 (15:28 +0200)]
Add loudness normalization to Export Format & Graph
Robin Gareus [Mon, 2 May 2016 11:58:51 +0000 (13:58 +0200)]
prepare loudness normalization
Robin Gareus [Sun, 1 May 2016 18:02:09 +0000 (20:02 +0200)]
tweak AU redrawing blocking heuristics
Robin Gareus [Sun, 1 May 2016 17:57:49 +0000 (19:57 +0200)]
increase visibility of actual compiler warnings
Robin Gareus [Sun, 1 May 2016 16:48:27 +0000 (18:48 +0200)]
Rhythm Rodent updates:
* fix aubio parameters (aubio-vamp picks them up on reset)
* group settings by Mode
* add new aubio4 functions and param
Robin Gareus [Sun, 1 May 2016 16:47:14 +0000 (18:47 +0200)]
fix aubio-onset detection parameters
Robin Gareus [Sun, 1 May 2016 16:09:37 +0000 (18:09 +0200)]
add option to auto-save post-export-analysis image
first revision, needs some label position fine-tuning and maybe
an option to include log-scale/rect waveform etc.
Robin Gareus [Sun, 1 May 2016 14:27:11 +0000 (16:27 +0200)]
fix plugin-creator display for non LADSPA plugins
e.g. "u-he"
Robin Gareus [Sun, 1 May 2016 11:35:30 +0000 (13:35 +0200)]
fix a Wsigncompare and 2 -Wuninitialized
Robin Gareus [Sun, 1 May 2016 11:20:53 +0000 (13:20 +0200)]
fix: gcc4.2 / PPC compilation
no match for 'operator!=' in 'x != std::list<_Tp, _Alloc>::rend()
[with _Tp = long long int, _Alloc = std::allocator<long long int>]()'
Robin Gareus [Sun, 1 May 2016 11:11:43 +0000 (13:11 +0200)]
fix adding favorite plugins post-fader
Robin Gareus [Sat, 30 Apr 2016 23:29:07 +0000 (01:29 +0200)]
make region > Edit context menus identical
Robin Gareus [Sat, 30 Apr 2016 23:28:44 +0000 (01:28 +0200)]
NO-OP use spaces throughout the menu file, remove trailing whitespace.
Robin Gareus [Sun, 1 May 2016 00:02:25 +0000 (02:02 +0200)]
GUI updates for transient rework
Robin Gareus [Sun, 1 May 2016 00:02:04 +0000 (02:02 +0200)]
various transient-detection fixes (split region, trim, move, undo,..)
* all API calls use session-time (allow region-lists)
* per-region transients are separated in
- Onset (Rhythm Rodent, Aubio)
- User-added
- internal/source (QM), used as fallback for next/prev (read-only)
Robin Gareus [Sat, 30 Apr 2016 22:28:54 +0000 (00:28 +0200)]
API call to be removed
Paul Davis [Sat, 30 Apr 2016 17:19:56 +0000 (13:19 -0400)]
use CFRunLoopTimer to check the effect of plugin redrawing, not a glib idle
Paul Davis [Sat, 30 Apr 2016 14:54:32 +0000 (10:54 -0400)]
make BasicUI (for control surfaces) loop toggle work like the GUI
Robin Gareus [Fri, 29 Apr 2016 16:34:41 +0000 (18:34 +0200)]
enable luaproc presets
Robin Gareus [Fri, 29 Apr 2016 16:34:27 +0000 (18:34 +0200)]
implement lua plugin presets
Robin Gareus [Fri, 29 Apr 2016 14:43:09 +0000 (16:43 +0200)]
remove skeleton backend (superseded by portaudio)
Robin Gareus [Fri, 29 Apr 2016 14:08:00 +0000 (16:08 +0200)]
I wanna be nasty, I wanna be cruel,..
Somme disastrous signal generators for QA.
Paul Davis [Fri, 29 Apr 2016 12:09:27 +0000 (08:09 -0400)]
clean up of displayIfNeeded hack code
Remove most debug output (not all). Rename variables and functions. Add comments
Robin Gareus [Thu, 28 Apr 2016 23:39:39 +0000 (01:39 +0200)]
save custom favorite plugin order (revert when merging VCA2)
Robin Gareus [Thu, 28 Apr 2016 23:40:06 +0000 (01:40 +0200)]
add Lua DSP plugin category
Robin Gareus [Thu, 28 Apr 2016 23:36:31 +0000 (01:36 +0200)]
remove "Lua DSP Proc" context meuu
Robin Gareus [Thu, 28 Apr 2016 23:26:46 +0000 (01:26 +0200)]
include lua processors in plugin-selector
Robin Gareus [Fri, 29 Apr 2016 00:57:42 +0000 (02:57 +0200)]
don't special case lua processors, use plugin-manager
Paul Davis [Thu, 28 Apr 2016 22:41:50 +0000 (18:41 -0400)]
clever tricks with code swizzling to slow down errant plugin GUIs for AU
This commit swizzles (replaces) NSView::displayIfNeeded to allow us to stop redraws of plugin
windows if the Glib idle timer fires less often then every 40msec. The next 10 plugin redraws
(for all plugin windows combined) will be skipped. Heuristics will likely need some adjustments
Robin Gareus [Thu, 28 Apr 2016 19:38:09 +0000 (21:38 +0200)]
consolidate and re-order luasession code
Robin Gareus [Thu, 28 Apr 2016 19:37:18 +0000 (21:37 +0200)]
flush pending Session Events at session close
This prevents a memory leak: The session is closed.
The session-butler drops memory pool trash. The Engine keeps running.
Once the AudioEngine is taken down (sample-rate switch, or at exit),
the backend process-thread is terminated but there is no trash-can anymore.
If there are unprocessed SessionEvents, this calls
free_per_thread_pool() -> cp->parent()->add_to_trash (cp).
"parent()" in this case the trash-can the butler emptied.
Robin Gareus [Thu, 28 Apr 2016 19:15:26 +0000 (21:15 +0200)]
fix a deadlock with jack2 when inserting a plugin adds ports.
When adding a processor, the processor may add ports leading to
a call to jack_port_register(). while Ardour holds a WritertLock on the
processor-list (this commit removes this WriterLock).
with jack2 that results in a graph-reorder callback (WHY?)
jack2 issues that graph-reorder in a separate thread BUT
port-registration does not return until the graph-reorder is complete.
On Ardour's side, graph_reordered() calls Session::resort_routes ()
which eventually checks Route::direct_feeds_according_to_reality()
which needs a ReadLock on the processor-list to check I/O.
Since jack_port_register() does not return, this constitutes a deadlock.
THE ACTUAL PROBLEM IS JACK2's THREAD DESIGN!
Why does jack_port_register() trigger a graph-order in jack2?
No connections are made.
..and why does it block jack_port_register() from returning if
that graph-order callback is in a different thread?
http://pastebin.com/DZANXJLz
Robin Gareus [Thu, 28 Apr 2016 10:27:53 +0000 (12:27 +0200)]
add a debug message for LV2 per port buffer allocation
Robin Gareus [Thu, 28 Apr 2016 00:52:05 +0000 (02:52 +0200)]
for mixed-i/o show HW ports of both types in the matrix
e.g. sidechain inputs with audio and midi.