ardour.git
8 years agofix AFL/PFL/SIP "stuck solo" - fixes #5803
Robin Gareus [Sun, 4 Oct 2015 19:47:35 +0000 (21:47 +0200)]
fix AFL/PFL/SIP "stuck solo" - fixes #5803

monitor_send are only active when listening (AFL, PFL).
don't activate them when re-configuring processors.

8 years agoupdate NSM executable name - fixes #6620
Robin Gareus [Sun, 4 Oct 2015 19:16:32 +0000 (21:16 +0200)]
update NSM executable name - fixes #6620

NSM requires an executable in $PATH, not full path

8 years agoglobally remove all trailing whitespace from .cpp and .hpp files missed by previous...
Paul Davis [Sun, 4 Oct 2015 19:11:15 +0000 (15:11 -0400)]
globally remove all trailing whitespace from .cpp and .hpp files missed by previous commit

8 years agoglobally remove all trailing whitespace from ardour code base.
Paul Davis [Sun, 4 Oct 2015 18:51:05 +0000 (14:51 -0400)]
globally remove all trailing whitespace from ardour code base.

Paul Davis was responsible for introducing almost all of this.

8 years agoattempt to stop transport, finish butler work, and close all files as part of Session...
Paul Davis [Sun, 4 Oct 2015 18:17:52 +0000 (14:17 -0400)]
attempt to stop transport, finish butler work, and close all files as part of Session > Cleanup

8 years agoNOOP: delete trailing whitespace
Paul Davis [Sun, 4 Oct 2015 16:46:27 +0000 (12:46 -0400)]
NOOP: delete trailing whitespace

8 years agoadd a hidden option to show hidden processors
Robin Gareus [Sun, 4 Oct 2015 17:39:53 +0000 (19:39 +0200)]
add a hidden option to show hidden processors

simplify debugging solo, monitor-processors, etc

8 years agonamespace fix.
Robin Gareus [Sun, 4 Oct 2015 16:43:27 +0000 (18:43 +0200)]
namespace fix.

8 years agochange wording of autosave option to be more clear
Paul Davis [Sun, 4 Oct 2015 16:25:33 +0000 (12:25 -0400)]
change wording of autosave option to be more clear

8 years agoreplace std::ifstream with g_fopen for portability
Robin Gareus [Sun, 4 Oct 2015 16:23:21 +0000 (18:23 +0200)]
replace std::ifstream with g_fopen for portability

8 years agogcc ABI check happens before unpacking
Robin Gareus [Sun, 4 Oct 2015 15:52:29 +0000 (17:52 +0200)]
gcc ABI check happens before unpacking

8 years agocorrect error message
Robin Gareus [Sun, 4 Oct 2015 13:35:14 +0000 (15:35 +0200)]
correct error message

8 years agoremove unused function
Robin Gareus [Sun, 4 Oct 2015 13:35:00 +0000 (15:35 +0200)]
remove unused function

8 years agoChange a few instances of 'stat()' to use 'g_stat()' (for UTF8 compatibility on Windows)
John Emmas [Sun, 4 Oct 2015 13:18:54 +0000 (14:18 +0100)]
Change a few instances of 'stat()' to use 'g_stat()' (for UTF8 compatibility on Windows)

8 years agoalways use session rt-event to un/set solo
Robin Gareus [Sun, 4 Oct 2015 00:03:49 +0000 (02:03 +0200)]
always use session rt-event to un/set solo

8 years agodon't export video-frame request function
Robin Gareus [Sun, 4 Oct 2015 00:02:46 +0000 (02:02 +0200)]
don't export video-frame request function

8 years agoInitialize variable every loop so MCP devices don't accumulate too.
Len Ovens [Sat, 3 Oct 2015 20:15:18 +0000 (13:15 -0700)]
Initialize variable every loop so MCP devices don't accumulate too.

8 years agoInitialize variable every loop so MCP profiles don't accumulate.
Len Ovens [Sat, 3 Oct 2015 20:06:34 +0000 (13:06 -0700)]
Initialize variable every loop so MCP profiles don't accumulate.

8 years agoNOOP: delete trailing whitespace
Paul Davis [Sat, 3 Oct 2015 18:03:29 +0000 (14:03 -0400)]
NOOP: delete trailing whitespace

8 years agoreset IP MIDI port when deleting a mackie surface port
Paul Davis [Sat, 3 Oct 2015 17:51:17 +0000 (13:51 -0400)]
reset IP MIDI port when deleting a mackie surface port

8 years agoreset shared_ptr to master surface when clearing surfaces, to ensure Surface destruct...
Paul Davis [Sat, 3 Oct 2015 17:50:59 +0000 (13:50 -0400)]
reset shared_ptr to master surface when clearing surfaces, to ensure Surface destructor is called

8 years agoMerge branch 'zamaudio-click-level'
Paul Davis [Sat, 3 Oct 2015 17:14:37 +0000 (13:14 -0400)]
Merge branch 'zamaudio-click-level'

8 years agoClick: Normalized then dropped by 6dB
Damien Zammit [Sat, 3 Oct 2015 16:02:04 +0000 (03:02 +1100)]
Click: Normalized then dropped by 6dB

Applied gain to both emph click and default click using sox.
This results in louder click sound by default and user is
able to boost click to 0dBFS using the fader on the pref pane.

Signed-off-by: Damien Zammit <damien@zamaudio.com>
8 years agomake a start on providing direct choice of MIDI ports where an MCP device can be...
Paul Davis [Sat, 3 Oct 2015 17:13:52 +0000 (13:13 -0400)]
make a start on providing direct choice of MIDI ports where an MCP device can be reached

8 years agoNOOP: reformat indentation
Paul Davis [Sat, 3 Oct 2015 16:37:13 +0000 (12:37 -0400)]
NOOP: reformat indentation

8 years agoNOOP: reformat indentation
Paul Davis [Sat, 3 Oct 2015 16:11:32 +0000 (12:11 -0400)]
NOOP: reformat indentation

8 years agomore code-control when laying out Mackie Control GUI panel
Paul Davis [Sat, 3 Oct 2015 16:11:04 +0000 (12:11 -0400)]
more code-control when laying out Mackie Control GUI panel

8 years agoadd basic support for HUI heartbeat, only used for HUI devices
Paul Davis [Sat, 3 Oct 2015 16:03:07 +0000 (12:03 -0400)]
add basic support for HUI heartbeat, only used for HUI devices

8 years agoadd DeviceType specifier for mackie devices.
Paul Davis [Sat, 3 Oct 2015 15:39:36 +0000 (11:39 -0400)]
add DeviceType specifier for mackie devices.

Incomplete, because we need a way to handle multiple devices of different types

8 years agoNOOP: reformat indentation
Paul Davis [Sat, 3 Oct 2015 15:31:46 +0000 (11:31 -0400)]
NOOP: reformat indentation

8 years agoadd device type to Mackie device info
Paul Davis [Sat, 3 Oct 2015 15:31:17 +0000 (11:31 -0400)]
add device type to Mackie device info

8 years agoadd support to display and set key aliases in mackie GUI
Paul Davis [Sat, 3 Oct 2015 15:08:47 +0000 (11:08 -0400)]
add support to display and set key aliases in mackie GUI

8 years agoadditional check for DSP falloff.
Robin Gareus [Sat, 3 Oct 2015 15:46:55 +0000 (17:46 +0200)]
additional check for DSP falloff.

8 years agoless verbose unit-tests
Robin Gareus [Sat, 3 Oct 2015 15:46:39 +0000 (17:46 +0200)]
less verbose unit-tests

8 years agoDSP load fall-off from 100%.
Robin Gareus [Sat, 3 Oct 2015 15:46:19 +0000 (17:46 +0200)]
DSP load fall-off from 100%.

get_dsp_load_unbound() will return large values >100% for testing,
but actual fall-off is from 100%.

8 years agofix float calc:
Robin Gareus [Sat, 3 Oct 2015 15:44:56 +0000 (17:44 +0200)]
fix float calc:

divide large number. not multiply a small.

8 years agofix windows compilation
Robin Gareus [Sat, 3 Oct 2015 09:20:15 +0000 (11:20 +0200)]
fix windows compilation

8 years agoinitial pass at a profile (key bindings) for MCU Pro surface.
Paul Davis [Sat, 3 Oct 2015 02:10:28 +0000 (22:10 -0400)]
initial pass at a profile (key bindings) for MCU Pro surface.

Lots more work to do here

8 years agoremove undefined and unused method declaration
Paul Davis [Sat, 3 Oct 2015 02:08:05 +0000 (22:08 -0400)]
remove undefined and unused method declaration

8 years agoanother change from modifier_state() to main_modifier_state()
Paul Davis [Sat, 3 Oct 2015 02:07:49 +0000 (22:07 -0400)]
another change from modifier_state() to main_modifier_state()

8 years agoavoid handling pitchbend (fader) messages while SHIFT modifier is active.
Paul Davis [Sat, 3 Oct 2015 02:07:24 +0000 (22:07 -0400)]
avoid handling pitchbend (fader) messages while SHIFT modifier is active.

See comment in code for more detail

8 years agono longer call ::zero_all() when deleting an MCP surface object.
Paul Davis [Sat, 3 Oct 2015 02:06:24 +0000 (22:06 -0400)]
no longer call ::zero_all() when deleting an MCP surface object.

The ports required may no longer exist, and it requires a lot of messages. A reset is sent instead

8 years agouse ::main_modifier_state() in some more places
Paul Davis [Sat, 3 Oct 2015 02:06:02 +0000 (22:06 -0400)]
use ::main_modifier_state() in some more places

8 years agonecessary header changes for new redisplay code in MCP
Paul Davis [Sat, 3 Oct 2015 02:04:02 +0000 (22:04 -0400)]
necessary header changes for new redisplay code in MCP

8 years agoadd new (fast) redisplay timer that pushes parameter display text to MCP device.
Paul Davis [Sat, 3 Oct 2015 02:03:17 +0000 (22:03 -0400)]
add new (fast) redisplay timer that pushes parameter display text to MCP device.

Changes are queued in a FIFO, and pulled when a timeout in the MCP event loop fires.

8 years agofix comment spelling
Paul Davis [Sat, 3 Oct 2015 01:59:05 +0000 (21:59 -0400)]
fix comment spelling

8 years agouse Surface::reset() when deleting MackieControlProtocol, rather than sending lots...
Paul Davis [Sat, 3 Oct 2015 01:57:12 +0000 (21:57 -0400)]
use Surface::reset() when deleting MackieControlProtocol, rather than sending lots of messages.

This may be a bit "strong" because on the MCU Pro (at least) it causes a fader recalibration.

8 years agoimplement backlight, fader touch sensitivity and recalibrate fader functions for...
Paul Davis [Sat, 3 Oct 2015 01:54:40 +0000 (21:54 -0400)]
implement backlight, fader touch sensitivity and recalibrate fader functions for MCP GUI

8 years agoavoid sending replicated fader set position messages
Paul Davis [Fri, 2 Oct 2015 23:24:04 +0000 (19:24 -0400)]
avoid sending replicated fader set position messages

8 years agoexplicitly drop control surface protocols before disconnecting from engine.
Paul Davis [Fri, 2 Oct 2015 23:22:16 +0000 (19:22 -0400)]
explicitly drop control surface protocols before disconnecting from engine.

This is not bomb/thread proof yet, because it still requires at least one process callback to function

8 years agoadd missing "fi" to stage2.run script used for linux install
Paul Davis [Fri, 2 Oct 2015 23:19:21 +0000 (19:19 -0400)]
add missing "fi" to stage2.run script used for linux install

8 years agoremove debug output
Paul Davis [Fri, 2 Oct 2015 20:31:30 +0000 (16:31 -0400)]
remove debug output

8 years agothe return of the 1 second fade out at session close
Paul Davis [Fri, 2 Oct 2015 20:29:58 +0000 (16:29 -0400)]
the return of the 1 second fade out at session close

8 years agofix unbound DSP calc.
Robin Gareus [Fri, 2 Oct 2015 20:28:03 +0000 (22:28 +0200)]
fix unbound DSP calc.

8 years agoescape markup in region list
Robin Gareus [Fri, 2 Oct 2015 17:38:32 +0000 (19:38 +0200)]
escape markup in region list

8 years agoadd missing markup escape
Robin Gareus [Fri, 2 Oct 2015 17:14:24 +0000 (19:14 +0200)]
add missing markup escape

(e.g. import file with ampersand)

8 years agouse new error-messages
Robin Gareus [Fri, 2 Oct 2015 15:51:17 +0000 (17:51 +0200)]
use new error-messages

8 years agodefine more backend error-messages.
Robin Gareus [Fri, 2 Oct 2015 15:49:31 +0000 (17:49 +0200)]
define more backend error-messages.

8 years agoimprove CoreAudio error reporting
Robin Gareus [Fri, 2 Oct 2015 15:28:16 +0000 (17:28 +0200)]
improve CoreAudio error reporting

8 years agofix handler of fader (pitchbend) messages in Mackie Control so that the outbound...
Paul Davis [Fri, 2 Oct 2015 14:22:00 +0000 (10:22 -0400)]
fix handler of fader (pitchbend) messages in Mackie Control so that the outbound messages match the inbound ones

Pitch bend values really can span 0 to 16384, not 16383

8 years agoallow aliasing Mackie Control buttons to other buttons
Paul Davis [Fri, 2 Oct 2015 14:21:20 +0000 (10:21 -0400)]
allow aliasing Mackie Control buttons to other buttons

8 years agoprovide Main/cancel-solo as an action and make rude solo button(s) use it
Paul Davis [Fri, 2 Oct 2015 11:32:49 +0000 (07:32 -0400)]
provide Main/cancel-solo as an action and make rude solo button(s) use it

8 years agocatch changes in click status and alter LED appropriately
Paul Davis [Fri, 2 Oct 2015 11:31:48 +0000 (07:31 -0400)]
catch changes in click status and alter LED appropriately

8 years agochange zoom and scrub handling to use modifier bits
Paul Davis [Fri, 2 Oct 2015 11:31:31 +0000 (07:31 -0400)]
change zoom and scrub handling to use modifier bits

8 years agospelling correction in error message
Paul Davis [Fri, 2 Oct 2015 11:29:51 +0000 (07:29 -0400)]
spelling correction in error message

8 years agoadd a proper license to the GCC ABI check tool
Robin Gareus [Fri, 2 Oct 2015 11:17:45 +0000 (13:17 +0200)]
add a proper license to the GCC ABI check tool

8 years agore-apply roll-delay after seek - fixes #5781
Robin Gareus [Thu, 1 Oct 2015 21:17:01 +0000 (23:17 +0200)]
re-apply roll-delay after seek - fixes #5781

8 years agoremove ancient doxyfile
Robin Gareus [Thu, 1 Oct 2015 19:58:00 +0000 (21:58 +0200)]
remove ancient doxyfile

8 years agoupdate Doxyfile
Robin Gareus [Thu, 1 Oct 2015 19:57:27 +0000 (21:57 +0200)]
update Doxyfile

8 years agothere's no class called "The" :)
Robin Gareus [Thu, 1 Oct 2015 19:39:15 +0000 (21:39 +0200)]
there's no class called "The" :)

8 years agoALSA: update error-codes for HW initialization.
Robin Gareus [Thu, 1 Oct 2015 10:42:05 +0000 (12:42 +0200)]
ALSA: update error-codes for HW initialization.

8 years agoAdd parent window argument to ARDOUR_UI::check_audioengine
Tim Mayberry [Sun, 27 Sep 2015 03:15:32 +0000 (13:15 +1000)]
Add parent window argument to ARDOUR_UI::check_audioengine

Ensures relevant placement of the dialog when presented

8 years agoDisplay warning when closing Audio Setup dialog with engine stopped
Tim Mayberry [Sat, 26 Sep 2015 10:43:47 +0000 (20:43 +1000)]
Display warning when closing Audio Setup dialog with engine stopped

Only show warning when a session is loaded

8 years agoDon't hide Audio Setup dialog when clicking 'OK' if engine fails to start
Tim Mayberry [Sat, 26 Sep 2015 10:22:46 +0000 (20:22 +1000)]
Don't hide Audio Setup dialog when clicking 'OK' if engine fails to start

This has to be handled in two places, in ARDOUR_UI::do_audio_midi_setup and in
the dialogs response handler and in as the window can also be triggered via the
window action manager.

8 years agoUse AudioSetupDialog as parent of the error message popup when failing to start engine
Tim Mayberry [Sat, 26 Sep 2015 07:49:16 +0000 (17:49 +1000)]
Use AudioSetupDialog as parent of the error message popup when failing to start engine

Without a session loaded this makes the message dialog appear in front of the
AudioSetup dialog instead of randomly up in the top left somewhere. This does
mean though that if the AudioSetup dialog is not visible the error message
popup will appear randomly up in the top left(at least on windows, it seems
fine on linux) but I will fix that shortly.

8 years agoReturn meaningful error codes when ALSA backend fails to start
Tim Mayberry [Sat, 26 Sep 2015 11:03:02 +0000 (21:03 +1000)]
Return meaningful error codes when ALSA backend fails to start

Unfortunately it seems that in zita-alsa-pcmi doesn't set state() correctly in
some cases. Setting an invalid SR doesn't display the correct error message,
first guess would be that set_hwpar is failing and state() is not
representative of the actual error.

8 years agoReturn meaningful error codes when PortaudioBackend fails to start
Tim Mayberry [Sat, 26 Sep 2015 22:53:19 +0000 (08:53 +1000)]
Return meaningful error codes when PortaudioBackend fails to start

So they can be used to give a contextual error message in the GUI

8 years agoUse portaudio error codes in the PortaudioIO class.
Tim Mayberry [Sat, 26 Sep 2015 10:49:41 +0000 (20:49 +1000)]
Use portaudio error codes in the PortaudioIO class.

Having error codes defined in PortaudioIO means it is not dependent on the
ErrorCodes in AudioBackend but it doesn't really make sense to have another
set, so just use the PA ones until they become insufficient.

8 years agoUse AudioEngine::get_last_backend_error in message dialog when failing to start engine
Tim Mayberry [Sat, 26 Sep 2015 07:27:04 +0000 (17:27 +1000)]
Use AudioEngine::get_last_backend_error in message dialog when failing to start engine

If a backend is not returning AudioBackend::ErrorCode values to indicate the
type of error then the default string will be returned which is the same as
what was previously displayed.

8 years agoReinterpret the return value of AudioBackend::start as AudioBackend::ErrorCode
Tim Mayberry [Sat, 26 Sep 2015 07:14:43 +0000 (17:14 +1000)]
Reinterpret the return value of AudioBackend::start as AudioBackend::ErrorCode

This will allow backends to return a more meaningful error message. Eventually
an error code could be returned by AudioEngine::start and the GUI can then use
AudioBackend::get_error_string to convert the error into a translated error
message directly, or it may be desirable to define its own error messages.

The reasons for not doing that right now is that this is a workable solution
with the least change required.

8 years agoAdd a couple of error codes to AudioBackend::ErrorCode
Tim Mayberry [Sat, 26 Sep 2015 07:02:37 +0000 (17:02 +1000)]
Add a couple of error codes to AudioBackend::ErrorCode

Also use the error message from ARDOUR_UI::reconnect_to_engine as the default
error string

8 years agoGray out "strip silence" and "rhtyhm ferret" for midi regions.
André Nusser [Wed, 30 Sep 2015 21:20:27 +0000 (23:20 +0200)]
Gray out "strip silence" and "rhtyhm ferret" for midi regions.

The former even triggered a segfault.

8 years agoMerge branch 'chaot4-fix_track_list_context_menu'
Paul Davis [Wed, 30 Sep 2015 18:43:13 +0000 (14:43 -0400)]
Merge branch 'chaot4-fix_track_list_context_menu'

8 years agoFixed spelling.
André Nusser [Mon, 28 Sep 2015 21:48:07 +0000 (23:48 +0200)]
Fixed spelling.

8 years agoMake all the context menu entries of the track list work.
André Nusser [Mon, 28 Sep 2015 20:14:04 +0000 (22:14 +0200)]
Make all the context menu entries of the track list work.

8 years agochange the logic for a capture buffer flush to disk when a locate is occuring
Paul Davis [Wed, 30 Sep 2015 17:02:50 +0000 (13:02 -0400)]
change the logic for a capture buffer flush to disk when a locate is occuring

We can't check for Session::actively_recording() because punch out may have disabled that. Rather
than add logic to check if a flush is needed (which is not much different than the code that runs
as part of the flush to disk), just do a flush anyway.

8 years agotweak some debug output
Paul Davis [Wed, 30 Sep 2015 17:00:55 +0000 (13:00 -0400)]
tweak some debug output

8 years agoremove apparently bogus adjustment to capture_captured in AudioDiskstream::transport_...
Paul Davis [Wed, 30 Sep 2015 16:59:58 +0000 (12:59 -0400)]
remove apparently bogus adjustment to capture_captured in AudioDiskstream::transport_looped

8 years agosplit Butler::flush_tracks_to_disk() into two distinct versions with clear names...
Paul Davis [Wed, 30 Sep 2015 16:58:36 +0000 (12:58 -0400)]
split Butler::flush_tracks_to_disk() into two distinct versions with clear names and make one of them private

8 years agois there a better way to make gcc+enumwriter happy?
Robin Gareus [Tue, 29 Sep 2015 13:50:43 +0000 (15:50 +0200)]
is there a better way to make gcc+enumwriter happy?

8 years agoFix midi tracer to show MSB too. (fixes #6566)
Len Ovens [Tue, 29 Sep 2015 13:06:40 +0000 (06:06 -0700)]
Fix midi tracer to show MSB too. (fixes #6566)

8 years agoset waveform height depending on Layer mode
Robin Gareus [Tue, 29 Sep 2015 07:34:29 +0000 (09:34 +0200)]
set waveform height depending on Layer mode

Fixes background peakfile/waveform creation. Waves need to be
created directly with the proper attributes as set by StreamView.

8 years agoFix Mackie control metering (fixes #6608).
Len Ovens [Tue, 29 Sep 2015 03:13:15 +0000 (20:13 -0700)]
Fix Mackie control metering (fixes #6608).

8 years agoRevert "change the way the audio clock cursor is drawn (somewhat of an experiment...
Paul Davis [Tue, 29 Sep 2015 00:15:03 +0000 (20:15 -0400)]
Revert "change the way the audio clock cursor is drawn (somewhat of an experiment but it has some benefits"

This reverts commit 601770837e2530a73056a6aa67759d56e16e735a.

This work continued in the "clockwork" branch where it was done correctly.

8 years agoBWF USID according to EBU-R99
Robin Gareus [Mon, 28 Sep 2015 23:20:09 +0000 (01:20 +0200)]
BWF USID according to EBU-R99

8 years agochange clearlooks style file so that small_entry and related styles use text color...
Paul Davis [Mon, 28 Sep 2015 22:20:54 +0000 (18:20 -0400)]
change clearlooks style file so that small_entry and related styles use text color for text even when selected

8 years agoMerge branch 'chaot4-fix_lock_solo_ctrl_shift'
Paul Davis [Mon, 28 Sep 2015 21:59:10 +0000 (17:59 -0400)]
Merge branch 'chaot4-fix_lock_solo_ctrl_shift'

8 years agoIntroduce Ctrl+Shift+Click on lock solo in the mixer.
André Nusser [Mon, 28 Sep 2015 16:38:33 +0000 (18:38 +0200)]
Introduce Ctrl+Shift+Click on lock solo in the mixer.

8 years agofix initialization of reserved I/O names vector
Paul Davis [Mon, 28 Sep 2015 21:52:27 +0000 (17:52 -0400)]
fix initialization of reserved I/O names vector

8 years agofix const-ness
Paul Davis [Mon, 28 Sep 2015 21:52:13 +0000 (17:52 -0400)]
fix const-ness