From 5691abdf031b8958649f3d6da665be15becdaec8 Mon Sep 17 00:00:00 2001 From: "Julien \"_FrnchFrgg_\" RIVAUD" Date: Thu, 4 Aug 2016 10:11:21 +0200 Subject: [PATCH] Remove ad-hoc handling of possible_out == 0 Just refuse configurations without any output at all, and let the remaining logic take care of selecting configurations with no audio output if they make sense and there are no better configurations. POLICY CHANGE: configurations with no output might now be considered even if they have audio inputs (e.g. a pure pitch detector without audio passthrough), whereas they were skipped before. --- libs/ardour/luaproc.cc | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/libs/ardour/luaproc.cc b/libs/ardour/luaproc.cc index 09be770b0a..35e39fe4eb 100644 --- a/libs/ardour/luaproc.cc +++ b/libs/ardour/luaproc.cc @@ -445,19 +445,8 @@ LuaProc::can_support_io_configuration (const ChanCount& in, ChanCount& out, Chan FOUNDCFG_PENALTY(audio_in, preferred_out, -1); } - // "imprecise" matches - if (possible_out == 0) { - /* skip configurations with no audio output, unless - * the plugin is a midi filter or generator */ - if (possible_in == 0 && _has_midi_output) { - if (audio_in == 0) { - FOUNDCFG(possible_out); - break; - } else if (imprecise) { - // TODO hide audio input from plugin - FOUNDCFG_IMPRECISE (possible_in, possible_out); - } - } + if (possible_out == 0 && possible_midiout == 0) { + /* skip configurations with no output at all */ continue; } -- 2.30.2