From 6d5878a92614304711fb77b0c863d68cb2d44d21 Mon Sep 17 00:00:00 2001 From: Paul Davis Date: Fri, 23 Sep 2016 13:57:29 -0500 Subject: [PATCH] leave a comment about port reconnection --- libs/surfaces/push2/push2.cc | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/libs/surfaces/push2/push2.cc b/libs/surfaces/push2/push2.cc index a9498ee383..ec234be712 100644 --- a/libs/surfaces/push2/push2.cc +++ b/libs/surfaces/push2/push2.cc @@ -1537,6 +1537,14 @@ Push2::stripable_selection_change (StripableNotificationListPtr selected) /* disconnect from pad port, if appropriate */ if (current_midi_track && pad_port) { + + /* XXX this could possibly leave dangling MIDI notes. + * + * A general libardour fix is required. It isn't obvious + * how note resolution can be done unless disconnecting + * becomes "slow" (i.e. deferred for as long as it takes + * to resolve notes). + */ current_midi_track->input()->disconnect (current_midi_track->input()->nth(0), pad_port->name(), this); } -- 2.30.2