Fix typo if -> of (thanks to Uwe Dittes)
[dcpomatic.git] / src / lib / dcp_content.cc
index 6c2db91d3bbcbb093f89a8fabba5bc4a65023d56..fa6ec383f8ccae10bde9e6990dda77345948fc5c 100644 (file)
@@ -18,6 +18,7 @@
 
 */
 
+#include "atmos_content.h"
 #include "dcp_content.h"
 #include "video_content.h"
 #include "audio_content.h"
 #include <dcp/dcp.h>
 #include <dcp/raw_convert.h>
 #include <dcp/exceptions.h>
+#include <dcp/reel_closed_caption_asset.h>
 #include <dcp/reel_picture_asset.h>
+#include <dcp/reel_subtitle_asset.h>
 #include <dcp/reel.h>
 #include <libxml++/libxml++.h>
-#include <boost/foreach.hpp>
 #include <iterator>
 #include <iostream>
 
 #include "i18n.h"
 
-using std::string;
 using std::cout;
 using std::distance;
-using std::pair;
-using std::vector;
 using std::list;
+using std::make_shared;
 using std::map;
-using boost::shared_ptr;
+using std::pair;
+using std::shared_ptr;
+using std::string;
+using std::vector;
 using boost::scoped_ptr;
 using boost::optional;
-using boost::function;
-using boost::dynamic_pointer_cast;
+using std::function;
+using std::dynamic_pointer_cast;
+#if BOOST_VERSION >= 106100
+using namespace boost::placeholders;
+#endif
 using dcp::raw_convert;
 using namespace dcpomatic;
 
@@ -80,7 +86,7 @@ DCPContent::DCPContent (boost::filesystem::path p)
        read_directory (p);
        set_default_colour_conversion ();
 
-       for (int i = 0; i < TEXT_COUNT; ++i) {
+       for (int i = 0; i < static_cast<int>(TextType::COUNT); ++i) {
                _reference_text[i] = false;
        }
 }
@@ -91,22 +97,21 @@ DCPContent::DCPContent (cxml::ConstNodePtr node, int version)
        video = VideoContent::from_xml (this, node, version);
        audio = AudioContent::from_xml (this, node, version);
        text = TextContent::from_xml (this, node, version);
+       atmos = AtmosContent::from_xml (this, node);
 
-       for (int i = 0; i < TEXT_COUNT; ++i) {
+       for (int i = 0; i < static_cast<int>(TextType::COUNT); ++i) {
                _reference_text[i] = false;
        }
 
        if (video && audio) {
                audio->set_stream (
-                       AudioStreamPtr (
-                               new AudioStream (
-                                       node->number_child<int> ("AudioFrameRate"),
-                                       /* AudioLength was not present in some old metadata versions */
-                                       node->optional_number_child<Frame>("AudioLength").get_value_or (
-                                               video->length() * node->number_child<int>("AudioFrameRate") / video_frame_rate().get()
-                                               ),
-                                       AudioMapping (node->node_child ("AudioMapping"), version)
-                                       )
+                       make_shared<AudioStream> (
+                               node->number_child<int> ("AudioFrameRate"),
+                               /* AudioLength was not present in some old metadata versions */
+                               node->optional_number_child<Frame>("AudioLength").get_value_or (
+                                       video->length() * node->number_child<int>("AudioFrameRate") / video_frame_rate().get()
+                                       ),
+                               AudioMapping (node->node_child ("AudioMapping"), version)
                                )
                        );
        }
@@ -121,66 +126,84 @@ DCPContent::DCPContent (cxml::ConstNodePtr node, int version)
        _reference_video = node->optional_bool_child ("ReferenceVideo").get_value_or (false);
        _reference_audio = node->optional_bool_child ("ReferenceAudio").get_value_or (false);
        if (version >= 37) {
-               _reference_text[TEXT_OPEN_SUBTITLE] = node->optional_bool_child("ReferenceOpenSubtitle").get_value_or(false);
-               _reference_text[TEXT_CLOSED_CAPTION] = node->optional_bool_child("ReferenceClosedCaption").get_value_or(false);
+               _reference_text[static_cast<int>(TextType::OPEN_SUBTITLE)] = node->optional_bool_child("ReferenceOpenSubtitle").get_value_or(false);
+               _reference_text[static_cast<int>(TextType::CLOSED_CAPTION)] = node->optional_bool_child("ReferenceClosedCaption").get_value_or(false);
        } else {
-               _reference_text[TEXT_OPEN_SUBTITLE] = node->optional_bool_child("ReferenceSubtitle").get_value_or(false);
-               _reference_text[TEXT_CLOSED_CAPTION] = false;
+               _reference_text[static_cast<int>(TextType::OPEN_SUBTITLE)] = node->optional_bool_child("ReferenceSubtitle").get_value_or(false);
+               _reference_text[static_cast<int>(TextType::CLOSED_CAPTION)] = false;
        }
        if (node->optional_string_child("Standard")) {
-               string const s = node->optional_string_child("Standard").get();
+               auto const s = node->optional_string_child("Standard").get();
                if (s == "Interop") {
-                       _standard = dcp::INTEROP;
+                       _standard = dcp::Standard::INTEROP;
                } else if (s == "SMPTE") {
-                       _standard = dcp::SMPTE;
+                       _standard = dcp::Standard::SMPTE;
                } else {
                        DCPOMATIC_ASSERT (false);
                }
        }
        _three_d = node->optional_bool_child("ThreeD").get_value_or (false);
 
-       optional<string> ck = node->optional_string_child("ContentKind");
+       auto ck = node->optional_string_child("ContentKind");
        if (ck) {
                _content_kind = dcp::content_kind_from_string (*ck);
        }
        _cpl = node->optional_string_child("CPL");
-       BOOST_FOREACH (cxml::ConstNodePtr i, node->node_children("ReelLength")) {
+       for (auto i: node->node_children("ReelLength")) {
                _reel_lengths.push_back (raw_convert<int64_t> (i->content ()));
        }
 
-       BOOST_FOREACH (cxml::ConstNodePtr i, node->node_children("Marker")) {
+       for (auto i: node->node_children("Marker")) {
                _markers[dcp::marker_from_string(i->string_attribute("type"))] = ContentTime(raw_convert<int64_t>(i->content()));
        }
+
+       for (auto i: node->node_children("Rating")) {
+               _ratings.push_back (dcp::Rating(i));
+       }
+
+       for (auto i: node->node_children("ContentVersion")) {
+               _content_versions.push_back (i->content());
+       }
 }
 
 void
 DCPContent::read_directory (boost::filesystem::path p)
 {
-       read_sub_directory (p);
+       using namespace boost::filesystem;
 
        bool have_assetmap = false;
-       BOOST_FOREACH (boost::filesystem::path i, paths()) {
-               if (i.filename() == "ASSETMAP" || i.filename() == "ASSETMAP.xml") {
+       bool have_metadata = false;
+
+       for (directory_iterator i(p); i != directory_iterator(); ++i) {
+               if (i->path().filename() == "ASSETMAP" || i->path().filename() == "ASSETMAP.xml") {
                        have_assetmap = true;
+               } else if (i->path().filename() == "metadata.xml") {
+                       have_metadata = true;
                }
        }
 
        if (!have_assetmap) {
-               throw DCPError ("No ASSETMAP or ASSETMAP.xml file found: is this a DCP?");
+               if (!have_metadata) {
+                       throw DCPError ("No ASSETMAP or ASSETMAP.xml file found: is this a DCP?");
+               } else {
+                       throw ProjectFolderError ();
+               }
        }
+
+       read_sub_directory (p);
 }
 
 void
 DCPContent::read_sub_directory (boost::filesystem::path p)
 {
        LOG_GENERAL ("DCPContent::read_sub_directory reads %1", p.string());
-       for (boost::filesystem::directory_iterator i(p); i != boost::filesystem::directory_iterator(); ++i) {
-               if (boost::filesystem::is_regular_file (i->path())) {
-                       LOG_GENERAL ("Inside there's regular file %1", i->path().string());
-                       add_path (i->path());
-               } else if (boost::filesystem::is_directory (i->path ())) {
-                       LOG_GENERAL ("Inside there's directory %1", i->path().string());
-                       read_sub_directory (i->path());
+       for (auto i: boost::filesystem::directory_iterator(p)) {
+               if (boost::filesystem::is_regular_file(i.path())) {
+                       LOG_GENERAL ("Inside there's regular file %1", i.path().string());
+                       add_path (i.path());
+               } else if (boost::filesystem::is_directory (i.path())) {
+                       LOG_GENERAL ("Inside there's directory %1", i.path().string());
+                       read_sub_directory (i.path());
                }
        }
 }
@@ -192,24 +215,23 @@ DCPContent::examine (shared_ptr<const Film> film, shared_ptr<Job> job)
        bool const needed_assets = needs_assets ();
        bool const needed_kdm = needs_kdm ();
        string const old_name = name ();
-       int const old_texts = text.size ();
 
-       ChangeSignaller<Content> cc_texts (this, DCPContentProperty::TEXTS);
-       ChangeSignaller<Content> cc_assets (this, DCPContentProperty::NEEDS_ASSETS);
-       ChangeSignaller<Content> cc_kdm (this, DCPContentProperty::NEEDS_KDM);
-       ChangeSignaller<Content> cc_name (this, DCPContentProperty::NAME);
+       ContentChangeSignaller cc_texts (this, DCPContentProperty::TEXTS);
+       ContentChangeSignaller cc_assets (this, DCPContentProperty::NEEDS_ASSETS);
+       ContentChangeSignaller cc_kdm (this, DCPContentProperty::NEEDS_KDM);
+       ContentChangeSignaller cc_name (this, DCPContentProperty::NAME);
 
        if (job) {
                job->set_progress_unknown ();
        }
        Content::examine (film, job);
 
-       shared_ptr<DCPExaminer> examiner (new DCPExaminer(shared_from_this(), film ? film->tolerant() : true));
+       auto examiner = make_shared<DCPExaminer>(shared_from_this(), film ? film->tolerant() : true);
 
        if (examiner->has_video()) {
                {
                        boost::mutex::scoped_lock lm (_mutex);
-                       video.reset (new VideoContent (this));
+                       video = make_shared<VideoContent>(this);
                }
                video->take_from_examiner (examiner);
                set_default_colour_conversion ();
@@ -218,25 +240,45 @@ DCPContent::examine (shared_ptr<const Film> film, shared_ptr<Job> job)
        if (examiner->has_audio()) {
                {
                        boost::mutex::scoped_lock lm (_mutex);
-                       audio.reset (new AudioContent (this));
+                       audio = make_shared<AudioContent>(this);
                }
-               AudioStreamPtr as (new AudioStream (examiner->audio_frame_rate(), examiner->audio_length(), examiner->audio_channels()));
+               auto as = make_shared<AudioStream>(examiner->audio_frame_rate(), examiner->audio_length(), examiner->audio_channels());
                audio->set_stream (as);
-               AudioMapping m = as->mapping ();
+               auto m = as->mapping ();
                m.make_default (film ? film->audio_processor() : 0);
                as->set_mapping (m);
        }
 
-       int texts = 0;
+       if (examiner->has_atmos()) {
+               {
+                       boost::mutex::scoped_lock lm (_mutex);
+                       atmos = make_shared<AtmosContent>(this);
+               }
+               /* Setting length will cause calculations to be made based on edit rate, so that must
+                * be set up first otherwise hard-to-spot exceptions will be thrown.
+                */
+               atmos->set_edit_rate (examiner->atmos_edit_rate());
+               atmos->set_length (examiner->atmos_length());
+       }
+
+       list<shared_ptr<TextContent>> new_text;
+
+       for (int i = 0; i < examiner->text_count(TextType::OPEN_SUBTITLE); ++i) {
+               auto c = make_shared<TextContent>(this, TextType::OPEN_SUBTITLE, TextType::OPEN_SUBTITLE);
+               c->set_language (examiner->open_subtitle_language());
+               new_text.push_back (c);
+       }
+
+       for (int i = 0; i < examiner->text_count(TextType::CLOSED_CAPTION); ++i) {
+               auto c = make_shared<TextContent>(this, TextType::CLOSED_CAPTION, TextType::CLOSED_CAPTION);
+               c->set_dcp_track (examiner->dcp_text_track(i));
+               new_text.push_back (c);
+       }
+
        {
                boost::mutex::scoped_lock lm (_mutex);
+               text = new_text;
                _name = examiner->name ();
-               for (int i = 0; i < TEXT_COUNT; ++i) {
-                       for (int j = 0; j < examiner->text_count(static_cast<TextType>(i)); ++j) {
-                               text.push_back (shared_ptr<TextContent>(new TextContent(this, static_cast<TextType>(i), static_cast<TextType>(i))));
-                       }
-               }
-               texts = text.size ();
                _encrypted = examiner->encrypted ();
                _needs_assets = examiner->needs_assets ();
                _kdm_valid = examiner->kdm_valid ();
@@ -245,14 +287,11 @@ DCPContent::examine (shared_ptr<const Film> film, shared_ptr<Job> job)
                _content_kind = examiner->content_kind ();
                _cpl = examiner->cpl ();
                _reel_lengths = examiner->reel_lengths ();
-               map<dcp::Marker, dcp::Time> markers = examiner->markers();
-               for (map<dcp::Marker, dcp::Time>::const_iterator i = markers.begin(); i != markers.end(); ++i) {
-                       _markers[i->first] = ContentTime(i->second.as_editable_units(DCPTime::HZ));
+               for (auto const& i: examiner->markers()) {
+                       _markers[i.first] = ContentTime(i.second.as_editable_units_ceil(DCPTime::HZ));
                }
-       }
-
-       if (old_texts == texts) {
-               cc_texts.abort ();
+               _ratings = examiner->ratings ();
+               _content_versions = examiner->content_versions ();
        }
 
        if (needed_assets == needs_assets()) {
@@ -268,7 +307,7 @@ DCPContent::examine (shared_ptr<const Film> film, shared_ptr<Job> job)
        }
 
        if (video) {
-               video->set_frame_type (_three_d ? VIDEO_FRAME_TYPE_3D : VIDEO_FRAME_TYPE_2D);
+               video->set_frame_type (_three_d ? VideoFrameType::THREE_D : VideoFrameType::TWO_D);
        }
 }
 
@@ -310,10 +349,14 @@ DCPContent::as_xml (xmlpp::Node* node, bool with_paths) const
                audio->stream()->mapping().as_xml (node->add_child("AudioMapping"));
        }
 
-       BOOST_FOREACH (shared_ptr<TextContent> i, text) {
+       for (auto i: text) {
                i->as_xml (node);
        }
 
+       if (atmos) {
+               atmos->as_xml (node);
+       }
+
        boost::mutex::scoped_lock lm (_mutex);
        node->add_child("Name")->add_child_text (_name);
        node->add_child("Encrypted")->add_child_text (_encrypted ? "1" : "0");
@@ -324,14 +367,14 @@ DCPContent::as_xml (xmlpp::Node* node, bool with_paths) const
        node->add_child("KDMValid")->add_child_text (_kdm_valid ? "1" : "0");
        node->add_child("ReferenceVideo")->add_child_text (_reference_video ? "1" : "0");
        node->add_child("ReferenceAudio")->add_child_text (_reference_audio ? "1" : "0");
-       node->add_child("ReferenceOpenSubtitle")->add_child_text(_reference_text[TEXT_OPEN_SUBTITLE] ? "1" : "0");
-       node->add_child("ReferenceClosedCaption")->add_child_text(_reference_text[TEXT_CLOSED_CAPTION] ? "1" : "0");
+       node->add_child("ReferenceOpenSubtitle")->add_child_text(_reference_text[static_cast<int>(TextType::OPEN_SUBTITLE)] ? "1" : "0");
+       node->add_child("ReferenceClosedCaption")->add_child_text(_reference_text[static_cast<int>(TextType::CLOSED_CAPTION)] ? "1" : "0");
        if (_standard) {
                switch (_standard.get ()) {
-               case dcp::INTEROP:
+               case dcp::Standard::INTEROP:
                        node->add_child("Standard")->add_child_text ("Interop");
                        break;
-               case dcp::SMPTE:
+               case dcp::Standard::SMPTE:
                        node->add_child("Standard")->add_child_text ("SMPTE");
                        break;
                default:
@@ -345,14 +388,23 @@ DCPContent::as_xml (xmlpp::Node* node, bool with_paths) const
        if (_cpl) {
                node->add_child("CPL")->add_child_text (_cpl.get ());
        }
-       BOOST_FOREACH (int64_t i, _reel_lengths) {
+       for (auto i: _reel_lengths) {
                node->add_child("ReelLength")->add_child_text (raw_convert<string> (i));
        }
 
-       for (map<dcp::Marker, ContentTime>::const_iterator i = _markers.begin(); i != _markers.end(); ++i) {
-               xmlpp::Element* marker = node->add_child("Marker");
-               marker->set_attribute("type", dcp::marker_to_string(i->first));
-               marker->add_child_text(raw_convert<string>(i->second.get()));
+       for (auto const& i: _markers) {
+               auto marker = node->add_child("Marker");
+               marker->set_attribute("type", dcp::marker_to_string(i.first));
+               marker->add_child_text(raw_convert<string>(i.second.get()));
+       }
+
+       for (auto i: _ratings) {
+               auto rating = node->add_child("Rating");
+               i.as_xml (rating);
+       }
+
+       for (auto i: _content_versions) {
+               node->add_child("ContentVersion")->add_child_text(i);
        }
 }
 
@@ -360,7 +412,7 @@ DCPTime
 DCPContent::full_length (shared_ptr<const Film> film) const
 {
        if (!video) {
-               return DCPTime();
+               return {};
        }
        FrameRateChange const frc (film, shared_from_this());
        return DCPTime::from_frames (llrint(video->length() * frc.factor()), film->video_frame_rate());
@@ -370,7 +422,7 @@ DCPTime
 DCPContent::approximate_length () const
 {
        if (!video) {
-               return DCPTime();
+               return {};
        }
        return DCPTime::from_frames (video->length(), 24);
 }
@@ -384,12 +436,12 @@ DCPContent::identifier () const
                s += video->identifier() + "_";
        }
 
-       BOOST_FOREACH (shared_ptr<TextContent> i, text) {
+       for (auto i: text) {
                s += i->identifier () + " ";
        }
 
        s += string (_reference_video ? "1" : "0");
-       for (int i = 0; i < TEXT_COUNT; ++i) {
+       for (int i = 0; i < static_cast<int>(TextType::COUNT); ++i) {
                s += string (_reference_text[i] ? "1" : "0");
        }
        return s;
@@ -457,7 +509,7 @@ DCPContent::set_default_colour_conversion ()
 void
 DCPContent::set_reference_video (bool r)
 {
-       ChangeSignaller<Content> cc (this, DCPContentProperty::REFERENCE_VIDEO);
+       ContentChangeSignaller cc (this, DCPContentProperty::REFERENCE_VIDEO);
 
        {
                boost::mutex::scoped_lock lm (_mutex);
@@ -468,7 +520,7 @@ DCPContent::set_reference_video (bool r)
 void
 DCPContent::set_reference_audio (bool r)
 {
-       ChangeSignaller<Content> cc (this, DCPContentProperty::REFERENCE_AUDIO);
+       ContentChangeSignaller cc (this, DCPContentProperty::REFERENCE_AUDIO);
 
        {
                boost::mutex::scoped_lock lm (_mutex);
@@ -479,19 +531,19 @@ DCPContent::set_reference_audio (bool r)
 void
 DCPContent::set_reference_text (TextType type, bool r)
 {
-       ChangeSignaller<Content> cc (this, DCPContentProperty::REFERENCE_TEXT);
+       ContentChangeSignaller cc (this, DCPContentProperty::REFERENCE_TEXT);
 
        {
                boost::mutex::scoped_lock lm (_mutex);
-               _reference_text[type] = r;
+               _reference_text[static_cast<int>(type)] = r;
        }
 }
 
 list<DCPTimePeriod>
 DCPContent::reels (shared_ptr<const Film> film) const
 {
-       list<int64_t> reel_lengths = _reel_lengths;
-       if (reel_lengths.empty ()) {
+       auto reel_lengths = _reel_lengths;
+       if (reel_lengths.empty()) {
                /* Old metadata with no reel lengths; get them here instead */
                try {
                        scoped_ptr<DCPExaminer> examiner (new DCPExaminer(shared_from_this(), film->tolerant()));
@@ -509,13 +561,13 @@ DCPContent::reels (shared_ptr<const Film> film) const
        */
 
        /* The starting point of this content on the timeline */
-       DCPTime pos = position() - DCPTime (trim_start().get());
+       auto pos = position() - DCPTime (trim_start().get());
 
-       BOOST_FOREACH (int64_t i, reel_lengths) {
+       for (auto i: reel_lengths) {
                /* This reel runs from `pos' to `to' */
                DCPTime const to = pos + DCPTime::from_frames (i, film->video_frame_rate());
                if (to > position()) {
-                       p.push_back (DCPTimePeriod (max(position(), pos), min(end(film), to)));
+                       p.push_back (DCPTimePeriod(max(position(), pos), min(end(film), to)));
                        if (to > end(film)) {
                                break;
                        }
@@ -530,7 +582,7 @@ list<DCPTime>
 DCPContent::reel_split_points (shared_ptr<const Film> film) const
 {
        list<DCPTime> s;
-       BOOST_FOREACH (DCPTimePeriod i, reels(film)) {
+       for (auto i: reels(film)) {
                s.push_back (i.from);
        }
        return s;
@@ -541,11 +593,11 @@ DCPContent::can_reference (shared_ptr<const Film> film, function<bool (shared_pt
 {
        /* We must be using the same standard as the film */
        if (_standard) {
-               if (_standard.get() == dcp::INTEROP && !film->interop()) {
+               if (_standard.get() == dcp::Standard::INTEROP && !film->interop()) {
                        /// TRANSLATORS: this string will follow "Cannot reference this DCP: "
                        why_not = _("it is Interop and the film is set to SMPTE.");
                        return false;
-               } else if (_standard.get() == dcp::SMPTE && film->interop()) {
+               } else if (_standard.get() == dcp::Standard::SMPTE && film->interop()) {
                        /// TRANSLATORS: this string will follow "Cannot reference this DCP: "
                        why_not = _("it is SMPTE and the film is set to Interop.");
                        return false;
@@ -559,7 +611,7 @@ DCPContent::can_reference (shared_ptr<const Film> film, function<bool (shared_pt
                return false;
        }
 
-       list<DCPTimePeriod> const fr = film->reels ();
+       auto const fr = film->reels ();
 
        list<DCPTimePeriod> reel_list;
        try {
@@ -575,7 +627,7 @@ DCPContent::can_reference (shared_ptr<const Film> film, function<bool (shared_pt
        /* fr must contain reels().  It can also contain other reels, but it must at
           least contain reels().
        */
-       BOOST_FOREACH (DCPTimePeriod i, reel_list) {
+       for (auto i: reel_list) {
                if (find (fr.begin(), fr.end(), i) == fr.end ()) {
                        /// TRANSLATORS: this string will follow "Cannot reference this DCP: "
                        why_not = _("its reel lengths differ from those in the film; set the reel mode to 'split by video content'.");
@@ -583,7 +635,7 @@ DCPContent::can_reference (shared_ptr<const Film> film, function<bool (shared_pt
                }
        }
 
-       ContentList a = overlaps (film, film->content(), part, position(), end(film));
+       auto a = overlaps (film, film->content(), part, position(), end(film));
        if (a.size() != 1 || a.front().get() != this) {
                why_not = overlapping;
                return false;
@@ -595,7 +647,7 @@ DCPContent::can_reference (shared_ptr<const Film> film, function<bool (shared_pt
 static
 bool check_video (shared_ptr<const Content> c)
 {
-       return static_cast<bool>(c->video);
+       return static_cast<bool>(c->video) && c->video->use();
 }
 
 bool
@@ -607,7 +659,7 @@ DCPContent::can_reference_video (shared_ptr<const Film> film, string& why_not) c
        }
 
        if (film->resolution() != resolution()) {
-               if (resolution() == RESOLUTION_4K) {
+               if (resolution() == Resolution::FOUR_K) {
                        /// TRANSLATORS: this string will follow "Cannot reference this DCP: "
                        why_not = _("it is 4K and the film is 2K.");
                } else {
@@ -628,7 +680,7 @@ DCPContent::can_reference_video (shared_ptr<const Film> film, string& why_not) c
 static
 bool check_audio (shared_ptr<const Content> c)
 {
-       return static_cast<bool>(c->audio);
+       return static_cast<bool>(c->audio) && !c->audio->mapping().mapped_output_channels().empty();
 }
 
 bool
@@ -648,7 +700,7 @@ DCPContent::can_reference_audio (shared_ptr<const Film> film, string& why_not) c
                return false;
        }
 
-        BOOST_FOREACH (shared_ptr<dcp::Reel> i, decoder->reels()) {
+        for (auto i: decoder->reels()) {
                 if (!i->main_sound()) {
                        /// TRANSLATORS: this string will follow "Cannot reference this DCP: "
                         why_not = _("it does not have sound in all its reels.");
@@ -680,19 +732,40 @@ DCPContent::can_reference_text (shared_ptr<const Film> film, TextType type, stri
                return false;
        }
 
-        BOOST_FOREACH (shared_ptr<dcp::Reel> i, decoder->reels()) {
-                if (type == TEXT_OPEN_SUBTITLE && !i->main_subtitle()) {
-                       /// TRANSLATORS: this string will follow "Cannot reference this DCP: "
-                        why_not = _("it does not have open subtitles in all its reels.");
-                        return false;
+        for (auto i: decoder->reels()) {
+                if (type == TextType::OPEN_SUBTITLE) {
+                       if (!i->main_subtitle()) {
+                               /// TRANSLATORS: this string will follow "Cannot reference this DCP: "
+                               why_not = _("it does not have open subtitles in all its reels.");
+                               return false;
+                       } else if (i->main_subtitle()->entry_point().get_value_or(0) != 0) {
+                               /// TRANSLATORS: this string will follow "Cannot reference this DCP: "
+                               why_not = _("one of its subtitle reels has a non-zero entry point so it must be re-written.");
+                               return false;
+                       }
                 }
-               if (type == TEXT_CLOSED_CAPTION && i->closed_captions().empty()) {
-                       /// TRANSLATORS: this string will follow "Cannot reference this DCP: "
-                        why_not = _("it does not have closed captions in all its reels.");
-                        return false;
+               if (type == TextType::CLOSED_CAPTION) {
+                       if (i->closed_captions().empty()) {
+                               /// TRANSLATORS: this string will follow "Cannot reference this DCP: "
+                               why_not = _("it does not have closed captions in all its reels.");
+                               return false;
+                       }
+                       for (auto j: i->closed_captions()) {
+                               if (j->entry_point().get_value_or(0) != 0) {
+                                       /// TRANSLATORS: this string will follow "Cannot reference this DCP: "
+                                       why_not = _("one of its closed caption has a non-zero entry point so it must be re-written.");
+                                       return false;
+                               }
+                       }
                }
         }
 
+       if (trim_start() != dcpomatic::ContentTime()) {
+               /// TRANSLATORS: this string will follow "Cannot reference this DCP: "
+               why_not = _("it has a start trim so its subtitles or closed captions must be re-written.");
+               return false;
+       }
+
        /// TRANSLATORS: this string will follow "Cannot reference this DCP: "
        return can_reference (film, bind (&check_text, _1), _("it overlaps other text content; remove the other content."), why_not);
 }
@@ -700,14 +773,14 @@ DCPContent::can_reference_text (shared_ptr<const Film> film, TextType type, stri
 void
 DCPContent::take_settings_from (shared_ptr<const Content> c)
 {
-       shared_ptr<const DCPContent> dc = dynamic_pointer_cast<const DCPContent> (c);
+       auto dc = dynamic_pointer_cast<const DCPContent>(c);
        if (!dc) {
                return;
        }
 
        _reference_video = dc->_reference_video;
        _reference_audio = dc->_reference_audio;
-       for (int i = 0; i < TEXT_COUNT; ++i) {
+       for (int i = 0; i < static_cast<int>(TextType::COUNT); ++i) {
                _reference_text[i] = dc->_reference_text[i];
        }
 }
@@ -715,7 +788,7 @@ DCPContent::take_settings_from (shared_ptr<const Content> c)
 void
 DCPContent::set_cpl (string id)
 {
-       ChangeSignaller<Content> cc (this, DCPContentProperty::CPL);
+       ContentChangeSignaller cc (this, DCPContentProperty::CPL);
 
        {
                boost::mutex::scoped_lock lm (_mutex);
@@ -739,9 +812,9 @@ Resolution
 DCPContent::resolution () const
 {
        if (video->size().width > 2048 || video->size().height > 1080) {
-               return RESOLUTION_4K;
+               return Resolution::FOUR_K;
        }
 
-       return RESOLUTION_2K;
+       return Resolution::TWO_K;
 }