Rename SafeStringStream -> locked_stringstream. Bump deps for removal of stringstream.
[dcpomatic.git] / src / lib / ffmpeg_content.cc
index b47116bdcbb87f17761141e42521defb1888a00b..60c777b3c3d9f6107386525fa211630c14906afc 100644 (file)
@@ -1,23 +1,26 @@
 /*
-    Copyright (C) 2013-2015 Carl Hetherington <cth@carlh.net>
+    Copyright (C) 2013-2016 Carl Hetherington <cth@carlh.net>
 
-    This program is free software; you can redistribute it and/or modify
+    This file is part of DCP-o-matic.
+
+    DCP-o-matic is free software; you can redistribute it and/or modify
     it under the terms of the GNU General Public License as published by
     the Free Software Foundation; either version 2 of the License, or
     (at your option) any later version.
 
-    This program is distributed in the hope that it will be useful,
+    DCP-o-matic is distributed in the hope that it will be useful,
     but WITHOUT ANY WARRANTY; without even the implied warranty of
     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
     GNU General Public License for more details.
 
     You should have received a copy of the GNU General Public License
-    along with this program; if not, write to the Free Software
-    Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+    along with DCP-o-matic.  If not, see <http://www.gnu.org/licenses/>.
 
 */
 
 #include "ffmpeg_content.h"
+#include "video_content.h"
+#include "audio_content.h"
 #include "ffmpeg_examiner.h"
 #include "ffmpeg_subtitle_stream.h"
 #include "ffmpeg_audio_stream.h"
@@ -29,8 +32,9 @@
 #include "log.h"
 #include "exceptions.h"
 #include "frame_rate_change.h"
-#include "safe_stringstream.h"
 #include "raw_convert.h"
+#include "subtitle_content.h"
+#include <locked_sstream.h>
 #include <libcxml/cxml.h>
 extern "C" {
 #include <libavformat/avformat.h>
@@ -50,6 +54,7 @@ using std::list;
 using std::cout;
 using std::pair;
 using std::make_pair;
+using std::max;
 using boost::shared_ptr;
 using boost::dynamic_pointer_cast;
 using boost::optional;
@@ -60,19 +65,17 @@ int const FFmpegContentProperty::FILTERS = 102;
 
 FFmpegContent::FFmpegContent (shared_ptr<const Film> film, boost::filesystem::path p)
        : Content (film, p)
-       , VideoContent (film, p)
-       , AudioContent (film, p)
-       , SubtitleContent (film, p)
 {
 
 }
 
 FFmpegContent::FFmpegContent (shared_ptr<const Film> film, cxml::ConstNodePtr node, int version, list<string>& notes)
        : Content (film, node)
-       , VideoContent (film, node, version)
-       , AudioContent (film, node)
-       , SubtitleContent (film, node, version)
 {
+       video = VideoContent::from_xml (this, node, version);
+       audio = AudioContent::from_xml (this, node, version);
+       subtitle = SubtitleContent::from_xml (this, node, version);
+
        list<cxml::NodePtr> c = node->node_children ("SubtitleStream");
        for (list<cxml::NodePtr>::const_iterator i = c.begin(); i != c.end(); ++i) {
                _subtitle_streams.push_back (shared_ptr<FFmpegSubtitleStream> (new FFmpegSubtitleStream (*i, version)));
@@ -83,10 +86,11 @@ FFmpegContent::FFmpegContent (shared_ptr<const Film> film, cxml::ConstNodePtr no
 
        c = node->node_children ("AudioStream");
        for (list<cxml::NodePtr>::const_iterator i = c.begin(); i != c.end(); ++i) {
-               _audio_streams.push_back (shared_ptr<FFmpegAudioStream> (new FFmpegAudioStream (*i, version)));
+               shared_ptr<FFmpegAudioStream> as (new FFmpegAudioStream (*i, version));
+               audio->add_stream (as);
                if (version < 11 && !(*i)->optional_node_child ("Selected")) {
                        /* This is an old file and this stream is not selected, so un-map it */
-                       _audio_streams.back()->set_mapping (AudioMapping (_audio_streams.back()->channels (), MAX_DCP_AUDIO_CHANNELS));
+                       as->set_mapping (AudioMapping (as->channels (), MAX_DCP_AUDIO_CHANNELS));
                }
        }
 
@@ -115,18 +119,50 @@ FFmpegContent::FFmpegContent (shared_ptr<const Film> film, cxml::ConstNodePtr no
 
 }
 
-FFmpegContent::FFmpegContent (shared_ptr<const Film> film, vector<boost::shared_ptr<Content> > c)
+FFmpegContent::FFmpegContent (shared_ptr<const Film> film, vector<shared_ptr<Content> > c)
        : Content (film, c)
-       , VideoContent (film, c)
-       , AudioContent (film, c)
-       , SubtitleContent (film, c)
 {
+       vector<shared_ptr<Content> >::const_iterator i = c.begin ();
+
+       bool need_video = false;
+       bool need_audio = false;
+       bool need_subtitle = false;
+
+       if (i != c.end ()) {
+               need_video = static_cast<bool> ((*i)->video);
+               need_audio = static_cast<bool> ((*i)->audio);
+               need_subtitle = static_cast<bool> ((*i)->subtitle);
+       }
+
+       while (i != c.end ()) {
+               if (need_video != static_cast<bool> ((*i)->video)) {
+                       throw JoinError (_("Content to be joined must all have or not have video"));
+               }
+               if (need_audio != static_cast<bool> ((*i)->audio)) {
+                       throw JoinError (_("Content to be joined must all have or not have audio"));
+               }
+               if (need_subtitle != static_cast<bool> ((*i)->subtitle)) {
+                       throw JoinError (_("Content to be joined must all have or not have subtitles"));
+               }
+               ++i;
+       }
+
+       if (need_video) {
+               video.reset (new VideoContent (this, c));
+       }
+       if (need_audio) {
+               audio.reset (new AudioContent (this, c));
+       }
+       if (need_subtitle) {
+               subtitle.reset (new SubtitleContent (this, c));
+       }
+
        shared_ptr<FFmpegContent> ref = dynamic_pointer_cast<FFmpegContent> (c[0]);
        DCPOMATIC_ASSERT (ref);
 
        for (size_t i = 0; i < c.size(); ++i) {
                shared_ptr<FFmpegContent> fc = dynamic_pointer_cast<FFmpegContent> (c[i]);
-               if (fc->use_subtitles() && *(fc->_subtitle_stream.get()) != *(ref->_subtitle_stream.get())) {
+               if (fc->subtitle && fc->subtitle->use() && *(fc->_subtitle_stream.get()) != *(ref->_subtitle_stream.get())) {
                        throw JoinError (_("Content to be joined must use the same subtitle stream."));
                }
        }
@@ -135,7 +171,6 @@ FFmpegContent::FFmpegContent (shared_ptr<const Film> film, vector<boost::shared_
 
        _subtitle_streams = ref->subtitle_streams ();
        _subtitle_stream = ref->subtitle_stream ();
-       _audio_streams = ref->ffmpeg_audio_streams ();
        _first_video = ref->_first_video;
        _filters = ref->_filters;
        _color_range = ref->_color_range;
@@ -150,9 +185,24 @@ FFmpegContent::as_xml (xmlpp::Node* node) const
 {
        node->add_child("Type")->add_child_text ("FFmpeg");
        Content::as_xml (node);
-       VideoContent::as_xml (node);
-       AudioContent::as_xml (node);
-       SubtitleContent::as_xml (node);
+
+       if (video) {
+               video->as_xml (node);
+       }
+
+       if (audio) {
+               audio->as_xml (node);
+
+               BOOST_FOREACH (AudioStreamPtr i, audio->streams ()) {
+                       shared_ptr<FFmpegAudioStream> f = dynamic_pointer_cast<FFmpegAudioStream> (i);
+                       DCPOMATIC_ASSERT (f);
+                       f->as_xml (node->add_child("AudioStream"));
+               }
+       }
+
+       if (subtitle) {
+               subtitle->as_xml (node);
+       }
 
        boost::mutex::scoped_lock lm (_mutex);
 
@@ -164,10 +214,6 @@ FFmpegContent::as_xml (xmlpp::Node* node) const
                (*i)->as_xml (t);
        }
 
-       for (vector<shared_ptr<FFmpegAudioStream> >::const_iterator i = _audio_streams.begin(); i != _audio_streams.end(); ++i) {
-               (*i)->as_xml (node->add_child("AudioStream"));
-       }
-
        for (vector<Filter const *>::const_iterator i = _filters.begin(); i != _filters.end(); ++i) {
                node->add_child("Filter")->add_child_text ((*i)->id ());
        }
@@ -193,43 +239,64 @@ FFmpegContent::examine (shared_ptr<Job> job)
        Content::examine (job);
 
        shared_ptr<FFmpegExaminer> examiner (new FFmpegExaminer (shared_from_this (), job));
-       take_from_video_examiner (examiner);
+
+       if (examiner->has_video ()) {
+               video.reset (new VideoContent (this));
+               video->take_from_examiner (examiner);
+               set_default_colour_conversion ();
+       }
+
+       boost::filesystem::path first_path = path (0);
 
        {
                boost::mutex::scoped_lock lm (_mutex);
 
-               _subtitle_streams = examiner->subtitle_streams ();
-               if (!_subtitle_streams.empty ()) {
-                       _subtitle_stream = _subtitle_streams.front ();
+               if (examiner->has_video ()) {
+                       _first_video = examiner->first_video ();
+                       _color_range = examiner->color_range ();
+                       _color_primaries = examiner->color_primaries ();
+                       _color_trc = examiner->color_trc ();
+                       _colorspace = examiner->colorspace ();
+                       _bits_per_pixel = examiner->bits_per_pixel ();
                }
 
-               _audio_streams = examiner->audio_streams ();
+               if (!examiner->audio_streams().empty ()) {
+                       audio.reset (new AudioContent (this));
 
-               if (!_audio_streams.empty ()) {
-                       AudioMapping m = _audio_streams.front()->mapping ();
-                       film()->make_audio_mapping_default (m);
-                       _audio_streams.front()->set_mapping (m);
+                       BOOST_FOREACH (shared_ptr<FFmpegAudioStream> i, examiner->audio_streams ()) {
+                               audio->add_stream (i);
+                       }
+
+                       AudioStreamPtr as = audio->streams().front();
+                       AudioMapping m = as->mapping ();
+                       film()->make_audio_mapping_default (m, first_path);
+                       as->set_mapping (m);
                }
 
-               _first_video = examiner->first_video ();
+               _subtitle_streams = examiner->subtitle_streams ();
+               if (!_subtitle_streams.empty ()) {
+                       subtitle.reset (new SubtitleContent (this));
+                       _subtitle_stream = _subtitle_streams.front ();
+               }
 
-               _color_range = examiner->color_range ();
-               _color_primaries = examiner->color_primaries ();
-               _color_trc = examiner->color_trc ();
-               _colorspace = examiner->colorspace ();
-               _bits_per_pixel = examiner->bits_per_pixel ();
        }
 
        signal_changed (FFmpegContentProperty::SUBTITLE_STREAMS);
        signal_changed (FFmpegContentProperty::SUBTITLE_STREAM);
-       signal_changed (AudioContentProperty::AUDIO_STREAMS);
 }
 
 string
 FFmpegContent::summary () const
 {
-       /* Get the string() here so that the name does not have quotes around it */
-       return String::compose (_("%1 [movie]"), path_summary ());
+       if (video && audio) {
+               return String::compose (_("%1 [movie]"), path_summary ());
+       } else if (video) {
+               return String::compose (_("%1 [video]"), path_summary ());
+       } else if (audio) {
+               return String::compose (_("%1 [audio]"), path_summary ());
+       }
+
+       return path_summary ();
 }
 
 string
@@ -251,12 +318,19 @@ FFmpegContent::technical_summary () const
 
        string filt = Filter::ffmpeg_string (_filters);
 
-       return Content::technical_summary() + " - "
-               + VideoContent::technical_summary() + " - "
-               + AudioContent::technical_summary() + " - "
-               + String::compose (
-                       "ffmpeg: audio %1 subtitle %2 filters %3", as, ss, filt
-                       );
+       string s = Content::technical_summary ();
+
+       if (video) {
+               s += " - " + video->technical_summary ();
+       }
+
+       if (audio) {
+               s += " - " + audio->technical_summary ();
+       }
+
+       return s + String::compose (
+               "ffmpeg: audio %1 subtitle %2 filters %3", as, ss, filt
+               );
 }
 
 void
@@ -285,8 +359,19 @@ operator!= (FFmpegStream const & a, FFmpegStream const & b)
 DCPTime
 FFmpegContent::full_length () const
 {
-       FrameRateChange const frc (video_frame_rate (), film()->video_frame_rate ());
-       return DCPTime::from_frames (llrint (video_length_after_3d_combine() * frc.factor()), film()->video_frame_rate());
+       FrameRateChange const frc (active_video_frame_rate (), film()->video_frame_rate ());
+       if (video) {
+               return DCPTime::from_frames (llrint (video->length_after_3d_combine() * frc.factor()), film()->video_frame_rate());
+       }
+
+       DCPOMATIC_ASSERT (audio);
+
+       DCPTime longest;
+       BOOST_FOREACH (AudioStreamPtr i, audio->streams ()) {
+               longest = max (longest, DCPTime::from_frames (llrint (i->length() / frc.speed_up), i->frame_rate()));
+       }
+
+       return longest;
 }
 
 void
@@ -303,10 +388,17 @@ FFmpegContent::set_filters (vector<Filter const *> const & filters)
 string
 FFmpegContent::identifier () const
 {
-       SafeStringStream s;
+       locked_stringstream s;
+
+       s << Content::identifier();
+
+       if (video) {
+               s << "_" << video->identifier();
+       }
 
-       s << VideoContent::identifier() << "_"
-         << SubtitleContent::identifier();
+       if (subtitle) {
+               s << "_" << subtitle->identifier();
+       }
 
        boost::mutex::scoped_lock lm (_mutex);
 
@@ -322,158 +414,190 @@ FFmpegContent::identifier () const
 }
 
 list<ContentTimePeriod>
-FFmpegContent::subtitles_during (ContentTimePeriod period, bool starting) const
+FFmpegContent::image_subtitles_during (ContentTimePeriod period, bool starting) const
 {
        shared_ptr<FFmpegSubtitleStream> stream = subtitle_stream ();
        if (!stream) {
                return list<ContentTimePeriod> ();
        }
 
-       return stream->subtitles_during (period, starting);
+       return stream->image_subtitles_during (period, starting);
 }
 
-bool
-FFmpegContent::has_text_subtitles () const
+list<ContentTimePeriod>
+FFmpegContent::text_subtitles_during (ContentTimePeriod period, bool starting) const
 {
-       return false;
-}
+       shared_ptr<FFmpegSubtitleStream> stream = subtitle_stream ();
+       if (!stream) {
+               return list<ContentTimePeriod> ();
+       }
 
-bool
-FFmpegContent::has_image_subtitles () const
-{
-       return !subtitle_streams().empty ();
+       return stream->text_subtitles_during (period, starting);
 }
 
 void
 FFmpegContent::set_default_colour_conversion ()
 {
-       dcp::Size const s = video_size ();
+       DCPOMATIC_ASSERT (video);
+
+       dcp::Size const s = video->size ();
 
        boost::mutex::scoped_lock lm (_mutex);
 
        if (s.width < 1080) {
-               _colour_conversion = PresetColourConversion::from_id ("rec601").conversion;
+               video->set_colour_conversion (PresetColourConversion::from_id ("rec601").conversion);
        } else {
-               _colour_conversion = PresetColourConversion::from_id ("rec709").conversion;
+               video->set_colour_conversion (PresetColourConversion::from_id ("rec709").conversion);
        }
 }
 
-vector<AudioStreamPtr>
-FFmpegContent::audio_streams () const
+void
+FFmpegContent::add_properties (list<UserProperty>& p) const
 {
-       boost::mutex::scoped_lock lm (_mutex);
+       Content::add_properties (p);
+
+       if (video) {
+               video->add_properties (p);
+
+               if (_bits_per_pixel) {
+                       int const sub = 219 * pow (2, _bits_per_pixel.get() - 8);
+                       int const total = pow (2, _bits_per_pixel.get());
+
+                       switch (_color_range) {
+                       case AVCOL_RANGE_UNSPECIFIED:
+                               /// TRANSLATORS: this means that the range of pixel values used in this
+                               /// file is unknown (not specified in the file).
+                               p.push_back (UserProperty (UserProperty::VIDEO, _("Colour range"), _("Unspecified")));
+                               break;
+                       case AVCOL_RANGE_MPEG:
+                               /// TRANSLATORS: this means that the range of pixel values used in this
+                               /// file is limited, so that not all possible values are valid.
+                               p.push_back (
+                                       UserProperty (
+                                               UserProperty::VIDEO, _("Colour range"), String::compose (_("Limited (%1-%2)"), (total - sub) / 2, (total + sub) / 2)
+                                               )
+                                       );
+                               break;
+                       case AVCOL_RANGE_JPEG:
+                               /// TRANSLATORS: this means that the range of pixel values used in this
+                               /// file is full, so that all possible pixel values are valid.
+                               p.push_back (UserProperty (UserProperty::VIDEO, _("Colour range"), String::compose (_("Full (0-%1)"), total)));
+                               break;
+                       default:
+                               DCPOMATIC_ASSERT (false);
+                       }
+               } else {
+                       switch (_color_range) {
+                       case AVCOL_RANGE_UNSPECIFIED:
+                               /// TRANSLATORS: this means that the range of pixel values used in this
+                               /// file is unknown (not specified in the file).
+                               p.push_back (UserProperty (UserProperty::VIDEO, _("Colour range"), _("Unspecified")));
+                               break;
+                       case AVCOL_RANGE_MPEG:
+                               /// TRANSLATORS: this means that the range of pixel values used in this
+                               /// file is limited, so that not all possible values are valid.
+                               p.push_back (UserProperty (UserProperty::VIDEO, _("Colour range"), _("Limited")));
+                               break;
+                       case AVCOL_RANGE_JPEG:
+                               /// TRANSLATORS: this means that the range of pixel values used in this
+                               /// file is full, so that all possible pixel values are valid.
+                               p.push_back (UserProperty (UserProperty::VIDEO, _("Colour range"), _("Full")));
+                               break;
+                       default:
+                               DCPOMATIC_ASSERT (false);
+                       }
+               }
 
-       vector<AudioStreamPtr> s;
-       copy (_audio_streams.begin(), _audio_streams.end(), back_inserter (s));
-       return s;
+               char const * primaries[] = {
+                       _("Unspecified"),
+                       _("BT709"),
+                       _("Unspecified"),
+                       _("Unspecified"),
+                       _("BT470M"),
+                       _("BT470BG"),
+                       _("SMPTE 170M (BT601)"),
+                       _("SMPTE 240M"),
+                       _("Film"),
+                       _("BT2020"),
+                       _("SMPTE ST 428-1 (CIE 1931 XYZ)")
+               };
+
+               DCPOMATIC_ASSERT (AVCOL_PRI_NB <= 11);
+               p.push_back (UserProperty (UserProperty::VIDEO, _("Colour primaries"), primaries[_color_primaries]));
+
+               char const * transfers[] = {
+                       _("Unspecified"),
+                       _("BT709"),
+                       _("Unspecified"),
+                       _("Unspecified"),
+                       _("Gamma 22 (BT470M)"),
+                       _("Gamma 28 (BT470BG)"),
+                       _("SMPTE 170M (BT601)"),
+                       _("SMPTE 240M"),
+                       _("Linear"),
+                       _("Logarithmic (100:1 range)"),
+                       _("Logarithmic (316:1 range)"),
+                       _("IEC61966-2-4"),
+                       _("BT1361 extended colour gamut"),
+                       _("IEC61966-2-1 (sRGB or sYCC)"),
+                       _("BT2020 for a 10-bit system"),
+                       _("BT2020 for a 12-bit system"),
+                       _("SMPTE ST 2084 for 10, 12, 14 and 16 bit systems"),
+                       _("SMPTE ST 428-1"),
+                       _("ARIB STD-B67 ('Hybrid log-gamma')")
+               };
+
+               DCPOMATIC_ASSERT (AVCOL_TRC_NB <= 19);
+               p.push_back (UserProperty (UserProperty::VIDEO, _("Colour transfer characteristic"), transfers[_color_trc]));
+
+               char const * spaces[] = {
+                       _("RGB / sRGB (IEC61966-2-1)"),
+                       _("BT709"),
+                       _("Unspecified"),
+                       _("Unspecified"),
+                       _("FCC"),
+                       _("BT470BG (BT601-6)"),
+                       _("SMPTE 170M (BT601-6)"),
+                       _("SMPTE 240M"),
+                       _("YCOCG"),
+                       _("BT2020 non-constant luminance"),
+                       _("BT2020 constant luminance"),
+               };
+
+               DCPOMATIC_ASSERT (AVCOL_SPC_NB == 11);
+               p.push_back (UserProperty (UserProperty::VIDEO, _("Colourspace"), spaces[_colorspace]));
+
+               if (_bits_per_pixel) {
+                       p.push_back (UserProperty (UserProperty::VIDEO, _("Bits per pixel"), raw_convert<string> (_bits_per_pixel.get ())));
+               }
+       }
+
+       if (audio) {
+               audio->add_properties (p);
+       }
 }
 
+/** Our subtitle streams have colour maps, which can be changed, but
+ *  they have no way of signalling that change.  As a hack, we have this
+ *  method which callers can use when they've modified one of our subtitle
+ *  streams.
+ */
 void
-FFmpegContent::add_properties (list<pair<string, string> >& p) const
+FFmpegContent::signal_subtitle_stream_changed ()
 {
-       VideoContent::add_properties (p);
+       signal_changed (FFmpegContentProperty::SUBTITLE_STREAM);
+}
 
-       if (_bits_per_pixel) {
-               int const sub = 219 * pow (2, _bits_per_pixel.get() - 8);
-               int const total = pow (2, _bits_per_pixel.get());
-
-               switch (_color_range) {
-               case AVCOL_RANGE_UNSPECIFIED:
-                       /// TRANSLATORS: this means that the range of pixel values used in this
-                       /// file is unknown (not specified in the file).
-                       p.push_back (make_pair (_("Colour range"), _("Unspecified")));
-                       break;
-               case AVCOL_RANGE_MPEG:
-                       /// TRANSLATORS: this means that the range of pixel values used in this
-                       /// file is limited, so that not all possible values are valid.
-                       p.push_back (make_pair (_("Colour range"), String::compose (_("Limited (%1-%2)"), (total - sub) / 2, (total + sub) / 2)));
-                       break;
-               case AVCOL_RANGE_JPEG:
-                       /// TRANSLATORS: this means that the range of pixel values used in this
-                       /// file is full, so that all possible pixel values are valid.
-                       p.push_back (make_pair (_("Colour range"), String::compose (_("Full (0-%1)"), total)));
-                       break;
-               default:
-                       DCPOMATIC_ASSERT (false);
-               }
-       } else {
-               switch (_color_range) {
-               case AVCOL_RANGE_UNSPECIFIED:
-                       /// TRANSLATORS: this means that the range of pixel values used in this
-                       /// file is unknown (not specified in the file).
-                       p.push_back (make_pair (_("Colour range"), _("Unspecified")));
-                       break;
-               case AVCOL_RANGE_MPEG:
-                       /// TRANSLATORS: this means that the range of pixel values used in this
-                       /// file is limited, so that not all possible values are valid.
-                       p.push_back (make_pair (_("Colour range"), _("Limited")));
-                       break;
-               case AVCOL_RANGE_JPEG:
-                       /// TRANSLATORS: this means that the range of pixel values used in this
-                       /// file is full, so that all possible pixel values are valid.
-                       p.push_back (make_pair (_("Colour range"), _("Full")));
-                       break;
-               default:
-                       DCPOMATIC_ASSERT (false);
+vector<shared_ptr<FFmpegAudioStream> >
+FFmpegContent::ffmpeg_audio_streams () const
+{
+       vector<shared_ptr<FFmpegAudioStream> > fa;
+
+       if (audio) {
+               BOOST_FOREACH (AudioStreamPtr i, audio->streams()) {
+                       fa.push_back (dynamic_pointer_cast<FFmpegAudioStream> (i));
                }
        }
 
-       char const * primaries[] = {
-               _("Unspecified"),
-               _("BT709"),
-               _("Unspecified"),
-               _("Unspecified"),
-               _("BT470M"),
-               _("BT470BG"),
-               _("SMPTE 170M (BT601)"),
-               _("SMPTE 240M"),
-               _("Film"),
-               _("BT2020")
-       };
-
-       DCPOMATIC_ASSERT (AVCOL_PRI_NB == 10);
-       p.push_back (make_pair (_("Colour primaries"), primaries[_color_primaries]));
-
-       char const * transfers[] = {
-               _("Unspecified"),
-               _("BT709"),
-               _("Unspecified"),
-               _("Unspecified"),
-               _("Gamma 22 (BT470M)"),
-               _("Gamma 28 (BT470BG)"),
-               _("SMPTE 170M (BT601)"),
-               _("SMPTE 240M"),
-               _("Linear"),
-               _("Logarithmic (100:1 range)"),
-               _("Logarithmic (316:1 range)"),
-               _("IEC61966-2-4"),
-               _("BT1361 extended colour gamut"),
-               _("IEC61966-2-1 (sRGB or sYCC)"),
-               _("BT2020 for a 10-bit system"),
-               _("BT2020 for a 12-bit system")
-       };
-
-       DCPOMATIC_ASSERT (AVCOL_TRC_NB == 16);
-       p.push_back (make_pair (_("Colour transfer characteristic"), transfers[_color_trc]));
-
-       char const * spaces[] = {
-               _("RGB / sRGB (IEC61966-2-1)"),
-               _("BT709"),
-               _("Unspecified"),
-               _("Unspecified"),
-               _("FCC"),
-               _("BT470BG (BT601-6)"),
-               _("SMPTE 170M (BT601-6)"),
-               _("SMPTE 240M"),
-               _("YCOCG"),
-               _("BT2020 non-constant luminance"),
-               _("BT2020 constant luminance"),
-       };
-
-       DCPOMATIC_ASSERT (AVCOL_SPC_NB == 11);
-       p.push_back (make_pair (_("Colourspace"), spaces[_colorspace]));
-
-       if (_bits_per_pixel) {
-               p.push_back (make_pair (_("Bits per pixel"), raw_convert<string> (_bits_per_pixel.get ())));
-       }
+       return fa;
 }