C++11 tidying.

[dcpomatic.git] / src / lib / filter_graph.cc

diff --git a/src/lib/filter_graph.cc b/src/lib/filter_graph.cc
index 249fa7966e7307a202105bdda65668e643ca15aa..fc6b9033ac97805e01b4ea45aaeca6dc6fb41208 100644 (file)
--- a/src/lib/filter_graph.cc
+++ b/src/lib/filter_graph.cc
@@ -1,36 +1,36 @@
 /*
-    Copyright (C) 2012 Carl Hetherington <cth@carlh.net>
+    Copyright (C) 2012-2021 Carl Hetherington <cth@carlh.net>
 
-    This program is free software; you can redistribute it and/or modify
+    This file is part of DCP-o-matic.
+
+    DCP-o-matic is free software; you can redistribute it and/or modify
     it under the terms of the GNU General Public License as published by
     the Free Software Foundation; either version 2 of the License, or
     (at your option) any later version.
 
-    This program is distributed in the hope that it will be useful,
+    DCP-o-matic is distributed in the hope that it will be useful,
     but WITHOUT ANY WARRANTY; without even the implied warranty of
     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
     GNU General Public License for more details.
 
     You should have received a copy of the GNU General Public License
-    along with this program; if not, write to the Free Software
-    Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+    along with DCP-o-matic.  If not, see <http://www.gnu.org/licenses/>.
 
 */
 
+
 /** @file src/lib/filter_graph.cc
  *  @brief A graph of FFmpeg filters.
  */
 
+
 #include "filter_graph.h"
 #include "filter.h"
 #include "exceptions.h"
 #include "image.h"
-#include "safe_stringstream.h"
 #include "compose.hpp"
 extern "C" {
-#include <libavfilter/avfiltergraph.h>
 #include <libavfilter/buffersrc.h>
-#include <libavfilter/avcodec.h>
 #include <libavfilter/buffersink.h>
 #include <libavformat/avio.h>
 }
@@ -38,36 +38,23 @@ extern "C" {
 
 #include "i18n.h"
 
+
 using std::string;
 using std::list;
 using std::pair;
 using std::make_pair;
 using std::cout;
 using std::vector;
-using boost::shared_ptr;
-using boost::weak_ptr;
+using std::shared_ptr;
+using std::weak_ptr;
 using dcp::Size;
 
-/** Construct a FilterGraph for the settings in a piece of content.
- *  @param content Content.
- *  @param s Size of the images to process.
- *  @param p Pixel format of the images to process.
- */
-FilterGraph::FilterGraph ()
-       : _graph (0)
-       , _copy (false)
-       , _buffer_src_context (0)
-       , _buffer_sink_context (0)
-       , _frame (0)
-{
-
-}
 
 void
 FilterGraph::setup (vector<Filter const *> filters)
 {
-       string const filters_string = Filter::ffmpeg_string (filters);
-       if (filters.empty ()) {
+       auto const filters_string = Filter::ffmpeg_string (filters);
+       if (filters.empty()) {
                _copy = true;
                return;
        }
@@ -79,12 +66,12 @@ FilterGraph::setup (vector<Filter const *> filters)
                throw DecodeError (N_("could not create filter graph."));
        }
 
-       AVFilter* buffer_src = avfilter_get_by_name (src_name().c_str());
+       auto const buffer_src = avfilter_get_by_name (src_name().c_str());
        if (!buffer_src) {
                throw DecodeError (N_("could not find buffer src filter"));
        }
 
-       AVFilter* buffer_sink = avfilter_get_by_name (sink_name().c_str());
+       auto const buffer_sink = avfilter_get_by_name (sink_name().c_str());
        if (!buffer_sink) {
                throw DecodeError (N_("Could not create buffer sink filter"));
        }
@@ -93,21 +80,19 @@ FilterGraph::setup (vector<Filter const *> filters)
                throw DecodeError (N_("could not create buffer source"));
        }
 
-       void* sink_params = sink_parameters ();
-
-       if (avfilter_graph_create_filter (&_buffer_sink_context, buffer_sink, N_("out"), 0, sink_params, _graph) < 0) {
+       if (avfilter_graph_create_filter (&_buffer_sink_context, buffer_sink, N_("out"), nullptr, nullptr, _graph) < 0) {
                throw DecodeError (N_("could not create buffer sink."));
        }
 
-       av_free (sink_params);
+       set_parameters (_buffer_sink_context);
 
-       AVFilterInOut* outputs = avfilter_inout_alloc ();
+       auto outputs = avfilter_inout_alloc ();
        outputs->name = av_strdup(N_("in"));
        outputs->filter_ctx = _buffer_src_context;
        outputs->pad_idx = 0;
        outputs->next = 0;
 
-       AVFilterInOut* inputs = avfilter_inout_alloc ();
+       auto inputs = avfilter_inout_alloc ();
        inputs->name = av_strdup(N_("out"));
        inputs->filter_ctx = _buffer_sink_context;
        inputs->pad_idx = 0;
@@ -117,11 +102,13 @@ FilterGraph::setup (vector<Filter const *> filters)
                throw DecodeError (N_("could not set up filter graph."));
        }
 
-       if (avfilter_graph_config (_graph, 0) < 0) {
-               throw DecodeError (N_("could not configure filter graph."));
+       int e = avfilter_graph_config (_graph, 0);
+       if (e < 0) {
+               throw DecodeError (String::compose(N_("could not configure filter graph (%1)"), e));
        }
 }
 
+
 FilterGraph::~FilterGraph ()
 {
        if (_frame) {
@@ -133,8 +120,9 @@ FilterGraph::~FilterGraph ()
        }
 }
 
+
 AVFilterContext *
 FilterGraph::get (string name)
 {
-       return avfilter_graph_get_filter (_graph, name.c_str ());
+       return avfilter_graph_get_filter (_graph, name.c_str());
 }