Add a test for short pieces of content amongst longer.

[dcpomatic.git] / test / reels_test.cc

diff --git a/test/reels_test.cc b/test/reels_test.cc
index 3d79017f0abdaec7be8024e313a2c6163a0aff88..c6fb21977ed108bffc7ec4ad7a6d8aacdedff1d2 100644 (file)
--- a/test/reels_test.cc
+++ b/test/reels_test.cc
@@ -1,5 +1,5 @@
 /*
-    Copyright (C) 2015-2019 Carl Hetherington <cth@carlh.net>
+    Copyright (C) 2015-2020 Carl Hetherington <cth@carlh.net>
 
     This file is part of DCP-o-matic.
 
@@ -39,7 +39,10 @@
 
 using std::list;
 using std::cout;
+using std::vector;
+using std::string;
 using boost::shared_ptr;
+using boost::function;
 using namespace dcpomatic;
 
 /** Test Film::reels() */
@@ -482,3 +485,111 @@ BOOST_AUTO_TEST_CASE (reels_test12)
        BOOST_CHECK_EQUAL (i->from.get(), DCPTime::from_seconds(14).get());
        BOOST_CHECK_EQUAL (i->to.get(),   DCPTime::from_seconds(19).get());
 }
+
+static void
+no_op ()
+{
+
+}
+
+
+/** Using less than 1 second's worth of content should not result in a reel
+ *  of less than 1 second's duration.
+ */
+BOOST_AUTO_TEST_CASE (reels_should_not_be_short1)
+{
+       shared_ptr<Film> film = new_test_film2 ("reels_should_not_be_short1");
+       film->set_video_frame_rate (24);
+
+       shared_ptr<FFmpegContent> A(new FFmpegContent("test/data/flat_red.png"));
+       film->examine_and_add_content (A);
+       BOOST_REQUIRE (!wait_for_jobs());
+       A->video->set_length (23);
+
+       film->make_dcp ();
+       BOOST_REQUIRE (!wait_for_jobs());
+
+       vector<boost::filesystem::path> dirs;
+       dirs.push_back (film->dir(film->dcp_name(false)));
+       BOOST_REQUIRE (dcp::verify(dirs, boost::bind(&no_op), boost::bind(&no_op), TestPaths::xsd).empty());
+}
+
+/** Leaving less than 1 second's gap between two pieces of content with
+ *  REELTYPE_BY_VIDEO_CONTENT should not make a <1s reel.
+ */
+BOOST_AUTO_TEST_CASE (reels_should_not_be_short2)
+{
+       shared_ptr<Film> film = new_test_film2 ("reels_should_not_be_short2");
+       film->set_video_frame_rate (24);
+       film->set_reel_type (REELTYPE_BY_VIDEO_CONTENT);
+
+       shared_ptr<FFmpegContent> A(new FFmpegContent("test/data/flat_red.png"));
+       film->examine_and_add_content (A);
+       BOOST_REQUIRE (!wait_for_jobs());
+       A->video->set_length (240);
+
+       shared_ptr<FFmpegContent> B(new FFmpegContent("test/data/flat_red.png"));
+       film->examine_and_add_content (B);
+       BOOST_REQUIRE (!wait_for_jobs());
+       B->video->set_length (240);
+       B->set_position (film, DCPTime::from_seconds(10.2));
+
+       film->make_dcp ();
+       BOOST_REQUIRE (!wait_for_jobs());
+
+       vector<boost::filesystem::path> dirs;
+       dirs.push_back (film->dir(film->dcp_name(false)));
+       BOOST_REQUIRE (dcp::verify(dirs, boost::bind(&no_op), boost::bind(&no_op), TestPaths::xsd).empty());
+}
+
+/** Setting REELTYPE_BY_LENGTH and using a small length value should not make
+ *  <1s reels.
+ */
+BOOST_AUTO_TEST_CASE (reels_should_not_be_short3)
+{
+       shared_ptr<Film> film = new_test_film2 ("reels_should_not_be_short3");
+       film->set_video_frame_rate (24);
+       film->set_reel_type (REELTYPE_BY_LENGTH);
+       film->set_reel_length (1024 * 1024 * 10);
+
+       shared_ptr<FFmpegContent> A(new FFmpegContent("test/data/flat_red.png"));
+       film->examine_and_add_content (A);
+       BOOST_REQUIRE (!wait_for_jobs());
+       A->video->set_length (240);
+
+       film->make_dcp ();
+       BOOST_REQUIRE (!wait_for_jobs());
+
+       vector<boost::filesystem::path> dirs;
+       dirs.push_back (film->dir(film->dcp_name(false)));
+       BOOST_REQUIRE (dcp::verify(dirs, boost::bind(&no_op), boost::bind(&no_op), TestPaths::xsd).empty());
+}
+
+/** Having one piece of content less than 1s long in REELTYPE_BY_VIDEO_CONTENT
+ *  should not make a reel less than 1s long.
+ */
+BOOST_AUTO_TEST_CASE (reels_should_not_be_short4)
+{
+       shared_ptr<Film> film = new_test_film2 ("reels_should_not_be_short4");
+       film->set_video_frame_rate (24);
+       film->set_reel_type (REELTYPE_BY_VIDEO_CONTENT);
+
+       shared_ptr<FFmpegContent> A(new FFmpegContent("test/data/flat_red.png"));
+       film->examine_and_add_content (A);
+       BOOST_REQUIRE (!wait_for_jobs());
+       A->video->set_length (240);
+
+       shared_ptr<FFmpegContent> B(new FFmpegContent("test/data/flat_red.png"));
+       film->examine_and_add_content (B);
+       BOOST_REQUIRE (!wait_for_jobs());
+       B->video->set_length (23);
+       B->set_position (film, DCPTime::from_frames(240, 24));
+
+       film->make_dcp ();
+       BOOST_REQUIRE (!wait_for_jobs());
+
+       vector<boost::filesystem::path> dirs;
+       dirs.push_back (film->dir(film->dcp_name(false)));
+       BOOST_REQUIRE (dcp::verify(dirs, boost::bind(&no_op), boost::bind(&no_op), TestPaths::xsd).empty());
+}
+