X-Git-Url: https://main.carlh.net/gitweb/?p=dcpomatic.git;a=blobdiff_plain;f=src%2Flib%2Fbutler.h;h=0a0050e8ff90aa8f1aeb184bf531da457322efdb;hp=b1debfca2b2c948bb407cb8faa3cc844d6444ae3;hb=463496994d770577ff1e1ea6e7b1e4addb4252b2;hpb=f41310384889e4cfb6e709d098b316e212d8bf22

diff --git a/src/lib/butler.h b/src/lib/butler.h
index b1debfca2..0a0050e8f 100644
--- a/src/lib/butler.h
+++ b/src/lib/butler.h
@@ -32,14 +32,12 @@
 
 class Player;
 class PlayerVideo;
-class Log;
 
 class Butler : public ExceptionStore, public boost::noncopyable
 {
 public:
 	Butler (
 		boost::shared_ptr<Player> player,
-		boost::shared_ptr<Log> log,
 		AudioMapping map,
 		int audio_channels,
 		boost::function<AVPixelFormat (AVPixelFormat)> pixel_format,
@@ -49,15 +47,15 @@ public:
 
 	~Butler ();
 
-	void seek (DCPTime position, bool accurate);
+	void seek (dcpomatic::DCPTime position, bool accurate);
 
 	enum Error {
 		NONE,
 		AGAIN
 	};
 
-	std::pair<boost::shared_ptr<PlayerVideo>, DCPTime> get_video (Error* e = 0);
-	boost::optional<DCPTime> get_audio (float* out, Frame frames);
+	std::pair<boost::shared_ptr<PlayerVideo>, dcpomatic::DCPTime> get_video (bool blocking, Error* e = 0);
+	boost::optional<dcpomatic::DCPTime> get_audio (float* out, Frame frames);
 	boost::optional<TextRingBuffers::Data> get_closed_caption ();
 
 	void disable_audio ();
@@ -66,24 +64,17 @@ public:
 
 private:
 	void thread ();
-	void video (boost::shared_ptr<PlayerVideo> video, DCPTime time);
-	void audio (boost::shared_ptr<AudioBuffers> audio, DCPTime time);
-	void text (PlayerText pt, TextType type, boost::optional<DCPTextTrack> track, DCPTimePeriod period);
+	void video (boost::shared_ptr<PlayerVideo> video, dcpomatic::DCPTime time);
+	void audio (boost::shared_ptr<AudioBuffers> audio, dcpomatic::DCPTime time, int frame_rate);
+	void text (PlayerText pt, TextType type, boost::optional<DCPTextTrack> track, dcpomatic::DCPTimePeriod period);
 	bool should_run () const;
-	void prepare (boost::weak_ptr<PlayerVideo> video) const;
-	void player_change (ChangeType type, bool frequent);
-	void seek_unlocked (DCPTime position, bool accurate);
+	void prepare (boost::weak_ptr<PlayerVideo> video);
+	void player_change (ChangeType type);
+	void seek_unlocked (dcpomatic::DCPTime position, bool accurate);
 
 	boost::shared_ptr<Player> _player;
-	boost::shared_ptr<Log> _log;
-	boost::thread* _thread;
+	boost::thread _thread;
 
-	/** mutex to protect _video, _audio and _closed_caption for when we are clearing them and they all need to be
-	    cleared together without any data being inserted in the interim;
-	    XXX: is this necessary now that all butler output data is timestamped? Perhaps the locked clear-out
-	    is only required if we guarantee that get_video() and get_audio() calls are in sync.
-	*/
-	boost::mutex _buffers_mutex;
 	VideoRingBuffers _video;
 	AudioRingBuffers _audio;
 	TextRingBuffers _closed_caption;
@@ -96,7 +87,7 @@ private:
 	boost::mutex _mutex;
 	boost::condition _summon;
 	boost::condition _arrived;
-	boost::optional<DCPTime> _pending_seek_position;
+	boost::optional<dcpomatic::DCPTime> _pending_seek_position;
 	bool _pending_seek_accurate;
 	int _suspended;
 	bool _finished;
@@ -115,7 +106,7 @@ private:
 	/** If we are waiting to be refilled following a seek, this is the time we were
 	    seeking to.
 	*/
-	boost::optional<DCPTime> _awaiting;
+	boost::optional<dcpomatic::DCPTime> _awaiting;
 
 	boost::signals2::scoped_connection _player_video_connection;
 	boost::signals2::scoped_connection _player_audio_connection;