X-Git-Url: https://main.carlh.net/gitweb/?p=dcpomatic.git;a=blobdiff_plain;f=src%2Flib%2Fcinema_kdms.cc;h=3af1e0d84ca7c1ec932c635c9cfa223d32153e2f;hp=aaeb0d9056f3f89b94b9c62c731b4a8edd7912ef;hb=4ead1f24f97edde9b6a77e47947cb188a551b49b;hpb=8c0ca24cfddee9d1541fd2240ba62eaf52d18da5

diff --git a/src/lib/cinema_kdms.cc b/src/lib/cinema_kdms.cc
index aaeb0d905..3af1e0d84 100644
--- a/src/lib/cinema_kdms.cc
+++ b/src/lib/cinema_kdms.cc
@@ -27,7 +27,8 @@
 #include "emailer.h"
 #include "compose.hpp"
 #include "log.h"
-#include <zip.h>
+#include "zipper.h"
+#include "dcpomatic_log.h"
 #include <boost/foreach.hpp>
 
 #include "i18n.h"
@@ -42,46 +43,25 @@ using boost::function;
 void
 CinemaKDMs::make_zip_file (boost::filesystem::path zip_file, dcp::NameFormat name_format, dcp::NameFormat::Map name_values) const
 {
-	int error;
-	struct zip* zip = zip_open (zip_file.string().c_str(), ZIP_CREATE | ZIP_EXCL, &error);
-	if (!zip) {
-		if (error == ZIP_ER_EXISTS) {
-			throw FileError ("ZIP file already exists", zip_file);
-		}
-		throw FileError ("could not create ZIP file", zip_file);
-	}
-
-	list<shared_ptr<string> > kdm_strings;
+	Zipper zipper (zip_file);
 
 	name_values['c'] = cinema->name;
 
-	BOOST_FOREACH (ScreenKDM const & i, screen_kdms) {
-		shared_ptr<string> kdm (new string (i.kdm.as_xml ()));
-		kdm_strings.push_back (kdm);
-
-		struct zip_source* source = zip_source_buffer (zip, kdm->c_str(), kdm->length(), 0);
-		if (!source) {
-			throw runtime_error ("could not create ZIP source");
-		}
-
-		name_values['s'] = i.screen->name;
-		name_values['i'] = i.kdm.id ();
-		string const name = name_format.get(name_values, ".xml");
-		if (zip_add (zip, name.c_str(), source) == -1) {
-			throw runtime_error ("failed to add KDM to ZIP archive");
-		}
+	BOOST_FOREACH (shared_ptr<ScreenKDM> i, screen_kdms) {
+		name_values['s'] = i->screen->name;
+		name_values['i'] = i->kdm_id ();
+		string const name = careful_string_filter(name_format.get(name_values, ".xml"));
+		zipper.add (name, i->kdm_as_xml());
 	}
 
-	if (zip_close (zip) == -1) {
-		throw runtime_error ("failed to close ZIP archive");
-	}
+	zipper.close ();
 }
 
 /** Collect a list of ScreenKDMs into a list of CinemaKDMs so that each
  *  CinemaKDM contains the KDMs for its cinema.
  */
 list<CinemaKDMs>
-CinemaKDMs::collect (list<ScreenKDM> screen_kdms)
+CinemaKDMs::collect (list<shared_ptr<ScreenKDM> > screen_kdms)
 {
 	list<CinemaKDMs> cinema_kdms;
 
@@ -91,17 +71,17 @@ CinemaKDMs::collect (list<ScreenKDM> screen_kdms)
 
 		CinemaKDMs ck;
 
-		list<ScreenKDM>::iterator i = screen_kdms.begin ();
-		ck.cinema = i->screen->cinema;
+		list<shared_ptr<ScreenKDM> >::iterator i = screen_kdms.begin ();
+		ck.cinema = (*i)->screen->cinema;
 		ck.screen_kdms.push_back (*i);
-		list<ScreenKDM>::iterator j = i;
+		list<shared_ptr<ScreenKDM> >::iterator j = i;
 		++i;
 		screen_kdms.remove (*j);
 
 		while (i != screen_kdms.end ()) {
-			if (i->screen->cinema == ck.cinema) {
+			if ((*i)->screen->cinema == ck.cinema) {
 				ck.screen_kdms.push_back (*i);
-				list<ScreenKDM>::iterator j = i;
+				list<shared_ptr<ScreenKDM> >::iterator j = i;
 				++i;
 				screen_kdms.remove (*j);
 			} else {
@@ -184,7 +164,6 @@ CinemaKDMs::write_zip_files (
  *  @param filename_format Format of filenames to use.
  *  @param name_values Values to substitute into \p container_name_format and \p filename_format.
  *  @param cpl_name Name of the CPL that the KDMs are for.
- *  @param log Log to write email session transcript to, or 0.
  */
 void
 CinemaKDMs::email (
@@ -192,8 +171,7 @@ CinemaKDMs::email (
 	dcp::NameFormat container_name_format,
 	dcp::NameFormat filename_format,
 	dcp::NameFormat::Map name_values,
-	string cpl_name,
-	shared_ptr<Log> log
+	string cpl_name
 	)
 {
 	Config* config = Config::instance ();
@@ -207,6 +185,10 @@ CinemaKDMs::email (
 
 	BOOST_FOREACH (CinemaKDMs const & i, cinema_kdms) {
 
+		if (i.cinema->emails.empty()) {
+			continue;
+		}
+
 		name_values['c'] = i.cinema->name;
 
 		boost::filesystem::path zip_file = boost::filesystem::temp_directory_path() / boost::filesystem::unique_path();
@@ -227,8 +209,8 @@ CinemaKDMs::email (
 		boost::algorithm::replace_all (body, "$CINEMA_NAME", i.cinema->name);
 
 		string screens;
-		BOOST_FOREACH (ScreenKDM const & j, i.screen_kdms) {
-			screens += j.screen->name + ", ";
+		BOOST_FOREACH (shared_ptr<ScreenKDM> j, i.screen_kdms) {
+			screens += j->screen->name + ", ";
 		}
 		boost::algorithm::replace_all (body, "$SCREENS", screens.substr (0, screens.length() - 2));
 
@@ -246,25 +228,21 @@ CinemaKDMs::email (
 		Config* c = Config::instance ();
 
 		try {
-			email.send (c->mail_server(), c->mail_port(), c->mail_user(), c->mail_password());
+			email.send (c->mail_server(), c->mail_port(), c->mail_protocol(), c->mail_user(), c->mail_password());
 		} catch (...) {
 			boost::filesystem::remove (zip_file);
-			if (log) {
-				log->log ("Email content follows", LogEntry::TYPE_DEBUG_EMAIL);
-				log->log (email.email(), LogEntry::TYPE_DEBUG_EMAIL);
-				log->log ("Email session follows", LogEntry::TYPE_DEBUG_EMAIL);
-				log->log (email.notes(), LogEntry::TYPE_DEBUG_EMAIL);
-			}
+			dcpomatic_log->log ("Email content follows", LogEntry::TYPE_DEBUG_EMAIL);
+			dcpomatic_log->log (email.email(), LogEntry::TYPE_DEBUG_EMAIL);
+			dcpomatic_log->log ("Email session follows", LogEntry::TYPE_DEBUG_EMAIL);
+			dcpomatic_log->log (email.notes(), LogEntry::TYPE_DEBUG_EMAIL);
 			throw;
 		}
 
 		boost::filesystem::remove (zip_file);
 
-		if (log) {
-			log->log ("Email content follows", LogEntry::TYPE_DEBUG_EMAIL);
-			log->log (email.email(), LogEntry::TYPE_DEBUG_EMAIL);
-			log->log ("Email session follows", LogEntry::TYPE_DEBUG_EMAIL);
-			log->log (email.notes(), LogEntry::TYPE_DEBUG_EMAIL);
-		}
+		dcpomatic_log->log ("Email content follows", LogEntry::TYPE_DEBUG_EMAIL);
+		dcpomatic_log->log (email.email(), LogEntry::TYPE_DEBUG_EMAIL);
+		dcpomatic_log->log ("Email session follows", LogEntry::TYPE_DEBUG_EMAIL);
+		dcpomatic_log->log (email.notes(), LogEntry::TYPE_DEBUG_EMAIL);
 	}
 }