X-Git-Url: https://main.carlh.net/gitweb/?p=dcpomatic.git;a=blobdiff_plain;f=src%2Flib%2Fencode_server.cc;h=5884df09aae9642ccea356b640a9d4491ef4fa3e;hp=16c65dba76f6df8d62c3546d9105fea6ea8662a2;hb=f515b8daea9d28200be803bb64ff17e9f30343c4;hpb=671eee9ef5f22f5043e58973a8e001a07cc697eb diff --git a/src/lib/encode_server.cc b/src/lib/encode_server.cc index 16c65dba7..5884df09a 100644 --- a/src/lib/encode_server.cc +++ b/src/lib/encode_server.cc @@ -88,11 +88,10 @@ EncodeServer::~EncodeServer () } BOOST_FOREACH (boost::thread* i, _worker_threads) { - /* Ideally this would be a DCPOMATIC_ASSERT(i->joinable()) but we - can't throw exceptions from a destructor. - */ - if (i->joinable ()) { + try { i->join (); + } catch (...) { + } delete i; } @@ -107,14 +106,12 @@ EncodeServer::~EncodeServer () } _broadcast.io_service.stop (); - if (_broadcast.thread) { - /* Ideally this would be a DCPOMATIC_ASSERT(_broadcast.thread->joinable()) but we - can't throw exceptions from a destructor. - */ - if (_broadcast.thread->joinable ()) { - _broadcast.thread->join (); + if (_broadcast.thread.joinable()) { + try { + _broadcast.thread.join (); + } catch (...) { + } - delete _broadcast.thread; } } @@ -237,16 +234,16 @@ EncodeServer::run () } for (int i = 0; i < _num_threads; ++i) { - thread* t = new thread (bind (&EncodeServer::worker_thread, this)); + boost::thread* t = new thread(bind(&EncodeServer::worker_thread, this)); + _worker_threads.push_back (t); #ifdef DCPOMATIC_LINUX pthread_setname_np (t->native_handle(), "encode-server-worker"); #endif - _worker_threads.push_back (t); } - _broadcast.thread = new thread (bind (&EncodeServer::broadcast_thread, this)); + _broadcast.thread = thread (bind(&EncodeServer::broadcast_thread, this)); #ifdef DCPOMATIC_LINUX - pthread_setname_np (_broadcast.thread->native_handle(), "encode-server-broadcast"); + pthread_setname_np (_broadcast.thread.native_handle(), "encode-server-broadcast"); #endif Server::run (); @@ -326,6 +323,9 @@ EncodeServer::handle (shared_ptr socket) { boost::mutex::scoped_lock lock (_mutex); + Waker waker; + waker.nudge (); + /* Wait until the queue has gone down a bit */ while (_queue.size() >= _worker_threads.size() * 2 && !_terminate) { _full_condition.wait (lock);