X-Git-Url: https://main.carlh.net/gitweb/?p=dcpomatic.git;a=blobdiff_plain;f=src%2Fwx%2Fhints_dialog.cc;h=cb0de450a73ad7d141941536c003f4f057cfddf7;hp=9f89569481f0d8f17cd8e570b68216d0d768a7a8;hb=6ca34bc1ef59dd206379f35eb940e607a59c9804;hpb=9980c40a47abe24f8dd3cb16e14ad4a3254a8465 diff --git a/src/wx/hints_dialog.cc b/src/wx/hints_dialog.cc index 9f8956948..cb0de450a 100644 --- a/src/wx/hints_dialog.cc +++ b/src/wx/hints_dialog.cc @@ -1,155 +1,183 @@ /* - Copyright (C) 2012-2013 Carl Hetherington + Copyright (C) 2012-2018 Carl Hetherington - This program is free software; you can redistribute it and/or modify + This file is part of DCP-o-matic. + + DCP-o-matic is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. - This program is distributed in the hope that it will be useful, + DCP-o-matic is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License - along with this program; if not, write to the Free Software - Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. + along with DCP-o-matic. If not, see . */ -#include -#include -#include "lib/film.h" -#include "lib/ratio.h" #include "hints_dialog.h" +#include "wx_util.h" +#include "static_text.h" +#include "check_box.h" +#include "lib/film.h" +#include "lib/hints.h" +#include "lib/config.h" +#include +#include +using std::max; +using std::vector; +using std::string; +using std::cout; using boost::shared_ptr; +using boost::optional; +using boost::bind; using boost::dynamic_pointer_cast; -HintsDialog::HintsDialog (wxWindow* parent, boost::weak_ptr f) +HintsDialog::HintsDialog (wxWindow* parent, boost::weak_ptr film, bool ok) : wxDialog (parent, wxID_ANY, _("Hints")) - , _film (f) + , _film (film) + , _hints (0) + , _finished (false) { wxBoxSizer* sizer = new wxBoxSizer (wxVERTICAL); + + _gauge = new wxGauge (this, wxID_ANY, 100); + sizer->Add (_gauge, 0, wxALL | wxEXPAND, DCPOMATIC_SIZER_GAP); + _gauge_message = new StaticText (this, wxT("")); + sizer->Add (_gauge_message, 0, wxALL | wxEXPAND, DCPOMATIC_SIZER_GAP); + _text = new wxRichTextCtrl (this, wxID_ANY, wxEmptyString, wxDefaultPosition, wxSize (400, 300), wxRE_READONLY); sizer->Add (_text, 1, wxEXPAND | wxALL, 6); - wxSizer* buttons = CreateSeparatedButtonSizer (wxOK); - if (buttons) { - sizer->Add (buttons, wxSizerFlags().Expand().DoubleBorder()); + if (!ok) { + wxCheckBox* b = new CheckBox (this, _("Don't show hints again")); + sizer->Add (b, 0, wxALL, 6); + b->Bind (wxEVT_CHECKBOX, bind (&HintsDialog::shut_up, this, _1)); } + wxStdDialogButtonSizer* buttons = CreateStdDialogButtonSizer (0); + sizer->Add (CreateSeparatedSizer(buttons), wxSizerFlags().Expand().DoubleBorder()); + if (ok) { + buttons->SetAffirmativeButton (new wxButton (this, wxID_OK)); + } else { + buttons->SetAffirmativeButton (new wxButton (this, wxID_OK, _("Make DCP"))); + buttons->SetNegativeButton (new wxButton (this, wxID_CANCEL, _("Go back"))); + } + + buttons->Realize (); + SetSizer (sizer); sizer->Layout (); sizer->SetSizeHints (this); _text->GetCaret()->Hide (); - boost::shared_ptr film = _film.lock (); - if (film) { - film->Changed.connect (boost::bind (&HintsDialog::film_changed, this)); - film->ContentChanged.connect (boost::bind (&HintsDialog::film_changed, this)); + boost::shared_ptr locked_film = _film.lock (); + if (locked_film) { + _film_change_connection = locked_film->Change.connect (boost::bind (&HintsDialog::film_change, this, _1)); + _film_content_change_connection = locked_film->ContentChange.connect (boost::bind (&HintsDialog::film_content_change, this, _1)); } - film_changed (); + film_change (CHANGE_TYPE_DONE); } void -HintsDialog::film_changed () +HintsDialog::film_change (ChangeType type) { - _text->Clear (); - bool hint = false; - - boost::shared_ptr film = _film.lock (); - if (!film) { + if (type != CHANGE_TYPE_DONE) { return; } - _text->BeginStandardBullet (N_("standard/circle"), 1, 50); - if (film->audio_channels() % 2) { - hint = true; - _text->WriteText (_("Your DCP has an odd number of audio channels. This is very likely to cause problems on playback.")); - _text->Newline (); - } else if (film->audio_channels() < 6) { - hint = true; - _text->WriteText (_("Your DCP has fewer than 6 audio channels. This may cause problems on some projectors.")); - _text->Newline (); - } else if (film->audio_channels() == 0) { - /* Carsten Kurz reckons having no audio can be a problem */ - hint = true; - _text->WriteText (_("Your DCP has no audio channels. This is likely to cause problems on playback.")); - _text->Newline (); - } - - ContentList content = film->content (); - int flat_or_narrower = 0; - int scope = 0; - for (ContentList::const_iterator i = content.begin(); i != content.end(); ++i) { - shared_ptr vc = dynamic_pointer_cast (*i); - if (vc) { - Ratio const * r = vc->scale().ratio (); - if (r && r->id() == "239") { - ++scope; - } else if (r && r->id() != "239" && r->id() != "full-frame") { - ++flat_or_narrower; - } - } - } + _text->Clear (); + _current.clear (); - if (scope && !flat_or_narrower && film->container()->id() == "185") { - hint = true; - _text->WriteText (_("All of your content is in Scope (2.39:1) but your DCP's container is Flat (1.85:1). This will letter-box your content inside a Flat (1.85:1) frame. You may prefer to set your DCP's container to Scope (2.39:1) in the \"DCP\" tab.")); - _text->Newline (); + boost::shared_ptr film = _film.lock (); + if (!film) { + return; } - if (!scope && flat_or_narrower && film->container()->id() == "239") { - hint = true; - _text->WriteText (_("All of your content is at 1.85:1 or narrower but your DCP's container is Scope (2.39:1). This will pillar-box your content inside a Flat (1.85:1) frame. You may prefer to set your DCP's container to Flat (1.85:1) in the \"DCP\" tab.")); - _text->Newline (); - } - - if (film->video_frame_rate() != 24 && film->video_frame_rate() != 48) { - hint = true; - _text->WriteText (wxString::Format (_("Your DCP frame rate (%d fps) may cause problems in a few (mostly older) projectors. Use 24 or 48 frames per second to be on the safe side."), film->video_frame_rate())); - _text->Newline (); - } + _gauge->Show (); + _gauge_message->Show (); + Layout (); + _gauge->SetValue (0); + update (); + _finished = false; + + _hints.reset (new Hints (_film)); + _hints->Hint.connect (bind (&HintsDialog::hint, this, _1)); + _hints->Progress.connect (bind (&HintsDialog::progress, this, _1)); + _hints->Pulse.connect (bind (&HintsDialog::pulse, this)); + _hints->Finished.connect (bind (&HintsDialog::finished, this)); + _hints->start (); +} - if (film->j2k_bandwidth() >= 245000000) { - hint = true; - _text->WriteText (_("A few projectors have problems playing back very high bit-rate DCPs. It is a good idea to drop the JPEG2000 bandwidth down to about 200Mbit/s; this is unlikely to have any visible effect on the image.")); - _text->Newline (); - } +void +HintsDialog::film_content_change (ChangeType type) +{ + film_change (type); +} - int vob = 0; - for (ContentList::const_iterator i = content.begin(); i != content.end(); ++i) { - if (boost::algorithm::starts_with ((*i)->path(0).filename().string(), "VTS_")) { - ++vob; +void +HintsDialog::update () +{ + _text->Clear (); + if (_current.empty ()) { + if (_finished) { + _text->WriteText (_("There are no hints: everything looks good!")); + } else { + _text->WriteText (_("There are no hints yet: project check in progress.")); + } + } else { + _text->BeginStandardBullet (N_("standard/circle"), 1, 50); + BOOST_FOREACH (string i, _current) { + _text->WriteText (std_to_wx (i)); + _text->Newline (); } + _text->EndSymbolBullet (); } +} - if (vob > 1) { - hint = true; - _text->WriteText (wxString::Format (_("You have %d files that look like they are VOB files from DVD. You should join them to ensure smooth joins between the files."), vob)); - _text->Newline (); - } +void +HintsDialog::hint (string text) +{ + _current.push_back (text); + update (); +} - int three_d = 0; - for (ContentList::const_iterator i = content.begin(); i != content.end(); ++i) { - shared_ptr vc = dynamic_pointer_cast (*i); - if (vc && vc->video_frame_type() != VIDEO_FRAME_TYPE_2D) { - ++three_d; - } - } +void +HintsDialog::shut_up (wxCommandEvent& ev) +{ + Config::instance()->set_show_hints_before_make_dcp (!ev.IsChecked()); +} + +void +HintsDialog::pulse () +{ + _gauge->Pulse (); +} - if (three_d > 0) { - hint = true; - _text->WriteText (_("You are using 3D content but your DCP is set to 2D. Set the DCP to 3D if you want to play it back on a 3D system (e.g. Real-D, MasterImage etc.)")); - _text->Newline (); +void +HintsDialog::finished () +{ + try { + _hints->rethrow (); + } catch (std::exception& e) { + error_dialog (this, wxString::Format(_("A problem occurred when looking for hints (%s)"), std_to_wx(e.what()))); } - _text->EndSymbolBullet (); + _finished = true; + update (); + _gauge->Hide (); + _gauge_message->Hide (); + Layout (); +} - if (!hint) { - _text->WriteText (_("There are no hints: everything looks good!")); - } +void +HintsDialog::progress (string m) +{ + _gauge_message->SetLabel (std_to_wx(m)); }