X-Git-Url: https://main.carlh.net/gitweb/?p=dcpomatic.git;a=blobdiff_plain;f=src%2Fwx%2Ftimecode.cc;h=1ab4b590b2b130b4f7d0c80cd21c766c6706ff41;hp=7208bd4c6672e6b18ae8bb70afb4ed07d8cf0215;hb=854f2e5bbb7ffb9758b823af87034033033f3cb8;hpb=1629bd7df2150156109afbc7a16677cb29e82adf diff --git a/src/wx/timecode.cc b/src/wx/timecode.cc index 7208bd4c6..1ab4b590b 100644 --- a/src/wx/timecode.cc +++ b/src/wx/timecode.cc @@ -85,34 +85,38 @@ Timecode::Timecode (wxWindow* parent) void Timecode::set (DCPTime t, int fps) { - int const h = t / (3600 * TIME_HZ); - t -= h * 3600 * TIME_HZ; - int const m = t / (60 * TIME_HZ); - t -= m * 60 * TIME_HZ; - int const s = t / TIME_HZ; - t -= s * TIME_HZ; - int const f = divide_with_round (t * fps, TIME_HZ); + /* Do this calculation with frames so that we can round + to a frame boundary at the start rather than the end. + */ + int64_t f = rint (t.seconds() * fps); + + int const h = f / (3600 * fps); + f -= h * 3600 * fps; + int const m = f / (60 * fps); + f -= m * 60 * fps; + int const s = f / fps; + f -= s * fps; checked_set (_hours, lexical_cast (h)); checked_set (_minutes, lexical_cast (m)); checked_set (_seconds, lexical_cast (s)); checked_set (_frames, lexical_cast (f)); - _fixed->SetLabel (wxString::Format ("%02d:%02d:%02d.%02d", h, m, s, f)); + _fixed->SetLabel (wxString::Format ("%02d:%02d:%02d.%02" wxLongLongFmtSpec "d", h, m, s, f)); } DCPTime Timecode::get (int fps) const { - DCPTime t = 0; + DCPTime t; string const h = wx_to_std (_hours->GetValue ()); - t += lexical_cast (h.empty() ? "0" : h) * 3600 * TIME_HZ; + t += DCPTime::from_seconds (lexical_cast (h.empty() ? "0" : h) * 3600); string const m = wx_to_std (_minutes->GetValue()); - t += lexical_cast (m.empty() ? "0" : m) * 60 * TIME_HZ; + t += DCPTime::from_seconds (lexical_cast (m.empty() ? "0" : m) * 60); string const s = wx_to_std (_seconds->GetValue()); - t += lexical_cast (s.empty() ? "0" : s) * TIME_HZ; + t += DCPTime::from_seconds (lexical_cast (s.empty() ? "0" : s)); string const f = wx_to_std (_frames->GetValue()); - t += lexical_cast (f.empty() ? "0" : f) * TIME_HZ / fps; + t += DCPTime::from_seconds (lexical_cast (f.empty() ? "0" : f) / fps); return t; }