More tidying up.
authorCarl Hetherington <cth@carlh.net>
Thu, 21 Nov 2019 23:10:35 +0000 (00:10 +0100)
committerCarl Hetherington <cth@carlh.net>
Wed, 8 Jan 2020 20:56:47 +0000 (21:56 +0100)
src/wx/film_viewer.cc
src/wx/gl_video_view.cc
src/wx/simple_video_view.cc
src/wx/simple_video_view.h
src/wx/video_view.cc
src/wx/video_view.h

index df66a8a..c7b32ff 100644 (file)
@@ -406,16 +406,7 @@ FilmViewer::slow_refresh ()
 bool
 FilmViewer::quick_refresh ()
 {
-       if (!_video_view->_player_video.first) {
-               return false;
-       }
-
-       if (!_video_view->_player_video.first->reset_metadata (_film, _player->video_container_size(), _film->frame_size())) {
-               return false;
-       }
-
-       _video_view->display_player_video ();
-       return true;
+       return _video_view->refresh_metadata (_film, _player->video_container_size(), _film->frame_size());
 }
 
 void
index 869d555..2da16f1 100644 (file)
@@ -325,7 +325,6 @@ try
                        }
 
                        get_next_frame (false);
-                       //--
                        set_image (player_video().first->image(bind(&PlayerVideo::force, _1, AV_PIX_FMT_RGB24), false, true));
                        inter_position = player_video().first->inter_position();
                        inter_size = player_video().first->inter_size();
index 22e4db8..6eabbc0 100644 (file)
@@ -134,9 +134,9 @@ SimpleVideoView::paint ()
 }
 
 void
-SimpleVideoView::update ()
+SimpleVideoView::refresh_panel ()
 {
-       _state_timer.set ("update-view");
+       _state_timer.set ("refresh-panel");
        _panel->Refresh ();
        _panel->Update ();
        _state_timer.unset ();
@@ -193,7 +193,7 @@ SimpleVideoView::display_next_frame (bool non_blocking)
                }
        }
 
-       display_player_video ();
+       update ();
 
        try {
                _viewer->butler()->rethrow ();
@@ -205,11 +205,11 @@ SimpleVideoView::display_next_frame (bool non_blocking)
 }
 
 void
-SimpleVideoView::display_player_video ()
+SimpleVideoView::update ()
 {
        if (!player_video().first) {
                set_image (shared_ptr<Image>());
-               update ();
+               refresh_panel ();
                return;
        }
 
@@ -252,5 +252,5 @@ SimpleVideoView::display_player_video ()
        _inter_position = player_video().first->inter_position ();
        _inter_size = player_video().first->inter_size ();
 
-       update ();
+       refresh_panel ();
 }
index 86451fa..a6a5cf4 100644 (file)
@@ -43,9 +43,9 @@ public:
        bool display_next_frame (bool non_blocking);
 
 private:
+       void refresh_panel ();
        void paint ();
        void timer ();
-       void display_player_video ();
 
        wxPanel* _panel;
        boost::shared_ptr<const Image> _image;
index ee14f4a..7e9e1a9 100644 (file)
@@ -110,3 +110,20 @@ VideoView::start ()
        boost::mutex::scoped_lock lm (_mutex);
        _dropped = 0;
 }
+
+bool
+VideoView::refresh_metadata (shared_ptr<const Film> film, dcp::Size video_container_size, dcp::Size film_frame_size)
+{
+       boost::mutex::scoped_lock lm (_mutex);
+       if (!_player_video.first) {
+               return false;
+       }
+
+       if (!_player_video.first->reset_metadata (film, video_container_size, film_frame_size)) {
+               return false;
+       }
+
+       update ();
+       return true;
+}
+
index 5d5d331..ad492bd 100644 (file)
@@ -41,25 +41,25 @@ public:
        VideoView (FilmViewer* viewer);
        virtual ~VideoView () {}
 
-       virtual void set_image (boost::shared_ptr<const Image> image) = 0;
+       /** @return the thing displaying the image */
        virtual wxWindow* get () const = 0;
-       /** Redraw the view after something has changed like content outlining,
-        *  the film being removed, etc.
-        */
+       /** Re-make and display the image from the current _player_video */
        virtual void update () = 0;
-
+       /** Called when playback starts */
        virtual void start ();
-       /* XXX_b: make pure */
+       /** Called when playback stops */
        virtual void stop () {}
+       /** Get the next frame and display it; used after seek */
+       virtual bool display_next_frame (bool) = 0;
 
        void clear ();
+       bool refresh_metadata (boost::shared_ptr<const Film> film, dcp::Size video_container_size, dcp::Size film_frame_size);
 
+       /** Emitted from the GUI thread when our display changes in size */
        boost::signals2::signal<void()> Sized;
 
-       virtual bool display_next_frame (bool) = 0;
 
-       /* XXX_b: to remove */
-       virtual void display_player_video () {}
+       /* Accessors for FilmViewer */
 
        int dropped () const {
                boost::mutex::scoped_lock lm (_mutex);
@@ -80,6 +80,11 @@ public:
                return _player_video.second;
        }
 
+
+       /* Setters for FilmViewer so it can tell us our state and
+        * we can then use (thread) safely.
+        */
+
        void set_video_frame_rate (int r) {
                boost::mutex::scoped_lock lm (_mutex);
                _video_frame_rate = r;
@@ -101,9 +106,6 @@ public:
        }
 
 protected:
-       /* XXX_b: to remove */
-       friend class FilmViewer;
-
        bool get_next_frame (bool non_blocking);
        int time_until_next_frame () const;
        dcpomatic::DCPTime one_video_frame () const;
@@ -144,7 +146,7 @@ protected:
        StateTimer _state_timer;
 
 private:
-       /** Mutex protecting all the state in VideoView */
+       /** Mutex protecting all the state in this class */
        mutable boost::mutex _mutex;
 
        std::pair<boost::shared_ptr<PlayerVideo>, dcpomatic::DCPTime> _player_video;