Extend the amount of allowed disagreement between the audio

coming from the content and the calculated periods of silence.

It sees that there is some scope for disagreements here when
trim start/end times are rounded to frame boundaries.

Fixes #1708.

diff --git a/src/lib/player.cc b/src/lib/player.cc
index c88be58266251da86ecb85a91ea3d2e96b4426f7..79db7cc2c76d1695ac3201a09a1a470ecc360b30 100644 (file)
--- a/src/lib/player.cc
+++ b/src/lib/player.cc
@@ -652,7 +652,8 @@ Player::pass ()
                           remove a little silence at the end of some content.
                        */
                        int64_t const error = labs(period.from.get() - _last_audio_time->get());
-                       int64_t const too_much_error = 4;
+                       /* Let's not worry about less than a frame at 24fps */
+                       int64_t const too_much_error = DCPTime::from_frames(1, 24).get();
                        if (error >= too_much_error) {
                                _film->log()->log(String::compose("Silence starting before or after last audio by %1", error), LogEntry::TYPE_ERROR);
                        }