From: Carl Hetherington <cth@carlh.net>
Date: Sun, 1 May 2022 17:35:26 +0000 (+0200)
Subject: Make sure that crop preview rectangle is properly hidden when we close the auto crop... 
X-Git-Tag: merged-to-main^0
X-Git-Url: https://main.carlh.net/gitweb/?p=dcpomatic.git;a=commitdiff_plain;h=09df98b2b47f6f9a754d5ff8a1787da5a07c14b4

Make sure that crop preview rectangle is properly hidden when we close the auto crop dialog.
---

diff --git a/src/wx/content_menu.cc b/src/wx/content_menu.cc
index ed515f6c8..93bcc0a6d 100644
--- a/src/wx/content_menu.cc
+++ b/src/wx/content_menu.cc
@@ -602,13 +602,13 @@ ContentMenu::auto_crop ()
 
 	/* Handle the user closing the dialog (with OK or cancel) */
 	_auto_crop_dialog->Bind (wxEVT_BUTTON, [this, viewer](wxCommandEvent& ev) {
+		_auto_crop_config_connection.disconnect ();
+		_auto_crop_viewer_connection.disconnect ();
 		if (ev.GetId() == wxID_OK) {
 			_content.front()->video->set_crop(_auto_crop_dialog->get());
 		}
 		_auto_crop_dialog->Show (false);
 		viewer->unset_crop_guess ();
-		_auto_crop_config_connection.disconnect ();
-		_auto_crop_viewer_connection.disconnect ();
 	});
 
 	/* Update the view when something in the dialog is changed */