From: Carl Hetherington <cth@carlh.net>
Date: Tue, 19 May 2020 23:51:25 +0000 (+0200)
Subject: Difficult to see how any unprotected write with multiple readers
X-Git-Tag: v2.15.76~18
X-Git-Url: https://main.carlh.net/gitweb/?p=dcpomatic.git;a=commitdiff_plain;h=93f6b7f36dba0eed49936dcd014a9cf5941a66ac;ds=sidebyside

Difficult to see how any unprotected write with multiple readers
could be safe.
---

diff --git a/src/lib/writer.cc b/src/lib/writer.cc
index d346c4a4f..699f220c4 100644
--- a/src/lib/writer.cc
+++ b/src/lib/writer.cc
@@ -777,10 +777,9 @@ Writer::video_reel (int frame) const
 void
 Writer::set_digest_progress (Job* job, float progress)
 {
-	/* I believe this is thread-safe */
-	_digest_progresses[boost::this_thread::get_id()] = progress;
-
 	boost::mutex::scoped_lock lm (_digest_progresses_mutex);
+
+	_digest_progresses[boost::this_thread::get_id()] = progress;
 	float min_progress = FLT_MAX;
 	for (map<boost::thread::id, float>::const_iterator i = _digest_progresses.begin(); i != _digest_progresses.end(); ++i) {
 		min_progress = min (min_progress, i->second);