From: Carl Hetherington <cth@carlh.net>
Date: Wed, 30 Oct 2019 21:38:50 +0000 (+0000)
Subject: Remove an optimisation to not run the body of ContentPanel::check_selection
X-Git-Tag: v2.14.13~1
X-Git-Url: https://main.carlh.net/gitweb/?p=dcpomatic.git;a=commitdiff_plain;h=c51e34376ea3abe67d02be88ff3fbe9fe24cb5ef

Remove an optimisation to not run the body of ContentPanel::check_selection
if it is called with an unchanged selection.  It breaks updates
of the available tabs when a OV is added to a VF DCP, or when a new CPL
is chosen that has subs where the previous one did not.

Backport from d038abd7a0dce09aa84101c45af5ec8e4086e64f in v2.15.x.
---

diff --git a/src/wx/content_panel.cc b/src/wx/content_panel.cc
index d22e45401..18318d4b2 100644
--- a/src/wx/content_panel.cc
+++ b/src/wx/content_panel.cc
@@ -298,13 +298,6 @@ ContentPanel::item_selected ()
 void
 ContentPanel::check_selection ()
 {
-	if (_last_selected == selected()) {
-		/* This was triggered by a re-build of the view but the selection
-		   did not really change.
-		*/
-		return;
-	}
-
 	_last_selected = selected ();
 
 	setup_sensitivity ();