From: Carl Hetherington <cth@carlh.net>
Date: Sat, 21 Nov 2020 21:38:45 +0000 (+0100)
Subject: Add hint when making a FTR without FFEC/FFMC markers (#1804).
X-Git-Tag: v2.15.108~23
X-Git-Url: https://main.carlh.net/gitweb/?p=dcpomatic.git;a=commitdiff_plain;h=ce058471aa9995adac968cecc205f5a4319f449e

Add hint when making a FTR without FFEC/FFMC markers (#1804).
---

diff --git a/src/lib/hints.cc b/src/lib/hints.cc
index 6228f0a48..14022bb59 100644
--- a/src/lib/hints.cc
+++ b/src/lib/hints.cc
@@ -1,5 +1,5 @@
 /*
-    Copyright (C) 2016-2019 Carl Hetherington <cth@carlh.net>
+    Copyright (C) 2016-2020 Carl Hetherington <cth@carlh.net>
 
     This file is part of DCP-o-matic.
 
@@ -18,6 +18,7 @@
 
 */
 
+#include "dcp_content_type.h"
 #include "hints.h"
 #include "types.h"
 #include "film.h"
@@ -326,6 +327,7 @@ Hints::thread ()
 	check_vob ();
 	check_3d_in_2d ();
 	check_loudness ();
+	check_ffec_and_ffmc_in_smpte_feature ();
 
 	emit (bind(boost::ref(Progress), _("Examining closed captions")));
 
@@ -403,3 +405,13 @@ Hints::film () const
 	DCPOMATIC_ASSERT (film);
 	return film;
 }
+
+
+void
+Hints::check_ffec_and_ffmc_in_smpte_feature ()
+{
+	shared_ptr<const Film> f = film();
+	if (!f->interop() && f->dcp_content_type()->libdcp_kind() == dcp::FEATURE && (!f->marker(dcp::FFEC) || !f->marker(dcp::FFMC))) {
+		hint (_("SMPTE DCPs with the type FTR (feature) should have markers for the first frame of end credits (FFEC) and the first frame of moving credits (FFMC).  You should add these markers using the 'Markers' button in the DCP tab."));
+	}
+}
diff --git a/src/lib/hints.h b/src/lib/hints.h
index 7a9074625..b5a26998d 100644
--- a/src/lib/hints.h
+++ b/src/lib/hints.h
@@ -61,6 +61,7 @@ private:
 	void check_vob ();
 	void check_3d_in_2d ();
 	void check_loudness ();
+	void check_ffec_and_ffmc_in_smpte_feature ();
 
 	boost::weak_ptr<const Film> _film;
 	boost::thread _thread;