dcpomatic.git
8 weeks agoStore subtitle language(s) in Film, and allow setup of those
Carl Hetherington [Wed, 18 Nov 2020 00:06:49 +0000 (01:06 +0100)]
Store subtitle language(s) in Film, and allow setup of those
languages from the Interop/SMPTE metadata dialogues.

8 weeks agoTidy up button alignment.
Carl Hetherington [Tue, 17 Nov 2020 22:19:19 +0000 (23:19 +0100)]
Tidy up button alignment.

8 weeks agoMove labelling out of LanguageTagWidget.
Carl Hetherington [Tue, 17 Nov 2020 21:06:49 +0000 (22:06 +0100)]
Move labelling out of LanguageTagWidget.

8 weeks agoMove make_black_test into image_test.
Carl Hetherington [Fri, 20 Nov 2020 21:53:34 +0000 (22:53 +0100)]
Move make_black_test into image_test.

8 weeks agoSome tidying up of test Doxygen.
Carl Hetherington [Fri, 20 Nov 2020 21:53:10 +0000 (22:53 +0100)]
Some tidying up of test Doxygen.

8 weeks agoAlways add FFOC and LFOC markers (#1805).
Carl Hetherington [Fri, 20 Nov 2020 21:51:15 +0000 (22:51 +0100)]
Always add FFOC and LFOC markers (#1805).

8 weeks agoTweak comment containing Doxygen text group name.
Carl Hetherington [Fri, 20 Nov 2020 21:25:55 +0000 (22:25 +0100)]
Tweak comment containing Doxygen text group name.

8 weeks agoDisable video range control for DCP content (#1821).
Carl Hetherington [Fri, 20 Nov 2020 20:59:02 +0000 (21:59 +0100)]
Disable video range control for DCP content (#1821).

8 weeks agoTry to enable all streams in MOV exports.
Carl Hetherington [Fri, 7 Aug 2020 21:41:15 +0000 (23:41 +0200)]
Try to enable all streams in MOV exports.

This is a speculative fix which I haven't tested.

2 months agoMake the default disk writer window wider.
Carl Hetherington [Wed, 18 Nov 2020 00:46:21 +0000 (01:46 +0100)]
Make the default disk writer window wider.

2 months agoFix strange OR operator.
Carl Hetherington [Mon, 16 Nov 2020 23:24:47 +0000 (00:24 +0100)]
Fix strange OR operator.

2 months agoFix cropping of subsampled images.
Carl Hetherington [Mon, 16 Nov 2020 23:00:50 +0000 (00:00 +0100)]
Fix cropping of subsampled images.

The calculations for how to crop subsampled components of YUV images
were wrong, causing strange effects like misregistration of colour
components in cropped images.  Should fix #1872.

2 months agoAdd some lrintf() calls to be sure.
Carl Hetherington [Mon, 16 Nov 2020 22:58:53 +0000 (23:58 +0100)]
Add some lrintf() calls to be sure.

2 months agoUse 64-byte alignment for aligned image memory.
Carl Hetherington [Mon, 16 Nov 2020 22:56:11 +0000 (23:56 +0100)]
Use 64-byte alignment for aligned image memory.

FFmpeg uses this values if AVX512 is available, and with only
32-byte alignment I am seeing strange scaling effects whereby
crop_scale_window_test7 gives black bars down the right side of
cropped images (when run on an i7 7700).

2 months agoBump libdcp for const fix.
Carl Hetherington [Sun, 15 Nov 2020 23:38:23 +0000 (00:38 +0100)]
Bump libdcp for const fix.

2 months agoUpdate test references following 26bd62d1e49b63e47fca820c5b4d36c5dacb9bfd
Carl Hetherington [Sun, 15 Nov 2020 23:32:41 +0000 (00:32 +0100)]
Update test references following 26bd62d1e49b63e47fca820c5b4d36c5dacb9bfd

2 months agoAdd tests of video range.
Carl Hetherington [Sun, 15 Nov 2020 19:50:39 +0000 (20:50 +0100)]
Add tests of video range.

These should hopefully cover all combinations of input and output
range.  Fixes #1851.

2 months agoMake sure we use limited ("video") range data when exporting.
Carl Hetherington [Sun, 15 Nov 2020 19:47:42 +0000 (20:47 +0100)]
Make sure we use limited ("video") range data when exporting.

Our export formats all currently use limited range but we weren't
making sure data fed to the encoders was limited range.

Should fix #1832.

2 months agoAdd catch-all assertion.
Carl Hetherington [Mon, 9 Nov 2020 00:12:10 +0000 (01:12 +0100)]
Add catch-all assertion.

2 months agoFix unnecessary condition.
Carl Hetherington [Mon, 9 Nov 2020 00:12:05 +0000 (01:12 +0100)]
Fix unnecessary condition.

2 months agoFix thinko-ed logic causing all subtitles to be treated as though
Carl Hetherington [Mon, 9 Nov 2020 00:11:20 +0000 (01:11 +0100)]
Fix thinko-ed logic causing all subtitles to be treated as though
they have borders.  This fix will cause some movement of border-less
subtitles (in existing projects) within the video frame.

2 months agoRemove unused code.
Carl Hetherington [Mon, 9 Nov 2020 00:09:22 +0000 (01:09 +0100)]
Remove unused code.

2 months agoFix limited value ranges in properties.
Carl Hetherington [Sun, 8 Nov 2020 22:36:58 +0000 (23:36 +0100)]
Fix limited value ranges in properties.

2 months agoRemove pointless comment.
Carl Hetherington [Sun, 8 Nov 2020 21:37:34 +0000 (22:37 +0100)]
Remove pointless comment.

2 months agoObey requests to change the video range of RGB content.
Carl Hetherington [Sun, 8 Nov 2020 21:34:18 +0000 (22:34 +0100)]
Obey requests to change the video range of RGB content.

Video that comes in with RGB pixels will not have its video level
ranges changed by libswscale (it only does this for YUV and greyscale).
Here we add code to do it ourselves for RGB content coming in
via image files (e.g. PNG/DPX etc).  Part of #1851.

2 months agoAdd some more pixel formats to hack/pixfmts.c
Carl Hetherington [Sun, 8 Nov 2020 21:28:24 +0000 (22:28 +0100)]
Add some more pixel formats to hack/pixfmts.c

2 months agoAdd LanguageTagWidget and use it for the SMPTE metadata.
Carl Hetherington [Sun, 15 Nov 2020 22:16:56 +0000 (23:16 +0100)]
Add LanguageTagWidget and use it for the SMPTE metadata.

2 months agoFix invisible subtag lists in some cases.
Carl Hetherington [Sun, 15 Nov 2020 22:15:57 +0000 (23:15 +0100)]
Fix invisible subtag lists in some cases.

On Debian 10 / GTK3 (at least) sometimes when you add a new subtag
the searchable list isn't displayed until you scroll it a little.

This hack seems to fix that.

2 months agoAdd Remove button to language tag dialogue.
Carl Hetherington [Sun, 15 Nov 2020 21:36:59 +0000 (22:36 +0100)]
Add Remove button to language tag dialogue.

2 months agoImprove text panel layout with GTK3's enormous spin controls.
Carl Hetherington [Sun, 15 Nov 2020 20:25:09 +0000 (21:25 +0100)]
Improve text panel layout with GTK3's enormous spin controls.

2 months agoFix uninitialised variable (affecting tests only).
Carl Hetherington [Sat, 14 Nov 2020 16:22:26 +0000 (17:22 +0100)]
Fix uninitialised variable (affecting tests only).

2 months agoFix finding of subtitles when clicking in the list view.
Carl Hetherington [Fri, 13 Nov 2020 16:37:08 +0000 (17:37 +0100)]
Fix finding of subtitles when clicking in the list view.

I didn't look into this as deeply as I probably should have, but
it seems there's some rounding error which means we don't always
hit the subtitle's frame unless we add one on.

2 months agoMore vertical alignment fixes.
Carl Hetherington [Fri, 13 Nov 2020 16:37:04 +0000 (17:37 +0100)]
More vertical alignment fixes.

2 months agoRemove assertion checking that rotations are a multiple of 90.
Carl Hetherington [Wed, 11 Nov 2020 22:35:32 +0000 (23:35 +0100)]
Remove assertion checking that rotations are a multiple of 90.

This is checked later, anyway (without asserting) and we have seen
files in the wild with other rotations (e.g. -135.62) which do not
appear to need rotation to be applied.

Fixes #1871.

Backported-from-commit: f235ed07f969e1b8b9d3d05082dcdd68ceae771e
Backported-from-branch: master

2 months agoRemove references to / support for old RtError class (now RtAudioError).
Carl Hetherington [Sun, 8 Nov 2020 21:13:34 +0000 (22:13 +0100)]
Remove references to / support for old RtError class (now RtAudioError).

2 months agoFix start_player() on macOS (#1870). v2.15.107
Carl Hetherington [Thu, 5 Nov 2020 20:36:32 +0000 (21:36 +0100)]
Fix start_player() on macOS (#1870).

2 months agoRename a variable and add some logging to start_tool on macOS.
Carl Hetherington [Thu, 5 Nov 2020 20:36:16 +0000 (21:36 +0100)]
Rename a variable and add some logging to start_tool on macOS.

2 months agoFix video waveform view with GL backend.
Carl Hetherington [Thu, 5 Nov 2020 21:12:27 +0000 (22:12 +0100)]
Fix video waveform view with GL backend.

2 months agoFix some alignment.
Carl Hetherington [Thu, 5 Nov 2020 20:52:07 +0000 (21:52 +0100)]
Fix some alignment.

2 months agoRe-add mutex that was taken away in
Carl Hetherington [Wed, 4 Nov 2020 22:33:10 +0000 (23:33 +0100)]
Re-add mutex that was taken away in
73ebb92e9df01ba7afb97121b6e2cef6ca13a18e

I'm not sure why it was removed, and it seems necessary;
servers_list_changed() can be called from a variety of different places
(the constructor and two different EncodeServerFinder threads).

May help with #1854.

2 months agoMove video frame rate override into advanced prefs (#1852).
Carl Hetherington [Tue, 3 Nov 2020 23:17:53 +0000 (00:17 +0100)]
Move video frame rate override into advanced prefs (#1852).

2 months agoFix crash on Linux (and maybe others).
Carl Hetherington [Tue, 3 Nov 2020 23:15:30 +0000 (00:15 +0100)]
Fix crash on Linux (and maybe others).

Calling _canvas->SetCurrent() without the canvas being on screen
causes a crash on Linux (and maybe elsewhere).

2 months agoRevert "Re-allow audio channel 15 to be mapped so that users can add"
Carl Hetherington [Tue, 3 Nov 2020 19:52:56 +0000 (20:52 +0100)]
Revert "Re-allow audio channel 15 to be mapped so that users can add"

This reverts commit 4cf45229bf55344e708fead769f694f13bacf39c.
It's wrong - the sign language channel is 15 (1-indexed) not 15
(0-indexed) as in this commit.

2 months agoAdd some tests. v2.15.106
Carl Hetherington [Sun, 1 Nov 2020 23:11:50 +0000 (00:11 +0100)]
Add some tests.

2 months agoPass around JPEG2000 data as a shared_ptr and hence avoid a copy
Carl Hetherington [Sun, 1 Nov 2020 22:51:19 +0000 (23:51 +0100)]
Pass around JPEG2000 data as a shared_ptr and hence avoid a copy
of 4MB of data for every JPEG2000 frame we decode.

2 months agoReplace dcp::Data with dcp::ArrayData
Carl Hetherington [Sun, 1 Nov 2020 22:40:01 +0000 (23:40 +0100)]
Replace dcp::Data with dcp::ArrayData

2 months agoBump libdcp for new dcp::ArrayData stuff.
Carl Hetherington [Sun, 1 Nov 2020 23:18:22 +0000 (00:18 +0100)]
Bump libdcp for new dcp::ArrayData stuff.

2 months agoRe-allow audio channel 15 to be mapped so that users can add
Carl Hetherington [Mon, 2 Nov 2020 22:08:01 +0000 (23:08 +0100)]
Re-allow audio channel 15 to be mapped so that users can add
their own sign language tracks until DoM supports them properly.

2 months agoAdd some comments.
Carl Hetherington [Wed, 28 Oct 2020 15:25:01 +0000 (16:25 +0100)]
Add some comments.

2 months agoPrevent import of directories as DCPs if they do not have an
Carl Hetherington [Wed, 28 Oct 2020 11:48:48 +0000 (12:48 +0100)]
Prevent import of directories as DCPs if they do not have an
ASSETMAP{,.xml} in the top level.

This should avoid some confusion, as previously DoM would scan the
whole directory tree looking for an ASSETMAP.  It also prevents
people adding a DCP-o-matic project to itself, which I believe is the
cause of #1620.

2 months agoAdd uninstaller for the .pkg part of the disk writer on macOS (#1740).
Carl Hetherington [Sat, 24 Oct 2020 18:44:24 +0000 (20:44 +0200)]
Add uninstaller for the .pkg part of the disk writer on macOS (#1740).

2 months agoCatch more errors when non-CPLs are loaded as CPLs.
Carl Hetherington [Mon, 26 Oct 2020 13:06:55 +0000 (14:06 +0100)]
Catch more errors when non-CPLs are loaded as CPLs.

Backported-from-commit: b73549f6c4f13e8ef5cadebbc767829aea5a2c16
Backported-from-branch: master

2 months agoFix Ubuntu 20.10 dependencies.
Carl Hetherington [Sun, 25 Oct 2020 21:04:47 +0000 (22:04 +0100)]
Fix Ubuntu 20.10 dependencies.

2 months agoRemove unnecessary Ubuntu 20.04 dependency on wxWidgets.
Carl Hetherington [Sun, 25 Oct 2020 21:04:44 +0000 (22:04 +0100)]
Remove unnecessary Ubuntu 20.04 dependency on wxWidgets.

2 months agoEnable disable-library-validation entitlement to allow use of @executable_path v2.15.105
Carl Hetherington [Sat, 24 Oct 2020 21:18:23 +0000 (23:18 +0200)]
Enable disable-library-validation entitlement to allow use of @executable_path

2 months agoWhite space tweak.
Carl Hetherington [Fri, 23 Oct 2020 22:45:48 +0000 (00:45 +0200)]
White space tweak.

2 months agoFix some label alignments.
Carl Hetherington [Fri, 23 Oct 2020 21:58:43 +0000 (23:58 +0200)]
Fix some label alignments.

2 months agomacOS / new boost build fixes. v2.15.104
Carl Hetherington [Wed, 21 Oct 2020 07:23:12 +0000 (09:23 +0200)]
macOS / new boost build fixes.

2 months agoBump libdcp for build fixes.
Carl Hetherington [Tue, 20 Oct 2020 23:04:20 +0000 (01:04 +0200)]
Bump libdcp for build fixes.

2 months agoBump libdcp for macOS warning fixes.
Carl Hetherington [Tue, 20 Oct 2020 20:17:40 +0000 (22:17 +0200)]
Bump libdcp for macOS warning fixes.

2 months agoTry to improve splitter behaviour when shrinking and then enlarging
Carl Hetherington [Tue, 20 Oct 2020 19:10:49 +0000 (21:10 +0200)]
Try to improve splitter behaviour when shrinking and then enlarging
the main window (#1839).

2 months agoMove the LimitedSplitter constructor into the .cc file.
Carl Hetherington [Tue, 20 Oct 2020 15:03:08 +0000 (17:03 +0200)]
Move the LimitedSplitter constructor into the .cc file.

2 months agoMove contents of ContentPanel::first_shown into LimitedSplitter.
Carl Hetherington [Tue, 20 Oct 2020 14:52:04 +0000 (16:52 +0200)]
Move contents of ContentPanel::first_shown into LimitedSplitter.

2 months agoMove LimitedSplitter into the header file.
Carl Hetherington [Tue, 20 Oct 2020 14:39:09 +0000 (16:39 +0200)]
Move LimitedSplitter into the header file.

3 months agoPlaylist editor: try to make progress dialogue appear sooner when scanning content.
Carl Hetherington [Mon, 19 Oct 2020 21:22:25 +0000 (23:22 +0200)]
Playlist editor: try to make progress dialogue appear sooner when scanning content.

3 months agoPlaylist editor: save configuration when it changes.
Carl Hetherington [Mon, 19 Oct 2020 21:21:51 +0000 (23:21 +0200)]
Playlist editor: save configuration when it changes.

3 months agoPlaylist editor: update content list when configuration changes.
Carl Hetherington [Mon, 19 Oct 2020 21:21:13 +0000 (23:21 +0200)]
Playlist editor: update content list when configuration changes.

3 months agoAdd some icons missing from the macOS build.
Carl Hetherington [Sun, 18 Oct 2020 22:07:28 +0000 (00:07 +0200)]
Add some icons missing from the macOS build.

3 months agomacOS build fix.
Carl Hetherington [Sun, 18 Oct 2020 19:43:03 +0000 (21:43 +0200)]
macOS build fix.

3 months agoTidy up and fix bitmap path finding in the playlist editor.
Carl Hetherington [Sun, 18 Oct 2020 18:01:44 +0000 (20:01 +0200)]
Tidy up and fix bitmap path finding in the playlist editor.

3 months agoAdd missing files from share/libdcp to .deb packages.
Carl Hetherington [Sun, 18 Oct 2020 20:16:50 +0000 (22:16 +0200)]
Add missing files from share/libdcp to .deb packages.

3 months agoFix typo.
Carl Hetherington [Sun, 18 Oct 2020 18:00:25 +0000 (20:00 +0200)]
Fix typo.

3 months agoClarify some error messages on macOS (#1837). jenkins
Carl Hetherington [Sat, 17 Oct 2020 22:16:25 +0000 (00:16 +0200)]
Clarify some error messages on macOS (#1837).

When we say we can't start a particular tool, it may be because it
has not even been downloaded/installed.

3 months agoFix failure to update player information when changing CPLs.
Carl Hetherington [Sat, 17 Oct 2020 20:25:40 +0000 (22:25 +0200)]
Fix failure to update player information when changing CPLs.

3 months agoFix deadlock when changing CPL in the player (#1827).
Carl Hetherington [Sat, 17 Oct 2020 20:23:12 +0000 (22:23 +0200)]
Fix deadlock when changing CPL in the player (#1827).

TextContent::set_dcp_track can end up requesting a view update, which
involves calls to methods in Content which lock the Content::_mutex.
Do these calls without a lock on that mutex held.

Also, it looks like we would append to texts on every call to
examine().  Fix that so that we replace the texts list on each
examine() call.

3 months agoFix finding of graphics when running from the source tree on Linux.
Carl Hetherington [Sat, 17 Oct 2020 20:23:01 +0000 (22:23 +0200)]
Fix finding of graphics when running from the source tree on Linux.

3 months agoTest script tweaks for Windows.
Carl Hetherington [Thu, 15 Oct 2020 11:53:39 +0000 (13:53 +0200)]
Test script tweaks for Windows.

3 months agoAdd test for #1857.
Carl Hetherington [Wed, 14 Oct 2020 19:43:21 +0000 (21:43 +0200)]
Add test for #1857.

3 months agoFix test DCP index.
Carl Hetherington [Wed, 14 Oct 2020 19:29:19 +0000 (21:29 +0200)]
Fix test DCP index.

3 months agoDon't crash if the first packet in a stream has AV_NOPTS_VALUE;
Carl Hetherington [Wed, 14 Oct 2020 19:24:57 +0000 (21:24 +0200)]
Don't crash if the first packet in a stream has AV_NOPTS_VALUE;
instead, assume it should be at timestamp 0.

3 months agoClear out _next_time when seeking, so out-of-date values don't
Carl Hetherington [Wed, 14 Oct 2020 19:23:36 +0000 (21:23 +0200)]
Clear out _next_time when seeking, so out-of-date values don't
hang around.  Part of the fix for #1857.

3 months agocscript can now run tests on Windows.
Carl Hetherington [Wed, 14 Oct 2020 13:14:26 +0000 (15:14 +0200)]
cscript can now run tests on Windows.

3 months agoRemove some debug output.
Carl Hetherington [Mon, 12 Oct 2020 17:59:17 +0000 (19:59 +0200)]
Remove some debug output.

3 months agoProvide path to find ffcmp tool for tests.
Carl Hetherington [Fri, 9 Oct 2020 19:18:34 +0000 (21:18 +0200)]
Provide path to find ffcmp tool for tests.

3 months agoFix deprecation warning from cdist.
Carl Hetherington [Thu, 8 Oct 2020 23:18:11 +0000 (01:18 +0200)]
Fix deprecation warning from cdist.

3 months agoTweak mac environment path.
Carl Hetherington [Thu, 8 Oct 2020 21:02:57 +0000 (23:02 +0200)]
Tweak mac environment path.

3 months agoSome macOS test build fixes.
Carl Hetherington [Thu, 8 Oct 2020 19:30:00 +0000 (21:30 +0200)]
Some macOS test build fixes.

3 months agoFix a REQUIRE that should be REQUIRE_EQUAL.
Carl Hetherington [Wed, 7 Oct 2020 07:24:50 +0000 (09:24 +0200)]
Fix a REQUIRE that should be REQUIRE_EQUAL.

3 months agoFix errors when over-reading a "large" amount from FileGroups on
Carl Hetherington [Tue, 6 Oct 2020 23:02:47 +0000 (01:02 +0200)]
Fix errors when over-reading a "large" amount from FileGroups on
Windows.  I haven't been able to find any conclusive explanation for
why this stuff happens;

https://stackoverflow.com/questions/7241168/safe-maximum-number-of-records-read-by-fread

is one possible lead.

3 months agoHack to allow us to make a valid boost::filesystem::path from a
Carl Hetherington [Tue, 6 Oct 2020 21:54:32 +0000 (23:54 +0200)]
Hack to allow us to make a valid boost::filesystem::path from a
UTF8 constant on Windows.  This might actually be a way to get around
the fopen_boost hacks.

3 months agoAdd ffcmp dependency for tests.
Carl Hetherington [Tue, 6 Oct 2020 21:18:40 +0000 (23:18 +0200)]
Add ffcmp dependency for tests.

3 months agoStop the Windows version of run_ffprobe manipulating the current working directory...
Carl Hetherington [Tue, 6 Oct 2020 19:37:46 +0000 (21:37 +0200)]
Stop the Windows version of run_ffprobe manipulating the current working directory as tests rely on it.

3 months agoModify KDM naming test to use shorter path names on Windows.
Carl Hetherington [Tue, 6 Oct 2020 09:58:29 +0000 (11:58 +0200)]
Modify KDM naming test to use shorter path names on Windows.

3 months agoBump libdcp for better error checking.
Carl Hetherington [Tue, 6 Oct 2020 09:27:06 +0000 (11:27 +0200)]
Bump libdcp for better error checking.

3 months agoRemove dependency on srand() and predictable output from rand()
Carl Hetherington [Tue, 6 Oct 2020 08:10:01 +0000 (10:10 +0200)]
Remove dependency on srand() and predictable output from rand()
to work around a strange problem on Windows where this test would
fail with the random values offset by 1 step.

3 months agoMake socket tests connect explicitly to localhost to try to fix
Carl Hetherington [Mon, 5 Oct 2020 20:47:30 +0000 (22:47 +0200)]
Make socket tests connect explicitly to localhost to try to fix
error 1214 on Windows.

3 months agoUse rand() instead of /dev/urandom to make test files.
Carl Hetherington [Mon, 5 Oct 2020 20:27:49 +0000 (22:27 +0200)]
Use rand() instead of /dev/urandom to make test files.

3 months agoFix POSIX path embedded in test check string.
Carl Hetherington [Mon, 5 Oct 2020 09:45:39 +0000 (11:45 +0200)]
Fix POSIX path embedded in test check string.

3 months agoStop run_ffprobe from changing the current working directory on Windows.
Carl Hetherington [Mon, 5 Oct 2020 09:15:24 +0000 (11:15 +0200)]
Stop run_ffprobe from changing the current working directory on Windows.

3 months agoTry to make crypo_test more likely to pass.
Carl Hetherington [Sun, 4 Oct 2020 22:26:25 +0000 (00:26 +0200)]
Try to make crypo_test more likely to pass.