dcpomatic.git
17 months agofixup! Add AudioAPI and some related methods. 2363-asio-take2
Carl Hetherington [Mon, 14 Nov 2022 21:57:05 +0000 (22:57 +0100)]
fixup! Add AudioAPI and some related methods.

17 months agofixup! Add AudioAPI and some related methods.
Carl Hetherington [Mon, 14 Nov 2022 21:33:11 +0000 (22:33 +0100)]
fixup! Add AudioAPI and some related methods.

17 months agoBind audio API choice to do something.
Carl Hetherington [Sat, 12 Nov 2022 23:11:11 +0000 (00:11 +0100)]
Bind audio API choice to do something.

17 months agoCleanup: whitespace.
Carl Hetherington [Sat, 12 Nov 2022 23:06:16 +0000 (00:06 +0100)]
Cleanup: whitespace.

17 months agoAdd bind() to Choice.
Carl Hetherington [Sat, 12 Nov 2022 20:41:23 +0000 (21:41 +0100)]
Add bind() to Choice.

17 months agoKeep _audio as a pointer so that we can replace it without having
Carl Hetherington [Sat, 12 Nov 2022 20:40:37 +0000 (21:40 +0100)]
Keep _audio as a pointer so that we can replace it without having
problems with RtAudio's questionable copy-construction.

17 months agoAdd unbound audio API selection choice.
Carl Hetherington [Sat, 12 Nov 2022 19:51:00 +0000 (20:51 +0100)]
Add unbound audio API selection choice.

17 months agoCleanup: default return.
Carl Hetherington [Sat, 12 Nov 2022 19:50:26 +0000 (20:50 +0100)]
Cleanup: default return.

17 months agoCleanup: const
Carl Hetherington [Sat, 12 Nov 2022 19:49:54 +0000 (20:49 +0100)]
Cleanup: const

17 months agoCleanup: auto.
Carl Hetherington [Sat, 12 Nov 2022 19:49:29 +0000 (20:49 +0100)]
Cleanup: auto.

17 months agoAdd AudioAPI and some related methods.
Carl Hetherington [Fri, 11 Nov 2022 23:02:51 +0000 (00:02 +0100)]
Add AudioAPI and some related methods.

17 months agoAdd PreviewSoundAPI to config.
Carl Hetherington [Wed, 9 Nov 2022 23:40:58 +0000 (00:40 +0100)]
Add PreviewSoundAPI to config.

17 months agoCleanup: use boost::none.
Carl Hetherington [Wed, 9 Nov 2022 23:40:49 +0000 (00:40 +0100)]
Cleanup: use boost::none.

17 months agounset_sound_output should emit a specific type of changed().
Carl Hetherington [Wed, 9 Nov 2022 18:49:28 +0000 (19:49 +0100)]
unset_sound_output should emit a specific type of changed().

17 months agoCleanup: move unset_sound_output() to a more logical place.
Carl Hetherington [Wed, 9 Nov 2022 18:43:05 +0000 (19:43 +0100)]
Cleanup: move unset_sound_output() to a more logical place.

17 months agoCreate only one RtAudio instance, in the FilmViewer, rather than
Carl Hetherington [Wed, 9 Nov 2022 23:20:41 +0000 (00:20 +0100)]
Create only one RtAudio instance, in the FilmViewer, rather than
creating them on-the-fly in config as well.

17 months agoCleanup: whitespace.
Carl Hetherington [Sat, 12 Nov 2022 00:11:53 +0000 (01:11 +0100)]
Cleanup: whitespace.

17 months agoFix macOS build.
Carl Hetherington [Thu, 10 Nov 2022 22:48:46 +0000 (23:48 +0100)]
Fix macOS build.

17 months agoBump libsub for fix unicode LINE SEPARATOR in subtitles.
Carl Hetherington [Thu, 10 Nov 2022 10:29:50 +0000 (11:29 +0100)]
Bump libsub for fix unicode LINE SEPARATOR in subtitles.

17 months agoFix uninitialised variable.
Carl Hetherington [Wed, 9 Nov 2022 23:08:19 +0000 (00:08 +0100)]
Fix uninitialised variable.

17 months agoFix error message.
Carl Hetherington [Sun, 6 Nov 2022 22:54:59 +0000 (23:54 +0100)]
Fix error message.

17 months agoCleanup: J2KEncoder does not need enable_shared_from_this.
Carl Hetherington [Sun, 6 Nov 2022 21:00:55 +0000 (22:00 +0100)]
Cleanup: J2KEncoder does not need enable_shared_from_this.

17 months agoCleanup: Player does not need enable_shared_from_this.
Carl Hetherington [Sat, 5 Nov 2022 20:37:10 +0000 (21:37 +0100)]
Cleanup: Player does not need enable_shared_from_this.

17 months agoCleanup: remove unnecessary explicit.
Carl Hetherington [Wed, 19 Oct 2022 20:31:12 +0000 (22:31 +0200)]
Cleanup: remove unnecessary explicit.

17 months agoCleanup: use default value in header.
Carl Hetherington [Tue, 6 Sep 2022 19:02:42 +0000 (21:02 +0200)]
Cleanup: use default value in header.

17 months agoCleanup: better variable name.
Carl Hetherington [Tue, 6 Sep 2022 18:50:24 +0000 (20:50 +0200)]
Cleanup: better variable name.

17 months agoHide the endless stream of warnings from wx/GTK.
Carl Hetherington [Sun, 6 Nov 2022 22:44:53 +0000 (23:44 +0100)]
Hide the endless stream of warnings from wx/GTK.

17 months agoExtract ImageStore.
Carl Hetherington [Sun, 6 Nov 2022 22:44:33 +0000 (23:44 +0100)]
Extract ImageStore.

17 months agoStrictly I think we should be putting each component of an image into _pending_images.
Carl Hetherington [Sun, 6 Nov 2022 22:19:00 +0000 (23:19 +0100)]
Strictly I think we should be putting each component of an image into _pending_images.
We probably get away with only keeping component 0 but I think that could perhaps lead
to use-after-free as the Image for components 1 and 2 could go away a bit before
it should.

17 months agoFix build on macOS and Windows.
Carl Hetherington [Fri, 4 Nov 2022 10:40:23 +0000 (11:40 +0100)]
Fix build on macOS and Windows.

17 months agoBump libdcp for subtitle Z-position fixes (#2356).
Carl Hetherington [Wed, 2 Nov 2022 21:39:49 +0000 (22:39 +0100)]
Bump libdcp for subtitle Z-position fixes (#2356).

17 months agoFix test references for passive option change.
Carl Hetherington [Thu, 3 Nov 2022 08:24:40 +0000 (09:24 +0100)]
Fix test references for passive option change.

17 months agoCleanup: use new CheckBox::bind().
Carl Hetherington [Tue, 1 Nov 2022 23:18:56 +0000 (00:18 +0100)]
Cleanup: use new CheckBox::bind().

17 months agoEnable some debug logging for TMS upload.
Carl Hetherington [Tue, 1 Nov 2022 20:11:40 +0000 (21:11 +0100)]
Enable some debug logging for TMS upload.

17 months agoAdd passive mode option to TMS upload.
Carl Hetherington [Tue, 1 Nov 2022 19:58:10 +0000 (20:58 +0100)]
Add passive mode option to TMS upload.

Disabling this fixes TMS upload with some FTP servers
(reported on a Synology NAS).

17 months agoAdd get() and bind() to CheckBox.
Carl Hetherington [Tue, 1 Nov 2022 19:57:55 +0000 (20:57 +0100)]
Add get() and bind() to CheckBox.

17 months agoThrow exception if av_frame_alloc() fails.
Carl Hetherington [Thu, 27 Oct 2022 21:13:24 +0000 (23:13 +0200)]
Throw exception if av_frame_alloc() fails.

17 months agoAdd tooltip to player DCP name with path details.
Carl Hetherington [Thu, 27 Oct 2022 08:54:27 +0000 (10:54 +0200)]
Add tooltip to player DCP name with path details.

17 months agoFix player with high-frame-rate DCPs.
Carl Hetherington [Thu, 27 Oct 2022 08:41:45 +0000 (10:41 +0200)]
Fix player with high-frame-rate DCPs.

17 months agoSupporters update. v2.16.32
Carl Hetherington [Wed, 26 Oct 2022 17:47:03 +0000 (19:47 +0200)]
Supporters update.

17 months agoFix player being destroyed while the butler is still using it.
Carl Hetherington [Wed, 26 Oct 2022 17:45:11 +0000 (19:45 +0200)]
Fix player being destroyed while the butler is still using it.

17 months agoRemove unnecessary copy constructors (default ones are OK).
Carl Hetherington [Wed, 26 Oct 2022 17:41:23 +0000 (19:41 +0200)]
Remove unnecessary copy constructors (default ones are OK).

17 months agoAllow move construction of Player.
Carl Hetherington [Wed, 26 Oct 2022 17:41:12 +0000 (19:41 +0200)]
Allow move construction of Player.

17 months agoAllow move construction of AudioMerger.
Carl Hetherington [Wed, 26 Oct 2022 13:16:36 +0000 (15:16 +0200)]
Allow move construction of AudioMerger.

17 months agoAllow move construction of ActiveText.
Carl Hetherington [Wed, 26 Oct 2022 13:16:30 +0000 (15:16 +0200)]
Allow move construction of ActiveText.

17 months agoFurther test/data SNAFU.
Carl Hetherington [Tue, 25 Oct 2022 19:24:11 +0000 (21:24 +0200)]
Further test/data SNAFU.

17 months agoFix mangling of the v2.16.x test/data commit somewhere along the line.
Carl Hetherington [Tue, 25 Oct 2022 17:38:11 +0000 (19:38 +0200)]
Fix mangling of the v2.16.x test/data commit somewhere along the line.

17 months agoHopefully fix crash when the same frame is encoded twice.
Carl Hetherington [Mon, 24 Oct 2022 18:37:02 +0000 (20:37 +0200)]
Hopefully fix crash when the same frame is encoded twice.

Previously if some frame X was passed to the encoder twice
I think this would happen:

X1 written; X stored to _pending_images
X2 written; _pending_images remains the same
X1 encode finishes; X is discarded from _pending_images
Data for X2 is read by the encoder but was just freed

I think this might have resulted in intermittent crashes, which were
fairly common in the 2.17.x branch with the test
ffmpeg_encoder_prores_regression_1

But I didn't conclusively prove it.

17 months agoFix missing switch of Append -> add (#2358).
Carl Hetherington [Mon, 24 Oct 2022 22:16:44 +0000 (00:16 +0200)]
Fix missing switch of Append -> add (#2358).

17 months agoAdd Daniel Courville to testers.
Carl Hetherington [Sun, 23 Oct 2022 19:50:18 +0000 (21:50 +0200)]
Add Daniel Courville to testers.

17 months agoFix colour range property for subsampled sources (#2357).
Carl Hetherington [Fri, 21 Oct 2022 10:55:44 +0000 (12:55 +0200)]
Fix colour range property for subsampled sources (#2357).

18 months agoFix macOS 10.8 build. v2.16.31
Carl Hetherington [Wed, 19 Oct 2022 12:23:19 +0000 (14:23 +0200)]
Fix macOS 10.8 build.

18 months agoSupporters update.
Carl Hetherington [Tue, 18 Oct 2022 22:31:13 +0000 (00:31 +0200)]
Supporters update.

18 months agoAdd search to DKDM list (#2298).
Carl Hetherington [Wed, 17 Aug 2022 15:05:43 +0000 (17:05 +0200)]
Add search to DKDM list (#2298).

18 months agoCleanup: 0 -> nullptr.
Carl Hetherington [Tue, 18 Oct 2022 21:29:21 +0000 (23:29 +0200)]
Cleanup: 0 -> nullptr.

18 months agoExtract Collator class.
Carl Hetherington [Wed, 17 Aug 2022 15:45:35 +0000 (17:45 +0200)]
Extract Collator class.

18 months agoSupporters update.
Carl Hetherington [Tue, 18 Oct 2022 19:46:45 +0000 (21:46 +0200)]
Supporters update.

18 months agoImprove the appearance of things in macOS dark mode in various ways.
Carl Hetherington [Tue, 18 Oct 2022 18:37:14 +0000 (20:37 +0200)]
Improve the appearance of things in macOS dark mode in various ways.

18 months agoImprove timeline view colouring in dark mode.
Carl Hetherington [Mon, 17 Oct 2022 18:36:55 +0000 (20:36 +0200)]
Improve timeline view colouring in dark mode.

18 months agoUse different icons for the timeline in dark/light modes.
Carl Hetherington [Sun, 16 Oct 2022 22:46:05 +0000 (00:46 +0200)]
Use different icons for the timeline in dark/light modes.

18 months agoMove timeline tools into a single .svg and tidy them up a bit.
Carl Hetherington [Sun, 16 Oct 2022 21:53:03 +0000 (23:53 +0200)]
Move timeline tools into a single .svg and tidy them up a bit.

18 months agoFix colouring of audio plot in dark mode.
Carl Hetherington [Sun, 16 Oct 2022 20:22:22 +0000 (22:22 +0200)]
Fix colouring of audio plot in dark mode.

18 months agoFix dark mode for release notes.
Carl Hetherington [Sun, 16 Oct 2022 20:21:49 +0000 (22:21 +0200)]
Fix dark mode for release notes.

18 months agoUse slightly better icons for macOS prefs in dark mode.
Carl Hetherington [Sun, 16 Oct 2022 20:21:34 +0000 (22:21 +0200)]
Use slightly better icons for macOS prefs in dark mode.

18 months agoSupporters update.
Carl Hetherington [Tue, 18 Oct 2022 18:35:29 +0000 (20:35 +0200)]
Supporters update.

18 months agoHopefully fix colour of Rec.2020 sources in the preview.
Carl Hetherington [Tue, 18 Oct 2022 18:26:05 +0000 (20:26 +0200)]
Hopefully fix colour of Rec.2020 sources in the preview.

18 months agoFix colour primaries when previewing Rec.2020 content with OpenGL.
Carl Hetherington [Mon, 17 Oct 2022 21:36:02 +0000 (23:36 +0200)]
Fix colour primaries when previewing Rec.2020 content with OpenGL.

18 months agoClarify RGB fragment type as being for Rec709/sRGB primaries.
Carl Hetherington [Mon, 17 Oct 2022 20:46:48 +0000 (22:46 +0200)]
Clarify RGB fragment type as being for Rec709/sRGB primaries.

18 months agoAdd a scope.
Carl Hetherington [Mon, 17 Oct 2022 20:38:23 +0000 (22:38 +0200)]
Add a scope.

18 months agoExtract ublas_to_gl method.
Carl Hetherington [Mon, 17 Oct 2022 20:37:39 +0000 (22:37 +0200)]
Extract ublas_to_gl method.

18 months agoRename colour_conversion -> xyz_rec709_colour_conversion.
Carl Hetherington [Mon, 17 Oct 2022 20:22:11 +0000 (22:22 +0200)]
Rename colour_conversion -> xyz_rec709_colour_conversion.

18 months agoUse a colorspace filter when previewing Rec.2020 content with the simple viewer.
Carl Hetherington [Sat, 8 Oct 2022 19:32:05 +0000 (21:32 +0200)]
Use a colorspace filter when previewing Rec.2020 content with the simple viewer.

18 months agoAdd VideoFilterGraph::process for Image.
Carl Hetherington [Thu, 6 Oct 2022 22:39:59 +0000 (00:39 +0200)]
Add VideoFilterGraph::process for Image.

18 months agoCleanup: some const-correctness.
Carl Hetherington [Thu, 6 Oct 2022 22:39:40 +0000 (00:39 +0200)]
Cleanup: some const-correctness.

18 months agoExtract VideoFilterGraphSet.
Carl Hetherington [Thu, 6 Oct 2022 21:38:07 +0000 (23:38 +0200)]
Extract VideoFilterGraphSet.

18 months agoRemove believed-unnecessary mutex.
Carl Hetherington [Thu, 6 Oct 2022 21:37:50 +0000 (23:37 +0200)]
Remove believed-unnecessary mutex.

18 months agoSupport Rec2020 YUV/RGB conversion.
Carl Hetherington [Wed, 5 Oct 2022 22:12:28 +0000 (00:12 +0200)]
Support Rec2020 YUV/RGB conversion.

18 months agoBump libdcp to handle XYZ->RGB conversions correctly for Rec.2020.
Carl Hetherington [Mon, 17 Oct 2022 22:23:44 +0000 (00:23 +0200)]
Bump libdcp to handle XYZ->RGB conversions correctly for Rec.2020.

18 months agoMake the _film member of Player a weak_ptr.
Carl Hetherington [Sat, 15 Oct 2022 21:04:58 +0000 (23:04 +0200)]
Make the _film member of Player a weak_ptr.

18 months agoRemove some more unnecessary use of shared_ptr.
Carl Hetherington [Fri, 14 Oct 2022 22:28:32 +0000 (00:28 +0200)]
Remove some more unnecessary use of shared_ptr.

18 months agoRemove some unnecessary use of shared_ptr.
Carl Hetherington [Fri, 14 Oct 2022 19:21:36 +0000 (21:21 +0200)]
Remove some unnecessary use of shared_ptr.

18 months agoMake the advanced content dialogue properly respect OK/Cancel.
Carl Hetherington [Sat, 15 Oct 2022 21:34:32 +0000 (23:34 +0200)]
Make the advanced content dialogue properly respect OK/Cancel.

18 months agoMake overridden subtitle language option respect OK/Cancel.
Carl Hetherington [Sat, 15 Oct 2022 00:17:38 +0000 (02:17 +0200)]
Make overridden subtitle language option respect OK/Cancel.

18 months agoMake video frame rate option respect OK/Cancel.
Carl Hetherington [Fri, 14 Oct 2022 23:58:54 +0000 (01:58 +0200)]
Make video frame rate option respect OK/Cancel.

18 months agoMake filters option respect OK/Cancel.
Carl Hetherington [Fri, 14 Oct 2022 23:32:00 +0000 (01:32 +0200)]
Make filters option respect OK/Cancel.

18 months agoMake ignore video option respect OK/Cancel.
Carl Hetherington [Fri, 14 Oct 2022 23:10:46 +0000 (01:10 +0200)]
Make ignore video option respect OK/Cancel.

18 months agoCleanup: sort some using statements.
Carl Hetherington [Fri, 14 Oct 2022 23:06:49 +0000 (01:06 +0200)]
Cleanup: sort some using statements.

18 months agoAlso build tests on Ubuntu 22.04.
Carl Hetherington [Sat, 15 Oct 2022 00:21:25 +0000 (02:21 +0200)]
Also build tests on Ubuntu 22.04.

18 months agoAdd some missing change signals in the Player.
Carl Hetherington [Fri, 14 Oct 2022 09:19:50 +0000 (11:19 +0200)]
Add some missing change signals in the Player.

18 months agoCleanup: use ChangeSignaller in player.
Carl Hetherington [Fri, 14 Oct 2022 08:49:50 +0000 (10:49 +0200)]
Cleanup: use ChangeSignaller in player.

18 months agoAdd a comment.
Carl Hetherington [Fri, 14 Oct 2022 08:41:16 +0000 (10:41 +0200)]
Add a comment.

18 months agoUse a plain declaration rather than a shared_ptr.
Carl Hetherington [Thu, 13 Oct 2022 23:09:45 +0000 (01:09 +0200)]
Use a plain declaration rather than a shared_ptr.

18 months agoCleanup: add header guards.
Carl Hetherington [Thu, 13 Oct 2022 23:09:11 +0000 (01:09 +0200)]
Cleanup: add header guards.

18 months agoEllipsize content names in the middle (#2350).
Carl Hetherington [Thu, 13 Oct 2022 22:21:06 +0000 (00:21 +0200)]
Ellipsize content names in the middle (#2350).

18 months agoRemove unused variable.
Carl Hetherington [Thu, 13 Oct 2022 05:51:19 +0000 (07:51 +0200)]
Remove unused variable.

18 months agoSave and restore sash positions in the main DoM.
Carl Hetherington [Wed, 12 Oct 2022 21:21:09 +0000 (23:21 +0200)]
Save and restore sash positions in the main DoM.

18 months agoAllow dragging of the border between the controls and the preview (#2350).
Carl Hetherington [Wed, 12 Oct 2022 20:48:13 +0000 (22:48 +0200)]
Allow dragging of the border between the controls and the preview (#2350).

18 months agoRename LimitedSplitter -> LimitedContentPanelSplitter.
Carl Hetherington [Wed, 12 Oct 2022 20:47:10 +0000 (22:47 +0200)]
Rename LimitedSplitter -> LimitedContentPanelSplitter.

18 months agoCleanup: move LimitedSplitter out of the header.
Carl Hetherington [Wed, 12 Oct 2022 20:14:57 +0000 (22:14 +0200)]
Cleanup: move LimitedSplitter out of the header.

18 months agoCleanup: use simpler ownership for FilmViewer.
Carl Hetherington [Tue, 11 Oct 2022 23:03:28 +0000 (01:03 +0200)]
Cleanup: use simpler ownership for FilmViewer.