dcpomatic.git
3 years agoAdd some icons missing from the macOS build. playlist
Carl Hetherington [Sun, 18 Oct 2020 22:07:28 +0000 (00:07 +0200)]
Add some icons missing from the macOS build.

3 years agomacOS build fix.
Carl Hetherington [Sun, 18 Oct 2020 19:43:03 +0000 (21:43 +0200)]
macOS build fix.

3 years agoTidy up and fix bitmap path finding in the playlist editor.
Carl Hetherington [Sun, 18 Oct 2020 18:01:44 +0000 (20:01 +0200)]
Tidy up and fix bitmap path finding in the playlist editor.

3 years agoFix typo.
Carl Hetherington [Sun, 18 Oct 2020 18:00:25 +0000 (20:00 +0200)]
Fix typo.

3 years agoClarify some error messages on macOS (#1837). jenkins
Carl Hetherington [Sat, 17 Oct 2020 22:16:25 +0000 (00:16 +0200)]
Clarify some error messages on macOS (#1837).

When we say we can't start a particular tool, it may be because it
has not even been downloaded/installed.

3 years agoFix failure to update player information when changing CPLs.
Carl Hetherington [Sat, 17 Oct 2020 20:25:40 +0000 (22:25 +0200)]
Fix failure to update player information when changing CPLs.

3 years agoFix deadlock when changing CPL in the player (#1827).
Carl Hetherington [Sat, 17 Oct 2020 20:23:12 +0000 (22:23 +0200)]
Fix deadlock when changing CPL in the player (#1827).

TextContent::set_dcp_track can end up requesting a view update, which
involves calls to methods in Content which lock the Content::_mutex.
Do these calls without a lock on that mutex held.

Also, it looks like we would append to texts on every call to
examine().  Fix that so that we replace the texts list on each
examine() call.

3 years agoFix finding of graphics when running from the source tree on Linux.
Carl Hetherington [Sat, 17 Oct 2020 20:23:01 +0000 (22:23 +0200)]
Fix finding of graphics when running from the source tree on Linux.

3 years agoTest script tweaks for Windows.
Carl Hetherington [Thu, 15 Oct 2020 11:53:39 +0000 (13:53 +0200)]
Test script tweaks for Windows.

3 years agoAdd test for #1857.
Carl Hetherington [Wed, 14 Oct 2020 19:43:21 +0000 (21:43 +0200)]
Add test for #1857.

3 years agoFix test DCP index.
Carl Hetherington [Wed, 14 Oct 2020 19:29:19 +0000 (21:29 +0200)]
Fix test DCP index.

3 years agoDon't crash if the first packet in a stream has AV_NOPTS_VALUE;
Carl Hetherington [Wed, 14 Oct 2020 19:24:57 +0000 (21:24 +0200)]
Don't crash if the first packet in a stream has AV_NOPTS_VALUE;
instead, assume it should be at timestamp 0.

3 years agoClear out _next_time when seeking, so out-of-date values don't
Carl Hetherington [Wed, 14 Oct 2020 19:23:36 +0000 (21:23 +0200)]
Clear out _next_time when seeking, so out-of-date values don't
hang around.  Part of the fix for #1857.

3 years agocscript can now run tests on Windows.
Carl Hetherington [Wed, 14 Oct 2020 13:14:26 +0000 (15:14 +0200)]
cscript can now run tests on Windows.

3 years agoRemove some debug output.
Carl Hetherington [Mon, 12 Oct 2020 17:59:17 +0000 (19:59 +0200)]
Remove some debug output.

3 years agoProvide path to find ffcmp tool for tests.
Carl Hetherington [Fri, 9 Oct 2020 19:18:34 +0000 (21:18 +0200)]
Provide path to find ffcmp tool for tests.

3 years agoFix deprecation warning from cdist.
Carl Hetherington [Thu, 8 Oct 2020 23:18:11 +0000 (01:18 +0200)]
Fix deprecation warning from cdist.

3 years agoTweak mac environment path.
Carl Hetherington [Thu, 8 Oct 2020 21:02:57 +0000 (23:02 +0200)]
Tweak mac environment path.

3 years agoSome macOS test build fixes.
Carl Hetherington [Thu, 8 Oct 2020 19:30:00 +0000 (21:30 +0200)]
Some macOS test build fixes.

3 years agoFix a REQUIRE that should be REQUIRE_EQUAL.
Carl Hetherington [Wed, 7 Oct 2020 07:24:50 +0000 (09:24 +0200)]
Fix a REQUIRE that should be REQUIRE_EQUAL.

3 years agoFix errors when over-reading a "large" amount from FileGroups on
Carl Hetherington [Tue, 6 Oct 2020 23:02:47 +0000 (01:02 +0200)]
Fix errors when over-reading a "large" amount from FileGroups on
Windows.  I haven't been able to find any conclusive explanation for
why this stuff happens;

https://stackoverflow.com/questions/7241168/safe-maximum-number-of-records-read-by-fread

is one possible lead.

3 years agoHack to allow us to make a valid boost::filesystem::path from a
Carl Hetherington [Tue, 6 Oct 2020 21:54:32 +0000 (23:54 +0200)]
Hack to allow us to make a valid boost::filesystem::path from a
UTF8 constant on Windows.  This might actually be a way to get around
the fopen_boost hacks.

3 years agoAdd ffcmp dependency for tests.
Carl Hetherington [Tue, 6 Oct 2020 21:18:40 +0000 (23:18 +0200)]
Add ffcmp dependency for tests.

3 years agoStop the Windows version of run_ffprobe manipulating the current working directory...
Carl Hetherington [Tue, 6 Oct 2020 19:37:46 +0000 (21:37 +0200)]
Stop the Windows version of run_ffprobe manipulating the current working directory as tests rely on it.

3 years agoModify KDM naming test to use shorter path names on Windows.
Carl Hetherington [Tue, 6 Oct 2020 09:58:29 +0000 (11:58 +0200)]
Modify KDM naming test to use shorter path names on Windows.

3 years agoBump libdcp for better error checking.
Carl Hetherington [Tue, 6 Oct 2020 09:27:06 +0000 (11:27 +0200)]
Bump libdcp for better error checking.

3 years agoRemove dependency on srand() and predictable output from rand()
Carl Hetherington [Tue, 6 Oct 2020 08:10:01 +0000 (10:10 +0200)]
Remove dependency on srand() and predictable output from rand()
to work around a strange problem on Windows where this test would
fail with the random values offset by 1 step.

3 years agoMake socket tests connect explicitly to localhost to try to fix
Carl Hetherington [Mon, 5 Oct 2020 20:47:30 +0000 (22:47 +0200)]
Make socket tests connect explicitly to localhost to try to fix
error 1214 on Windows.

3 years agoUse rand() instead of /dev/urandom to make test files.
Carl Hetherington [Mon, 5 Oct 2020 20:27:49 +0000 (22:27 +0200)]
Use rand() instead of /dev/urandom to make test files.

3 years agoFix POSIX path embedded in test check string.
Carl Hetherington [Mon, 5 Oct 2020 09:45:39 +0000 (11:45 +0200)]
Fix POSIX path embedded in test check string.

3 years agoStop run_ffprobe from changing the current working directory on Windows.
Carl Hetherington [Mon, 5 Oct 2020 09:15:24 +0000 (11:15 +0200)]
Stop run_ffprobe from changing the current working directory on Windows.

3 years agoTry to make crypo_test more likely to pass.
Carl Hetherington [Sun, 4 Oct 2020 22:26:25 +0000 (00:26 +0200)]
Try to make crypo_test more likely to pass.

3 years agoAdd python script to do repetitive code changes.
Carl Hetherington [Sun, 4 Oct 2020 21:31:47 +0000 (23:31 +0200)]
Add python script to do repetitive code changes.

3 years agoFix use of DCPOMATIC_TEST_PRIVATE variable to specify where
Carl Hetherington [Sun, 4 Oct 2020 20:04:40 +0000 (22:04 +0200)]
Fix use of DCPOMATIC_TEST_PRIVATE variable to specify where
test private data is.

3 years agoWindows test run script.
Carl Hetherington [Sun, 4 Oct 2020 18:51:35 +0000 (20:51 +0200)]
Windows test run script.

3 years agoFix Windows console apps to actually have a console.
Carl Hetherington [Fri, 2 Oct 2020 11:31:35 +0000 (13:31 +0200)]
Fix Windows console apps to actually have a console.

3 years agoLabel vertical alignment fixes.
Carl Hetherington [Thu, 1 Oct 2020 23:11:29 +0000 (01:11 +0200)]
Label vertical alignment fixes.

3 years agoFix integer overflow in test.
Carl Hetherington [Thu, 1 Oct 2020 16:55:40 +0000 (18:55 +0200)]
Fix integer overflow in test.

3 years agoFix tests after changes made in 4f652387cbeeda9b7b8ace71e047c450acf5c871
Carl Hetherington [Thu, 1 Oct 2020 11:27:32 +0000 (13:27 +0200)]
Fix tests after changes made in 4f652387cbeeda9b7b8ace71e047c450acf5c871

3 years agoRemove Image/GraphicsMagick dependency.
Carl Hetherington [Thu, 1 Oct 2020 08:44:11 +0000 (10:44 +0200)]
Remove Image/GraphicsMagick dependency.

3 years agoAdd some more pixfmts to hack.
Carl Hetherington [Thu, 1 Oct 2020 08:40:42 +0000 (10:40 +0200)]
Add some more pixfmts to hack.

3 years agoBuild tests on Windows.
Carl Hetherington [Wed, 30 Sep 2020 19:26:37 +0000 (21:26 +0200)]
Build tests on Windows.

3 years agomacOS extensions to run/tests.
Carl Hetherington [Tue, 29 Sep 2020 20:25:29 +0000 (22:25 +0200)]
macOS extensions to run/tests.

3 years agoMake use of default_font_file().
Carl Hetherington [Tue, 29 Sep 2020 20:06:36 +0000 (22:06 +0200)]
Make use of default_font_file().

3 years agoFix incorrect sign on boost test constants.
Carl Hetherington [Tue, 29 Sep 2020 18:55:16 +0000 (20:55 +0200)]
Fix incorrect sign on boost test constants.

3 years agoCope with different names for ImageMagick's .pc file (Linux and macOS).
Carl Hetherington [Tue, 29 Sep 2020 18:54:17 +0000 (20:54 +0200)]
Cope with different names for ImageMagick's .pc file (Linux and macOS).

3 years agoFix incorrect forward declaration of struct as class.
Carl Hetherington [Tue, 29 Sep 2020 18:51:02 +0000 (20:51 +0200)]
Fix incorrect forward declaration of struct as class.

3 years agoEnable building of unit tests on macOS.
Carl Hetherington [Tue, 29 Sep 2020 18:50:41 +0000 (20:50 +0200)]
Enable building of unit tests on macOS.

3 years agoAdapt for cdist doing notarization.
Carl Hetherington [Mon, 28 Sep 2020 19:17:42 +0000 (21:17 +0200)]
Adapt for cdist doing notarization.

3 years agoRemove notarization from make_dmg.sh.
Carl Hetherington [Mon, 28 Sep 2020 12:45:58 +0000 (14:45 +0200)]
Remove notarization from make_dmg.sh.

3 years agoFix up config backup tests.
Carl Hetherington [Thu, 8 Oct 2020 14:13:02 +0000 (16:13 +0200)]
Fix up config backup tests.

3 years agoFix error when trying to make the openssl symlink again.
Carl Hetherington [Thu, 8 Oct 2020 13:37:35 +0000 (15:37 +0200)]
Fix error when trying to make the openssl symlink again.

3 years agoFix assorted GTK3-related alignment problems.
Carl Hetherington [Mon, 5 Oct 2020 22:12:16 +0000 (00:12 +0200)]
Fix assorted GTK3-related alignment problems.

3 years agoMake unit tests use their own configuration rather than whatever
Carl Hetherington [Tue, 29 Sep 2020 21:17:53 +0000 (23:17 +0200)]
Make unit tests use their own configuration rather than whatever
happens to be in $HOME.

This is especially important for signer certificates; without this
it looks like the ones from $HOME will be used.

3 years agoRemove debug code.
Carl Hetherington [Tue, 29 Sep 2020 21:17:47 +0000 (23:17 +0200)]
Remove debug code.

3 years agoTry a little harder to make sure we use the patched openssl for
Carl Hetherington [Tue, 29 Sep 2020 21:17:24 +0000 (23:17 +0200)]
Try a little harder to make sure we use the patched openssl for
unit tests.

3 years agoRemove some Linux hacks that I can't see the point of any more.
Carl Hetherington [Tue, 29 Sep 2020 20:15:56 +0000 (22:15 +0200)]
Remove some Linux hacks that I can't see the point of any more.

3 years agoDisable some more warnings.
Carl Hetherington [Sun, 27 Sep 2020 21:47:47 +0000 (23:47 +0200)]
Disable some more warnings.

3 years agoTweak trim-to-end behaviour and button label.
Carl Hetherington [Sun, 27 Sep 2020 21:41:25 +0000 (23:41 +0200)]
Tweak trim-to-end behaviour and button label.

Now this button trims the current frame and all following (#1831).
It seems to be likely that you'd be looking at something you want
to remove, not the thing before what you want to remove.

3 years agoFix playhead position after trim-up-to (#1847).
Carl Hetherington [Sun, 27 Sep 2020 21:31:06 +0000 (23:31 +0200)]
Fix playhead position after trim-up-to (#1847).

3 years agoGo back to add_to_cairo_context rather than show_in_cairo_context.
Carl Hetherington [Sun, 27 Sep 2020 20:50:43 +0000 (22:50 +0200)]
Go back to add_to_cairo_context rather than show_in_cairo_context.

On Linux, at least, doing

add_to_cairo_context()
fill()
add_to_cairo_context()
stroke()

gives a nicer output than

show_in_cairo_context()

It's not clear exactly what the difference is, but the anti aliasing
looks better and the font outlines basically look smoother.

May help with #1815.

3 years agoBuild fix.
Carl Hetherington [Sun, 27 Sep 2020 20:40:13 +0000 (22:40 +0200)]
Build fix.

3 years agoBump libdcp for missing xsd fixes.
Carl Hetherington [Sun, 27 Sep 2020 19:19:24 +0000 (21:19 +0200)]
Bump libdcp for missing xsd fixes.

3 years agoFixes for new libdcp with multiple content versions.
Carl Hetherington [Sun, 27 Sep 2020 19:18:51 +0000 (21:18 +0200)]
Fixes for new libdcp with multiple content versions.

3 years agoTidy up xsd list in Windows installer.
Carl Hetherington [Sun, 27 Sep 2020 19:18:15 +0000 (21:18 +0200)]
Tidy up xsd list in Windows installer.

3 years agoUse bitmap_path() method to find the splash screen image.
Carl Hetherington [Sun, 27 Sep 2020 18:07:06 +0000 (20:07 +0200)]
Use bitmap_path() method to find the splash screen image.

3 years agoAdd missing tags_path() for Windows and macOS.
Carl Hetherington [Sun, 27 Sep 2020 18:06:57 +0000 (20:06 +0200)]
Add missing tags_path() for Windows and macOS.

3 years agoRevert some of the Linux stuff from a few commits ago.
Carl Hetherington [Sun, 27 Sep 2020 18:05:48 +0000 (20:05 +0200)]
Revert some of the Linux stuff from a few commits ago.

This fixes startup from the source tree.

3 years agoInstall libdcp tags files on Windows.
Carl Hetherington [Sun, 27 Sep 2020 18:05:16 +0000 (20:05 +0200)]
Install libdcp tags files on Windows.

3 years agoInstall libdcp tags files on macOS.
Carl Hetherington [Sun, 27 Sep 2020 18:05:09 +0000 (20:05 +0200)]
Install libdcp tags files on macOS.

3 years agoAdapt for new libdcp (fixing large compiler resource requirements).
Carl Hetherington [Sun, 27 Sep 2020 17:35:12 +0000 (19:35 +0200)]
Adapt for new libdcp (fixing large compiler resource requirements).

Also adjust Linux resource-finding code to juse look for stuff
relative to the executable's location.

3 years agoBump libdcp trying to reduce RAM needed for build.
Carl Hetherington [Sat, 26 Sep 2020 09:29:22 +0000 (11:29 +0200)]
Bump libdcp trying to reduce RAM needed for build.

3 years agoBump libdcp for macOS build fix.
Carl Hetherington [Sat, 26 Sep 2020 09:22:44 +0000 (11:22 +0200)]
Bump libdcp for macOS build fix.

3 years agoIt's not 7.1 until we have 12 channels. v2.15.103
Carl Hetherington [Fri, 25 Sep 2020 22:22:08 +0000 (00:22 +0200)]
It's not 7.1 until we have 12 channels.

3 years agoUpdate test ref for new metadata.
Carl Hetherington [Fri, 25 Sep 2020 22:21:21 +0000 (00:21 +0200)]
Update test ref for new metadata.

3 years agoAdd NamedChannel and use it to hide the never-used channels
Carl Hetherington [Fri, 25 Sep 2020 20:51:18 +0000 (22:51 +0200)]
Add NamedChannel and use it to hide the never-used channels
when mapping into a DCP.

3 years agoAdd missing try/catch to a call to getDeviceInfo.
Carl Hetherington [Fri, 25 Sep 2020 19:04:06 +0000 (21:04 +0200)]
Add missing try/catch to a call to getDeviceInfo.

3 years agoUse the appropriate RtAudio exception (though I'm not sure if this
Carl Hetherington [Fri, 25 Sep 2020 19:03:23 +0000 (21:03 +0200)]
Use the appropriate RtAudio exception (though I'm not sure if this
still necessary).

3 years agoRemove unnecessary explicit.
Carl Hetherington [Fri, 25 Sep 2020 14:37:49 +0000 (16:37 +0200)]
Remove unnecessary explicit.

3 years agoFix crash now that some audio channels are definitely unused.
Carl Hetherington [Wed, 23 Sep 2020 18:16:12 +0000 (20:16 +0200)]
Fix crash now that some audio channels are definitely unused.

3 years agoUndefine Status that somebody decided to put in the global namespace.
Carl Hetherington [Wed, 23 Sep 2020 15:35:40 +0000 (17:35 +0200)]
Undefine Status that somebody decided to put in the global namespace.

3 years agoMissing #include.
Carl Hetherington [Wed, 23 Sep 2020 15:19:24 +0000 (17:19 +0200)]
Missing #include.

3 years agoAdd audio language configuration and pass it to libdcp.
Carl Hetherington [Wed, 23 Sep 2020 15:05:01 +0000 (17:05 +0200)]
Add audio language configuration and pass it to libdcp.

3 years agoBuild fixes.
Carl Hetherington [Wed, 23 Sep 2020 15:04:53 +0000 (17:04 +0200)]
Build fixes.

3 years agoFix some vertical alignment.
Carl Hetherington [Wed, 23 Sep 2020 12:48:35 +0000 (14:48 +0200)]
Fix some vertical alignment.

3 years agoBump libdcp for new API stuff.
Carl Hetherington [Wed, 23 Sep 2020 10:22:38 +0000 (12:22 +0200)]
Bump libdcp for new API stuff.

3 years agoAdd new .xsd files for Windows.
Carl Hetherington [Mon, 21 Sep 2020 20:23:24 +0000 (22:23 +0200)]
Add new .xsd files for Windows.

3 years agoBump libdcp/libsub.
Carl Hetherington [Mon, 21 Sep 2020 20:23:12 +0000 (22:23 +0200)]
Bump libdcp/libsub.

3 years agoSupport CPL metadata.
Carl Hetherington [Fri, 4 Sep 2020 15:24:12 +0000 (17:24 +0200)]
Support CPL metadata.

3 years agoAdapt for changes to libdcp API.
Carl Hetherington [Fri, 4 Sep 2020 07:29:41 +0000 (09:29 +0200)]
Adapt for changes to libdcp API.

3 years agoAdd missing dcpomatic2_playlist.bat.
Carl Hetherington [Tue, 22 Sep 2020 07:38:08 +0000 (09:38 +0200)]
Add missing dcpomatic2_playlist.bat.

3 years agoAdd missing dcpomatic2_create.bat.
Carl Hetherington [Tue, 22 Sep 2020 05:49:00 +0000 (07:49 +0200)]
Add missing dcpomatic2_create.bat.

3 years agoAdd missing dcpomatic2_cli.bat.
Carl Hetherington [Mon, 21 Sep 2020 23:13:12 +0000 (01:13 +0200)]
Add missing dcpomatic2_cli.bat.

3 years agoAdd missing dcpomatic2_kdm_cli_debug.bat.
Carl Hetherington [Mon, 21 Sep 2020 22:54:03 +0000 (00:54 +0200)]
Add missing dcpomatic2_kdm_cli_debug.bat.

3 years agoTry to fix Windows debug build.
Carl Hetherington [Mon, 21 Sep 2020 22:27:00 +0000 (00:27 +0200)]
Try to fix Windows debug build.

3 years agoMissing bits of packaging for combiner on Linux.
Carl Hetherington [Mon, 21 Sep 2020 17:53:00 +0000 (19:53 +0200)]
Missing bits of packaging for combiner on Linux.

3 years agoFix --standard flag to dcpomatic2_cli (github #9).
Carl Hetherington [Mon, 21 Sep 2020 17:49:31 +0000 (19:49 +0200)]
Fix --standard flag to dcpomatic2_cli (github #9).

Forward-ported-from-commit: c1e8c8638bcb3b4c9d90adc3719f38fa7bf81be9
Forward-ported-from-branch: master

3 years agoFix windows installer. combine v2.15.102
Carl Hetherington [Sat, 19 Sep 2020 22:24:31 +0000 (00:24 +0200)]
Fix windows installer.

3 years agoWe only need Libre Baskerville when running update on Linux.
Carl Hetherington [Sat, 19 Sep 2020 21:41:45 +0000 (23:41 +0200)]
We only need Libre Baskerville when running update on Linux.

3 years agoUse sensitivity to disallow empty template names, rather than
Carl Hetherington [Wed, 16 Sep 2020 22:05:09 +0000 (00:05 +0200)]
Use sensitivity to disallow empty template names, rather than
giving an error after the fact.