dcpomatic.git
3 years agoBump libdcp. v2.15.131
Carl Hetherington [Tue, 23 Feb 2021 22:55:00 +0000 (23:55 +0100)]
Bump libdcp.

3 years agoFix missing test exception.
Carl Hetherington [Tue, 23 Feb 2021 22:49:39 +0000 (23:49 +0100)]
Fix missing test exception.

3 years agoFix assertion failure in AudioBuffers::copy_from() (#1909)
Carl Hetherington [Tue, 23 Feb 2021 19:01:49 +0000 (20:01 +0100)]
Fix assertion failure in AudioBuffers::copy_from() (#1909)

A number of frames N was being split up into two parts which together
were bigger than N, meaning a copy of one of the parts failed.

3 years agoRemove wxSTAY_ON_TOP from splash screen on Windows to stop it hiding
Carl Hetherington [Tue, 23 Feb 2021 00:47:21 +0000 (01:47 +0100)]
Remove wxSTAY_ON_TOP from splash screen on Windows to stop it hiding
error dialogues that pop up during startup.

3 years agoVerify a whole bunch of DCPs made by unit tests.
Carl Hetherington [Sun, 21 Feb 2021 19:28:59 +0000 (20:28 +0100)]
Verify a whole bunch of DCPs made by unit tests.

3 years agoDon't write active picture area with zero width or height as it makes verification...
Carl Hetherington [Sun, 21 Feb 2021 19:27:58 +0000 (20:27 +0100)]
Don't write active picture area with zero width or height as it makes verification fail.

3 years agoDon't create empty SMPTE subtitles files with empty <SubtitleList>
Carl Hetherington [Sun, 21 Feb 2021 19:26:37 +0000 (20:26 +0100)]
Don't create empty SMPTE subtitles files with empty <SubtitleList>

Files like this fail validation against the XSD.  Perhaps the XSD
is wrong; for now though, create an empty 1-second-long subtitle
in such files.

3 years agoFix reel setup when the last reel is less than 1 second long.
Carl Hetherington [Sun, 21 Feb 2021 19:26:32 +0000 (20:26 +0100)]
Fix reel setup when the last reel is less than 1 second long.

3 years agoFix some wxWidgets assertion failures.
Carl Hetherington [Tue, 23 Feb 2021 00:11:28 +0000 (01:11 +0100)]
Fix some wxWidgets assertion failures.

Casued by specifying wxFD_OVERWRITE_PROMPT without wxFD_SAVE; it makes
no sense and in wx3.1 it raises an error.

3 years agoFix assertion ordering.
Carl Hetherington [Tue, 23 Feb 2021 00:11:18 +0000 (01:11 +0100)]
Fix assertion ordering.

3 years agoFix some wx3.1 alignment.
Carl Hetherington [Sat, 20 Feb 2021 23:11:44 +0000 (00:11 +0100)]
Fix some wx3.1 alignment.

3 years agoFix typos. v2.15.130
Carl Hetherington [Wed, 17 Feb 2021 19:08:15 +0000 (20:08 +0100)]
Fix typos.

3 years agoAssorted C++11 tidying.
Carl Hetherington [Wed, 17 Feb 2021 16:33:35 +0000 (17:33 +0100)]
Assorted C++11 tidying.

3 years agoFix some wx3.1 assertions and some C++ tidying.
Carl Hetherington [Wed, 17 Feb 2021 16:30:12 +0000 (17:30 +0100)]
Fix some wx3.1 assertions and some C++ tidying.

3 years agoC++11 tidying.
Carl Hetherington [Tue, 16 Feb 2021 09:40:12 +0000 (10:40 +0100)]
C++11 tidying.

3 years agoAvoid using unzip.exe for Windows tests, as it crashes quite a lot for some reason.
Carl Hetherington [Mon, 15 Feb 2021 23:18:35 +0000 (00:18 +0100)]
Avoid using unzip.exe for Windows tests, as it crashes quite a lot for some reason.

3 years agoTweak markdown in DEVELOP.md
Carl Hetherington [Mon, 15 Feb 2021 22:29:17 +0000 (23:29 +0100)]
Tweak markdown in DEVELOP.md

3 years agoCompile fix for ubuntu-16.04-era gcc.
Carl Hetherington [Mon, 15 Feb 2021 20:15:37 +0000 (21:15 +0100)]
Compile fix for ubuntu-16.04-era gcc.

3 years agoTell user we need a KDM when we have none, and content is encrypted. v2.15.129
Carl Hetherington [Mon, 15 Feb 2021 01:57:24 +0000 (02:57 +0100)]
Tell user we need a KDM when we have none, and content is encrypted.

If you try to fetch encrypted content from asdcplib without specifying
any key it will happily return the encrypted content, so check for that,
as well as checking any key we *do* have actually works.

3 years agoDon't keep returning AGAIN from the butler when it is already dead/finished.
Carl Hetherington [Mon, 15 Feb 2021 01:50:03 +0000 (02:50 +0100)]
Don't keep returning AGAIN from the butler when it is already dead/finished.

This causes, for example, player UI hangs when trying to play
something unplayable (e.g. a DCP with no KDM).

3 years agoCoalesce player changes around KDM loading.
Carl Hetherington [Mon, 15 Feb 2021 00:42:06 +0000 (01:42 +0100)]
Coalesce player changes around KDM loading.

A similar fix for KDM changes as 7d33aff2d5e81185f3361e28c84e3f9858464ef1
was for CPL changes.

3 years agoFix wx3.1.x alignment errors.
Carl Hetherington [Mon, 15 Feb 2021 00:39:22 +0000 (01:39 +0100)]
Fix wx3.1.x alignment errors.

3 years agoTest reference tweaks.
Carl Hetherington [Mon, 15 Feb 2021 00:15:19 +0000 (01:15 +0100)]
Test reference tweaks.

3 years agoAllow multiple video tracks to be visible in the timeline.
Carl Hetherington [Sun, 14 Feb 2021 23:43:12 +0000 (00:43 +0100)]
Allow multiple video tracks to be visible in the timeline.

3 years agoFix timeline zoom oddities after dragging a very small zoom rectangle.
Carl Hetherington [Sun, 14 Feb 2021 23:42:55 +0000 (00:42 +0100)]
Fix timeline zoom oddities after dragging a very small zoom rectangle.

3 years agoTypo fix.
Carl Hetherington [Sun, 14 Feb 2021 23:42:22 +0000 (00:42 +0100)]
Typo fix.

3 years agoBasic handling of overlapping video (#1848).
Carl Hetherington [Tue, 29 Sep 2020 12:16:56 +0000 (14:16 +0200)]
Basic handling of overlapping video (#1848).

3 years agoFix incorrect coalesce() output when one input range is wholly
Carl Hetherington [Sun, 14 Feb 2021 11:36:23 +0000 (12:36 +0100)]
Fix incorrect coalesce() output when one input range is wholly
covered by another.

3 years agoRemove use of boost::noncopyable
Carl Hetherington [Sat, 13 Feb 2021 23:29:48 +0000 (00:29 +0100)]
Remove use of boost::noncopyable

3 years agoFix typos in operator=
Carl Hetherington [Sat, 13 Feb 2021 23:29:25 +0000 (00:29 +0100)]
Fix typos in operator=

3 years agoC++11 cleanups.
Carl Hetherington [Sun, 14 Feb 2021 20:39:31 +0000 (21:39 +0100)]
C++11 cleanups.

3 years agoTest: smaller steps when adding noise. v2.15.128
Carl Hetherington [Thu, 11 Feb 2021 20:33:08 +0000 (21:33 +0100)]
Test: smaller steps when adding noise.

3 years agoManual tweaks; both content and style for new website.
Carl Hetherington [Wed, 10 Feb 2021 00:34:21 +0000 (01:34 +0100)]
Manual tweaks; both content and style for new website.

3 years agoCoalesce player changes around CPL change. v2.15.127
Carl Hetherington [Tue, 9 Feb 2021 13:08:46 +0000 (14:08 +0100)]
Coalesce player changes around CPL change.

If multiple player changes happen, causing the player to be suspended,
there are problems if one of those changes causes a FilmViewer:seek.
In there, we wait for the seek to finish, but it will never finish
because of the suspension.  Hence it's important that we only trigger
the seek once the suspension is over.

Fixes #1905.

3 years agoHandle pending player changes more efficiently.
Carl Hetherington [Tue, 9 Feb 2021 13:05:46 +0000 (14:05 +0100)]
Handle pending player changes more efficiently.

Rather than looping over all changes, possibly calling a refresh
method for each, coalesce them.

3 years agoMove some updates from content_change to player_change.
Carl Hetherington [Tue, 9 Feb 2021 12:58:37 +0000 (13:58 +0100)]
Move some updates from content_change to player_change.

So far as I can see there's no need for them to respond to
content_change, and it's neater to do it all in one place.

3 years agoUse vector for _pending_player_changes
Carl Hetherington [Tue, 9 Feb 2021 12:56:31 +0000 (13:56 +0100)]
Use vector for _pending_player_changes

3 years agoSome small C++11 tweaks.
Carl Hetherington [Tue, 9 Feb 2021 12:53:18 +0000 (13:53 +0100)]
Some small C++11 tweaks.

3 years agoRevert "Build tests on ubuntu 16.04."
Carl Hetherington [Sun, 7 Feb 2021 23:13:37 +0000 (00:13 +0100)]
Revert "Build tests on ubuntu 16.04."

This reverts commit 93c2ca7dfc8feeae374c867c1c679334571a7547.

Building the tests on 16.04 needs a newer boost than it provides;
you can build it statically but then you need to link the boost test
library statically (which requires the removal of BOOST_TEST_DYN_LINK
all over the place).  Doing that fails in libsub for some reason.

3 years agoC++11.
Carl Hetherington [Sun, 7 Feb 2021 22:05:38 +0000 (23:05 +0100)]
C++11.

3 years agoMore libdcp include fixes.
Carl Hetherington [Sun, 7 Feb 2021 22:01:28 +0000 (23:01 +0100)]
More libdcp include fixes.

3 years agoFix libdcp include.
Carl Hetherington [Sun, 7 Feb 2021 21:57:58 +0000 (22:57 +0100)]
Fix libdcp include.

3 years agoBe more defensive when calling boost::filesystem::last_write_time.
Carl Hetherington [Sun, 7 Feb 2021 21:31:43 +0000 (22:31 +0100)]
Be more defensive when calling boost::filesystem::last_write_time.

3 years agoReport boost::filesystem_error with more details.
Carl Hetherington [Sun, 7 Feb 2021 21:16:58 +0000 (22:16 +0100)]
Report boost::filesystem_error with more details.

3 years agoRemove erroneous wxFD_MULTIPLE flag.
Carl Hetherington [Sun, 7 Feb 2021 20:37:23 +0000 (21:37 +0100)]
Remove erroneous wxFD_MULTIPLE flag.

3 years agoC++ tidying.
Carl Hetherington [Sun, 7 Feb 2021 20:32:44 +0000 (21:32 +0100)]
C++ tidying.

3 years agolibdcp update.
Carl Hetherington [Sun, 7 Feb 2021 01:46:58 +0000 (02:46 +0100)]
libdcp update.

3 years agoFix previous.
Carl Hetherington [Sun, 7 Feb 2021 00:32:34 +0000 (01:32 +0100)]
Fix previous.

3 years agoBuild tests on ubuntu 16.04.
Carl Hetherington [Sun, 7 Feb 2021 00:03:14 +0000 (01:03 +0100)]
Build tests on ubuntu 16.04.

3 years agoInclude creator/issuer in default name of exported KDM decryption key (#1888).
Carl Hetherington [Sat, 6 Feb 2021 19:41:48 +0000 (20:41 +0100)]
Include creator/issuer in default name of exported KDM decryption key (#1888).

3 years agoTweak label of KDM decryption key export button (#1888).
Carl Hetherington [Sat, 6 Feb 2021 19:41:10 +0000 (20:41 +0100)]
Tweak label of KDM decryption key export button (#1888).

3 years agoC++11 tidying.
Carl Hetherington [Sat, 6 Feb 2021 19:40:31 +0000 (20:40 +0100)]
C++11 tidying.

3 years agoForce .pem extension when saving certificates.
Carl Hetherington [Sat, 6 Feb 2021 19:39:33 +0000 (20:39 +0100)]
Force .pem extension when saving certificates.

3 years agoAdd some default filenames to the advanced certificate/key export dialogues (#1888).
Carl Hetherington [Sat, 6 Feb 2021 19:39:08 +0000 (20:39 +0100)]
Add some default filenames to the advanced certificate/key export dialogues (#1888).

3 years agoFix copy-and-paste error in manual.
Carl Hetherington [Sat, 6 Feb 2021 19:36:59 +0000 (20:36 +0100)]
Fix copy-and-paste error in manual.

3 years agoGive some more detail about what issuer/creator mean (#1888).
Carl Hetherington [Sat, 6 Feb 2021 19:36:48 +0000 (20:36 +0100)]
Give some more detail about what issuer/creator mean (#1888).

3 years agoTesting: add minimum frame size configuration option. v2.15.126
Carl Hetherington [Fri, 5 Feb 2021 19:36:19 +0000 (20:36 +0100)]
Testing: add minimum frame size configuration option.

3 years agoFix set_paths.sh to be used on ci.
Carl Hetherington [Thu, 4 Feb 2021 22:14:07 +0000 (23:14 +0100)]
Fix set_paths.sh to be used on ci.

3 years agoBump libdcp for Interop closed caption fix. v2.15.125
Carl Hetherington [Thu, 4 Feb 2021 16:35:18 +0000 (17:35 +0100)]
Bump libdcp for Interop closed caption fix.

3 years agoSpeculative fix for incorrect rendering of UTF-8 in closed captions in the player.
Carl Hetherington [Thu, 4 Feb 2021 16:33:47 +0000 (17:33 +0100)]
Speculative fix for incorrect rendering of UTF-8 in closed captions in the player.

3 years agoUse auto.
Carl Hetherington [Thu, 4 Feb 2021 16:33:36 +0000 (17:33 +0100)]
Use auto.

3 years agoFix no subtitles/captions in the player after changing the CPL.
Carl Hetherington [Thu, 4 Feb 2021 16:21:42 +0000 (17:21 +0100)]
Fix no subtitles/captions in the player after changing the CPL.

3 years agoC++11 tidying.
Carl Hetherington [Thu, 4 Feb 2021 16:19:34 +0000 (17:19 +0100)]
C++11 tidying.

3 years agoSome C++11 stuff.
Carl Hetherington [Thu, 4 Feb 2021 14:44:12 +0000 (15:44 +0100)]
Some C++11 stuff.

3 years agoFix test for better diacriticals handling.
Carl Hetherington [Thu, 4 Feb 2021 07:18:08 +0000 (08:18 +0100)]
Fix test for better diacriticals handling.

3 years agoSome noncopyable removal.
Carl Hetherington [Wed, 3 Feb 2021 23:24:55 +0000 (00:24 +0100)]
Some noncopyable removal.

3 years agoUse strcoll() to compare cinemas/screens in the KDM dialog (#1904).
Carl Hetherington [Wed, 3 Feb 2021 23:03:50 +0000 (00:03 +0100)]
Use strcoll() to compare cinemas/screens in the KDM dialog (#1904).

3 years agoc++11 tidying.
Carl Hetherington [Wed, 3 Feb 2021 21:32:58 +0000 (22:32 +0100)]
c++11 tidying.

3 years agoUse icu to remove diacritics from strings.
Carl Hetherington [Wed, 3 Feb 2021 21:02:18 +0000 (22:02 +0100)]
Use icu to remove diacritics from strings.

This replaces some ad-hoc code and extends it to work with more
characters (#1904).

3 years agoReduce the disk space needed when running tests. v2.15.124
Carl Hetherington [Tue, 2 Feb 2021 15:36:31 +0000 (16:36 +0100)]
Reduce the disk space needed when running tests.

3 years agoC++11 tidying.
Carl Hetherington [Mon, 1 Feb 2021 22:58:04 +0000 (23:58 +0100)]
C++11 tidying.

3 years agoc++11-ification.
Carl Hetherington [Mon, 1 Feb 2021 22:38:56 +0000 (23:38 +0100)]
c++11-ification.

3 years agoRemove some debugging code from tests.
Carl Hetherington [Mon, 1 Feb 2021 22:13:06 +0000 (23:13 +0100)]
Remove some debugging code from tests.

3 years agoAdd a better error when failing to read a DCP in some cases.
Carl Hetherington [Mon, 1 Feb 2021 16:47:23 +0000 (17:47 +0100)]
Add a better error when failing to read a DCP in some cases.

3 years agoUse a predictable RNG when adding noise to low-bitrate images.
Carl Hetherington [Mon, 1 Feb 2021 16:46:22 +0000 (17:46 +0100)]
Use a predictable RNG when adding noise to low-bitrate images.

The recovery code assumes that encoding a given frame from the
same data will always give the same output; it always encodes frame 0
again to set things up properly and if that frame is a different size
to the previous run everything breaks.

3 years agoFix build error thinko.
Carl Hetherington [Mon, 1 Feb 2021 09:16:52 +0000 (10:16 +0100)]
Fix build error thinko.

3 years agoFix wxWidgets 3.1.x alignment assertion failure.
Carl Hetherington [Mon, 1 Feb 2021 09:14:45 +0000 (10:14 +0100)]
Fix wxWidgets 3.1.x alignment assertion failure.

3 years agoC++11-ification.
Carl Hetherington [Mon, 1 Feb 2021 09:03:03 +0000 (10:03 +0100)]
C++11-ification.

3 years agoFix hang when trying to assure minimum bitrate.
Carl Hetherington [Mon, 1 Feb 2021 09:02:56 +0000 (10:02 +0100)]
Fix hang when trying to assure minimum bitrate.

3 years agoAdd noise to very small J2K frames (#1902).
Carl Hetherington [Mon, 1 Feb 2021 00:24:55 +0000 (01:24 +0100)]
Add noise to very small J2K frames (#1902).

3 years agoAdd some parameter names in headers.
Carl Hetherington [Mon, 1 Feb 2021 00:22:58 +0000 (01:22 +0100)]
Add some parameter names in headers.

3 years agoBump libdcp for Windows build fix.
Carl Hetherington [Sun, 31 Jan 2021 22:52:01 +0000 (23:52 +0100)]
Bump libdcp for Windows build fix.

3 years agoUse enum class for Film::Property.
Carl Hetherington [Sun, 31 Jan 2021 22:47:14 +0000 (23:47 +0100)]
Use enum class for Film::Property.

3 years agoMore enum class additions.
Carl Hetherington [Sun, 31 Jan 2021 02:14:24 +0000 (03:14 +0100)]
More enum class additions.

3 years agoRename debug type THREED to THREED_D.
Carl Hetherington [Sat, 30 Jan 2021 15:33:26 +0000 (16:33 +0100)]
Rename debug type THREED to THREED_D.

3 years agoUse enum class for VideoRange.
Carl Hetherington [Wed, 27 Jan 2021 00:44:20 +0000 (01:44 +0100)]
Use enum class for VideoRange.

3 years agolibdcp API change ReelMXF -> ReelFileAsset.
Carl Hetherington [Tue, 26 Jan 2021 21:15:41 +0000 (22:15 +0100)]
libdcp API change ReelMXF -> ReelFileAsset.

3 years agoSmall bits of c++11 tidying.
Carl Hetherington [Mon, 25 Jan 2021 23:54:55 +0000 (00:54 +0100)]
Small bits of c++11 tidying.

3 years agoFix label alignment.
Carl Hetherington [Mon, 25 Jan 2021 23:37:42 +0000 (00:37 +0100)]
Fix label alignment.

3 years agoBump libdcp for asdcplib version fix.
Carl Hetherington [Sat, 23 Jan 2021 09:01:14 +0000 (10:01 +0100)]
Bump libdcp for asdcplib version fix.

3 years agoBump libdcp for Windows build fix.
Carl Hetherington [Sat, 23 Jan 2021 08:31:31 +0000 (09:31 +0100)]
Bump libdcp for Windows build fix.

3 years agoRevert "Experimental define to stop windows.h defining a constant called ERROR."
Carl Hetherington [Sat, 23 Jan 2021 07:37:34 +0000 (08:37 +0100)]
Revert "Experimental define to stop windows.h defining a constant called ERROR."

Doing this means PIXELFORMATDESCRIPTOR is no longer available.

This reverts commit 95c0bd115eacf76e3794de8558ccd4e1d8d34a4a.

3 years agoc++11 tidying.
Carl Hetherington [Fri, 22 Jan 2021 22:50:58 +0000 (23:50 +0100)]
c++11 tidying.

3 years agoTest fixes.
Carl Hetherington [Fri, 22 Jan 2021 19:57:21 +0000 (20:57 +0100)]
Test fixes.

3 years agoCheck FFOC correctly.
Carl Hetherington [Fri, 22 Jan 2021 19:53:41 +0000 (20:53 +0100)]
Check FFOC correctly.

3 years agoC++ tidying.
Carl Hetherington [Fri, 22 Jan 2021 19:53:35 +0000 (20:53 +0100)]
C++ tidying.

3 years agoMake PKL AnnotationText the same as CPL ContentTitleText per Bv2.1
Carl Hetherington [Fri, 22 Jan 2021 19:52:56 +0000 (20:52 +0100)]
Make PKL AnnotationText the same as CPL ContentTitleText per Bv2.1

3 years agoFix FFOC time per Bv2.1
Carl Hetherington [Fri, 22 Jan 2021 19:52:43 +0000 (20:52 +0100)]
Fix FFOC time per Bv2.1

3 years agoTest updates for libdcp fix to the duration of Marker assets.
Carl Hetherington [Fri, 22 Jan 2021 12:04:21 +0000 (13:04 +0100)]
Test updates for libdcp fix to the duration of Marker assets.

3 years agoc++11 tidying.
Carl Hetherington [Fri, 22 Jan 2021 11:16:21 +0000 (12:16 +0100)]
c++11 tidying.