dcpomatic.git
3 years agoFix vertical alignment with subrip and embedded SSA \an codes. v2.15.90
Carl Hetherington [Mon, 20 Jul 2020 14:25:43 +0000 (16:25 +0200)]
Fix vertical alignment with subrip and embedded SSA \an codes.

3 years agoFix warning.
Carl Hetherington [Wed, 15 Jul 2020 20:40:22 +0000 (22:40 +0200)]
Fix warning.

3 years agoRemove ko_KR translation stub that was never used.
Carl Hetherington [Wed, 15 Jul 2020 21:02:55 +0000 (23:02 +0200)]
Remove ko_KR translation stub that was never used.

3 years agoFix typo in comment.
Carl Hetherington [Sun, 12 Jul 2020 22:49:47 +0000 (00:49 +0200)]
Fix typo in comment.

3 years agoUpdate manual Makefile for Inkscape 1.0
Carl Hetherington [Sun, 12 Jul 2020 22:49:32 +0000 (00:49 +0200)]
Update manual Makefile for Inkscape 1.0

3 years agoFix ATMOS frame numbering when decoding DCPs. v2.15.89
Carl Hetherington [Sun, 12 Jul 2020 13:11:26 +0000 (15:11 +0200)]
Fix ATMOS frame numbering when decoding DCPs.

3 years agoRemove pointless subheading in Keys->Advanced dialogues and improve spacing in the...
Carl Hetherington [Sat, 11 Jul 2020 22:43:50 +0000 (00:43 +0200)]
Remove pointless subheading in Keys->Advanced dialogues and improve spacing in the Keys page of config.

3 years agoUse new channel 14 ATMOS sync creation code in libdcp,
Carl Hetherington [Sat, 11 Jul 2020 21:46:39 +0000 (23:46 +0200)]
Use new channel 14 ATMOS sync creation code in libdcp,
and force films containing ATMOS to have 14 audio channels
and be SMPTE.

3 years agoAdd Antonio Casado as a tester.
Carl Hetherington [Wed, 8 Jul 2020 23:37:03 +0000 (01:37 +0200)]
Add Antonio Casado as a tester.

3 years agoSome ATMOS hacks.
Carl Hetherington [Wed, 8 Jul 2020 23:22:23 +0000 (01:22 +0200)]
Some ATMOS hacks.

3 years agoImprove butler error reporting during export. v2.15.88
Carl Hetherington [Sun, 5 Jul 2020 20:10:03 +0000 (22:10 +0200)]
Improve butler error reporting during export.

3 years agoAdd more logging and some missing prefs checkboxes for existing logging. v2.15.87
Carl Hetherington [Sun, 5 Jul 2020 19:38:35 +0000 (21:38 +0200)]
Add more logging and some missing prefs checkboxes for existing logging.

3 years agoFix typo truncating ./waf configure output.
Carl Hetherington [Fri, 3 Jul 2020 22:21:35 +0000 (00:21 +0200)]
Fix typo truncating ./waf configure output.

3 years agoPotential Windows build fix. v2.15.86
Carl Hetherington [Thu, 2 Jul 2020 20:04:49 +0000 (22:04 +0200)]
Potential Windows build fix.

3 years agoFix failure to import DCPs since Atmos changes. v2.15.85
Carl Hetherington [Thu, 2 Jul 2020 18:16:05 +0000 (20:16 +0200)]
Fix failure to import DCPs since Atmos changes.

3 years agoMake some methods private.
Carl Hetherington [Sun, 28 Jun 2020 21:12:59 +0000 (23:12 +0200)]
Make some methods private.

3 years agoFix confusion between one-shot and playing causing surprising
Carl Hetherington [Sat, 27 Jun 2020 23:46:20 +0000 (01:46 +0200)]
Fix confusion between one-shot and playing causing surprising
seeks when things are updated.

3 years agoMake _one_shot and _playing atomic.
Carl Hetherington [Sat, 27 Jun 2020 22:59:21 +0000 (00:59 +0200)]
Make _one_shot and _playing atomic.

3 years agoRename _playing_condition -> _thread_work_condition.
Carl Hetherington [Sat, 27 Jun 2020 22:49:54 +0000 (00:49 +0200)]
Rename _playing_condition -> _thread_work_condition.

3 years agoMove video filters controls into advanced content dialogue (#1748).
Carl Hetherington [Sat, 27 Jun 2020 21:08:42 +0000 (23:08 +0200)]
Move video filters controls into advanced content dialogue (#1748).

3 years agoSwitch the content advanced dialogue to use GridBagSizer.
Carl Hetherington [Sat, 27 Jun 2020 20:49:05 +0000 (22:49 +0200)]
Switch the content advanced dialogue to use GridBagSizer.

3 years agoMerge FilterEditor and FilterDialog.
Carl Hetherington [Sat, 20 Jun 2020 19:17:37 +0000 (21:17 +0200)]
Merge FilterEditor and FilterDialog.

3 years agoAvoid ResetClip() since (on GTK3, and maybe elsewhere) it seems to
Carl Hetherington [Sat, 27 Jun 2020 19:45:26 +0000 (21:45 +0200)]
Avoid ResetClip() since (on GTK3, and maybe elsewhere) it seems to
reset some internally-setup clipping so that drawing can overlap
the canvas that it's on.  Fixes #1769.

3 years agoUpdated nl_NL translation from Rob van Nieuwkerk. v2.15.84
Carl Hetherington [Thu, 25 Jun 2020 07:56:26 +0000 (09:56 +0200)]
Updated nl_NL translation from Rob van Nieuwkerk.

3 years agoTry to fix crash on calling glGetString() without a GL context.
Carl Hetherington [Tue, 23 Jun 2020 20:09:36 +0000 (22:09 +0200)]
Try to fix crash on calling glGetString() without a GL context.

3 years agoRemove out-of-date comment.
Carl Hetherington [Sun, 21 Jun 2020 19:25:17 +0000 (21:25 +0200)]
Remove out-of-date comment.

3 years agoFix hanging butler due to nasty signal ordering problems. v2.15.83
Carl Hetherington [Fri, 19 Jun 2020 20:47:28 +0000 (22:47 +0200)]
Fix hanging butler due to nasty signal ordering problems.

3 years agoMissing return statement.
Carl Hetherington [Fri, 19 Jun 2020 18:30:11 +0000 (20:30 +0200)]
Missing return statement.

3 years agoFix timeline for DCPs containing Atmos.
Carl Hetherington [Fri, 19 Jun 2020 18:30:04 +0000 (20:30 +0200)]
Fix timeline for DCPs containing Atmos.

3 years agoDCPExaminer must find Atmos length / edit rate.
Carl Hetherington [Fri, 19 Jun 2020 18:29:55 +0000 (20:29 +0200)]
DCPExaminer must find Atmos length / edit rate.

3 years agoMissing setup of AtmosContent in DCP.
Carl Hetherington [Fri, 19 Jun 2020 18:29:31 +0000 (20:29 +0200)]
Missing setup of AtmosContent in DCP.

3 years agoFix serialisation of the Atmos parts of a DCP.
Carl Hetherington [Fri, 19 Jun 2020 18:29:22 +0000 (20:29 +0200)]
Fix serialisation of the Atmos parts of a DCP.

3 years agoFix XML tag names; they are in the <Content> tag mixed in with all other sub-types.
Carl Hetherington [Fri, 19 Jun 2020 18:28:52 +0000 (20:28 +0200)]
Fix XML tag names; they are in the <Content> tag mixed in with all other sub-types.

3 years agoMake Atmos content work more like other content. Now its MXFs v2.15.82
Carl Hetherington [Fri, 19 Jun 2020 11:30:02 +0000 (13:30 +0200)]
Make Atmos content work more like other content.  Now its MXFs
are re-written, meaning that they can be encrypted.

This (along with the libdcp update) also fixes assorted Atmos bugs.

3 years agovalgrind suppression updates.
Carl Hetherington [Fri, 19 Jun 2020 11:19:16 +0000 (13:19 +0200)]
valgrind suppression updates.

3 years agoFix command line argument.
Carl Hetherington [Fri, 19 Jun 2020 11:18:53 +0000 (13:18 +0200)]
Fix command line argument.

3 years agoFix finding of CPLs to make KDMs for, broken by recent libdcp additions.
Carl Hetherington [Thu, 18 Jun 2020 10:54:07 +0000 (12:54 +0200)]
Fix finding of CPLs to make KDMs for, broken by recent libdcp additions.

3 years agoFix display of Atmos tracks in the timeline.
Carl Hetherington [Thu, 18 Jun 2020 10:53:38 +0000 (12:53 +0200)]
Fix display of Atmos tracks in the timeline.

3 years agoFix save/load of Atmos asset lengths.
Carl Hetherington [Thu, 18 Jun 2020 10:53:15 +0000 (12:53 +0200)]
Fix save/load of Atmos asset lengths.

3 years agopot/merge.
Carl Hetherington [Thu, 18 Jun 2020 08:22:44 +0000 (10:22 +0200)]
pot/merge.

3 years agoMove identifiers stuff out to a new prefs tab. v2.15.81
Carl Hetherington [Wed, 17 Jun 2020 09:54:33 +0000 (11:54 +0200)]
Move identifiers stuff out to a new prefs tab.

3 years agoAllow more complete control over the libdcp/DCP-o-matic metadata written to various...
Carl Hetherington [Tue, 16 Jun 2020 23:08:48 +0000 (01:08 +0200)]
Allow more complete control over the libdcp/DCP-o-matic metadata written to various places.

3 years agoGive a better error. v2.15.80
Carl Hetherington [Mon, 15 Jun 2020 22:21:28 +0000 (00:21 +0200)]
Give a better error.

3 years agoFix error when exporting stereo projects with "mixdown to stereo" v2.15.79
Carl Hetherington [Sun, 14 Jun 2020 20:12:51 +0000 (22:12 +0200)]
Fix error when exporting stereo projects with "mixdown to stereo"
set.

3 years agoFix for non-disk Linux build.
Carl Hetherington [Thu, 11 Jun 2020 22:06:37 +0000 (00:06 +0200)]
Fix for non-disk Linux build.

3 years agoUpdate test/data for removed Film metadata tags Signed and UploadAfterMakeDCP v2.15.78
Carl Hetherington [Thu, 11 Jun 2020 17:18:17 +0000 (19:18 +0200)]
Update test/data for removed Film metadata tags Signed and UploadAfterMakeDCP

3 years agoBump libdcp to fix failure to verify DCPs when the DTD path
Carl Hetherington [Thu, 11 Jun 2020 14:57:58 +0000 (16:57 +0200)]
Bump libdcp to fix failure to verify DCPs when the DTD path
has spaces in it (i.e. Windows) (#1766).

3 years agoI think we can waf install on the cscript build action even on Windows.
Carl Hetherington [Thu, 11 Jun 2020 12:29:43 +0000 (14:29 +0200)]
I think we can waf install on the cscript build action even on Windows.

3 years agoBump ffmpeg-cdist for ccache fixes on Windows.
Carl Hetherington [Thu, 11 Jun 2020 12:16:51 +0000 (14:16 +0200)]
Bump ffmpeg-cdist for ccache fixes on Windows.

3 years agoBump libdcp for fix to missing .xsd files in the install.
Carl Hetherington [Thu, 11 Jun 2020 09:20:00 +0000 (11:20 +0200)]
Bump libdcp for fix to missing .xsd files in the install.

3 years agoBump libdcp/libsub to get a Windows ccache build fix.
Carl Hetherington [Thu, 11 Jun 2020 08:52:57 +0000 (10:52 +0200)]
Bump libdcp/libsub to get a Windows ccache build fix.

3 years agoAdd some missing .xsd files to the Windows installer; may help with #1766.
Carl Hetherington [Wed, 10 Jun 2020 23:56:30 +0000 (01:56 +0200)]
Add some missing .xsd files to the Windows installer; may help with #1766.

3 years agoTry to provide some platform-specific menu text for 'show DCP in <thing>'
Carl Hetherington [Mon, 8 Jun 2020 23:45:00 +0000 (01:45 +0200)]
Try to provide some platform-specific menu text for 'show DCP in <thing>'

3 years agoAssorted GTK3 layout tidying in KDM dialogs.
Carl Hetherington [Mon, 8 Jun 2020 23:18:03 +0000 (01:18 +0200)]
Assorted GTK3 layout tidying in KDM dialogs.

3 years agoAdd a bunch of SetFocus calls.
Carl Hetherington [Mon, 8 Jun 2020 19:31:20 +0000 (21:31 +0200)]
Add a bunch of SetFocus calls.

3 years agoAdd space next to "use best" button.
Carl Hetherington [Mon, 8 Jun 2020 18:49:32 +0000 (20:49 +0200)]
Add space next to "use best" button.

3 years agoRemove unnecessary setup of _frame_rate_sizer which is
Carl Hetherington [Mon, 8 Jun 2020 18:49:11 +0000 (20:49 +0200)]
Remove unnecessary setup of _frame_rate_sizer which is
recreated later anyway.

3 years agoAdd a border round EditableLists on GTK3, otherwise they are hard to see.
Carl Hetherington [Mon, 8 Jun 2020 18:24:16 +0000 (20:24 +0200)]
Add a border round EditableLists on GTK3, otherwise they are hard to see.

3 years agoSet focus on opening dialog.
Carl Hetherington [Mon, 8 Jun 2020 18:23:52 +0000 (20:23 +0200)]
Set focus on opening dialog.

3 years agoImprove look of DCP metadata dialogue on scaling (#1762).
Carl Hetherington [Mon, 8 Jun 2020 17:41:10 +0000 (19:41 +0200)]
Improve look of DCP metadata dialogue on scaling (#1762).

3 years agoSpaces between content buttons in GTK3 (#1761).
Carl Hetherington [Mon, 8 Jun 2020 17:35:08 +0000 (19:35 +0200)]
Spaces between content buttons in GTK3 (#1761).

3 years agoMove upload-DCP-to-TMS button to preferences.
Carl Hetherington [Mon, 8 Jun 2020 16:21:37 +0000 (18:21 +0200)]
Move upload-DCP-to-TMS button to preferences.

3 years agoRemove encryption key options (#1760).
Carl Hetherington [Mon, 8 Jun 2020 00:16:06 +0000 (02:16 +0200)]
Remove encryption key options (#1760).

3 years agoAlways sign DCPs (#1760).
Carl Hetherington [Mon, 8 Jun 2020 00:11:18 +0000 (02:11 +0200)]
Always sign DCPs (#1760).

3 years agoFix erroneous hints about content being narrower than scope when it is near 2.35...
Carl Hetherington [Fri, 5 Jun 2020 23:56:11 +0000 (01:56 +0200)]
Fix erroneous hints about content being narrower than scope when it is near 2.35:1 (#1751).

3 years agoMake run script work when called from a different directory; some cleanup.
Carl Hetherington [Fri, 5 Jun 2020 23:18:53 +0000 (01:18 +0200)]
Make run script work when called from a different directory; some cleanup.

3 years agoThis AtomicityChecker was introduced a long time ago for reasons
Carl Hetherington [Thu, 4 Jun 2020 23:18:46 +0000 (01:18 +0200)]
This AtomicityChecker was introduced a long time ago for reasons
that are unclear.

This commit removes it because it was causing a bug whereby the
_suspended count on Butler would not go back down to 0 due to signals
being blocked by the AtomicityChecker.

I can see two possibilities:

1. AtomicityChecker is a band-aid for some deeper problem, in which
case other bugs will become apparent.  Perhaps it relates to signals
being sent before the butler/player/playlist are connected to content.

2. AtomicityChecker was correct but was not identifiying signals
from different pieces of content correctly; so the correct fix would
be to add the content pointer to the _checker.send() call and block
based also on that.

3 years agoAdd defensive check.
Carl Hetherington [Thu, 4 Jun 2020 23:18:31 +0000 (01:18 +0200)]
Add defensive check.

3 years agoFix thinko causing crashes when loading projects with legacy video ratios.
Carl Hetherington [Thu, 4 Jun 2020 22:09:31 +0000 (00:09 +0200)]
Fix thinko causing crashes when loading projects with legacy video ratios.

3 years agoFix crash when previewing projects with fewer than 6 audio channels;
Carl Hetherington [Thu, 4 Jun 2020 22:07:29 +0000 (00:07 +0200)]
Fix crash when previewing projects with fewer than 6 audio channels;
the old code tried to copy audio just because its channel had a non-0
value in the map without checking whether the destination channel
actually existed.

3 years agoOnly add ExamineContentJobs after a failed CheckContentChangeJob
Carl Hetherington [Thu, 4 Jun 2020 19:39:10 +0000 (21:39 +0200)]
Only add ExamineContentJobs after a failed CheckContentChangeJob
if we are in the GUI.  In the CLI client we will give up if the
CheckContentChangeJob fails, and immediately destroy the job manager
which doesn't end well if we have jobs running at the time.

3 years agoFall back to $PATH when searching for dcpomatic2_openssl.
Carl Hetherington [Thu, 4 Jun 2020 18:47:36 +0000 (20:47 +0200)]
Fall back to $PATH when searching for dcpomatic2_openssl.

3 years agoBump ffmpeg to get ccache fix.
Carl Hetherington [Thu, 4 Jun 2020 14:34:30 +0000 (16:34 +0200)]
Bump ffmpeg to get ccache fix.

3 years agoMissing virtual destructor.
Carl Hetherington [Wed, 3 Jun 2020 14:40:11 +0000 (16:40 +0200)]
Missing virtual destructor.

3 years agoClean up handling of paths relative to the executable.
Carl Hetherington [Wed, 3 Jun 2020 10:21:28 +0000 (12:21 +0200)]
Clean up handling of paths relative to the executable.

3 years agoWhite space fix.
Carl Hetherington [Wed, 3 Jun 2020 09:42:46 +0000 (11:42 +0200)]
White space fix.

3 years agoStart pinning libdcp/libsub versions again. v2.15.77
Carl Hetherington [Mon, 1 Jun 2020 22:23:43 +0000 (00:23 +0200)]
Start pinning libdcp/libsub versions again.

3 years agoHidden debug option to make _disk not start _disk_writer on Linux. v2.15.76
Carl Hetherington [Mon, 1 Jun 2020 20:47:17 +0000 (22:47 +0200)]
Hidden debug option to make _disk not start _disk_writer on Linux.

3 years agoRemove unused forward declaration.
Carl Hetherington [Wed, 27 May 2020 20:57:33 +0000 (22:57 +0200)]
Remove unused forward declaration.

3 years agoSome small manual updates.
Carl Hetherington [Tue, 26 May 2020 22:35:58 +0000 (00:35 +0200)]
Some small manual updates.

3 years agoMore fun with GTK3 and its enormous SpinButtons.
Carl Hetherington [Mon, 25 May 2020 21:57:52 +0000 (23:57 +0200)]
More fun with GTK3 and its enormous SpinButtons.

3 years agoDon't offer full-frame containers unless 'allow any container' is enabled.
Carl Hetherington [Mon, 25 May 2020 21:54:33 +0000 (23:54 +0200)]
Don't offer full-frame containers unless 'allow any container' is enabled.

3 years agoUse wxDC for all drawing of the audio mapping view, removing
Carl Hetherington [Sun, 24 May 2020 12:20:43 +0000 (14:20 +0200)]
Use wxDC for all drawing of the audio mapping view, removing
use of wxGraphicsContext.  This seems to fix strange rendering
problems on Windows.

3 years agoFix audio mapping view on GTK3, with some cleanups that mess up
Carl Hetherington [Sat, 23 May 2020 22:00:17 +0000 (00:00 +0200)]
Fix audio mapping view on GTK3, with some cleanups that mess up
display on Windows (fixed in the next commit).

3 years agoLayout tweaks for GTK3.
Carl Hetherington [Sat, 23 May 2020 20:59:39 +0000 (22:59 +0200)]
Layout tweaks for GTK3.

3 years agoWe must only link gtk2 if wx is also using it.
Carl Hetherington [Thu, 21 May 2020 22:26:53 +0000 (00:26 +0200)]
We must only link gtk2 if wx is also using it.

3 years agoWhite space.
Carl Hetherington [Thu, 21 May 2020 22:26:27 +0000 (00:26 +0200)]
White space.

3 years agoFix enabled/disable overlapping video/audio with DCP content (part of #1355)
Carl Hetherington [Tue, 19 May 2020 11:17:10 +0000 (13:17 +0200)]
Fix enabled/disable overlapping video/audio with DCP content (part of #1355)

3 years agoGive 'wrong target' KDM errors in a dialogue box rather than in the job manager ...
Carl Hetherington [Wed, 20 May 2020 22:05:50 +0000 (00:05 +0200)]
Give 'wrong target' KDM errors in a dialogue box rather than in the job manager (part of #1161).

3 years agoTell the user when they load a KDM which will not do anything useful (part of #1161).
Carl Hetherington [Wed, 20 May 2020 20:08:52 +0000 (22:08 +0200)]
Tell the user when they load a KDM which will not do anything useful (part of #1161).

3 years agoRound the length of video-containing content to the nearest frame.
Carl Hetherington [Wed, 20 May 2020 18:20:47 +0000 (20:20 +0200)]
Round the length of video-containing content to the nearest frame.
It seems reasonable, and is in the spirit of how positions are
rounded to frame boundaries.

It also fixes problems with unnecessary frames of black being
created at the end of trimmed files, where there can be
rounding-error-based confusion about where the content stops and
the black begins.

3 years agoAdd some context markers to a test.
Carl Hetherington [Wed, 20 May 2020 18:20:21 +0000 (20:20 +0200)]
Add some context markers to a test.

3 years agoAdd a bit more debug logging to the player.
Carl Hetherington [Wed, 20 May 2020 18:20:08 +0000 (20:20 +0200)]
Add a bit more debug logging to the player.

3 years agoTry rounding length_after_trim.
Carl Hetherington [Wed, 20 May 2020 12:36:16 +0000 (14:36 +0200)]
Try rounding length_after_trim.

3 years agoRename TYPE_DEBUG_PLAYER to TYPE_DEBUG_VIDEO_VIEW.
Carl Hetherington [Wed, 20 May 2020 08:02:06 +0000 (10:02 +0200)]
Rename TYPE_DEBUG_PLAYER to TYPE_DEBUG_VIDEO_VIEW.

3 years agoDifficult to see how any unprotected write with multiple readers
Carl Hetherington [Tue, 19 May 2020 23:51:25 +0000 (01:51 +0200)]
Difficult to see how any unprotected write with multiple readers
could be safe.

3 years agoCut the work done by a couple of tests, as previously they took
Carl Hetherington [Tue, 19 May 2020 22:13:07 +0000 (00:13 +0200)]
Cut the work done by a couple of tests, as previously they took
a much longer time for questionable benefit in terms of test
coverage.

3 years agoMore logging and make it go to the right place.
Carl Hetherington [Mon, 18 May 2020 23:39:47 +0000 (01:39 +0200)]
More logging and make it go to the right place.

3 years agoImprove test_timings script.
Carl Hetherington [Mon, 18 May 2020 22:45:35 +0000 (00:45 +0200)]
Improve test_timings script.

3 years agoUse test_suite log level with --debug so we can see when tests take
Carl Hetherington [Mon, 18 May 2020 19:54:55 +0000 (21:54 +0200)]
Use test_suite log level with --debug so we can see when tests take
long enough to time-out Jenkins.