From 5cc679b5c96e4a2916159f956e63d0d1a8724f86 Mon Sep 17 00:00:00 2001 From: Carl Hetherington Date: Sun, 6 Jan 2019 23:37:39 +0000 Subject: [PATCH] Disable subtitle view/font buttons with FFmpeg content (#1236). --- src/wx/text_panel.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/wx/text_panel.cc b/src/wx/text_panel.cc index ed49d8484..3c5abcefc 100644 --- a/src/wx/text_panel.cc +++ b/src/wx/text_panel.cc @@ -480,8 +480,9 @@ TextPanel::setup_sensitivity () _dcp_track->Enable (!reference && any_subs > 0 && use && type == TEXT_CLOSED_CAPTION); _language->Enable (!reference && any_subs > 0 && use && type == TEXT_OPEN_SUBTITLE); _stream->Enable (!reference && ffmpeg_subs == 1); - _text_view_button->Enable (!reference); - _fonts_dialog_button->Enable (!reference && type == TEXT_OPEN_SUBTITLE); + /* Ideally we would check here to see if the FFmpeg content has "string" subs (i.e. not bitmaps) */ + _text_view_button->Enable (!reference && any_subs > 0 && ffmpeg_subs == 0); + _fonts_dialog_button->Enable (!reference && any_subs > 0 && ffmpeg_subs == 0 && type == TEXT_OPEN_SUBTITLE); _appearance_dialog_button->Enable (!reference && any_subs > 0 && use && type == TEXT_OPEN_SUBTITLE); } -- 2.30.2