From 7560428649a428a4bdc3013f41ae7e8319cd5b42 Mon Sep 17 00:00:00 2001
From: Carl Hetherington <cth@carlh.net>
Date: Tue, 6 Apr 2021 00:49:23 +0200
Subject: [PATCH] Add hint for un-set text languages (#1954).

---
 src/lib/hints.cc | 16 ++++++++++++++++
 src/lib/hints.h  |  1 +
 2 files changed, 17 insertions(+)

diff --git a/src/lib/hints.cc b/src/lib/hints.cc
index 5ad0ba4bd..c9f901c18 100644
--- a/src/lib/hints.cc
+++ b/src/lib/hints.cc
@@ -394,6 +394,7 @@ Hints::thread ()
 	check_loudness ();
 	check_ffec_and_ffmc_in_smpte_feature ();
 	check_out_of_range_markers ();
+	check_text_languages ();
 
 	emit (bind(boost::ref(Progress), _("Examining closed captions")));
 
@@ -585,3 +586,18 @@ Hints::join ()
 {
 	_thread.join ();
 }
+
+
+void
+Hints::check_text_languages ()
+{
+	for (auto i: film()->content()) {
+		for (auto j: i->text) {
+			if (j->use() && !j->language()) {
+				hint (_("At least one piece of subtitle or closed caption content has no specified language.  "
+					"It is advisable to set the language for each piece of subtitle or closed caption content in the \"Content→Timed Text\" tab"));
+				return;
+			}
+		}
+	}
+}
diff --git a/src/lib/hints.h b/src/lib/hints.h
index 5fc2e245a..a7e476b2c 100644
--- a/src/lib/hints.h
+++ b/src/lib/hints.h
@@ -74,6 +74,7 @@ private:
 	void check_loudness ();
 	void check_ffec_and_ffmc_in_smpte_feature ();
 	void check_out_of_range_markers ();
+	void check_text_languages ();
 
 	boost::thread _thread;
 	/** This is used to make a partial DCP containing only the subtitles and closed captions that
-- 
2.30.2