From b6e54c2c9d89016df4e1efe98974d6d69c9cc22b Mon Sep 17 00:00:00 2001 From: Carl Hetherington Date: Tue, 18 Dec 2018 22:50:30 +0000 Subject: [PATCH] swaroop: at least partially fix crashes when trying to set the background image to something invalid. --- src/wx/player_config_dialog.cc | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/wx/player_config_dialog.cc b/src/wx/player_config_dialog.cc index b16c76b36..ab7228438 100644 --- a/src/wx/player_config_dialog.cc +++ b/src/wx/player_config_dialog.cc @@ -313,7 +313,16 @@ private: #ifdef DCPOMATIC_VARIANT_SWAROOP void background_image_changed () { - Config::instance()->set_player_background_image(wx_to_std(_background_image->GetPath())); + boost::filesystem::path const f = wx_to_std(_background_image->GetPath()); + if (!boost::filesystem::is_regular_file(f) || !wxImage::CanRead(std_to_wx(f.string()))) { + error_dialog (0, _("Could not load image file.")); + if (Config::instance()->player_background_image()) { + checked_set (_background_image, *Config::instance()->player_background_image()); + } + return; + } + + Config::instance()->set_player_background_image(f); } #endif -- 2.30.2