From ba48b2755a20fae63c9ae7c89134637ca1a9df3c Mon Sep 17 00:00:00 2001 From: Carl Hetherington Date: Fri, 20 Nov 2015 00:33:35 +0000 Subject: [PATCH] Tweak SubRip subtitle default position. --- ChangeLog | 4 ++++ src/lib/subrip_decoder.cc | 6 +++--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index cfa5de093..87edbddc4 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,7 @@ +2015-11-20 Carl Hetherington + + * Lower default position of SubRip subtitles a bit. + 2015-11-19 Carl Hetherington * Adjust preview subtitle position to better match reality diff --git a/src/lib/subrip_decoder.cc b/src/lib/subrip_decoder.cc index a9065994b..2f8b8a5f3 100644 --- a/src/lib/subrip_decoder.cc +++ b/src/lib/subrip_decoder.cc @@ -87,10 +87,10 @@ SubRipDecoder::pass (PassReason, bool) dcp::Time (_subtitles[_next].to.all_as_seconds(), 1000), 0, dcp::HALIGN_CENTER, - /* This 0.95 is an arbitrary value to lift the bottom sub off the bottom - of the screen a bit. + /* This 1.015 is an arbitrary value to lift the bottom sub off the bottom + of the screen a bit to a pleasing degree. */ - 0.95 - ((1 + highest - i.vertical_position.line.get()) * 1.5 / 22), + 1.015 - ((1 + highest - i.vertical_position.line.get()) * 1.5 / 22), dcp::VALIGN_TOP, j.text, content->outline() ? dcp::BORDER : dcp::NONE, -- 2.30.2