From 9c36e773ca56bb8b6b5082b22dff20412901049d Mon Sep 17 00:00:00 2001 From: Carl Hetherington Date: Mon, 22 Nov 2021 20:57:07 +0100 Subject: [PATCH] Clarify some errors and add comments wondering about their validity. --- src/verify_j2k.cc | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/verify_j2k.cc b/src/verify_j2k.cc index 48d85a33..7193f64d 100644 --- a/src/verify_j2k.cc +++ b/src/verify_j2k.cc @@ -221,7 +221,8 @@ dcp::verify_j2k (shared_ptr j2k, vector& notes) } else if (*marker_name == "COD") { num_COD++; get_16(); // length - require_8(1, "invalid coding style %1"); + /* XXX: I can't find any evidence for this: must the coding style really always be 1? */ + require_8(1, "invalid COD coding style %1"); require_8(4, "invalid progression order %1"); // CPRL require_16(1, "invalid quality layers count %1"); require_8(1, "invalid multi-component transform flag %1"); @@ -260,7 +261,8 @@ dcp::verify_j2k (shared_ptr j2k, vector& notes) } else if (*marker_name == "COC") { get_16(); // length require_8(0, "invalid COC component number"); - require_8(1, "invalid coding style %1"); + /* XXX: I can't find any evidence for this: must the coding style really always be 1? */ + require_8(1, "invalid COC coding style %1"); require_8(5, "invalid number of transform levels %1"); require_8(3, "invalid code block width exponent %1"); require_8(3, "invalid code block height exponent %1"); -- 2.30.2