From c6d187747222c980e28a6e50196a85ee570990a7 Mon Sep 17 00:00:00 2001 From: Carl Hetherington Date: Tue, 21 May 2019 21:23:55 +0100 Subject: [PATCH] Increase header size when writing SMPTE subtitle MXFs; fixes problems when writing lots of subs (DCP-o-matic bug #1561). This is a backport of b7c7e14463d91608b080a5a63fcfb4d330ced863 from master. --- src/smpte_subtitle_asset.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/smpte_subtitle_asset.cc b/src/smpte_subtitle_asset.cc index ae473071..27f486da 100644 --- a/src/smpte_subtitle_asset.cc +++ b/src/smpte_subtitle_asset.cc @@ -393,7 +393,10 @@ SMPTESubtitleAsset::write (boost::filesystem::path p) const descriptor.ContainerDuration = _intrinsic_duration; ASDCP::TimedText::MXFWriter writer; - ASDCP::Result_t r = writer.OpenWrite (p.string().c_str(), writer_info, descriptor); + /* This header size is a guess. Empirically it seems that each subtitle reference is 90 bytes, and we need some extra. + The defualt size is not enough for some feature-length PNG sub projects (see DCP-o-matic #1561). + */ + ASDCP::Result_t r = writer.OpenWrite (p.string().c_str(), writer_info, descriptor, _subtitles.size() * 90 + 16384); if (ASDCP_FAILURE (r)) { boost::throw_exception (FileError ("could not open subtitle MXF for writing", p.string(), r)); } -- 2.30.2