From 2f508609da978d20cdd5893ec91746a5167d1c7b Mon Sep 17 00:00:00 2001 From: Carl Hetherington Date: Thu, 26 Mar 2020 21:45:14 +0100 Subject: [PATCH] Add a FIXME. --- src/stl_binary_reader.cc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/stl_binary_reader.cc b/src/stl_binary_reader.cc index 9a7a150..e8e8832 100644 --- a/src/stl_binary_reader.cc +++ b/src/stl_binary_reader.cc @@ -211,6 +211,9 @@ void STLBinaryReader::read (shared_ptr reader) RawSubtitle sub; sub.from = reader->get_timecode(5, frame_rate); sub.to = reader->get_timecode(9, frame_rate); + /* XXX: only the verticial position of the first TTI block should be used (says the spec), + so using reader->get_int(13, 1) here is wrong if i > 0 + */ sub.vertical_position.line = reader->get_int(13, 1) + i; sub.vertical_position.lines = maximum_rows; sub.vertical_position.reference = TOP_OF_SCREEN; -- 2.30.2