From: Carl Hetherington <cth@carlh.net>
Date: Mon, 1 Jan 2018 23:57:07 +0000 (+0000)
Subject: Revert "Packet header writing: set empty packet header bit to 0 when appropriate... 
X-Git-Url: https://main.carlh.net/gitweb/?p=openjpeg.git;a=commitdiff_plain;h=94a73247dbebba37dc386924e5ae028acaa3d0a2

Revert "Packet header writing: set empty packet header bit to 0 when appropriate (small optimization)"

This reverts commit 2609fb8077125b5b31f1bcc2f98c12ff1e6572d7.

I am testing this reversion to see if it fixes problems with DCP
playback on various systems (DCP-o-matic bug #1136).
---

diff --git a/src/lib/openjp2/t2.c b/src/lib/openjp2/t2.c
index 71472b49..bc0475b9 100644
--- a/src/lib/openjp2/t2.c
+++ b/src/lib/openjp2/t2.c
@@ -797,8 +797,7 @@ static OPJ_BOOL opj_t2_encode_packet(OPJ_UINT32 tileno,
 
     /* Writing Packet header */
     band = res->bands;
-    for (bandno = 0; !packet_empty &&
-            bandno < res->numbands; ++bandno, ++band)      {
+    for (bandno = 0; bandno < res->numbands; ++bandno, ++band)      {
         opj_tcd_precinct_t *prc;
 
         /* Skip empty bands */
@@ -931,7 +930,7 @@ static OPJ_BOOL opj_t2_encode_packet(OPJ_UINT32 tileno,
 
     /* Writing the packet body */
     band = res->bands;
-    for (bandno = 0; !packet_empty && bandno < res->numbands; bandno++, ++band) {
+    for (bandno = 0; bandno < res->numbands; bandno++, ++band) {
         opj_tcd_precinct_t *prc;
 
         /* Skip empty bands */