From 9701b3305db58d35e4446946309f88937e2f5342 Mon Sep 17 00:00:00 2001 From: Robert Ancell Date: Sun, 17 Nov 2019 15:09:59 +1300 Subject: [PATCH] JPWL: convert: Fix buffer overflow reading an image file less than four characters (#1196) Fixes #1068 --- src/bin/jpwl/convert.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bin/jpwl/convert.c b/src/bin/jpwl/convert.c index 4f636c17..e6feea50 100644 --- a/src/bin/jpwl/convert.c +++ b/src/bin/jpwl/convert.c @@ -1488,7 +1488,7 @@ int imagetopgx(opj_image_t * image, const char *outfile) const size_t olen = strlen(outfile); const size_t dotpos = olen - 4; const size_t total = dotpos + 1 + 1 + 4; /* '-' + '[1-3]' + '.pgx' */ - if (outfile[dotpos] != '.') { + if (olen < 4 || outfile[dotpos] != '.') { /* `pgx` was recognized but there is no dot at expected position */ fprintf(stderr, "ERROR -> Impossible happen."); return 1; -- 2.30.2