Added Write All, Play All, etc. automation buttons to generic plugin UI
[ardour.git] / gtk2_ardour / generic_pluginui.cc
index 83f091a1e0a69c6a1e8765029d1be53cae3dfd06..dbb86277e0a19b69c647ebb13308e11d7c125eef 100644 (file)
@@ -25,6 +25,7 @@
 #include <cerrno>
 #include <cmath>
 #include <string>
+#include <vector>
 
 #include "pbd/stl_delete.h"
 #include "pbd/xml++.h"
 #include "ardour/plugin.h"
 #include "ardour/plugin_insert.h"
 #include "ardour/session.h"
+#include "ardour/value_as_string.h"
 
 #include "ardour_ui.h"
 #include "prompter.h"
 #include "plugin_ui.h"
-#include "utils.h"
 #include "gui_thread.h"
 #include "automation_controller.h"
 
@@ -57,14 +58,14 @@ using namespace Gtkmm2ext;
 using namespace Gtk;
 
 GenericPluginUI::GenericPluginUI (boost::shared_ptr<PluginInsert> pi, bool scrollable)
-       : PlugUIBase (pi),
-         button_table (initial_button_rows, initial_button_cols),
-         output_table (initial_output_rows, initial_output_cols),
-         hAdjustment(0.0, 0.0, 0.0),
-         vAdjustment(0.0, 0.0, 0.0),
-         scroller_view(hAdjustment, vAdjustment),
-         automation_menu (0),
-         is_scrollable(scrollable)
+       : PlugUIBase (pi)
+       , button_table (initial_button_rows, initial_button_cols)
+       , output_table (initial_output_rows, initial_output_cols)
+       , hAdjustment(0.0, 0.0, 0.0)
+       , vAdjustment(0.0, 0.0, 0.0)
+       , scroller_view(hAdjustment, vAdjustment)
+       , automation_menu (0)
+       , is_scrollable(scrollable)
 {
        set_name ("PluginEditor");
        set_border_width (10);
@@ -75,7 +76,9 @@ GenericPluginUI::GenericPluginUI (boost::shared_ptr<PluginInsert> pi, bool scrol
 
        HBox* constraint_hbox = manage (new HBox);
        HBox* smaller_hbox = manage (new HBox);
+       HBox* automation_hbox = manage (new HBox);
        smaller_hbox->set_spacing (4);
+       automation_hbox->set_spacing (4);
        Label* combo_label = manage (new Label (_("<span size=\"large\">Presets</span>")));
        combo_label->set_use_markup (true);
 
@@ -90,6 +93,20 @@ GenericPluginUI::GenericPluginUI (boost::shared_ptr<PluginInsert> pi, bool scrol
        smaller_hbox->pack_start (save_button, false, false);
        smaller_hbox->pack_start (delete_button, false, false);
        smaller_hbox->pack_start (bypass_button, false, true);
+       
+       automation_manual_all_button.set_label(_("Manual All"));
+       automation_play_all_button.set_label(_("Play All"));
+       automation_write_all_button.set_label(_("Write All"));
+       automation_touch_all_button.set_label(_("Touch All"));
+       
+       Gtk::Alignment *al = Gtk::manage(new Gtk::Alignment());
+    al->set_size_request(6, 2);
+    automation_hbox->pack_start(*al, false, true);
+    
+       automation_hbox->pack_start (automation_manual_all_button, false, false);
+       automation_hbox->pack_start (automation_play_all_button, false, false);
+       automation_hbox->pack_start (automation_write_all_button, false, false);
+       automation_hbox->pack_start (automation_touch_all_button, false, false);
 
        constraint_hbox->set_spacing (5);
        constraint_hbox->set_homogeneous (false);
@@ -102,6 +119,7 @@ GenericPluginUI::GenericPluginUI (boost::shared_ptr<PluginInsert> pi, bool scrol
        }
 
        v1_box->pack_start (*smaller_hbox, false, true);
+       v1_box->pack_start (*automation_hbox, false, true);
        v2_box->pack_start (focus_button, false, true);
 
        main_contents.pack_start (settings_box, false, false);
@@ -239,30 +257,35 @@ GenericPluginUI::build ()
        frame->add (*box);
        hpacker.pack_start(*frame, true, true);
 
-       /* find all ports. build control elements for all appropriate control ports */
-       std::vector<ControlUI *> cui_controls_list;
+       std::vector<ControlUI *> control_uis;
 
+       // Build a ControlUI for each control port
        for (i = 0; i < plugin->parameter_count(); ++i) {
 
                if (plugin->parameter_is_control (i)) {
 
                        /* Don't show latency control ports */
 
-                       if (plugin->describe_parameter (Evoral::Parameter(PluginAutomation, 0, i)) == X_("latency")) {
+                       const Evoral::Parameter param(PluginAutomation, 0, i);
+                       if (plugin->describe_parameter (param) == X_("latency")) {
                                continue;
                        }
 
-                       if (plugin->describe_parameter (Evoral::Parameter(PluginAutomation, 0, i)) == X_("hidden")) {
+                       if (plugin->describe_parameter (param) == X_("hidden")) {
                                continue;
                        }
 
+                       const float value = plugin->get_parameter(i);
+
                        ControlUI* cui;
 
                        boost::shared_ptr<ARDOUR::AutomationControl> c
                                = boost::dynamic_pointer_cast<ARDOUR::AutomationControl>(
-                                       insert->control(Evoral::Parameter(PluginAutomation, 0, i)));
+                                       insert->control(param));
 
-                       if ((cui = build_control_ui (i, c)) == 0) {
+                       ParameterDescriptor desc;
+                       plugin->get_parameter_descriptor(i, desc);
+                       if ((cui = build_control_ui (param, desc, c, value, plugin->parameter_is_input(i))) == 0) {
                                error << string_compose(_("Plugin Editor: could not build control element for port %1"), i) << endmsg;
                                continue;
                        }
@@ -272,46 +295,88 @@ GenericPluginUI::build ()
                                ARDOUR_UI::instance()->set_tip(cui, param_docs.c_str());
                        }
 
-                       if (cui->controller || cui->clickbox || cui->combo) {
-                               // Get all of the controls into a list, so that
-                               // we can lay them out a bit more nicely later.
-                               cui_controls_list.push_back(cui);
-                       } else if (cui->button) {
-
-                               if (!is_scrollable && button_row == button_rows) {
-                                       button_row = 0;
-                                       if (++button_col == button_cols) {
-                                               button_cols += 2;
-                                               button_table.resize (button_rows, button_cols);
-                                       }
-                               }
+                       control_uis.push_back(cui);
+               }
+       }
 
-                               button_table.attach (*cui, button_col, button_col + 1, button_row, button_row+1,
-                                                    FILL|EXPAND, FILL);
-                               button_row++;
+       // Build a ControlUI for each property
+       const Plugin::PropertyDescriptors& descs = plugin->get_supported_properties();
+       for (Plugin::PropertyDescriptors::const_iterator d = descs.begin(); d != descs.end(); ++d) {
+               const ParameterDescriptor& desc = d->second;
+               const Evoral::Parameter    param(PluginPropertyAutomation, 0, desc.key);
 
-                       } else if (cui->display) {
+               boost::shared_ptr<ARDOUR::AutomationControl> c
+                       = boost::dynamic_pointer_cast<ARDOUR::AutomationControl>(
+                               insert->control(param));
+
+               if (!c) {
+                       error << string_compose(_("Plugin Editor: no control for property %1"), desc.key) << endmsg;
+                       continue;
+               }
 
-                               output_table.attach (*cui, output_col, output_col + 1, output_row, output_row+1,
-                                                    FILL|EXPAND, FILL);
+               ControlUI* cui = build_control_ui(param, desc, c, c->get_value(), true);
+               if (!cui) {
+                       error << string_compose(_("Plugin Editor: could not build control element for property %1"),
+                                               desc.key) << endmsg;
+                       continue;
+               }
 
-                               // TODO: The meters should be divided into multiple rows
+               control_uis.push_back(cui);
+       }
+       if (!descs.empty()) {
+               plugin->announce_property_values();
+       }
+       
+       // Connect automation *_all buttons
+       automation_manual_all_button.signal_clicked().connect(boost::bind(&GenericPluginUI::automation_manual_all, this, control_uis));
+       automation_play_all_button.signal_clicked().connect(boost::bind(&GenericPluginUI::automation_play_all, this, control_uis));
+    automation_write_all_button.signal_clicked().connect(boost::bind(&GenericPluginUI::automation_write_all, this, control_uis));
+    automation_touch_all_button.signal_clicked().connect(boost::bind(&GenericPluginUI::automation_touch_all, this, control_uis));
 
-                               if (++output_col == output_cols) {
-                                       output_cols ++;
-                                       output_table.resize (output_rows, output_cols);
+       // Add special controls to UI, and build list of normal controls to be layed out later
+       std::vector<ControlUI *> cui_controls_list;
+       for (i = 0; i < control_uis.size(); ++i) {
+               ControlUI* cui = control_uis[i];
+
+               if (cui->controller || cui->clickbox || cui->combo) {
+                       // Get all of the controls into a list, so that
+                       // we can lay them out a bit more nicely later.
+                       cui_controls_list.push_back(cui);
+               } else if (cui->button || cui->file_button) {
+
+                       if (!is_scrollable && button_row == button_rows) {
+                               button_row = 0;
+                               if (++button_col == button_cols) {
+                                       button_cols += 2;
+                                       button_table.resize (button_rows, button_cols);
                                }
                        }
-               } 
+
+                       button_table.attach (*cui, button_col, button_col + 1, button_row, button_row+1,
+                                            FILL|EXPAND, FILL);
+                       button_row++;
+
+               } else if (cui->display) {
+
+                       output_table.attach (*cui, output_col, output_col + 1, output_row, output_row+1,
+                                            FILL|EXPAND, FILL);
+
+                       // TODO: The meters should be divided into multiple rows
+
+                       if (++output_col == output_cols) {
+                               output_cols ++;
+                               output_table.resize (output_rows, output_cols);
+                       }
+               }
        }
 
        // Iterate over the list of controls to find which adjacent controls
        // are similar enough to be grouped together.
        
        string label, previous_label = "";
-       int numbers_in_labels[cui_controls_list.size()];
+       std::vector<int> numbers_in_labels(cui_controls_list.size());
        
-       float similarity_scores[cui_controls_list.size()];
+       std::vector<float> similarity_scores(cui_controls_list.size());
        float most_similar = 0.0, least_similar = 1.0;
        
        i = 0;
@@ -412,8 +477,10 @@ GenericPluginUI::build ()
        button_table.show_all ();
 }
 
-GenericPluginUI::ControlUI::ControlUI ()
-       : automate_button (X_("")) // force creation of a label
+GenericPluginUI::ControlUI::ControlUI (const Evoral::Parameter& p)
+       : param(p)
+       , automate_button (X_("")) // force creation of a label
+       , file_button(NULL)
 {
        automate_button.set_name ("PluginAutomateButton");
        ARDOUR_UI::instance()->set_tip (automate_button, _("Automation control"));
@@ -466,25 +533,23 @@ GenericPluginUI::automation_state_changed (ControlUI* cui)
        }
 }
 
-
 bool
 GenericPluginUI::integer_printer (char buf[32], Adjustment &adj, ControlUI* cui)
 {
-       float const v = adj.get_value ();
-       
-       if (cui->scale_points) {
-               Plugin::ScalePoints::const_iterator i = cui->scale_points->begin ();
-               while (i != cui->scale_points->end() && i->second != v) {
-                       ++i;
-               }
+       float const        v   = cui->control->interface_to_internal(adj.get_value ());
+       const std::string& str = ARDOUR::value_as_string(cui->control->desc(), Variant(v));
+       const size_t       len = str.copy(buf, 31);
+       buf[len] = '\0';
+       return true;
+}
 
-               if (i != cui->scale_points->end ()) {
-                       snprintf (buf, 32, "%s", i->first.c_str());
-                       return true;
-               }
-       }
-               
-       snprintf (buf, 32, "%.0f", v);
+bool
+GenericPluginUI::midinote_printer (char buf[32], Adjustment &adj, ControlUI* cui)
+{
+       float const        v   = cui->control->interface_to_internal(adj.get_value ());
+       const std::string& str = ARDOUR::value_as_string(cui->control->desc(), Variant(v));
+       const size_t       len = str.copy(buf, 31);
+       buf[len] = '\0';
        return true;
 }
 
@@ -494,32 +559,34 @@ GenericPluginUI::print_parameter (char *buf, uint32_t len, uint32_t param)
        plugin->print_parameter (param, buf, len);
 }
 
+/** Build a ControlUI for a parameter/property.
+ * Note that mcontrol may be NULL for outputs.
+ */
 GenericPluginUI::ControlUI*
-GenericPluginUI::build_control_ui (guint32 port_index, boost::shared_ptr<AutomationControl> mcontrol)
+GenericPluginUI::build_control_ui (const Evoral::Parameter&             param,
+                                   const ParameterDescriptor&           desc,
+                                   boost::shared_ptr<AutomationControl> mcontrol,
+                                   float                                value,
+                                   bool                                 is_input)
 {
        ControlUI* control_ui = 0;
 
-       Plugin::ParameterDescriptor desc;
-
-       plugin->get_parameter_descriptor (port_index, desc);
-
-       control_ui = manage (new ControlUI ());
+       control_ui = manage (new ControlUI (param));
        control_ui->combo = 0;
        control_ui->control = mcontrol;
        control_ui->update_pending = false;
        control_ui->label.set_text (desc.label);
        control_ui->label.set_alignment (0.0, 0.5);
        control_ui->label.set_name ("PluginParameterLabel");
-       control_ui->port_index = port_index;
 
        control_ui->set_spacing (5);
 
        Gtk::Requisition req (control_ui->automate_button.size_request());
 
-       if (plugin->parameter_is_input(port_index)) {
+       if (is_input) {
 
                /* See if there any named values for our input value */
-               control_ui->scale_points = plugin->get_scale_points (port_index);
+               control_ui->scale_points = desc.scale_points;
 
                /* If this parameter is an integer, work out the number of distinct values
                   it can take on (assuming that lower and upper values are allowed).
@@ -535,7 +602,7 @@ GenericPluginUI::build_control_ui (guint32 port_index, boost::shared_ptr<Automat
 
                        std::vector<std::string> labels;
                        for (
-                               ARDOUR::Plugin::ScalePoints::const_iterator i = control_ui->scale_points->begin();
+                               ARDOUR::ScalePoints::const_iterator i = control_ui->scale_points->begin();
                                i != control_ui->scale_points->end();
                                ++i) {
                                
@@ -572,12 +639,12 @@ GenericPluginUI::build_control_ui (guint32 port_index, boost::shared_ptr<Automat
                        control_ui->pack_start (control_ui->automate_button, false, false);
 
                        control_ui->button->signal_clicked().connect (sigc::bind (sigc::mem_fun(*this, &GenericPluginUI::control_port_toggled), control_ui));
-                       control_ui->automate_button.signal_clicked().connect (bind (mem_fun(*this, &GenericPluginUI::astate_clicked), control_ui, (uint32_t) port_index));
+                       control_ui->automate_button.signal_clicked().connect (bind (mem_fun(*this, &GenericPluginUI::astate_clicked), control_ui));
 
                        mcontrol->Changed.connect (control_connections, invalidator (*this), boost::bind (&GenericPluginUI::toggle_parameter_changed, this, control_ui), gui_context());
                        mcontrol->alist()->automation_state_changed.connect (control_connections, invalidator (*this), boost::bind (&GenericPluginUI::automation_state_changed, this, control_ui), gui_context());
 
-                       if (plugin->get_parameter (port_index) > 0.5){
+                       if (value > 0.5){
                                control_ui->button->set_active(true);
                        }
 
@@ -586,10 +653,35 @@ GenericPluginUI::build_control_ui (guint32 port_index, boost::shared_ptr<Automat
                        return control_ui;
                }
 
+               if (desc.datatype == Variant::PATH) {
+
+                       /* Build a file selector button */
+
+                       // Create/add controller
+                       control_ui->file_button = manage(new Gtk::FileChooserButton(Gtk::FILE_CHOOSER_ACTION_OPEN));
+                       control_ui->file_button->set_title(desc.label);
+
+                       control_ui->pack_start (control_ui->label, true, true);
+                       control_ui->pack_start (*control_ui->file_button, true, true);
+
+                       // Connect signals (TODO: do this via the Control)
+                       control_ui->file_button->signal_file_set().connect(
+                               sigc::bind(sigc::mem_fun(*this, &GenericPluginUI::set_property),
+                                          desc, control_ui->file_button));
+                       plugin->PropertyChanged.connect(*this, invalidator(*this),
+                                                       boost::bind(&GenericPluginUI::property_changed, this, _1, _2),
+                                                       gui_context());
+
+                       _property_controls.insert(std::make_pair(desc.key, control_ui->file_button));
+                       control_ui->file_button = control_ui->file_button;
+
+                       return control_ui;
+               }
+
                /* create the controller */
 
                if (mcontrol) {
-                       control_ui->controller = AutomationController::create(insert, mcontrol->parameter(), mcontrol);
+                       control_ui->controller = AutomationController::create(insert, mcontrol->parameter(), desc, mcontrol);
                }
 
                /* XXX this code is not right yet, because it doesn't handle
@@ -597,33 +689,27 @@ GenericPluginUI::build_control_ui (guint32 port_index, boost::shared_ptr<Automat
                */
 
                Adjustment* adj = control_ui->controller->adjustment();
-               boost::shared_ptr<PluginInsert::PluginControl> pc = boost::dynamic_pointer_cast<PluginInsert::PluginControl> (control_ui->control);
-
-               adj->set_lower (pc->internal_to_interface (desc.lower));
-               adj->set_upper (pc->internal_to_interface (desc.upper));
-
-               adj->set_step_increment (desc.step);
-               adj->set_page_increment (desc.largestep);
 
                if (desc.integer_step) {
-                       control_ui->clickbox = new ClickBox (adj, "PluginUIClickBox");
+                       control_ui->clickbox = new ClickBox (adj, "PluginUIClickBox", desc.enumeration);
                        Gtkmm2ext::set_size_request_to_display_given_text (*control_ui->clickbox, "g9999999", 2, 2);
-                       control_ui->clickbox->set_printer (sigc::bind (sigc::mem_fun (*this, &GenericPluginUI::integer_printer), control_ui));
+                       if (desc.unit == ParameterDescriptor::MIDI_NOTE) {
+                               control_ui->clickbox->set_printer (sigc::bind (sigc::mem_fun (*this, &GenericPluginUI::midinote_printer), control_ui));
+                       } else {
+                               control_ui->clickbox->set_printer (sigc::bind (sigc::mem_fun (*this, &GenericPluginUI::integer_printer), control_ui));
+                       }
                } else {
                        //sigc::slot<void,char*,uint32_t> pslot = sigc::bind (sigc::mem_fun(*this, &GenericPluginUI::print_parameter), (uint32_t) port_index);
 
                        control_ui->controller->set_size_request (200, req.height);
-                       control_ui->controller->set_name (X_("PluginSlider"));
-                       control_ui->controller->set_style (BarController::LeftToRight);
-                       control_ui->controller->set_use_parent (true);
-                       control_ui->controller->set_logarithmic (desc.logarithmic);
+                       control_ui->controller->set_name (X_("ProcessorControlSlider"));
 
                        control_ui->controller->StartGesture.connect (sigc::bind (sigc::mem_fun(*this, &GenericPluginUI::start_touch), control_ui));
                        control_ui->controller->StopGesture.connect (sigc::bind (sigc::mem_fun(*this, &GenericPluginUI::stop_touch), control_ui));
 
                }
 
-               adj->set_value (pc->internal_to_interface (plugin->get_parameter (port_index)));
+               adj->set_value (mcontrol->internal_to_interface(value));
 
                /* XXX memory leak: SliderController not destroyed by ControlUI
                   destructor, and manage() reports object hierarchy
@@ -638,7 +724,7 @@ GenericPluginUI::build_control_ui (guint32 port_index, boost::shared_ptr<Automat
                }
 
                control_ui->pack_start (control_ui->automate_button, false, false);
-               control_ui->automate_button.signal_clicked().connect (sigc::bind (sigc::mem_fun(*this, &GenericPluginUI::astate_clicked), control_ui, (uint32_t) port_index));
+               control_ui->automate_button.signal_clicked().connect (sigc::bind (sigc::mem_fun(*this, &GenericPluginUI::astate_clicked), control_ui));
 
                automation_state_changed (control_ui);
 
@@ -647,7 +733,7 @@ GenericPluginUI::build_control_ui (guint32 port_index, boost::shared_ptr<Automat
 
                input_controls.push_back (control_ui);
 
-       } else if (plugin->parameter_is_output (port_index)) {
+       } else if (!is_input) {
 
                control_ui->display = manage (new EventBox);
                control_ui->display->set_name ("ParameterValueDisplay");
@@ -664,7 +750,7 @@ GenericPluginUI::build_control_ui (guint32 port_index, boost::shared_ptr<Automat
                /* set up a meter */
                /* TODO: only make a meter if the port is Hinted for it */
 
-               MeterInfo * info = new MeterInfo(port_index);
+               MeterInfo * info = new MeterInfo();
                control_ui->meterinfo = info;
 
                info->meter = new FastMeter (
@@ -675,8 +761,8 @@ GenericPluginUI::build_control_ui (guint32 port_index, boost::shared_ptr<Automat
                                0xcccc00ff, 0xcccc00ff,
                                0xffaa00ff, 0xffaa00ff,
                                0xff0000ff,
-                               ARDOUR_UI::config()->canvasvar_MeterBackgroundBot.get(),
-                               ARDOUR_UI::config()->canvasvar_MeterBackgroundTop.get()
+                               ARDOUR_UI::config()->get_MeterBackgroundBot(),
+                               ARDOUR_UI::config()->get_MeterBackgroundTop()
                                );
 
                info->min_unbound = desc.min_unbound;
@@ -727,7 +813,7 @@ GenericPluginUI::stop_touch (GenericPluginUI::ControlUI* cui)
 }
 
 void
-GenericPluginUI::astate_clicked (ControlUI* cui, uint32_t /*port*/)
+GenericPluginUI::astate_clicked (ControlUI* cui)
 {
        using namespace Menu_Helpers;
 
@@ -751,6 +837,42 @@ GenericPluginUI::astate_clicked (ControlUI* cui, uint32_t /*port*/)
        automation_menu->popup (1, gtk_get_current_event_time());
 }
 
+void 
+GenericPluginUI::automation_manual_all(std::vector<ControlUI *>& controls)
+{
+    for (std::vector<ControlUI *>::iterator control_it = controls.begin(); control_it != controls.end(); ++control_it)
+    {
+        set_automation_state((AutoState) ARDOUR::Off, (*control_it));
+    }
+}
+
+void 
+GenericPluginUI::automation_play_all(std::vector<ControlUI *>& controls)
+{
+    for (std::vector<ControlUI *>::iterator control_it = controls.begin(); control_it != controls.end(); ++control_it)
+    {
+        set_automation_state((AutoState) Play, (*control_it));
+    }
+}
+
+void 
+GenericPluginUI::automation_write_all(std::vector<ControlUI *>& controls)
+{
+    for (std::vector<ControlUI *>::iterator control_it = controls.begin(); control_it != controls.end(); ++control_it)
+    {
+        set_automation_state((AutoState) Write, (*control_it));
+    }
+}
+
+void 
+GenericPluginUI::automation_touch_all(std::vector<ControlUI *>& controls)
+{
+    for (std::vector<ControlUI *>::iterator control_it = controls.begin(); control_it != controls.end(); ++control_it)
+    {
+        set_automation_state((AutoState) Touch, (*control_it));
+    }
+}
+
 void
 GenericPluginUI::set_automation_state (AutoState state, ControlUI* cui)
 {
@@ -765,8 +887,10 @@ GenericPluginUI::toggle_parameter_changed (ControlUI* cui)
        if (!cui->ignore_change) {
                if (val > 0.5) {
                        cui->button->set_active (true);
+                       cui->button->set_name ("PluginEditorButton-active");
                } else {
                        cui->button->set_active (false);
+                       cui->button->set_name ("PluginEditorButton");
                }
        }
 }
@@ -792,7 +916,7 @@ GenericPluginUI::update_control_display (ControlUI* cui)
        cui->ignore_change++;
 
        if (cui->combo && cui->scale_points) {
-               for (ARDOUR::Plugin::ScalePoints::iterator it = cui->scale_points->begin(); it != cui->scale_points->end(); ++it) {
+               for (ARDOUR::ScalePoints::iterator it = cui->scale_points->begin(); it != cui->scale_points->end(); ++it) {
                        if (it->second == val) {
                                cui->combo->set_active_text(it->first);
                                break;
@@ -827,7 +951,13 @@ void
 GenericPluginUI::control_port_toggled (ControlUI* cui)
 {
        cui->ignore_change++;
-       insert->automation_control (cui->parameter())->set_value (cui->button->get_active());
+       const bool active = cui->button->get_active();
+       if (active) {
+               cui->button->set_name ("PluginEditorButton-active");
+       } else {
+               cui->button->set_name ("PluginEditorButton");
+       }
+       insert->automation_control (cui->parameter())->set_value (active);
        cui->ignore_change--;
 }
 
@@ -869,7 +999,7 @@ void
 GenericPluginUI::output_update ()
 {
        for (vector<ControlUI*>::iterator i = output_controls.begin(); i != output_controls.end(); ++i) {
-               float val = plugin->get_parameter ((*i)->port_index);
+               float val = plugin->get_parameter ((*i)->parameter().id());
                char buf[32];
                snprintf (buf, sizeof(buf), "%.2f", val);
                (*i)->display_label->set_text (buf);
@@ -899,4 +1029,20 @@ GenericPluginUI::output_update ()
        }
 }
 
+void
+GenericPluginUI::set_property (const ParameterDescriptor& desc,
+                               Gtk::FileChooserButton*    widget)
+{
+       plugin->set_property(desc.key, Variant(Variant::PATH, widget->get_filename()));
+}
 
+void
+GenericPluginUI::property_changed (uint32_t key, const Variant& value)
+{
+       PropertyControls::iterator c = _property_controls.find(key);
+       if (c != _property_controls.end()) {
+               c->second->set_filename(value.get_path());
+       } else {
+               std::cerr << "warning: property change for property with no control" << std::endl;
+       }
+}