ardour.git
10 years agoreset the visibility of the template selector stuff every time the startup/NSD gets...
Paul Davis [Sat, 21 Sep 2013 16:51:30 +0000 (12:51 -0400)]
reset the visibility of the template selector stuff every time the startup/NSD gets mapped, so that it is always current

10 years agolikely fix for creating new sessions from templates
Paul Davis [Sat, 21 Sep 2013 16:50:45 +0000 (12:50 -0400)]
likely fix for creating new sessions from templates

10 years agoif new session button clicked, clear any selection in recent sessions and mark browse...
Paul Davis [Fri, 20 Sep 2013 20:45:04 +0000 (16:45 -0400)]
if new session button clicked, clear any selection in recent sessions and mark browser unused

10 years agoRevert "actually load new state after creating a session."
Paul Davis [Fri, 20 Sep 2013 20:16:30 +0000 (16:16 -0400)]
Revert "actually load new state after creating a session."

This reverts commit 914ba475de48f72e57bb6ac8a81888ad71cea7fa.

Unclear why I applied this or what it was supposed to do. A new session has no
state.

10 years agomove advanced new session options into an expander, change some wording
Paul Davis [Fri, 20 Sep 2013 20:05:54 +0000 (16:05 -0400)]
move advanced new session options into an expander, change some wording

10 years agoMerge branch 'master' of https://github.com/nmains/ardour
Paul Davis [Fri, 20 Sep 2013 19:21:14 +0000 (15:21 -0400)]
Merge branch 'master' of https://github.com/nmains/ardour

10 years agorather hacky fix for the change of the SyncSource > JACK enum to SyncSource > Engine
Paul Davis [Fri, 20 Sep 2013 18:30:50 +0000 (14:30 -0400)]
rather hacky fix for the change of the SyncSource > JACK enum to SyncSource > Engine

This is needed in order to get ardour started if ardour.rc names "JACK" as the sync source

10 years agochanges to integrate new/recent/browse in new session dialog.
Paul Davis [Fri, 20 Sep 2013 18:17:59 +0000 (14:17 -0400)]
changes to integrate new/recent/browse in new session dialog.

Probably some errors/mistakes in here and no doubt some improvements to be done.

10 years agoswitch from JACK_Slave to Engine_Slave
Paul Davis [Thu, 19 Sep 2013 21:34:23 +0000 (17:34 -0400)]
switch from JACK_Slave to Engine_Slave

10 years agoreallow changing bufsize AND sample rate when we are in control, because this is...
Paul Davis [Thu, 19 Sep 2013 20:48:05 +0000 (16:48 -0400)]
reallow changing bufsize AND sample rate when we are in control, because this is cool

10 years agomissing initialization
Paul Davis [Thu, 19 Sep 2013 20:17:47 +0000 (16:17 -0400)]
missing initialization

10 years agoshow a different audio/MIDI option screen if JACK is already running. try to fix...
Paul Davis [Thu, 19 Sep 2013 19:03:20 +0000 (15:03 -0400)]
show a different audio/MIDI option screen if JACK is already running. try to fix problem with using AudioBackend::<property-value>() functions before anything has been set.

10 years agomore excision of "JACK" from labels, menu items, etc.
Paul Davis [Wed, 18 Sep 2013 02:25:21 +0000 (22:25 -0400)]
more excision of "JACK" from labels, menu items, etc.

NOTE: users will lose the sample rate/latency display in the status bar display. Not yet sure what to do about this

10 years agominor code changes
Paul Davis [Wed, 18 Sep 2013 01:22:22 +0000 (21:22 -0400)]
minor code changes

10 years agosubstantive changes to allow the audio/MIDI setup dialog to change settings as intended
Paul Davis [Wed, 18 Sep 2013 01:09:13 +0000 (21:09 -0400)]
substantive changes to allow the audio/MIDI setup dialog to change settings as intended

So far only tested with JACK backend, but expected to be more correct for other backends too

10 years agoremove JACK related action definitions (audio/MIDI setup is where this happens now)
Paul Davis [Wed, 18 Sep 2013 01:07:44 +0000 (21:07 -0400)]
remove JACK related action definitions (audio/MIDI setup is where this happens now)

10 years agochange return type on {disconnect_from,reconnect_to}_engine() and make public so...
Paul Davis [Wed, 18 Sep 2013 01:07:14 +0000 (21:07 -0400)]
change return type on {disconnect_from,reconnect_to}_engine() and make public so that we can use these when doing intentional disconnects without popping up the "HALTED" dialog

10 years agoremove JACK related menu items (audio/MIDI setup is where this happens now)
Paul Davis [Wed, 18 Sep 2013 01:06:15 +0000 (21:06 -0400)]
remove JACK related menu items (audio/MIDI setup is where this happens now)

10 years agoactually load new state after creating a session.
nick_m [Tue, 17 Sep 2013 16:02:31 +0000 (02:02 +1000)]
actually load new state after creating a session.

10 years agoadd basic display of existing MIDI ports to audio/MIDI setup
Paul Davis [Tue, 17 Sep 2013 14:01:24 +0000 (10:01 -0400)]
add basic display of existing MIDI ports to audio/MIDI setup

10 years agofix crash caused by trying to unregister null ports
Paul Davis [Tue, 17 Sep 2013 14:01:02 +0000 (10:01 -0400)]
fix crash caused by trying to unregister null ports

10 years agocorrectly restore zoom focus state after restart (from nick mainsbridge)
Paul Davis [Tue, 17 Sep 2013 02:32:04 +0000 (22:32 -0400)]
correctly restore zoom focus state after restart (from nick mainsbridge)

10 years agominor fixups for audio/MIDI setup spin buttons (now editable, as they should be)
Paul Davis [Tue, 17 Sep 2013 02:03:59 +0000 (22:03 -0400)]
minor fixups for audio/MIDI setup spin buttons (now editable, as they should be)

10 years agocheck for an existing PublicEditor instance AFTER attempting to handle a key press...
Paul Davis [Tue, 17 Sep 2013 02:03:27 +0000 (22:03 -0400)]
check for an existing PublicEditor instance AFTER attempting to handle a key press in a window that has called relay_key_press(), so that normal key handling works there (e.g. audio/MIDI setup)

10 years agoa few DEBUG_TRACE improvements
Paul Davis [Tue, 17 Sep 2013 02:02:36 +0000 (22:02 -0400)]
a few DEBUG_TRACE improvements

10 years agoend latency detection if AMS window closed while running detection (plus some non...
Paul Davis [Mon, 16 Sep 2013 22:47:30 +0000 (18:47 -0400)]
end latency detection if AMS window closed while running detection (plus some non-functioning changes to try to get spinbutton text entry to work

10 years agovarious bits of polish for the latency tab of audio/midi setup dialog
Paul Davis [Mon, 16 Sep 2013 19:21:32 +0000 (15:21 -0400)]
various bits of polish for the latency tab of audio/midi setup dialog

10 years agomore session construction order changes, and removal of n_physical_{inputs,outputs...
Paul Davis [Mon, 16 Sep 2013 16:08:19 +0000 (12:08 -0400)]
more session construction order changes, and removal of n_physical_{inputs,outputs} members which were (a) not initialized early enough (b) not used anywhere except monitor bus connection.

Things almost make sense now.

10 years agoupdate buffer size duration (msecs) while displaying saved audio/MIDI setup state
Paul Davis [Mon, 16 Sep 2013 15:10:05 +0000 (11:10 -0400)]
update buffer size duration (msecs) while displaying saved audio/MIDI setup state

10 years agofix missing initialization of two Session members, which fixes a crash during quit...
Paul Davis [Mon, 16 Sep 2013 14:23:37 +0000 (10:23 -0400)]
fix missing initialization of two Session members, which fixes a crash during quit-without-finished-session

10 years agocommit some logic problems with the EngineDialog when change the driver/device name...
Paul Davis [Mon, 16 Sep 2013 14:18:25 +0000 (10:18 -0400)]
commit some logic problems with the EngineDialog when change the driver/device name combos

10 years agofix language issue
Paul Davis [Mon, 16 Sep 2013 14:07:52 +0000 (10:07 -0400)]
fix language issue

10 years agoallow waf to handle inconsistent case where cwiid.h is present but not the pkg-config...
Paul Davis [Mon, 16 Sep 2013 14:07:27 +0000 (10:07 -0400)]
allow waf to handle inconsistent case where cwiid.h is present but not the pkg-config file

10 years agofix ordering in session construction so that new sessions and existing ones both...
Paul Davis [Mon, 16 Sep 2013 13:57:22 +0000 (09:57 -0400)]
fix ordering in session construction so that new sessions and existing ones both work

10 years agoreally fix build issues after removal of "using" directives
Paul Davis [Sat, 14 Sep 2013 20:34:08 +0000 (16:34 -0400)]
really fix build issues after removal of "using" directives

10 years agofix build issues after removal of "using" directives
Paul Davis [Sat, 14 Sep 2013 20:24:21 +0000 (16:24 -0400)]
fix build issues after removal of "using" directives

10 years agocerr output when JACK halt callback is executed
Paul Davis [Sat, 14 Sep 2013 20:18:17 +0000 (16:18 -0400)]
cerr output when JACK halt callback is executed

10 years agofix return value from thread creation function when not connected to JACK
Paul Davis [Sat, 14 Sep 2013 20:17:49 +0000 (16:17 -0400)]
fix return value from thread creation function when not connected to JACK

10 years agomove creation of Graph till after we have the engine running, since we need access...
Paul Davis [Sat, 14 Sep 2013 20:17:24 +0000 (16:17 -0400)]
move creation of Graph till after we have the engine running, since we need access to the backend

10 years agoMerge branch 'master--arm' of https://github.com/nphilipp/ardour
Paul Davis [Fri, 13 Sep 2013 16:58:29 +0000 (12:58 -0400)]
Merge branch 'master--arm' of https://github.com/nphilipp/ardour

10 years agouse visibility control on JACK audio backend, so that we can import this change into...
Paul Davis [Fri, 13 Sep 2013 16:32:50 +0000 (12:32 -0400)]
use visibility control on JACK audio backend, so that we can import this change into windows branch

10 years agoupdate JACK backend to use new inheritance structure for AudioBackend
Paul Davis [Fri, 13 Sep 2013 15:21:43 +0000 (11:21 -0400)]
update JACK backend to use new inheritance structure for AudioBackend

10 years agochange inheritance so that an AudioBackend IS-A PortEngine
Paul Davis [Fri, 13 Sep 2013 15:21:15 +0000 (11:21 -0400)]
change inheritance so that an AudioBackend IS-A PortEngine

This allows a derived (concrete) implementation to share information (e.g. sample rate, buffer size)
between the audio backend side of things and the port management side of things.

10 years agodon't confuse arm with i686
Nils Philippsen [Thu, 12 Sep 2013 15:24:28 +0000 (17:24 +0200)]
don't confuse arm with i686

10 years agoexplanatory comment
Paul Davis [Fri, 13 Sep 2013 14:19:01 +0000 (10:19 -0400)]
explanatory comment

10 years agoremove some debug output messages
Paul Davis [Thu, 12 Sep 2013 21:24:45 +0000 (17:24 -0400)]
remove some debug output messages

10 years agodon't stop metering thread when session is removed; move engine-setup code into its...
Paul Davis [Thu, 12 Sep 2013 21:06:21 +0000 (17:06 -0400)]
don't stop metering thread when session is removed; move engine-setup code into its own method. sorry, ardour build-from-source folk :)

10 years agovtl: export selected range
Robin Gareus [Thu, 12 Sep 2013 20:46:11 +0000 (22:46 +0200)]
vtl: export selected range

10 years agotweak narrow-mixer-strip meters: nettings vs the_CLA. Round 3.
Robin Gareus [Wed, 11 Sep 2013 16:32:39 +0000 (18:32 +0200)]
tweak narrow-mixer-strip meters: nettings vs the_CLA. Round 3.

10 years agolots of changes to auto-start (and stop) the backend for latency measurements, and...
Paul Davis [Thu, 12 Sep 2013 20:28:51 +0000 (16:28 -0400)]
lots of changes to auto-start (and stop) the backend for latency measurements, and continuing work on the session construction/engine configuration flow

10 years agoreinstate unblocking-of-connections in session setup, accidentally dropped in reorgan...
Paul Davis [Thu, 12 Sep 2013 20:27:58 +0000 (16:27 -0400)]
reinstate unblocking-of-connections in session setup, accidentally dropped in reorganization work

10 years agoprevent key press in pre-main-window dialog(s) from crashing the program because...
Paul Davis [Thu, 12 Sep 2013 18:39:17 +0000 (14:39 -0400)]
prevent key press in pre-main-window dialog(s) from crashing the program because there is no editor window to forward key presses to

10 years agochange names, add comment, improve return type to avoid extra call to get EngineContr...
Paul Davis [Thu, 12 Sep 2013 16:26:59 +0000 (12:26 -0400)]
change names, add comment, improve return type to avoid extra call to get EngineControl::State*

10 years agoadd AudioBackendNativeThread to serve the same role as jack_native_thread_t
Paul Davis [Thu, 12 Sep 2013 15:29:47 +0000 (11:29 -0400)]
add AudioBackendNativeThread to serve the same role as jack_native_thread_t

10 years agoalways add a timeout value of 200msec to jack, just like qjackctl does.
Paul Davis [Thu, 12 Sep 2013 01:00:21 +0000 (21:00 -0400)]
always add a timeout value of 200msec to jack, just like qjackctl does.

THIS IS A HACK. LONG TERM GOAL: understand why ardour gets zombified on the way up.

10 years ago*maybe* fix issues with zombification during session loading
Paul Davis [Wed, 11 Sep 2013 20:33:40 +0000 (16:33 -0400)]
*maybe* fix issues with zombification during session loading

10 years agomake use of measured latency values to set dialog controls, and use actual port laten...
Paul Davis [Wed, 11 Sep 2013 17:02:32 +0000 (13:02 -0400)]
make use of measured latency values to set dialog controls, and use actual port latency to compute extra delay

10 years agoremove some configure time tests from libs/ardour regarding JACK which are no longer...
Paul Davis [Wed, 11 Sep 2013 16:44:21 +0000 (12:44 -0400)]
remove some configure time tests from libs/ardour regarding JACK which are no longer relevant

10 years agoremove unused members and code from EngineControl dialog (related to different device...
Paul Davis [Wed, 11 Sep 2013 16:05:51 +0000 (12:05 -0400)]
remove unused members and code from EngineControl dialog (related to different devices for input+output)

10 years agomake quit work even when latency measurement is in progress
Paul Davis [Wed, 11 Sep 2013 14:06:02 +0000 (10:06 -0400)]
make quit work even when latency measurement is in progress

10 years agofix handling of new session
Paul Davis [Wed, 11 Sep 2013 13:59:56 +0000 (09:59 -0400)]
fix handling of new session

defer save state till after everything done in post_engine_init() is complete.

10 years agomore tweaks to latency measurement
Paul Davis [Wed, 11 Sep 2013 03:25:15 +0000 (23:25 -0400)]
more tweaks to latency measurement

don't open ports till absolutely necessary (store names for future use).

tidy up parts of the dialog (tab)

10 years agobasic functionality for hardware latency measurement
Paul Davis [Wed, 11 Sep 2013 02:58:33 +0000 (22:58 -0400)]
basic functionality for hardware latency measurement

10 years agomany changes relating to session construction and audioengine interaction
Paul Davis [Tue, 10 Sep 2013 19:41:19 +0000 (15:41 -0400)]
many changes relating to session construction and audioengine interaction

every session member is now initialized using C++ constructor syntax

session construction reordered to clarify the split(s) between work
where the engine is not relevant and work where is it is. this
split is still not 100% obvious, but is enormously clearer than
previously.

if engine/backend are not running as session is created, and the SR
of the sample rate is known, attempt to force backend to that value.

10 years agonew generic MIDI binding map for Novation Impulse 61 from Alexandre Prokoudine
Paul Davis [Tue, 10 Sep 2013 12:51:06 +0000 (08:51 -0400)]
new generic MIDI binding map for Novation Impulse 61 from Alexandre Prokoudine

10 years agostart reordering of Session initialization
Paul Davis [Tue, 10 Sep 2013 02:40:54 +0000 (22:40 -0400)]
start reordering of Session initialization

the goal is to allow a clear demarcation of where we need
the audioengine and have existing data parameters (e.g. sample rate)
for the session so that we can coerce the engine (if possible)
to match to session values.

also, to rationalize construction even more and use C++
constructor syntax as much as possible.

10 years agofix name of control app for Delta1010
Paul Davis [Tue, 10 Sep 2013 01:35:47 +0000 (21:35 -0400)]
fix name of control app for Delta1010

10 years agomove control app launching back into audio backend to allow ASIO/CoreAudio model...
Paul Davis [Tue, 10 Sep 2013 01:23:12 +0000 (21:23 -0400)]
move control app launching back into audio backend to allow ASIO/CoreAudio model to work; push initial state of AMS dialog to backend

Issues remain with the basic model of the AMS dialog - when is
newly chosen state pushed into the backend (which can then
modify the control app button sensitivity. This is a special
problem for this button because APIs like ASIO and CoreAudio
probably don't allow us to launch a control app for an arbitrary
device, but only one actually in use. In this sense it is
different from properties like available buffer size etc, where
we can typically query without actually using the device.

10 years agofix control app breakage
Paul Davis [Mon, 9 Sep 2013 22:06:44 +0000 (18:06 -0400)]
fix control app breakage

10 years agofix crash when unconditionally using null env var; tweak packing of control app button
Paul Davis [Mon, 9 Sep 2013 21:10:58 +0000 (17:10 -0400)]
fix crash when unconditionally using null env var; tweak packing of control app button

10 years agoadd envy24 control app name
Paul Davis [Mon, 9 Sep 2013 21:10:33 +0000 (17:10 -0400)]
add envy24 control app name

10 years agolaunching control app is now responsibility of ardour GUI, not audio backend; use...
Paul Davis [Mon, 9 Sep 2013 20:48:27 +0000 (16:48 -0400)]
launching control app is now responsibility of ardour GUI, not audio backend; use ARDOUR_DEVICE_CONTROL_APP if set in the environment

10 years agoinitial work on adding access to h/w control apps when ardour starts JACK
Paul Davis [Mon, 9 Sep 2013 19:17:29 +0000 (15:17 -0400)]
initial work on adding access to h/w control apps when ardour starts JACK

10 years agoadd can_change_{sample_rate,buffer_size}_while_running() methods to an AudioBackend
Paul Davis [Mon, 9 Sep 2013 17:27:48 +0000 (13:27 -0400)]
add can_change_{sample_rate,buffer_size}_while_running() methods to an AudioBackend

Allows the GUI and other stuff to know whether or not changing the SR/bufsize is possible while running, which is about to become useful

10 years agomove engine dialog from a widget to an actual dialog; emit Session::AudioEngineSetupR...
Paul Davis [Mon, 9 Sep 2013 17:17:53 +0000 (13:17 -0400)]
move engine dialog from a widget to an actual dialog; emit Session::AudioEngineSetupRequired when loading a session if it is necessary

10 years agohide tick-marks on narrow mixer-meters
Robin Gareus [Mon, 9 Sep 2013 17:33:30 +0000 (19:33 +0200)]
hide tick-marks on narrow mixer-meters

10 years agowiden narrow mixer-meters,hide metric display instead
Robin Gareus [Mon, 9 Sep 2013 16:31:50 +0000 (18:31 +0200)]
widen narrow mixer-meters,hide metric display instead

10 years agometerbridge: don't display metrics of invisible tracks
Robin Gareus [Mon, 9 Sep 2013 15:32:04 +0000 (17:32 +0200)]
meterbridge: don't display metrics of invisible tracks

10 years agovtl: update to ffmpeg v1.2.1 [lib]x264 option.
Robin Gareus [Sun, 8 Sep 2013 16:26:02 +0000 (18:26 +0200)]
vtl: update to ffmpeg v1.2.1 [lib]x264 option.

10 years agomove inadvertently moved jack_slave.cc back to its rightful spot
Paul Davis [Sat, 7 Sep 2013 17:39:36 +0000 (13:39 -0400)]
move inadvertently moved jack_slave.cc back to its rightful spot

10 years agoother changes for separated jack backend
Paul Davis [Sat, 7 Sep 2013 15:13:07 +0000 (11:13 -0400)]
other changes for separated jack backend

10 years agomove JACK audio backend to its own folder and adjust build system to reflect that...
Paul Davis [Sat, 7 Sep 2013 15:03:57 +0000 (11:03 -0400)]
move JACK audio backend to its own folder and adjust build system to reflect that (installed version may now work)

10 years agoadd input/output channel counts and reorganize table somewhat
Paul Davis [Sat, 7 Sep 2013 01:00:01 +0000 (21:00 -0400)]
add input/output channel counts and reorganize table somewhat

10 years agoadd support in JACK backend for specifying number of input and output channels to use
Paul Davis [Fri, 6 Sep 2013 21:21:23 +0000 (17:21 -0400)]
add support in JACK backend for specifying number of input and output channels to use

10 years agosave/restore I/O latency values in audio/midi setup
Paul Davis [Fri, 6 Sep 2013 20:43:02 +0000 (16:43 -0400)]
save/restore I/O latency values in audio/midi setup

10 years agofix merge conflicts with audioengine
Paul Davis [Fri, 6 Sep 2013 17:39:26 +0000 (13:39 -0400)]
fix merge conflicts with audioengine

10 years agofix JACK backend setup so that we know about graph, port changes etc.
Paul Davis [Fri, 6 Sep 2013 17:06:44 +0000 (13:06 -0400)]
fix JACK backend setup so that we know about graph, port changes etc.

10 years agotighten up error handling a little bit during various setup functions for Mackie...
Paul Davis [Fri, 6 Sep 2013 14:39:14 +0000 (10:39 -0400)]
tighten up error handling a little bit during various setup functions for Mackie Control

10 years agoexit early from AsyncMIDIPort::drain() if it will never be used in a process callback...
Paul Davis [Fri, 6 Sep 2013 14:38:49 +0000 (10:38 -0400)]
exit early from AsyncMIDIPort::drain() if it will never be used in a process callback again

10 years agofix a problem creating and displaying connected status for ports not owned by ardour...
Paul Davis [Fri, 6 Sep 2013 01:39:43 +0000 (21:39 -0400)]
fix a problem creating and displaying connected status for ports not owned by ardour (e.g. system:....)

This was caused by using jack_port_get_connections() which will
not return the correct status for ports owned by another JACK
client. Because of the potential for deadlock by calling
jack_port_get_all_connections(), an extra argument was added
to several PortEngine:: API calls to specify whether the call
is in a process-callback context, which defaults to true.

The only place where false is passed is within the GlobalPortMatrix
when we need to determine whether two non-ardour ports are
connected.

10 years agoalways save/keep audio/MIDI setup states so that they are available for use *after...
Paul Davis [Thu, 5 Sep 2013 18:21:25 +0000 (14:21 -0400)]
always save/keep audio/MIDI setup states so that they are available for use *after* instances where JACK was already running

10 years agomove MidiPortManager from AudioEngine to Session
Paul Davis [Thu, 5 Sep 2013 17:22:34 +0000 (13:22 -0400)]
move MidiPortManager from AudioEngine to Session

This makes the responsibilities and ownership of non-Route related MIDI ports
more clear, and removes a few wierd bits of code. It also ensures that open/close/open
on the same session will retain connections for those MIDI ports

10 years agoshorten tab labels on audio/midi setup notebook
Paul Davis [Thu, 5 Sep 2013 17:21:13 +0000 (13:21 -0400)]
shorten tab labels on audio/midi setup notebook

10 years agosave and restore the selected engine state at startup
Paul Davis [Thu, 5 Sep 2013 02:58:56 +0000 (22:58 -0400)]
save and restore the selected engine state at startup

10 years agofix up restoration of saved state from disk, still incomplete
Paul Davis [Thu, 5 Sep 2013 02:22:18 +0000 (22:22 -0400)]
fix up restoration of saved state from disk, still incomplete

10 years agosave and restore audio/MIDI setup states to disk (in ardour.rc)
Paul Davis [Wed, 4 Sep 2013 23:34:43 +0000 (19:34 -0400)]
save and restore audio/MIDI setup states to disk (in ardour.rc)

Not finished because the buffer size value will not always stick during restore

10 years agosave and restore settings for different backend/driver/device combinations
Paul Davis [Wed, 4 Sep 2013 19:45:54 +0000 (15:45 -0400)]
save and restore settings for different backend/driver/device combinations

So far, this is only internal - never saved to disk

10 years agochange names of actions groups that include "jack"
Paul Davis [Wed, 4 Sep 2013 16:49:52 +0000 (12:49 -0400)]
change names of actions groups that include "jack"

10 years agorename interface_ stuff in the engine dialog to device_, since that feels a bit clear...
Paul Davis [Wed, 4 Sep 2013 16:37:44 +0000 (12:37 -0400)]
rename interface_ stuff in the engine dialog to device_, since that feels a bit clearer terminology

10 years agosquash another compiler warning
Robin Gareus [Tue, 3 Sep 2013 23:37:15 +0000 (01:37 +0200)]
squash another compiler warning