Carl Hetherington [Wed, 11 Nov 2020 22:35:32 +0000 (23:35 +0100)]
Remove assertion checking that rotations are a multiple of 90.
This is checked later, anyway (without asserting) and we have seen
files in the wild with other rotations (e.g. -135.62) which do not
appear to need rotation to be applied.
Fixes #1871.
Backported-from-commit:
f235ed07f969e1b8b9d3d05082dcdd68ceae771e
Backported-from-branch: master
Carl Hetherington [Sun, 8 Nov 2020 21:13:34 +0000 (22:13 +0100)]
Remove references to / support for old RtError class (now RtAudioError).
Carl Hetherington [Thu, 5 Nov 2020 20:36:32 +0000 (21:36 +0100)]
Fix start_player() on macOS (#1870).
Carl Hetherington [Thu, 5 Nov 2020 20:36:16 +0000 (21:36 +0100)]
Rename a variable and add some logging to start_tool on macOS.
Carl Hetherington [Thu, 5 Nov 2020 21:12:27 +0000 (22:12 +0100)]
Fix video waveform view with GL backend.
Carl Hetherington [Thu, 5 Nov 2020 20:52:07 +0000 (21:52 +0100)]
Fix some alignment.
Carl Hetherington [Wed, 4 Nov 2020 22:33:10 +0000 (23:33 +0100)]
Re-add mutex that was taken away in
73ebb92e9df01ba7afb97121b6e2cef6ca13a18e
I'm not sure why it was removed, and it seems necessary;
servers_list_changed() can be called from a variety of different places
(the constructor and two different EncodeServerFinder threads).
May help with #1854.
Carl Hetherington [Tue, 3 Nov 2020 23:17:53 +0000 (00:17 +0100)]
Move video frame rate override into advanced prefs (#1852).
Carl Hetherington [Tue, 3 Nov 2020 23:15:30 +0000 (00:15 +0100)]
Fix crash on Linux (and maybe others).
Calling _canvas->SetCurrent() without the canvas being on screen
causes a crash on Linux (and maybe elsewhere).
Carl Hetherington [Tue, 3 Nov 2020 19:52:56 +0000 (20:52 +0100)]
Revert "Re-allow audio channel 15 to be mapped so that users can add"
This reverts commit
4cf45229bf55344e708fead769f694f13bacf39c.
It's wrong - the sign language channel is 15 (1-indexed) not 15
(0-indexed) as in this commit.
Carl Hetherington [Sun, 1 Nov 2020 23:11:50 +0000 (00:11 +0100)]
Add some tests.
Carl Hetherington [Sun, 1 Nov 2020 22:51:19 +0000 (23:51 +0100)]
Pass around JPEG2000 data as a shared_ptr and hence avoid a copy
of 4MB of data for every JPEG2000 frame we decode.
Carl Hetherington [Sun, 1 Nov 2020 22:40:01 +0000 (23:40 +0100)]
Replace dcp::Data with dcp::ArrayData
Carl Hetherington [Sun, 1 Nov 2020 23:18:22 +0000 (00:18 +0100)]
Bump libdcp for new dcp::ArrayData stuff.
Carl Hetherington [Mon, 2 Nov 2020 22:08:01 +0000 (23:08 +0100)]
Re-allow audio channel 15 to be mapped so that users can add
their own sign language tracks until DoM supports them properly.
Carl Hetherington [Wed, 28 Oct 2020 15:25:01 +0000 (16:25 +0100)]
Add some comments.
Carl Hetherington [Wed, 28 Oct 2020 11:48:48 +0000 (12:48 +0100)]
Prevent import of directories as DCPs if they do not have an
ASSETMAP{,.xml} in the top level.
This should avoid some confusion, as previously DoM would scan the
whole directory tree looking for an ASSETMAP. It also prevents
people adding a DCP-o-matic project to itself, which I believe is the
cause of #1620.
Carl Hetherington [Sat, 24 Oct 2020 18:44:24 +0000 (20:44 +0200)]
Add uninstaller for the .pkg part of the disk writer on macOS (#1740).
Carl Hetherington [Mon, 26 Oct 2020 13:06:55 +0000 (14:06 +0100)]
Catch more errors when non-CPLs are loaded as CPLs.
Backported-from-commit:
b73549f6c4f13e8ef5cadebbc767829aea5a2c16
Backported-from-branch: master
Carl Hetherington [Sun, 25 Oct 2020 21:04:47 +0000 (22:04 +0100)]
Fix Ubuntu 20.10 dependencies.
Carl Hetherington [Sun, 25 Oct 2020 21:04:44 +0000 (22:04 +0100)]
Remove unnecessary Ubuntu 20.04 dependency on wxWidgets.
Carl Hetherington [Sat, 24 Oct 2020 21:18:23 +0000 (23:18 +0200)]
Enable disable-library-validation entitlement to allow use of @executable_path
Carl Hetherington [Fri, 23 Oct 2020 22:45:48 +0000 (00:45 +0200)]
White space tweak.
Carl Hetherington [Fri, 23 Oct 2020 21:58:43 +0000 (23:58 +0200)]
Fix some label alignments.
Carl Hetherington [Wed, 21 Oct 2020 07:23:12 +0000 (09:23 +0200)]
macOS / new boost build fixes.
Carl Hetherington [Tue, 20 Oct 2020 23:04:20 +0000 (01:04 +0200)]
Bump libdcp for build fixes.
Carl Hetherington [Tue, 20 Oct 2020 20:17:40 +0000 (22:17 +0200)]
Bump libdcp for macOS warning fixes.
Carl Hetherington [Tue, 20 Oct 2020 19:10:49 +0000 (21:10 +0200)]
Try to improve splitter behaviour when shrinking and then enlarging
the main window (#1839).
Carl Hetherington [Tue, 20 Oct 2020 15:03:08 +0000 (17:03 +0200)]
Move the LimitedSplitter constructor into the .cc file.
Carl Hetherington [Tue, 20 Oct 2020 14:52:04 +0000 (16:52 +0200)]
Move contents of ContentPanel::first_shown into LimitedSplitter.
Carl Hetherington [Tue, 20 Oct 2020 14:39:09 +0000 (16:39 +0200)]
Move LimitedSplitter into the header file.
Carl Hetherington [Mon, 19 Oct 2020 21:22:25 +0000 (23:22 +0200)]
Playlist editor: try to make progress dialogue appear sooner when scanning content.
Carl Hetherington [Mon, 19 Oct 2020 21:21:51 +0000 (23:21 +0200)]
Playlist editor: save configuration when it changes.
Carl Hetherington [Mon, 19 Oct 2020 21:21:13 +0000 (23:21 +0200)]
Playlist editor: update content list when configuration changes.
Carl Hetherington [Sun, 18 Oct 2020 22:07:28 +0000 (00:07 +0200)]
Add some icons missing from the macOS build.
Carl Hetherington [Sun, 18 Oct 2020 19:43:03 +0000 (21:43 +0200)]
macOS build fix.
Carl Hetherington [Sun, 18 Oct 2020 18:01:44 +0000 (20:01 +0200)]
Tidy up and fix bitmap path finding in the playlist editor.
Carl Hetherington [Sun, 18 Oct 2020 20:16:50 +0000 (22:16 +0200)]
Add missing files from share/libdcp to .deb packages.
Carl Hetherington [Sun, 18 Oct 2020 18:00:25 +0000 (20:00 +0200)]
Fix typo.
Carl Hetherington [Sat, 17 Oct 2020 22:16:25 +0000 (00:16 +0200)]
Clarify some error messages on macOS (#1837).
When we say we can't start a particular tool, it may be because it
has not even been downloaded/installed.
Carl Hetherington [Sat, 17 Oct 2020 20:25:40 +0000 (22:25 +0200)]
Fix failure to update player information when changing CPLs.
Carl Hetherington [Sat, 17 Oct 2020 20:23:12 +0000 (22:23 +0200)]
Fix deadlock when changing CPL in the player (#1827).
TextContent::set_dcp_track can end up requesting a view update, which
involves calls to methods in Content which lock the Content::_mutex.
Do these calls without a lock on that mutex held.
Also, it looks like we would append to texts on every call to
examine(). Fix that so that we replace the texts list on each
examine() call.
Carl Hetherington [Sat, 17 Oct 2020 20:23:01 +0000 (22:23 +0200)]
Fix finding of graphics when running from the source tree on Linux.
Carl Hetherington [Thu, 15 Oct 2020 11:53:39 +0000 (13:53 +0200)]
Test script tweaks for Windows.
Carl Hetherington [Wed, 14 Oct 2020 19:43:21 +0000 (21:43 +0200)]
Add test for #1857.
Carl Hetherington [Wed, 14 Oct 2020 19:29:19 +0000 (21:29 +0200)]
Fix test DCP index.
Carl Hetherington [Wed, 14 Oct 2020 19:24:57 +0000 (21:24 +0200)]
Don't crash if the first packet in a stream has AV_NOPTS_VALUE;
instead, assume it should be at timestamp 0.
Carl Hetherington [Wed, 14 Oct 2020 19:23:36 +0000 (21:23 +0200)]
Clear out _next_time when seeking, so out-of-date values don't
hang around. Part of the fix for #1857.
Carl Hetherington [Wed, 14 Oct 2020 13:14:26 +0000 (15:14 +0200)]
cscript can now run tests on Windows.
Carl Hetherington [Mon, 12 Oct 2020 17:59:17 +0000 (19:59 +0200)]
Remove some debug output.
Carl Hetherington [Fri, 9 Oct 2020 19:18:34 +0000 (21:18 +0200)]
Provide path to find ffcmp tool for tests.
Carl Hetherington [Thu, 8 Oct 2020 23:18:11 +0000 (01:18 +0200)]
Fix deprecation warning from cdist.
Carl Hetherington [Thu, 8 Oct 2020 21:02:57 +0000 (23:02 +0200)]
Tweak mac environment path.
Carl Hetherington [Thu, 8 Oct 2020 19:30:00 +0000 (21:30 +0200)]
Some macOS test build fixes.
Carl Hetherington [Wed, 7 Oct 2020 07:24:50 +0000 (09:24 +0200)]
Fix a REQUIRE that should be REQUIRE_EQUAL.
Carl Hetherington [Tue, 6 Oct 2020 23:02:47 +0000 (01:02 +0200)]
Fix errors when over-reading a "large" amount from FileGroups on
Windows. I haven't been able to find any conclusive explanation for
why this stuff happens;
https://stackoverflow.com/questions/
7241168/safe-maximum-number-of-records-read-by-fread
is one possible lead.
Carl Hetherington [Tue, 6 Oct 2020 21:54:32 +0000 (23:54 +0200)]
Hack to allow us to make a valid boost::filesystem::path from a
UTF8 constant on Windows. This might actually be a way to get around
the fopen_boost hacks.
Carl Hetherington [Tue, 6 Oct 2020 21:18:40 +0000 (23:18 +0200)]
Add ffcmp dependency for tests.
Carl Hetherington [Tue, 6 Oct 2020 19:37:46 +0000 (21:37 +0200)]
Stop the Windows version of run_ffprobe manipulating the current working directory as tests rely on it.
Carl Hetherington [Tue, 6 Oct 2020 09:58:29 +0000 (11:58 +0200)]
Modify KDM naming test to use shorter path names on Windows.
Carl Hetherington [Tue, 6 Oct 2020 09:27:06 +0000 (11:27 +0200)]
Bump libdcp for better error checking.
Carl Hetherington [Tue, 6 Oct 2020 08:10:01 +0000 (10:10 +0200)]
Remove dependency on srand() and predictable output from rand()
to work around a strange problem on Windows where this test would
fail with the random values offset by 1 step.
Carl Hetherington [Mon, 5 Oct 2020 20:47:30 +0000 (22:47 +0200)]
Make socket tests connect explicitly to localhost to try to fix
error 1214 on Windows.
Carl Hetherington [Mon, 5 Oct 2020 20:27:49 +0000 (22:27 +0200)]
Use rand() instead of /dev/urandom to make test files.
Carl Hetherington [Mon, 5 Oct 2020 09:45:39 +0000 (11:45 +0200)]
Fix POSIX path embedded in test check string.
Carl Hetherington [Mon, 5 Oct 2020 09:15:24 +0000 (11:15 +0200)]
Stop run_ffprobe from changing the current working directory on Windows.
Carl Hetherington [Sun, 4 Oct 2020 22:26:25 +0000 (00:26 +0200)]
Try to make crypo_test more likely to pass.
Carl Hetherington [Sun, 4 Oct 2020 21:31:47 +0000 (23:31 +0200)]
Add python script to do repetitive code changes.
Carl Hetherington [Sun, 4 Oct 2020 20:04:40 +0000 (22:04 +0200)]
Fix use of DCPOMATIC_TEST_PRIVATE variable to specify where
test private data is.
Carl Hetherington [Sun, 4 Oct 2020 18:51:35 +0000 (20:51 +0200)]
Windows test run script.
Carl Hetherington [Fri, 2 Oct 2020 11:31:35 +0000 (13:31 +0200)]
Fix Windows console apps to actually have a console.
Carl Hetherington [Thu, 1 Oct 2020 23:11:29 +0000 (01:11 +0200)]
Label vertical alignment fixes.
Carl Hetherington [Thu, 1 Oct 2020 16:55:40 +0000 (18:55 +0200)]
Fix integer overflow in test.
Carl Hetherington [Thu, 1 Oct 2020 11:27:32 +0000 (13:27 +0200)]
Carl Hetherington [Thu, 1 Oct 2020 08:44:11 +0000 (10:44 +0200)]
Remove Image/GraphicsMagick dependency.
Carl Hetherington [Thu, 1 Oct 2020 08:40:42 +0000 (10:40 +0200)]
Add some more pixfmts to hack.
Carl Hetherington [Wed, 30 Sep 2020 19:26:37 +0000 (21:26 +0200)]
Build tests on Windows.
Carl Hetherington [Tue, 29 Sep 2020 20:25:29 +0000 (22:25 +0200)]
macOS extensions to run/tests.
Carl Hetherington [Tue, 29 Sep 2020 20:06:36 +0000 (22:06 +0200)]
Make use of default_font_file().
Carl Hetherington [Tue, 29 Sep 2020 18:55:16 +0000 (20:55 +0200)]
Fix incorrect sign on boost test constants.
Carl Hetherington [Tue, 29 Sep 2020 18:54:17 +0000 (20:54 +0200)]
Cope with different names for ImageMagick's .pc file (Linux and macOS).
Carl Hetherington [Tue, 29 Sep 2020 18:51:02 +0000 (20:51 +0200)]
Fix incorrect forward declaration of struct as class.
Carl Hetherington [Tue, 29 Sep 2020 18:50:41 +0000 (20:50 +0200)]
Enable building of unit tests on macOS.
Carl Hetherington [Mon, 28 Sep 2020 19:17:42 +0000 (21:17 +0200)]
Adapt for cdist doing notarization.
Carl Hetherington [Mon, 28 Sep 2020 12:45:58 +0000 (14:45 +0200)]
Remove notarization from make_dmg.sh.
Carl Hetherington [Thu, 8 Oct 2020 14:13:02 +0000 (16:13 +0200)]
Fix up config backup tests.
Carl Hetherington [Thu, 8 Oct 2020 13:37:35 +0000 (15:37 +0200)]
Fix error when trying to make the openssl symlink again.
Carl Hetherington [Mon, 5 Oct 2020 22:12:16 +0000 (00:12 +0200)]
Fix assorted GTK3-related alignment problems.
Carl Hetherington [Tue, 29 Sep 2020 21:17:53 +0000 (23:17 +0200)]
Make unit tests use their own configuration rather than whatever
happens to be in $HOME.
This is especially important for signer certificates; without this
it looks like the ones from $HOME will be used.
Carl Hetherington [Tue, 29 Sep 2020 21:17:47 +0000 (23:17 +0200)]
Remove debug code.
Carl Hetherington [Tue, 29 Sep 2020 21:17:24 +0000 (23:17 +0200)]
Try a little harder to make sure we use the patched openssl for
unit tests.
Carl Hetherington [Tue, 29 Sep 2020 20:15:56 +0000 (22:15 +0200)]
Remove some Linux hacks that I can't see the point of any more.
Carl Hetherington [Sun, 27 Sep 2020 21:47:47 +0000 (23:47 +0200)]
Disable some more warnings.
Carl Hetherington [Sun, 27 Sep 2020 21:41:25 +0000 (23:41 +0200)]
Tweak trim-to-end behaviour and button label.
Now this button trims the current frame and all following (#1831).
It seems to be likely that you'd be looking at something you want
to remove, not the thing before what you want to remove.
Carl Hetherington [Sun, 27 Sep 2020 21:31:06 +0000 (23:31 +0200)]
Fix playhead position after trim-up-to (#1847).
Carl Hetherington [Sun, 27 Sep 2020 20:50:43 +0000 (22:50 +0200)]
Go back to add_to_cairo_context rather than show_in_cairo_context.
On Linux, at least, doing
add_to_cairo_context()
fill()
add_to_cairo_context()
stroke()
gives a nicer output than
show_in_cairo_context()
It's not clear exactly what the difference is, but the anti aliasing
looks better and the font outlines basically look smoother.
May help with #1815.
Carl Hetherington [Sun, 27 Sep 2020 20:40:13 +0000 (22:40 +0200)]
Build fix.
Carl Hetherington [Sun, 27 Sep 2020 19:19:24 +0000 (21:19 +0200)]
Bump libdcp for missing xsd fixes.
Carl Hetherington [Sun, 27 Sep 2020 19:18:51 +0000 (21:18 +0200)]
Fixes for new libdcp with multiple content versions.
Carl Hetherington [Sun, 27 Sep 2020 19:18:15 +0000 (21:18 +0200)]
Tidy up xsd list in Windows installer.