Nikolaus Gullotta [Mon, 19 Mar 2018 18:30:19 +0000 (13:30 -0500)]
Fixed issue in plugin id invalidator caused by commit
d5d5c0c
Nikolaus Gullotta [Mon, 19 Mar 2018 17:24:46 +0000 (12:24 -0500)]
cleanup, fix in-on-change issue.
Robin Gareus [Mon, 19 Mar 2018 17:18:35 +0000 (18:18 +0100)]
Lua is not an acronym
Robin Gareus [Mon, 19 Mar 2018 17:13:37 +0000 (18:13 +0100)]
Speed up plugin-selector refill.
* Detach model from treeview and disable sorting during refill.
* Prevent multiple re-fills due to sensitivity updates of ComboBoxes:
gtk_widget_set_sensitive() -> CairoWidget::on_state_changed ()
-> CairoWidget::set_visual_state () -> StateChanged Signal
Robin Gareus [Mon, 19 Mar 2018 14:43:07 +0000 (15:43 +0100)]
Fix "Shortcut" special-case in the script-selector.
The Script-selector is used in various places, not just for
Action-scripts.
Also add a "--" prefix for the separator to avoid name conflicts with
actual script names.
Robin Gareus [Mon, 19 Mar 2018 01:26:24 +0000 (02:26 +0100)]
Lua: Lock bindings into memory for rt-scripts
Empirically this decreases gc-spike duration (worst-case) by a factor of
two and speeds up the average gc-run by a factor of over 4 (depending
on the amount of memory used by the plugin).
Robin Gareus [Mon, 19 Mar 2018 00:33:13 +0000 (01:33 +0100)]
Customize Lua GC, add object-memory-lock API.
Add custom API to prevent Lua Objects from being garbage collected.
This is intended to for Ardour LuaBridge bindings (~1MB Objects:
tables, functions and userdata).
The bindings are persistent and the gc can skip them in mark & sweep
phases. This is a significant performance improvement for garbage
collection.
Note. The next version of Lua (5.4) will come with a generational-gc
rather than an incremental, so extending the API at this point in time
is acceptable.
Robin Gareus [Sun, 18 Mar 2018 14:56:06 +0000 (15:56 +0100)]
Example Lua script to perform action at specific wallclock time
Damien Zammit [Sun, 18 Mar 2018 00:39:53 +0000 (11:39 +1100)]
Fix midi track mapping on pt import
Robin Gareus [Sat, 17 Mar 2018 20:13:06 +0000 (21:13 +0100)]
Remove calls to deprecated Lua bitlib
Robin Gareus [Sat, 17 Mar 2018 19:00:08 +0000 (20:00 +0100)]
Remove another C++11 construct (local struct) from UI code
Robin Gareus [Sat, 17 Mar 2018 18:59:38 +0000 (19:59 +0100)]
Remove C++11isms (libptformat)
Robin Gareus [Sat, 17 Mar 2018 17:17:25 +0000 (18:17 +0100)]
Fix wrong "_nth_" replacement in
ba202cc09
Robin Gareus [Sat, 17 Mar 2018 16:32:29 +0000 (17:32 +0100)]
Don't alter, use and rely on selection for PT import
Robin Gareus [Sat, 17 Mar 2018 16:21:21 +0000 (17:21 +0100)]
NO-OP: C++ify code
* remove typdef for struct
* Remove {} struct initializer, use a dedicated c'tor
* scope variables
Robin Gareus [Sat, 17 Mar 2018 16:15:44 +0000 (17:15 +0100)]
NO-OP: whitespace
* distinguish comments and commented-out-code
* add space after function, before bracket
Damien Zammit [Sat, 17 Mar 2018 11:41:44 +0000 (22:41 +1100)]
PT import: Use multitrack MIDI import support based on ptformat update
Damien Zammit [Sat, 17 Mar 2018 11:40:16 +0000 (22:40 +1100)]
ptformat: Update to upstream master
4e653041
- Better MIDI support
Ben Loftis [Fri, 16 Mar 2018 21:34:09 +0000 (16:34 -0500)]
Startup Dialog: A change to the monitor selection should trigger a write to config.
Nikolaus Gullotta [Fri, 16 Mar 2018 16:11:54 +0000 (11:11 -0500)]
add support to reinstantiate deleted plugins
Nikolaus Gullotta [Thu, 15 Mar 2018 18:36:25 +0000 (13:36 -0500)]
NO-OP: Convert Spaces to Tabs
Nikolaus Gullotta [Wed, 14 Mar 2018 19:51:37 +0000 (14:51 -0500)]
description changes and stop jumping instructions if proc:isnil()
Robin Gareus [Fri, 16 Mar 2018 14:33:56 +0000 (15:33 +0100)]
Expose a few more PluginInsert methods to Lua
Robin Gareus [Thu, 15 Mar 2018 19:25:14 +0000 (20:25 +0100)]
GUI: create_vca() API change
Robin Gareus [Thu, 15 Mar 2018 19:24:53 +0000 (20:24 +0100)]
VCA API-change: return created VCAs (handy for Lua scripts)
Nikolaus Gullotta [Wed, 14 Mar 2018 14:58:56 +0000 (09:58 -0500)]
re-add plugin bypass state and move proc order writing closer to top
Nikolaus Gullotta [Tue, 13 Mar 2018 19:51:47 +0000 (14:51 -0500)]
I said, LESS ugly, not more :)
Nikolaus Gullotta [Tue, 13 Mar 2018 19:26:27 +0000 (14:26 -0500)]
Now recalls plug-in ordering (also looks a bit less ugly hopefully?
7890 [Sun, 4 Feb 2018 09:10:00 +0000 (10:10 +0100)]
Add Midnam for Roland TB-03
Named controllers according to MIDI implementation chart.
https://www.roland.com/global/support/by_product/tb-03/
Robin Gareus [Tue, 13 Mar 2018 15:17:31 +0000 (16:17 +0100)]
Sort generic-midi bindings alphabetically
Robin Gareus [Tue, 13 Mar 2018 14:55:33 +0000 (15:55 +0100)]
Novation LaunchKey 49 bindings from Michael McLeod
Len Ovens [Tue, 13 Mar 2018 15:05:41 +0000 (08:05 -0700)]
Same for midi input enable button
Len Ovens [Mon, 12 Mar 2018 23:02:45 +0000 (16:02 -0700)]
Trim and vca button should also be insensitive in strip aux mode
Len Ovens [Sat, 10 Mar 2018 21:58:31 +0000 (13:58 -0800)]
OSC: group commands should feedback all off if no group
Nikolaus Gullotta [Mon, 12 Mar 2018 20:31:33 +0000 (15:31 -0500)]
Initial checkin of mixer store script
Ben Loftis [Sun, 11 Mar 2018 19:42:00 +0000 (14:42 -0500)]
Tweak logic in master-bus packing to make it clearer; will also minimize conflicts with Mixbus.
Len Ovens [Sat, 10 Mar 2018 21:06:17 +0000 (13:06 -0800)]
OSC: fix /strip/hidden feedback excess
Len Ovens [Sat, 10 Mar 2018 20:58:14 +0000 (12:58 -0800)]
OSC: change group sharing to individual commands
Send less feedback for group name and sharing
Len Ovens [Wed, 7 Mar 2018 20:36:56 +0000 (12:36 -0800)]
OSC: set surface should reset custom mode
Len Ovens [Wed, 7 Mar 2018 20:20:30 +0000 (12:20 -0800)]
OSC: Display only strips controlled by selected VCA
Len Ovens [Wed, 7 Mar 2018 18:41:07 +0000 (10:41 -0800)]
OSC: add set VCA for slavable strip
Len Ovens [Wed, 7 Mar 2018 17:38:38 +0000 (09:38 -0800)]
OSC: Added slaved feedback to select
Len Ovens [Wed, 7 Mar 2018 16:49:57 +0000 (08:49 -0800)]
Add virtual slaved, slaved_to calls to stripable
Len Ovens [Sun, 4 Mar 2018 23:46:09 +0000 (15:46 -0800)]
OSC: check route exists
Robin Gareus [Wed, 7 Mar 2018 23:37:54 +0000 (00:37 +0100)]
Safeguard against possibly invalid peak-requests
It may happen that WaveView requests a range that is larger than
the data on disk.
If start > _length, cnt becomes negative and the function will throw
or segfault.
Robin Gareus [Tue, 6 Mar 2018 20:46:35 +0000 (21:46 +0100)]
Allow loadfile in non-rt scripts
Nikolaus Gullotta [Tue, 6 Mar 2018 16:45:55 +0000 (10:45 -0600)]
Initial check in of EditorHook script transparent_regions.lua
Jan Lentfer [Sat, 3 Mar 2018 13:04:12 +0000 (14:04 +0100)]
generic_midi: add proper handling of midi controll toggles
Ben Loftis [Fri, 2 Mar 2018 23:35:18 +0000 (17:35 -0600)]
Unrecognized plugins are stored in the tagfile (FromPlug); but only set the user_set flag if the user actually edited it.
Ben Loftis [Fri, 2 Mar 2018 21:57:58 +0000 (15:57 -0600)]
Allow successive changes from the Gui to set tags.
Robin Gareus [Fri, 2 Mar 2018 15:13:37 +0000 (16:13 +0100)]
Remove interpolation unit-test (fails to compile)
Ardour vari-speed does no longer use ARDOUR::CubicInterpolation
and LinearInterpolation was removed.
vari-speed is now using zita-resampler.
Robin Gareus [Fri, 2 Mar 2018 15:11:21 +0000 (16:11 +0100)]
Fix gcc-4.2 OSX/PPC builds
ambiguity between
reverse_iterator rend();
const_reverse_iterator rend() const;
Ben Loftis [Fri, 2 Mar 2018 00:26:09 +0000 (18:26 -0600)]
Tag_reset() should be FromPlug, not FromGui.
Ben Loftis [Thu, 1 Mar 2018 15:09:50 +0000 (09:09 -0600)]
Fix thinko in prior commit 7c5f1c.
Ben Loftis [Thu, 1 Mar 2018 14:59:48 +0000 (08:59 -0600)]
Plugin-Tag improvements:
Initialize LADSPA tags.
Explicitly define behavior of tags provided by plugin, factory, or user.
Store the plugin name in the tag-file, for easier user-submissions and bulk editing.
Robin Gareus [Wed, 28 Feb 2018 19:48:49 +0000 (20:48 +0100)]
Yet another spelling mistake fix
Robin Gareus [Wed, 28 Feb 2018 19:02:13 +0000 (20:02 +0100)]
Fix a typo in session-utils (thanks to IOhannes/debian for reporting)
Robin Gareus [Wed, 28 Feb 2018 19:02:01 +0000 (20:02 +0100)]
Fix a typo (thanks to IOhannes/debian for reporting)
Robin Gareus [Wed, 28 Feb 2018 19:01:11 +0000 (20:01 +0100)]
Fix some GUI typos (thanks to IOhannes/debian for reporting)
Len Ovens [Wed, 28 Feb 2018 04:55:30 +0000 (20:55 -0800)]
OSC: add group sharing bit feedback
Len Ovens [Tue, 27 Feb 2018 19:55:49 +0000 (11:55 -0800)]
OSC: add group sharing bit setting
Len Ovens [Tue, 27 Feb 2018 19:15:08 +0000 (11:15 -0800)]
OSC: display only strips in group.
Ben Loftis [Tue, 27 Feb 2018 22:39:49 +0000 (16:39 -0600)]
Implement grid line colors ( was: measure lines ). This restores measure lines to a brighter color than beats.
Ben Loftis [Tue, 27 Feb 2018 19:08:40 +0000 (13:08 -0600)]
Reinstate the ability to split regions while dragging playhead. I think this was unintentionally lost.
Ben Loftis [Tue, 27 Feb 2018 14:55:17 +0000 (08:55 -0600)]
Remove some redundant calls to snap_to(). get_preferred_edit_position() already did it.
Ben Loftis [Tue, 27 Feb 2018 02:38:50 +0000 (20:38 -0600)]
Should be able to Split in range mode, with a selected track.
Ben Loftis [Tue, 27 Feb 2018 01:40:24 +0000 (19:40 -0600)]
Fix bug: sequential pasting to the same time, but different tracks, would trigger paste offset.
Ben Loftis [Tue, 27 Feb 2018 00:52:28 +0000 (18:52 -0600)]
Switch CDFrame grid to use MinSec ruler rather than Sample ruler.
Ben Loftis [Tue, 27 Feb 2018 00:38:18 +0000 (18:38 -0600)]
Rename SMPTE enum back to Timecode.
Ben Loftis [Mon, 26 Feb 2018 23:02:24 +0000 (17:02 -0600)]
Fix a rather large naming thinko: GridTypeSamples should be CDFrames.
Ben Loftis [Mon, 26 Feb 2018 21:52:06 +0000 (15:52 -0600)]
Add missing checkbox: Snap to Marker.
Ben Loftis [Sat, 24 Feb 2018 16:53:03 +0000 (10:53 -0600)]
Snap-to-grid should not invalidate other snap options. This was a leftover behavior from prior iterations of Snap+Grid.
Ben Loftis [Sat, 24 Feb 2018 16:30:52 +0000 (10:30 -0600)]
Fixes for region_boundary_cache:
If no region-snaps are defined, bail out before generating cache.
Avoid potential overflow at max_samplepos+1
Snap should continue to work beyond the End marker.
Robin Gareus [Sat, 24 Feb 2018 12:54:15 +0000 (13:54 +0100)]
NO-OP: whitespace
- remove trailing whitespace
- remove space after opening brackets and before closing brackets
- add space around operators
- do not use '//' for multi-line comments, do not use "//" on line-start
to comment-out code breaking indenting (-Wmisleading-indent)
- do add a single space after comment-start /*{SPACE}... or //{SPACE}...
- reserve duplicate whitespace " " for alignment, remove other duplicate
whitespace
- use established "TODO" and "XXX" (highlighted keywords)
- remove equal-sign series "====" (those indicate merge conflicts)
Robin Gareus [Sat, 24 Feb 2018 11:55:48 +0000 (12:55 +0100)]
Fix/amend
a23a8ebcad7.
Updated condition to check for transport_rolling to include preroll and
count-in (speed is != 0 during pre-roll and count-in, but transport is not
actually rolling).
Ben Loftis [Fri, 23 Feb 2018 20:37:32 +0000 (14:37 -0600)]
Tell the user why Insert/Remove Time failed, rather than fail silently.
Ben Loftis [Fri, 23 Feb 2018 19:59:46 +0000 (13:59 -0600)]
Use transport_stopped() instead of speed check.
Paul Davis [Fri, 23 Feb 2018 19:56:58 +0000 (14:56 -0500)]
catch (incorrect) inclusion of non-MIDI related automation parameters in MidiSource XML nodes
Ben Loftis [Fri, 23 Feb 2018 19:48:29 +0000 (13:48 -0600)]
Do not interpolate playhead when stopped.
This fixes a bug where, for a few seconds after transport stops, the users zoom+panning would get hijacked by the follow_playhead behavior, because the playhead was still "hunting".
Ben Loftis [Fri, 23 Feb 2018 14:49:14 +0000 (08:49 -0600)]
Revert afedd2 and associated commits (method to generate initial tag file)
Ben Loftis [Fri, 23 Feb 2018 14:34:59 +0000 (08:34 -0600)]
Start versioning Mixbus keybindings files.
John Emmas [Thu, 22 Feb 2018 11:24:43 +0000 (11:24 +0000)]
Accommodate recently removed source(s) in our MSVC project (gtk2_ardour)
Len Ovens [Thu, 22 Feb 2018 05:05:53 +0000 (21:05 -0800)]
fix compilation on windows with VST support
Len Ovens [Thu, 22 Feb 2018 03:24:18 +0000 (19:24 -0800)]
OSC: fix compiler warning and catch possible errors
Paul Davis [Thu, 22 Feb 2018 04:20:53 +0000 (23:20 -0500)]
fix compilation on linux with LXVST support
Ben Loftis [Thu, 22 Feb 2018 00:04:45 +0000 (18:04 -0600)]
Method to generate an initial tag file:
rm config/plugin_tags
touch config/init_plugin_tags
Len Ovens [Tue, 20 Feb 2018 23:48:54 +0000 (15:48 -0800)]
OSC: Add session name change
Paul Davis [Tue, 20 Feb 2018 22:19:43 +0000 (17:19 -0500)]
user-friendly hack/heuristic: if they edit a BBT non-duration clock to say zero beats, act as if they had used 1
Robin Gareus [Tue, 20 Feb 2018 11:53:21 +0000 (12:53 +0100)]
Re-add fixed-color DSP-load indicator background
Robin Gareus [Tue, 20 Feb 2018 11:22:11 +0000 (12:22 +0100)]
Remove ArdourGauges -- since they're no longer actual Gauge widgets
The Gauges devolved into Labels with dedicated formatting and UI-config
colors. Prevent ArdourButton to happen all over over again...
Robin Gareus [Tue, 20 Feb 2018 11:15:29 +0000 (12:15 +0100)]
Use standard Labels again.
Since the Gauges become little more than text with colored background,
prepare their removal. If color is wanted, use named widget-style.
Robin Gareus [Tue, 20 Feb 2018 10:06:37 +0000 (11:06 +0100)]
Keep track of unacknowledged log-level (error-indicator)
This code was incorrectly removed in
97fb3a5557b5.
Ben Loftis [Mon, 19 Feb 2018 15:50:30 +0000 (09:50 -0600)]
Replace missing widget-name that got lost.
Ben Loftis [Mon, 19 Feb 2018 14:15:18 +0000 (08:15 -0600)]
Prevent mixer-add buttons from getting focus.
Ben Loftis [Mon, 19 Feb 2018 14:05:55 +0000 (08:05 -0600)]
Add drop-shadow decorators to menu bar and transport toolbar.
Allow status bar to fill available width.
Ben Loftis [Mon, 19 Feb 2018 14:01:27 +0000 (08:01 -0600)]
Add flag for corners, where top+left shadows are both required.
Ben Loftis [Sun, 18 Feb 2018 18:39:35 +0000 (12:39 -0600)]
Remove unused widget.
John Emmas [Mon, 19 Feb 2018 11:16:49 +0000 (11:16 +0000)]
Accommodate newly added/renamed source(s) in our MSVC project (gtk2_ardour)
Len Ovens [Sun, 18 Feb 2018 17:15:35 +0000 (09:15 -0800)]
OSC: allow setting of marker name
Len Ovens [Sat, 17 Feb 2018 15:26:23 +0000 (07:26 -0800)]
OSC: select comment should feedback when comment changed