libdcp.git
4 years agoBump asdcplib to anything off the carl branch.
Carl Hetherington [Thu, 5 Dec 2019 00:09:20 +0000 (01:09 +0100)]
Bump asdcplib to anything off the carl branch.

4 years agoFix asdcplib git revision.
Carl Hetherington [Tue, 3 Dec 2019 19:29:57 +0000 (20:29 +0100)]
Fix asdcplib git revision.

4 years ago-cth -> -carl.
Carl Hetherington [Tue, 3 Dec 2019 16:20:41 +0000 (17:20 +0100)]
-cth -> -carl.

4 years agoUse new, improved asdcplib.
Carl Hetherington [Tue, 3 Dec 2019 15:53:14 +0000 (16:53 +0100)]
Use new, improved asdcplib.

4 years agoUpdate for openjpeg git repo tidying.
Carl Hetherington [Tue, 3 Dec 2019 11:07:33 +0000 (12:07 +0100)]
Update for openjpeg git repo tidying.

4 years agoCheck that KDM validity periods are safely within the validity periods
Carl Hetherington [Sun, 1 Dec 2019 22:13:25 +0000 (23:13 +0100)]
Check that KDM validity periods are safely within the validity periods
of the signing certificate chain.

This does cause problems when you try to create a KDM for a certificate
you just made (due to the fact that certificates always have a start-valid
time of "now") but hopefully this can be fixed up in another commit.

4 years agoFix incorrect month when returning not-before/not-after.
Carl Hetherington [Sun, 1 Dec 2019 22:11:02 +0000 (23:11 +0100)]
Fix incorrect month when returning not-before/not-after.

4 years agoBump default certificate validity period to 40 years.
Carl Hetherington [Sun, 1 Dec 2019 14:38:41 +0000 (15:38 +0100)]
Bump default certificate validity period to 40 years.

4 years agoMerge branch 'master' of ssh://git.carlh.net/home/carl/git/libdcp
Carl Hetherington [Sun, 1 Dec 2019 14:25:54 +0000 (15:25 +0100)]
Merge branch 'master' of ssh://git.carlh.net/home/carl/git/libdcp

4 years agoJust emit EmptyAssetPathError from DCP::read, not a MissingAssetError as well.
Carl Hetherington [Sun, 24 Nov 2019 21:31:25 +0000 (22:31 +0100)]
Just emit EmptyAssetPathError from DCP::read, not a MissingAssetError as well.

4 years agoMerge pull request #5 from Gofilex/increase-max-length
Carl Hetherington [Wed, 20 Nov 2019 15:16:18 +0000 (16:16 +0100)]
Merge pull request #5 from Gofilex/increase-max-length

Allow e.g. larger DKDMs for CPLs with 40+ unique sound and picture assets.

4 years agoAllow e.g. larger DKDMs for CPLs with 40+ unique sound and picture assets.
Mart Jansink [Wed, 20 Nov 2019 14:51:12 +0000 (15:51 +0100)]
Allow e.g. larger DKDMs for CPLs with 40+ unique sound and picture assets.

4 years agoFix incorrect LocalTime strings when timezone is behind UTC and not an integer number...
Carl Hetherington [Fri, 8 Nov 2019 22:48:42 +0000 (23:48 +0100)]
Fix incorrect LocalTime strings when timezone is behind UTC and not an integer number of hours.

4 years agoBump asdcplib-cth to allow it to be built with python 3.
Carl Hetherington [Sat, 2 Nov 2019 20:55:10 +0000 (21:55 +0100)]
Bump asdcplib-cth to allow it to be built with python 3.

4 years agoFix enum confusion.
Carl Hetherington [Wed, 9 Oct 2019 22:57:13 +0000 (00:57 +0200)]
Fix enum confusion.

4 years agoFix unit tests after CPL root namespace fix.
Carl Hetherington [Sun, 8 Sep 2019 00:47:26 +0000 (01:47 +0100)]
Fix unit tests after CPL root namespace fix.

4 years agoIn 8c852cb the CPL root attribute "dsig" was removed (to prevent
Carl Hetherington [Thu, 5 Sep 2019 00:51:11 +0000 (01:51 +0100)]
In 8c852cb the CPL root attribute "dsig" was removed (to prevent
'XML root element can contain only one namespace' errors)

In a266fc2 [Sony digest validation fix] this was (for some
unknown reason) re-added, which makes the root element bug recur.

This commit removes that namespace again.

It's a shame there was no unit test to pick this regression up.

4 years agoIt seems that <FrameRate> of 96 is ok for 48fps 3D.
Carl Hetherington [Thu, 5 Sep 2019 00:35:20 +0000 (01:35 +0100)]
It seems that <FrameRate> of 96 is ok for 48fps 3D.

4 years agoAllow DCP reading to continue even with empty <Path> nodes in ASSETMAP.
Carl Hetherington [Fri, 30 Aug 2019 21:28:06 +0000 (22:28 +0100)]
Allow DCP reading to continue even with empty <Path> nodes in ASSETMAP.

4 years agoCapitalise help message like all the others.
Carl Hetherington [Thu, 18 Jul 2019 15:16:58 +0000 (16:16 +0100)]
Capitalise help message like all the others.

4 years agoMerge pull request #4 from tschiemer/master
Carl Hetherington [Thu, 18 Jul 2019 15:16:00 +0000 (16:16 +0100)]
Merge pull request #4 from tschiemer/master

OpenMP selectable library + readme

4 years agoadded explanations and links
philip [Thu, 18 Jul 2019 10:06:50 +0000 (12:06 +0200)]
added explanations and links

4 years agoomp library can be chosen
philip [Thu, 18 Jul 2019 10:05:26 +0000 (12:05 +0200)]
omp library can be chosen

4 years agoadded missing configure message for +MAGICK
philip [Thu, 18 Jul 2019 08:56:50 +0000 (10:56 +0200)]
added missing configure message for +MAGICK

4 years agoAdd check that -fopenmp works (part of github bug #3).
Carl Hetherington [Wed, 17 Jul 2019 23:48:20 +0000 (00:48 +0100)]
Add check that -fopenmp works (part of github bug #3).

4 years agoSpeculative OpenMP build fix (github bug #1).
Carl Hetherington [Wed, 17 Jul 2019 19:53:20 +0000 (20:53 +0100)]
Speculative OpenMP build fix (github bug #1).

4 years agoAdd credit.
Carl Hetherington [Wed, 17 Jul 2019 19:52:02 +0000 (20:52 +0100)]
Add credit.

4 years agoMerge pull request #2 from tschiemer/master
Carl Hetherington [Wed, 17 Jul 2019 19:46:34 +0000 (20:46 +0100)]
Merge pull request #2 from tschiemer/master

bugfix: undefined template instantiation

4 years agobugfix: unknown template instantiation
philip [Wed, 17 Jul 2019 19:30:13 +0000 (21:30 +0200)]
bugfix: unknown template instantiation

4 years agoAdd some comments.
Carl Hetherington [Thu, 27 Jun 2019 22:11:03 +0000 (23:11 +0100)]
Add some comments.

4 years agoReject certificate chains where the adjacent certificates have the same subject.
Carl Hetherington [Wed, 26 Jun 2019 14:54:09 +0000 (15:54 +0100)]
Reject certificate chains where the adjacent certificates have the same subject.

4 years agoTry to fix build.
Carl Hetherington [Wed, 26 Jun 2019 01:05:07 +0000 (02:05 +0100)]
Try to fix build.

4 years agoTry to fix OS X build.
Carl Hetherington [Wed, 26 Jun 2019 00:12:44 +0000 (01:12 +0100)]
Try to fix OS X build.

4 years agoAdd another raw_convert type.
Carl Hetherington [Tue, 25 Jun 2019 20:38:56 +0000 (21:38 +0100)]
Add another raw_convert type.

5 years agoAdd another type to raw/locale convert.
Carl Hetherington [Wed, 12 Jun 2019 15:08:25 +0000 (16:08 +0100)]
Add another type to raw/locale convert.

5 years agoIncrease header size when writing SMPTE subtitle MXFs; fixes problems when writing...
Carl Hetherington [Tue, 21 May 2019 20:23:55 +0000 (21:23 +0100)]
Increase header size when writing SMPTE subtitle MXFs; fixes problems when writing lots of subs (DCP-o-matic bug #1561).

5 years agoclass/struct confusion.
Carl Hetherington [Sun, 28 Apr 2019 20:36:40 +0000 (21:36 +0100)]
class/struct confusion.

5 years agoThrow a different exception when an unrecognised LabelSetType is found.
Carl Hetherington [Thu, 25 Apr 2019 15:46:14 +0000 (15:46 +0000)]
Throw a different exception when an unrecognised LabelSetType is found.

5 years agoFix previous and add unit test for Key::hex.
Carl Hetherington [Mon, 8 Apr 2019 20:14:19 +0000 (21:14 +0100)]
Fix previous and add unit test for Key::hex.

5 years agoMake Key support any length.
Carl Hetherington [Mon, 8 Apr 2019 19:37:26 +0000 (20:37 +0100)]
Make Key support any length.

5 years agoAdd EPISODE and PROMO content types.
Carl Hetherington [Fri, 29 Mar 2019 14:35:02 +0000 (14:35 +0000)]
Add EPISODE and PROMO content types.

5 years agoOnly build tests on Ubuntu 18.04 as we need BOOST_TEST.
Carl Hetherington [Wed, 27 Mar 2019 00:23:49 +0000 (00:23 +0000)]
Only build tests on Ubuntu 18.04 as we need BOOST_TEST.

5 years agoBump libcxml.
Carl Hetherington [Tue, 26 Mar 2019 21:46:16 +0000 (21:46 +0000)]
Bump libcxml.

5 years agoBump libcxml for OS X fix.
Carl Hetherington [Sat, 23 Mar 2019 21:38:16 +0000 (21:38 +0000)]
Bump libcxml for OS X fix.

5 years agoBump libcxml for raw_convert type addition.
Carl Hetherington [Fri, 22 Mar 2019 15:02:58 +0000 (15:02 +0000)]
Bump libcxml for raw_convert type addition.

5 years agoFix incorrect type.
Carl Hetherington [Fri, 22 Mar 2019 15:02:45 +0000 (15:02 +0000)]
Fix incorrect type.

5 years agoBump libcxml for pkg-config fix.
Carl Hetherington [Fri, 22 Mar 2019 13:46:38 +0000 (13:46 +0000)]
Bump libcxml for pkg-config fix.

5 years agoMore bits in dcpkdm.
Carl Hetherington [Wed, 20 Mar 2019 20:03:48 +0000 (20:03 +0000)]
More bits in dcpkdm.

5 years agoMissing include.
Carl Hetherington [Tue, 19 Mar 2019 21:30:51 +0000 (21:30 +0000)]
Missing include.

5 years agoBump libcxml.
Carl Hetherington [Tue, 19 Mar 2019 21:22:51 +0000 (21:22 +0000)]
Bump libcxml.

5 years agoMissing file.
Carl Hetherington [Tue, 19 Mar 2019 21:15:49 +0000 (21:15 +0000)]
Missing file.

5 years agoContentVersion is required by SMPTE, I think.
Carl Hetherington [Tue, 19 Mar 2019 20:52:38 +0000 (20:52 +0000)]
ContentVersion is required by SMPTE, I think.

5 years agoSupport RatingList.
Carl Hetherington [Tue, 19 Mar 2019 19:47:07 +0000 (19:47 +0000)]
Support RatingList.

5 years agoBump cxml for removal of sstream dependency.
Carl Hetherington [Tue, 19 Mar 2019 15:15:12 +0000 (15:15 +0000)]
Bump cxml for removal of sstream dependency.

5 years agoAccept that <Duration> and <EntryPoint> are optional, and account for this in tests.
Carl Hetherington [Mon, 18 Mar 2019 00:29:47 +0000 (00:29 +0000)]
Accept that <Duration> and <EntryPoint> are optional, and account for this in tests.

Also fix tests to reflect <AnnotationText> no longer being filled in with a default
value.

5 years agoMissing header install.
Carl Hetherington [Sun, 17 Mar 2019 00:42:02 +0000 (00:42 +0000)]
Missing header install.

5 years agoMerge branch 'master' of ssh://git.carlh.net/home/carl/git/libdcp
Carl Hetherington [Sun, 17 Mar 2019 00:24:48 +0000 (00:24 +0000)]
Merge branch 'master' of ssh://git.carlh.net/home/carl/git/libdcp

5 years agoFinish initial CPL markers support.
Carl Hetherington [Fri, 15 Mar 2019 22:46:00 +0000 (22:46 +0000)]
Finish initial CPL markers support.

5 years agoMove asset refs and hash from ReelAsset to ReelMXF.
Carl Hetherington [Fri, 15 Mar 2019 00:49:41 +0000 (00:49 +0000)]
Move asset refs and hash from ReelAsset to ReelMXF.

5 years agoRemove some unused constructors.
Carl Hetherington [Thu, 14 Mar 2019 23:29:50 +0000 (23:29 +0000)]
Remove some unused constructors.

5 years agoAdd Marker enum.
Carl Hetherington [Thu, 14 Mar 2019 22:59:54 +0000 (22:59 +0000)]
Add Marker enum.

5 years agoFix some GPL boilerplate.
Carl Hetherington [Sat, 16 Mar 2019 20:36:53 +0000 (20:36 +0000)]
Fix some GPL boilerplate.

5 years agoTry to fix build with older openssl.
Carl Hetherington [Sat, 16 Mar 2019 19:56:07 +0000 (19:56 +0000)]
Try to fix build with older openssl.

5 years agoMerge branch 'master' of ssh://git.carlh.net/home/carl/git/libdcp
Carl Hetherington [Fri, 15 Mar 2019 23:25:21 +0000 (23:25 +0000)]
Merge branch 'master' of ssh://git.carlh.net/home/carl/git/libdcp

5 years agoCheck that all image data is present after loading a SMPTE subtitle asset.
Carl Hetherington [Fri, 15 Mar 2019 23:16:00 +0000 (23:16 +0000)]
Check that all image data is present after loading a SMPTE subtitle asset.

If we load SMPTE subtitles from a XML file try to load PNG data
from the same directory; this feels like a hack.

5 years agoTweak comment.
Carl Hetherington [Fri, 15 Mar 2019 22:40:46 +0000 (22:40 +0000)]
Tweak comment.

5 years agoWarn about incorrect string encoding in dcpkdm.
Carl Hetherington [Thu, 14 Mar 2019 19:38:48 +0000 (19:38 +0000)]
Warn about incorrect string encoding in dcpkdm.

5 years agoSome new features in dcpkdm.
Carl Hetherington [Thu, 14 Mar 2019 17:01:47 +0000 (17:01 +0000)]
Some new features in dcpkdm.

5 years agoHelp fix in dcpkdm tool.
Carl Hetherington [Thu, 14 Mar 2019 15:50:14 +0000 (15:50 +0000)]
Help fix in dcpkdm tool.

5 years agoTweak link flags. v1.6.4
Carl Hetherington [Tue, 12 Mar 2019 12:08:17 +0000 (12:08 +0000)]
Tweak link flags.

5 years agoAnd corresponding test updates.
Carl Hetherington [Tue, 12 Mar 2019 12:05:37 +0000 (12:05 +0000)]
And corresponding test updates.

5 years agoMore insulation against libdcp version updates.
Carl Hetherington [Tue, 12 Mar 2019 12:03:45 +0000 (12:03 +0000)]
More insulation against libdcp version updates.

5 years agoTry to fix libdcp static build.
Carl Hetherington [Tue, 12 Mar 2019 11:58:21 +0000 (11:58 +0000)]
Try to fix libdcp static build.

5 years agoUpdate tests for previous.
Carl Hetherington [Tue, 12 Mar 2019 11:53:04 +0000 (11:53 +0000)]
Update tests for previous.

5 years agoStop test output depending on libdcp version.
Carl Hetherington [Tue, 12 Mar 2019 11:52:43 +0000 (11:52 +0000)]
Stop test output depending on libdcp version.

5 years agoFix gcov shlib build; this fixes tests to run against the locally-built libdcp rather...
Carl Hetherington [Tue, 12 Mar 2019 11:49:50 +0000 (11:49 +0000)]
Fix gcov shlib build; this fixes tests to run against the locally-built libdcp rather than the installed one.

5 years agoFix string decoding; bump libcxml version. v1.6.3
Carl Hetherington [Tue, 12 Mar 2019 00:35:15 +0000 (00:35 +0000)]
Fix string decoding; bump libcxml version.

5 years agoBump wscript required version of libcxml. v1.6.2
Carl Hetherington [Mon, 11 Mar 2019 23:55:15 +0000 (23:55 +0000)]
Bump wscript required version of libcxml.

5 years agoBump libcxml to a release version.
Carl Hetherington [Mon, 11 Mar 2019 23:53:31 +0000 (23:53 +0000)]
Bump libcxml to a release version.

5 years agoUpdate for changes to video MXF headers.
Carl Hetherington [Mon, 4 Feb 2019 12:47:10 +0000 (12:47 +0000)]
Update for changes to video MXF headers.

5 years agoBump asdcplib for fix to DoM bug #1325.
Carl Hetherington [Thu, 31 Jan 2019 23:34:16 +0000 (23:34 +0000)]
Bump asdcplib for fix to DoM bug #1325.

5 years agoCheck return value of fread in File::File.
Carl Hetherington [Thu, 24 Jan 2019 22:21:02 +0000 (22:21 +0000)]
Check return value of fread in File::File.

5 years agoFix test references now that we indent things.
Carl Hetherington [Thu, 24 Jan 2019 17:36:22 +0000 (17:36 +0000)]
Fix test references now that we indent things.

5 years agoSlightly hacky but hopefully functional fix for KDMs after the changes
Carl Hetherington [Thu, 24 Jan 2019 17:34:37 +0000 (17:34 +0000)]
Slightly hacky but hopefully functional fix for KDMs after the changes
to signer.  The KDM stuff uses add_signature_value() but not sign()
since it has to allow pass-through of a KDM (so it handles <Signature> etc.
itself).  This means we have to make the indentation-adding optional.

It might have been nicer to make indent() not add indentation if it's
not already there.

5 years agoRemove sign test tool.
Carl Hetherington [Thu, 24 Jan 2019 02:21:10 +0000 (02:21 +0000)]
Remove sign test tool.

5 years agoFully indent PKL/CPL.
Carl Hetherington [Tue, 22 Jan 2019 00:40:16 +0000 (00:40 +0000)]
Fully indent PKL/CPL.

5 years agoAttempt to fix Sony digest validation by indenting the <Signer>
Carl Hetherington [Sun, 20 Jan 2019 20:26:41 +0000 (20:26 +0000)]
Attempt to fix Sony digest validation by indenting the <Signer>
and <Signature> before signing.  This is in the belief that, perhaps,
the Sony software "reformats" the XML before checking that the signature
is correct (or something).

5 years agoReveal path in MissingAssetError.
Carl Hetherington [Tue, 22 Jan 2019 15:45:48 +0000 (15:45 +0000)]
Reveal path in MissingAssetError.

5 years agoMissing include for arch.
Carl Hetherington [Thu, 17 Jan 2019 20:18:40 +0000 (20:18 +0000)]
Missing include for arch.

5 years agoUpdate waf and bump libcxml for similar updates.
Carl Hetherington [Thu, 17 Jan 2019 19:39:48 +0000 (19:39 +0000)]
Update waf and bump libcxml for similar updates.

5 years agoBump openjpeg2-cdist for debugging code.
Carl Hetherington [Tue, 15 Jan 2019 16:57:29 +0000 (16:57 +0000)]
Bump openjpeg2-cdist for debugging code.

5 years agoMerge branch 'master' of ssh://git.carlh.net/home/carl/git/libdcp
Carl Hetherington [Mon, 14 Jan 2019 15:47:35 +0000 (15:47 +0000)]
Merge branch 'master' of ssh://git.carlh.net/home/carl/git/libdcp

5 years agoTidy repeated call of make_uuid() and don't put urn:uuid: in front of default content...
Carl Hetherington [Mon, 14 Jan 2019 15:30:55 +0000 (15:30 +0000)]
Tidy repeated call of make_uuid() and don't put urn:uuid: in front of default content version label text as it's a bit confusing.

5 years agoSpeculative removal of call to xmlSecKeySetName when signing, on
Carl Hetherington [Mon, 14 Jan 2019 15:32:58 +0000 (15:32 +0000)]
Speculative removal of call to xmlSecKeySetName when signing, on
the basis that I can't see what it's for and opendcp doesn't
do it.  Chasing Sony no-validate bug.

5 years agoMove verify API away from strings towards error codes.
Carl Hetherington [Sat, 12 Jan 2019 23:12:46 +0000 (23:12 +0000)]
Move verify API away from strings towards error codes.

5 years agoFix crash with insufficient parameters to libdcp.
Carl Hetherington [Thu, 10 Jan 2019 13:35:47 +0000 (13:35 +0000)]
Fix crash with insufficient parameters to libdcp.

5 years agoFix incorrect XML namespace in MXF header; I was using the prefix
Carl Hetherington [Tue, 8 Jan 2019 09:58:56 +0000 (09:58 +0000)]
Fix incorrect XML namespace in MXF header; I was using the prefix
instead of the namespace URI for what asdcplib calls
TimedTextDescriptor::NamespaceName.

Thanks to clairmeta; see https://github.com/Ymagis/ClairMeta/issues/72

5 years agoClairMeta points out that SMPTE subtitle MXF's ResourceID should
Carl Hetherington [Sun, 6 Jan 2019 23:02:21 +0000 (23:02 +0000)]
ClairMeta points out that SMPTE subtitle MXF's ResourceID should
be the same as the internal XML ID.  This in turn must be different
from the MXF's UUID.

I *think* that we have:

AssetUUID: MXF's UUID, which must be different; written from
the WriterInfo (set up by fill_writer_info, which is passed _id)

AssetID: MXF's ResourceID, which must be the _xml_id; written from
the TimedTextDescriptor.

I believe that this patch fixes the ResourceID to be the XML ID (as
required) without undoing the Doremi fix whereby the MXF UUID must
be different to the XML ID.

This patch quells ClairMeta's error.

5 years agoMore DCP verification detail and testing.
Carl Hetherington [Sun, 6 Jan 2019 19:30:00 +0000 (19:30 +0000)]
More DCP verification detail and testing.

5 years agoTidy up a bit.
Carl Hetherington [Sun, 6 Jan 2019 02:34:47 +0000 (02:34 +0000)]
Tidy up a bit.