Speculative removal of call to xmlSecKeySetName when signing, on

the basis that I can't see what it's for and opendcp doesn't
do it.  Chasing Sony no-validate bug.

diff --git a/src/certificate_chain.cc b/src/certificate_chain.cc
index 0e032a851d17a7ad820f2c36fb591074f28bf471..6b4216b5eeadb2a73f2428aaf26a7d2f6d1066e7 100644 (file)
--- a/src/certificate_chain.cc
+++ b/src/certificate_chain.cc
@@ -639,11 +639,6 @@ CertificateChain::add_signature_value (xmlpp::Node* parent, string ns) const
                throw runtime_error ("could not read private key");
        }
 
-       /* XXX: set key name to the PEM string: this can't be right! */
-       if (xmlSecKeySetName (signature_context->signKey, reinterpret_cast<const xmlChar *> (_key->c_str())) < 0) {
-               throw MiscError ("could not set key name");
-       }
-
        int const r = xmlSecDSigCtxSign (signature_context, parent->cobj ());
        if (r < 0) {
                throw MiscError (String::compose ("could not sign (%1)", r));